1 2017-10-18 04:42:41 0|cfields|sdaftuar: https://github.com/theuni/bitcoin/tree/move-addrdb . It builds on top of #11457, mostly as a cheap review beg :)
2 2017-10-18 04:42:43 0|gribble|https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni ÷ Pull Request #11457 ÷ bitcoin/bitcoin ÷ GitHub
3 2017-10-18 04:44:58 0|cfields|It still needs a few things. At minimum, it needs an interface class (similar to NetEventsInterface) to be useful for your tests. Then a few things to tidy up in CConnman, as it was just kinda shoved in there as-is.
4 2017-10-18 04:45:40 0|cfields|I'll try to get it finished up tomorrow. But I think that gets you mostly what you were after.
5 2017-10-18 04:47:21 0|cfields|oh, and loading the addrdb is very shoe-horned in there. Need to figure out where to stick that. IMO moving it into CAddrMan makes sense, as other implementations (tests) will likely be memory-backed anyway.
6 2017-10-18 04:58:27 0|ossifrage|This may be me seeing things, of the 87 nodes connected, the ones with the longest ping times are all 0.15.0
7 2017-10-18 09:07:37 0|kallewoof|ossifrage: not seeing that on my end
8 2017-10-18 09:38:23 0|bitcoin-git|13bitcoin/06master 14258d33b 15Karl-Johan Alm: [mempool] Mark unaccepted txs present in mempool as 'already there'....
9 2017-10-18 09:38:23 0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/808c84f89d0e...26fee4f6bd9a
10 2017-10-18 09:38:24 0|bitcoin-git|13bitcoin/06master 1426fee4f 15Pieter Wuille: Merge #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there'...
11 2017-10-18 09:38:35 0|sipa|kallewoof: ^ i was confused to not see a 'already there' when starting up a master node, and then realized that wasn't merged yet
12 2017-10-18 09:38:48 0|bitcoin-git|[13bitcoin] 15sipa closed pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (06master...06mempool-alreadythere) 02 https://github.com/bitcoin/bitcoin/pull/11062
13 2017-10-18 09:39:17 0|gmaxwell|sipa: kallewoof: thanks.
14 2017-10-18 13:23:24 0|bitcoin-git|13bitcoin/06master 14207408b 15Jonas Schnelli: Fix crash via division by zero assertion
15 2017-10-18 13:23:24 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/26fee4f6bd9a...ffa5159cefb8
16 2017-10-18 13:23:25 0|bitcoin-git|13bitcoin/06master 14ffa5159 15Wladimir J. van der Laan: Merge #11508: Fix crash via division by zero assertion...
17 2017-10-18 13:24:04 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11508: Fix crash via division by zero assertion (06master...062017/10/qt_cc_crash_zero) 02 https://github.com/bitcoin/bitcoin/pull/11508
18 2017-10-18 13:40:09 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/ffa5159cefb8...b645f368f299
19 2017-10-18 13:40:10 0|bitcoin-git|13bitcoin/06master 147104de8 15João Barbosa: [wallet] Fix leak in CDB constructor...
20 2017-10-18 13:40:10 0|bitcoin-git|13bitcoin/06master 14b645f36 15Wladimir J. van der Laan: Merge #11492: [wallet] Fix leak in CDB constructor...
21 2017-10-18 13:40:17 0|promag|doesn't make sense to "return false" here: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L941 ?
22 2017-10-18 13:40:39 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11492: [wallet] Fix leak in CDB constructor (06master...062017-10-cdb-constructor-leak) 02 https://github.com/bitcoin/bitcoin/pull/11492
23 2017-10-18 13:41:23 0|promag|if fTxIndex and !ReadTxIndex why continue?
24 2017-10-18 13:42:12 0|sipa|promag: makes sense
25 2017-10-18 13:42:23 0|promag|PR on the way
26 2017-10-18 13:42:32 0|promag|btw
27 2017-10-18 13:42:55 0|promag|sometimes why on earth AssertLockHeld fails on some travis jobs?
28 2017-10-18 13:43:04 0|promag|any insight?
29 2017-10-18 13:43:31 0|promag|https://travis-ci.org/bitcoin/bitcoin/builds/289428354
30 2017-10-18 13:43:39 0|sipa|that would indicate a bug..
31 2017-10-18 13:44:03 0|promag|right, I've added the AssertLockHeld, but only some builds fail
32 2017-10-18 13:44:20 0|promag|s/builds/jobs
33 2017-10-18 13:46:19 0|sipa|not all are built with -DDEBUG_LOCKS
34 2017-10-18 13:47:52 0|wumpus|there is significant overhead to lock checking so it is only enabled for debug builds
35 2017-10-18 13:48:18 0|promag|you mean debug_lockorder?
36 2017-10-18 13:48:32 0|wumpus|yes
37 2017-10-18 13:48:39 0|promag|I understand, I'll check that out
38 2017-10-18 13:49:39 0|sipa|we have an ad-hoc lock contention/correctness checking, which is compiled in when you build with -DDEBUG_LOCKORDER
39 2017-10-18 13:49:59 0|Banzai10|promag, do you have the logs?
40 2017-10-18 13:50:00 0|bitcoin-git|13bitcoin/06master 14c5dfa90 15Cristian Mircea Messel: [tests] Add uacomment tests...
41 2017-10-18 13:50:00 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/b645f368f299...2ca518deff25
42 2017-10-18 13:50:01 0|bitcoin-git|13bitcoin/06master 142ca518d 15Wladimir J. van der Laan: Merge #11486: [tests] Add uacomment tests...
43 2017-10-18 13:50:33 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11486: [tests] Add uacomment tests (06master...06test_uacomment) 02 https://github.com/bitcoin/bitcoin/pull/11486
44 2017-10-18 13:50:46 0|promag|Banzai10: check https://travis-ci.org/bitcoin/bitcoin/jobs/289428359
45 2017-10-18 14:03:02 0|promag|forever alone #11514 :P
46 2017-10-18 14:03:03 0|gribble|https://github.com/bitcoin/bitcoin/issues/11514 | Iterate and remove nodes without container copy by promag ÷ Pull Request #11514 ÷ bitcoin/bitcoin ÷ GitHub
47 2017-10-18 14:04:08 0|promag|wumpus: now that 1 line pr is done, take this with 2 lines https://github.com/bitcoin/bitcoin/pull/11006/files
48 2017-10-18 14:05:36 0|wumpus|ah yes that one looks good to me now
49 2017-10-18 14:07:11 0|bitcoin-git|13bitcoin/06master 14793667a 15João Barbosa: Improve shutdown process
50 2017-10-18 14:07:11 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/2ca518deff25...a1d78b59fc03
51 2017-10-18 14:07:12 0|bitcoin-git|13bitcoin/06master 14a1d78b5 15Wladimir J. van der Laan: Merge #11006: Improve shutdown process...
52 2017-10-18 14:07:18 0|promag|:confetti:
53 2017-10-18 14:07:36 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11006: Improve shutdown process (06master...06201708-fast-shutdown) 02 https://github.com/bitcoin/bitcoin/pull/11006
54 2017-10-18 14:21:44 0|wumpus|vNodes.erase(remove(vNodes.begin(), vNodes.end(), pnode), vNodes.end()); , huh
55 2017-10-18 14:23:13 0|wumpus|so std::vector::erase removes elements in a range, remove() returns the range vNodes.begin() to vNodes.end() minus pnode
56 2017-10-18 14:23:33 0|wumpus|shouldn't this remove everything but pnode?
57 2017-10-18 14:27:46 0|wumpus|std::remove "Transforms the range [first,last) into a range with all the elements that compare equal to val removed, and returns an iterator to the new end of that range."
58 2017-10-18 14:28:42 0|cfields|wumpus: https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom
59 2017-10-18 14:28:52 0|cfields|I had to look it up first time I saw it
60 2017-10-18 14:29:07 0|wumpus|whoa that could have at least used a comment
61 2017-10-18 14:32:09 0|wumpus|oh no did i break travis?
62 2017-10-18 14:33:13 0|wumpus|E: Failed to fetch https://packagecloud.io/basho/riak/ubuntu/dists/trusty/main/source/Sources 401 Unauthorized no, apparently a download failure
63 2017-10-18 14:35:44 0|bitcoin-git|13bitcoin/06master 14f4c4e38 15John Newbery: [trivial] Make namespace explicit for is_regular_file...
64 2017-10-18 14:35:44 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/a1d78b59fc03...50d72b357081
65 2017-10-18 14:35:45 0|bitcoin-git|13bitcoin/06master 1450d72b3 15Wladimir J. van der Laan: Merge #11495: [trivial] Make namespace explicit for is_regular_file...
66 2017-10-18 14:36:07 0|sdaftuar|hm, this looks like a pretty sketchy comment: https://github.com/bitcoin/bitcoin/issues/11519#issuecomment-337453387
67 2017-10-18 14:36:19 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11495: [trivial] Make namespace explicit for is_regular_file (06master...06explicit_is_regular_file) 02 https://github.com/bitcoin/bitcoin/pull/11495
68 2017-10-18 14:37:41 0|wumpus|right, deleted it, it made no sense at all (download the app to your mobile? bitcoin.com?)
69 2017-10-18 14:47:15 0|sdaftuar|yeah, thanks - your response looks much better :)
70 2017-10-18 14:53:14 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/50d72b357081...6759a24eaaf7
71 2017-10-18 14:53:15 0|bitcoin-git|13bitcoin/06master 14fa9de37 15MarcoFalke: qa: Make tmpdir option an absolute path...
72 2017-10-18 14:53:15 0|bitcoin-git|13bitcoin/06master 14fafa003 15MarcoFalke: qa: Remove never used return value of sync_with_ping
73 2017-10-18 14:53:16 0|bitcoin-git|13bitcoin/06master 146759a24 15Wladimir J. van der Laan: Merge #11472: qa: Make tmpdir option an absolute path, misc cleanup...
74 2017-10-18 14:53:43 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11472: qa: Make tmpdir option an absolute path, misc cleanup (06master...06Mf1710-qaMultiwalletRelDir) 02 https://github.com/bitcoin/bitcoin/pull/11472
75 2017-10-18 14:53:51 0|wumpus|thanks :)
76 2017-10-18 14:55:57 0|wumpus|can we solve the basho riak download issue? I get an angry travis mail a few seconds after every merge now
77 2017-10-18 14:56:48 0|sipa|?
78 2017-10-18 14:56:50 0|wumpus|I have no idea why it's downloading that package in the first place, part of travis infrastructure I guess... hm in that case there's nothing we can do
79 2017-10-18 14:57:00 0|wumpus|https://travis-ci.org/bitcoin/bitcoin/jobs/289537283
80 2017-10-18 15:02:26 0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/6759a24eaaf7...937613d215de
81 2017-10-18 15:02:27 0|bitcoin-git|13bitcoin/06master 1468feb49 15practicalswift: Use nullptr instead of NULL
82 2017-10-18 15:02:27 0|bitcoin-git|13bitcoin/06master 14c6b07fd 15practicalswift: Fix a vs. an typo
83 2017-10-18 15:02:28 0|bitcoin-git|13bitcoin/06master 140aacfa4 15practicalswift: Remove accidental stray semicolon
84 2017-10-18 15:03:01 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11467: Fix typos. Use nullptr instead of NULL. (06master...06cleanups-20171009) 02 https://github.com/bitcoin/bitcoin/pull/11467
85 2017-10-18 16:09:36 0|cfields|sdaftuar: in case you missed it, see backlog re moving addrman
86 2017-10-18 16:10:00 0|sdaftuar|cfields: thanks, i got it -- reviewing #11457 now in fact
87 2017-10-18 16:10:02 0|gribble|https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni ÷ Pull Request #11457 ÷ bitcoin/bitcoin ÷ GitHub
88 2017-10-18 16:10:32 0|cfields|ok. with an added interface class, is that what you were after?
89 2017-10-18 16:11:24 0|sdaftuar|i think so, yeah (well i haven't looked at the addrman change yet, but if it's just like the banman change, then yes)
90 2017-10-18 16:12:04 0|sdaftuar|i think the idea would be in regtest mode, to create a special mockedaddrman and sub it in. so just would want a (minimal) interface class to have to implement
91 2017-10-18 16:12:29 0|cfields|sdaftuar: ok
92 2017-10-18 16:12:58 0|cfields|though, my hope was that creating interfaces for these would allow us to do actual c++ unit tests, rather than having to launch an entire program instance for tests
93 2017-10-18 16:15:03 0|sdaftuar|hm. that would be better!
94 2017-10-18 16:15:41 0|sdaftuar|do you think we could really unit test interactions between net and net_processing though? that seems very hard.
95 2017-10-18 16:15:58 0|sdaftuar|(then again, what i'm doing now is also very hard)
96 2017-10-18 16:16:13 0|cfields|well we're getting close. the message processor is now an interface
97 2017-10-18 16:16:45 0|cfields|so you can define your own PeerLogicValidation and ProcessMessages as necessary
98 2017-10-18 16:16:59 0|cfields|i assume you need a good bit of stuff pulled out still, though?
99 2017-10-18 16:17:15 0|cfields|you're trying to test the outgoing peer eviction here, right?
100 2017-10-18 16:17:35 0|sdaftuar|yeah i want to test the logic i'm adding in #11490
101 2017-10-18 16:17:36 0|gribble|https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar ÷ Pull Request #11490 ÷ bitcoin/bitcoin ÷ GitHub
102 2017-10-18 16:18:06 0|cfields|ah thaks, i didn't realize you'd already PR'd it. Will review.
103 2017-10-18 16:19:38 0|sdaftuar|i have one more commit that is possibly even harder to test than what i've pushed so far, actually. what is there now is mostly just behavior in net_processing which might be sort-of testable (i was able to rig a single peer in regtest mode that was correctly disconnected)
104 2017-10-18 16:20:09 0|sdaftuar|but the next commit, where i have net_processing set an able_to_evict flag for net.cpp to choose to use, is trickier
105 2017-10-18 16:20:30 0|sdaftuar|as i have no way to get multiple outbound connections in our regtest environment righ tnow
106 2017-10-18 16:21:16 0|sdaftuar|that's partly due to addrman behavior (no more than one peer per ip) and net (don't connect out to a peer in the same network group as an existing peer)
107 2017-10-18 16:21:32 0|cfields|sdaftuar: one thing i have in one of my libevent branches is an ip spoofer for CNode. The idea is to setup 2 CConnman, have 1 connect x times to the other, each with a specified (fake) IP. Then you can simulate the behavior of both sides of the conenection.
108 2017-10-18 16:21:33 0|sdaftuar|so that aspect of it might be easier to do in a unit test than regtest
109 2017-10-18 16:23:09 0|cfields|sounds like it would be, yes. Otherwise you have to shove in a bunch of test-specific behavior
110 2017-10-18 16:23:11 0|sdaftuar|i don't think i'm very familiar right now with the existing unit tests that use connman, i should start there
111 2017-10-18 16:23:33 0|cfields|heh, well there really aren't any. I'm desperately trying to get the interfaces stubbed out so that we can start writing them :)
112 2017-10-18 16:23:59 0|sdaftuar|well i just noticed the existing DoS_tests file while reviewing your banman pr, that is already more than i thought we could do!
113 2017-10-18 16:24:14 0|sdaftuar|so maybe it's not crazy to think i could write a unit test with just what we have now
114 2017-10-18 16:24:53 0|cfields|yes, that one is a pretty good example of where I'd like to be heading. It allows for all local behavior without relying on a global instance
115 2017-10-18 16:26:41 0|cfields|Something else I really needed when testing the libevent code was a way to flood a peer with garbage and see how it would react. Garbage from 1 peer, 100 peers, etc. I think that's the perfect use-case for this kind of testing, because it's easy to code up a quick stub of a message processor that just does ping/pong as quickly as possible.
116 2017-10-18 16:27:07 0|cfields|I could try to code that up if it'd be helpful
117 2017-10-18 16:27:42 0|sdaftuar|thanks, not sure yet what i need until i think about the unit testing framework a bit more! i'll dive into it and see what issues i run into
118 2017-10-18 16:28:00 0|cfields|ok
119 2017-10-18 16:29:18 0|cfields|sdaftuar: thanks for the review!
120 2017-10-18 16:36:16 0|sdaftuar|np!
121 2017-10-18 17:00:39 0|bitcoin-git|13bitcoin/06master 14cc9ee80 15João Barbosa: Improve ZMQ functional test
122 2017-10-18 17:00:39 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/937613d215de...02ac8c892b1f
123 2017-10-18 17:00:40 0|bitcoin-git|13bitcoin/06master 1402ac8c8 15Wladimir J. van der Laan: Merge #11452: Improve ZMQ functional test...
124 2017-10-18 17:01:11 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11452: Improve ZMQ functional test (06master...062017-10-improve-zmq-test) 02 https://github.com/bitcoin/bitcoin/pull/11452
125 2017-10-18 18:28:05 0|bitcoin-git|[13bitcoin] 15theuni opened pull request #11521: travis: move back to the minimal image (06master...06travis-minimal) 02 https://github.com/bitcoin/bitcoin/pull/11521
126 2017-10-18 18:56:04 0|bitcoin-git|[13bitcoin] 15laanwj pushed 26 new commits to 060.15: 02 https://github.com/bitcoin/bitcoin/compare/51bad9195eb4...1646f9c76036
127 2017-10-18 18:56:05 0|bitcoin-git|13bitcoin/060.15 149e8aae3 15Karl-Johan Alm: [wallet] Close DB on error....
128 2017-10-18 18:56:06 0|bitcoin-git|13bitcoin/060.15 1450bd3f6 15practicalswift: Avoid returning a BIP9Stats object with uninitialized values...
129 2017-10-18 18:56:06 0|bitcoin-git|13bitcoin/060.15 14b278a43 15Wladimir J. van der Laan: rpc: Write authcookie atomically...
130 2017-10-18 19:52:03 0|cfields|wumpus: I forgot to mention in the PR, but I believe 11521 would've mitigated today's travis issue
131 2017-10-18 21:39:27 0|ossifrage|This is very strange, the 'copy addess' (all copy to clipboard) functions just stop running on bitcoin-qt (0.15.0 linux), other programs talk to the cut buffer just fine, but not bitcoin-qt
132 2017-10-18 21:43:11 0|ossifrage|Ah, there is console output: "Warn Dissector bug, protocol Bitcoin, in packet 3560375: proto.c:5519: failed assertion "idx >= 0 && idx < num_tree_types""
133 2017-10-18 21:44:06 0|ossifrage|Never mind, that has nothing to do with this...
134 2017-10-18 21:45:29 0|ossifrage|I can't even copy text from the transaction details dialog...
135 2017-10-18 21:59:17 0|DEV_|we are working on a development project of the blockchain any donations will be welcome we will update you on the progress of the project as you go btc wallet : 1LJBnabTgobc6xpgH92eV7yha36KSMvtSP