1 2017-10-21 04:27:09	0|bitcoin-git|[13bitcoin] 15fanquake opened pull request #11541: Build: Fix Automake warnings when running autogen.sh (06master...06fix-automake-warnings) 02https://github.com/bitcoin/bitcoin/pull/11541
 2 2017-10-21 04:27:37	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11013: Build: Fix Automake warnings when running autogen.sh (06master...06override_gzip_env) 02https://github.com/bitcoin/bitcoin/pull/11013
 3 2017-10-21 06:52:12	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11428: Better understandable text for sending transaction option "Request Replace-By-Fee" (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11428
 4 2017-10-21 07:08:58	0|bitcoin-git|[13bitcoin] 15lyrra opened pull request #11542: freebsd 11.1 g++7 build (06master...06freebsd-11) 02https://github.com/bitcoin/bitcoin/pull/11542
 5 2017-10-21 07:10:15	0|bitcoin-git|13bitcoin/06master 14d23be30 15Matt Corallo: [verify-commits] Allow revoked keys to expire
 6 2017-10-21 07:10:15	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ff92fbf24739...e668a6e61d4f
 7 2017-10-21 07:10:16	0|bitcoin-git|13bitcoin/06master 14e668a6e 15Wladimir J. van der Laan: Merge #11539: [verify-commits] Allow revoked keys to expire...
 8 2017-10-21 07:10:58	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11539: [verify-commits] Allow revoked keys to expire (06master...062017-10-verify-regsig-expsig) 02https://github.com/bitcoin/bitcoin/pull/11539
 9 2017-10-21 09:14:59	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e668a6e61d4f...c0e513941398
10 2017-10-21 09:15:00	0|bitcoin-git|13bitcoin/06master 1408fd822 15Suhas Daftuar: qa: add test for minchainwork use in acceptblock
11 2017-10-21 09:15:00	0|bitcoin-git|13bitcoin/06master 14ce8cd7a 15Suhas Daftuar: Don't process unrequested, low-work blocks...
12 2017-10-21 09:15:01	0|bitcoin-git|13bitcoin/06master 1401b52ce 15Suhas Daftuar: Add comment explaining forced processing of compact blocks
13 2017-10-21 09:15:29	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11458: Don't process unrequested, low-work blocks (06master...062017-10-blocks-before-minwork) 02https://github.com/bitcoin/bitcoin/pull/11458
14 2017-10-21 09:33:57	0|sdaftuar|cfields: if you have a chance, i could use advice on #11534 -- i needed to write a unit test where i manipulated the nodes in a CConnman, and I didn't know what the right way to do that was.
15 2017-10-21 09:33:59	0|gribble|https://github.com/bitcoin/bitcoin/issues/11534 | Evict outbound peers if tip is stale by sdaftuar · Pull Request #11534 · bitcoin/bitcoin · GitHub
16 2017-10-21 09:34:17	0|sdaftuar|(so i did something awful in the interim)
17 2017-10-21 11:11:28	0|bitcoin-git|[13bitcoin] 15patikkangayon opened pull request #11543: thebitcoinscode (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11543
18 2017-10-21 14:29:17	0|jtimon|so, the other day we discussed the size of txs in tests is not deterministic because the size of the signatures may vary with the private key (yuck, but thanks aj again for pointing it out, I was hopelessly reading coin selection code)
19 2017-10-21 14:30:14	0|sipa|coin selection is also non-deterministic
20 2017-10-21 14:30:39	0|jtimon|would it make sense to publish some private keys in some tests to make those sizes deterministic ? (related to https://github.com/bitcoin/bitcoin/pull/10757 )
21 2017-10-21 14:39:26	0|jtimon|sipa: mhmm, right, but I think the txs in https://github.com/bitcoin/bitcoin/pull/10757/files#diff-57972ed7ff896d0805470e4b660ba895 are simple enough that it shouldn't matter, no?
22 2017-10-21 14:41:34	0|jtimon|for example, in https://github.com/bitcoin/bitcoin/pull/10757/files#diff-57972ed7ff896d0805470e4b660ba895R126 I'm getting some times 192 and some times 191, it seems like that's due to signatures
23 2017-10-21 15:10:06	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #11545: Support CMV signing of 17~20 key template (06master...0620of20) 02https://github.com/bitcoin/bitcoin/pull/11545
24 2017-10-21 20:27:00	0|cfields|sipa: around? I'm finally re-implementing bech32 to learn/test, and there's an inconsistency that's tripping me up.
25 2017-10-21 20:27:51	0|sipa|cfields: ok?
26 2017-10-21 20:28:17	0|sipa|i'm half here
27 2017-10-21 20:29:51	0|cfields|sipa: hmm, ok. Just noticed something. I'll form a solid question, and maybe some percentage of you will still be around :)
28 2017-10-21 20:32:24	0|cfields|sipa: the bip shows a test vector of 'A12UEL5L', which i presume to be a hrp of 'A' and empty data....
29 2017-10-21 20:32:57	0|cfields|It says "Encoders MUST always output an all lowercase Bech32 string".
30 2017-10-21 20:33:05	0|cfields|Confusingly, the c ref returns a failure on an uppercase HRP, but c++ returns an invalid encoding instead.
31 2017-10-21 20:34:01	0|cfields|I *think* the c++ ref needs to lc() the hrp input first, but the c ref leads me to believe that encoders should expect the hrp to already be lowercased.
32 2017-10-21 20:34:26	0|sipa|cfields: i think someone has ponted out that it's not entirely consistent
33 2017-10-21 20:34:45	0|sipa|either we alwaya assume the hrp is already lowercase
34 2017-10-21 20:34:51	0|sipa|or lc it
35 2017-10-21 20:36:28	0|cfields|well the bip specifies what decoders must not accept mixed case, maybe it would be worth amending to specify that either "encoders must not accept an uppercase hrp", or "encoders must first lowecase the hrp" ?
36 2017-10-21 20:37:41	0|cfields|either way, as-is, the c++ ref returns an incorrect encoding for bech32::encode('A', {})
37 2017-10-21 20:38:35	0|cfields|I'll open an issue for discussion
38 2017-10-21 22:22:48	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11543: thebitcoinscode (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11543