1 2017-12-15 00:19:12	0|bitcoin-git|[13bitcoin] 15himatripuramallu opened pull request #11905: done (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11905
  2 2017-12-15 00:19:27	0|GV|Hi, does anyone know any references on how to validate a P2SH BTC address?
  3 2017-12-15 00:20:59	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11905: done (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11905
  4 2017-12-15 00:21:13	0|GV|I have a validator but I only works with the older addresses. I heard that the byte version is different but the implementation is not that different
  5 2017-12-15 00:21:25	0|GV|it*
  6 2017-12-15 00:21:54	0|meshcollider|GV: what do you mean by validate it? Check that the script you have corresponds to that address? Check that you can sign a transaction sent to that address? what?
  7 2017-12-15 00:22:26	0|meshcollider|GV: And what do you mean by 'older addresses', just normal P2PKH addresses?
  8 2017-12-15 00:22:39	0|meshcollider|GV: This is not the right channel for support, you should ask in #bitcoin
  9 2017-12-15 00:22:50	0|GV|To make sure that the address is a valid P2PKH or P2SH address.
 10 2017-12-15 00:23:31	0|GV|Oh okay, I'll try there
 11 2017-12-15 01:22:58	0|Dylan|watcha working on?
 12 2017-12-15 05:05:38	0|meshcollider|is there any way for the functional tests to assert two error messages in a row
 13 2017-12-15 05:06:43	0|meshcollider|assert_start_raises_init_error only checks the last error I think, which is a more general failure in the test I am working on, the error directly before it is more specific which is what I want to assert
 14 2017-12-15 06:06:05	0|jonasschnelli|I'm working on a RPC call "scantxoutset" (scan utxo set for particular scrips or pubkeys[->script]) based on luke-jr sweepprivkey work. Would it make sense to run the command async?
 15 2017-12-15 06:07:26	0|jonasschnelli|Like "scantxoutset start [<pubkeys>]",... and "scantxoutset status", where the later would tell about the progess... then maybe a "scantxoutset result <jobid>" for getting the txouts (compatible with listunspents for createrawtransaction usage)
 16 2017-12-15 06:08:06	0|jonasschnelli|It would require an additional thread (utxo-scan-thread) and only one scan in time would be allowed
 17 2017-12-15 06:33:55	0|luke-jr|jonasschnelli: this sounds like a "create ram-only wallet; add watch addresses; rescan" tbh
 18 2017-12-15 06:34:47	0|jonasschnelli|luke-jr: scantxoutset purpose is to crate a raw sweep transaction (and more)
 19 2017-12-15 06:35:23	0|jonasschnelli|it would spit out utxos that can directly been used in createrawtransaction.. like:
 20 2017-12-15 06:35:39	0|luke-jr|jonasschnelli: you would then do a fundrawtransaction after the rescan ;)
 21 2017-12-15 06:36:01	0|luke-jr|I guess difference is you don't look at history; but maybe that should just be an alternative to rescan
 22 2017-12-15 06:36:05	0|jonasschnelli|luke-jr: you don't want to do a rescan..
 23 2017-12-15 06:36:18	0|jonasschnelli|the purpose of the utxo scan is to be much faster and works on pruned peers as well
 24 2017-12-15 06:36:26	0|luke-jr|right
 25 2017-12-15 06:37:04	0|luke-jr|my point is that if we're considering an async UTXO scan, it'd be better to have "createwallet" make a RAM-only one, and add a "scanutxo" or something
 26 2017-12-15 06:37:20	0|luke-jr|and the RAM-only wallet is your state
 27 2017-12-15 06:39:02	0|jonasschnelli|luke-jr: What would be the benefit of a mem only CWallet instead of a mem only CKeyStore?
 28 2017-12-15 06:39:26	0|luke-jr|having only one kind of state instead of multiple
 29 2017-12-15 06:42:05	0|jonasschnelli|luke-jr: I can't follow
 30 2017-12-15 06:42:55	0|jonasschnelli|luke-jr: or do you mean the possibility to run multiple utxo scans concurrently?
 31 2017-12-15 06:45:38	0|luke-jr|jonasschnelli: I would expect that to be supported, yes
 32 2017-12-15 06:45:54	0|jonasschnelli|Okay. Yes. That would make sense...
 33 2017-12-15 06:46:03	0|luke-jr|although maybe it has little use case, not sure
 34 2017-12-15 06:46:18	0|luke-jr|so long as the scan can look for multiple things at the same time, that would seem much more sensible after all
 35 2017-12-15 06:47:09	0|jonasschnelli|The major point I'm worried about is an RPC call that requires a couple of minutes to response...
 36 2017-12-15 06:47:33	0|jonasschnelli|multiple scans during the same time seems nice to have, but not extremely important.
 37 2017-12-15 06:49:10	0|luke-jr|I would expect simpler code to use a temporary wallet too
 38 2017-12-15 06:50:07	0|jonasschnelli|luke-jr: maybe
 39 2017-12-15 06:50:11	0|jonasschnelli|BlueMatt: re https://github.com/bitcoin/bitcoin/pull/11281#pullrequestreview-83551405
 40 2017-12-15 06:50:24	0|jonasschnelli|ack on "Caller needs to make sure pindexStop (and the optional pindexStart) are on the main chain after to the addition of any new keys you want to detect transactions for"?
 41 2017-12-15 07:29:20	0|jonasschnelli|wumpus: I think this should be merged (#11616), maybe do a last review/test?
 42 2017-12-15 07:29:22	0|gribble|https://github.com/bitcoin/bitcoin/issues/11616 | Update ban-state in case of dirty-state during periodic sweep by jonasschnelli · Pull Request #11616 · bitcoin/bitcoin · GitHub
 43 2017-12-15 08:44:42	0|vtt|hi
 44 2017-12-15 09:14:40	0|Provoostenator|My entire machine almost completely froze while trying shutdown QT. Maybe because I set DB cache to 10 GB on a 16 GB machine, but it could have some other process I was running.
 45 2017-12-15 09:15:17	0|Provoostenator|More interesting is that when I restart it and then immedidately try to quit, it took about 5 minutes for it to honor that quit command.
 46 2017-12-15 09:16:23	0|Provoostenator|Not much memory and CPU usage at all, just lots of disk writing.
 47 2017-12-15 09:17:33	0|Provoostenator|It showed the "don't shut the computer down message" during the first time (when the computer froze), but it did not show that warning message the second time.
 48 2017-12-15 09:18:39	0|Provoostenator|Does the db cache get written to disk during idle time?
 49 2017-12-15 09:36:19	0|gmaxwell|Provoostenator: no because that would undermine its benefits. (well it gets flushed after 24 hours if fullness doesn't trigger a flsh first)
 50 2017-12-15 09:36:56	0|gmaxwell|the main purpose of the dbcache is to act as a buffer that prevents utxo from ever hitting the database at all.
 51 2017-12-15 09:38:13	0|gmaxwell|since the design changes in the last year we can now do partial flushing, which would allow for some incremental flushing-- e.g. flush things more than N blocks old-- but it hasn't been implemented yet.
 52 2017-12-15 09:42:38	0|wumpus|jonasschnelli: yep, looks good to me
 53 2017-12-15 09:44:16	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c66adb286a89...8585bb8f0584
 54 2017-12-15 09:44:17	0|bitcoin-git|13bitcoin/06master 1457ac471 15Jonas Schnelli: Call BannedListChanged outside of cs_setBanned lock
 55 2017-12-15 09:44:17	0|bitcoin-git|13bitcoin/06master 14c853812 15Jonas Schnelli: Update ban-state in case of dirty-state during periodic sweep
 56 2017-12-15 09:44:18	0|bitcoin-git|13bitcoin/06master 148585bb8 15Wladimir J. van der Laan: Merge #11616: Update ban-state in case of dirty-state during periodic sweep...
 57 2017-12-15 09:44:41	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11616: Update ban-state in case of dirty-state during periodic sweep (06master...062017/11/qt_ban) 02https://github.com/bitcoin/bitcoin/pull/11616
 58 2017-12-15 10:12:22	0|Provoostenator|gmaxwell: I see. I set it to a high number during IBD with the idea of then lowering it after that's done.
 59 2017-12-15 10:14:04	0|Provoostenator|Maybe doing a flush after IBD makes sense?
 60 2017-12-15 10:20:10	0|gmaxwell|yes, a flush after IBD would make sense and probably avoid a lot of complaints from users who crashed their system and are unhappy that its effectively revalidating the whole chain. it's not really clear at what point it should flush though, ibd doesn't have a bright boundary line
 61 2017-12-15 10:21:19	0|luke-jr|when the best known header chain has been fully processed?
 62 2017-12-15 10:22:01	0|Provoostenator|Does the flush block the UI? If not, then I guess it can be done once the "downloading blocks" dialog goes away (I don't know what triggers that).
 63 2017-12-15 10:23:00	0|wumpus|that's complicated - a flush doesn't block normal user activity in the GUI, however holding up cs_main will make it block once the user does any action that requires response from the node
 64 2017-12-15 10:23:27	0|wumpus|or wallet, such as sending a transaction (fee computation), looking at transaction details, pretty much anything
 65 2017-12-15 10:23:30	0|Provoostenator|So then a progress bar would be good.
 66 2017-12-15 10:23:55	0|Provoostenator|Even if the user can dismiss it (as they can the IDB popover), at least they'd have a clue as to why somethign is unresponsive.
 67 2017-12-15 10:23:58	0|wumpus|anyhow isn't this only a problem with huge dbcaches? with the normal settings, flushes are abundant
 68 2017-12-15 10:24:12	0|wumpus|showing a progress bar every time would  be crazy
 69 2017-12-15 10:24:41	0|Provoostenator|If it's likely to take more than 10 seconds, there should be some UI indicator. But it doesn't have to cover the whole screen.
 70 2017-12-15 10:24:49	0|wumpus|we should just fix the GUI to be more async and not block the GUI thread on everything
 71 2017-12-15 10:24:58	0|wumpus|that's much better than hacking even more around it
 72 2017-12-15 10:25:04	0|Provoostenator|That for sure.
 73 2017-12-15 10:25:58	0|Provoostenator|Don't Block The Main Thread is a good mantra
 74 2017-12-15 10:26:40	0|Provoostenator|(iOs devs are obsessed by it, because blocking the main thread for more than 1/60th of a second breaks butter smooth scrolling.
 75 2017-12-15 10:27:20	0|Provoostenator|And probably many crashes are a result of over complicated engineering to keep said scrolling smooth.
 76 2017-12-15 10:28:17	0|wumpus|my brain is too slow to notice 1/60th of a second :) but yes, as a mantra it makes sense, I really wish I could go in time and convince myself to design the GUI with that in mind instead of planning to leave it for later
 77 2017-12-15 10:29:04	0|Provoostenator|Well, if you'd done that, maybe Bitcoin would never have taken off :-)
 78 2017-12-15 10:29:25	0|Provoostenator|(because of the never shipping)
 79 2017-12-15 10:30:25	0|wumpus|yep, good point
 80 2017-12-15 10:30:37	0|wumpus|going from wx to qt was already a huge change
 81 2017-12-15 10:31:05	0|wumpus|luke-jr: how do you mean that?
 82 2017-12-15 10:31:56	0|luke-jr|? quite often when I alt-tab, my window manager blocks on I/O until whatever fsync something else did has finished
 83 2017-12-15 10:32:33	0|wumpus|even when not swapping?
 84 2017-12-15 10:32:51	0|luke-jr|yes, only at 24 GB used (of 32 GB)
 85 2017-12-15 10:33:49	0|luke-jr|I suspect btrfs-related, but oh well
 86 2017-12-15 10:34:00	0|luke-jr|when Talos arrives, I'll probably switch back to ext4 or something
 87 2017-12-15 11:36:07	0|ryanofsky|MarcoFalke, others, anybody know about "Configuring boost..., /bin/sh: 1: requires: not found" errors from travis depends? i filed #11906
 88 2017-12-15 11:36:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/11906 | Travis x86_64-apple-darwin11 errors: "Configuring boost... /bin/sh: 1: requires: not found" · Issue #11906 · bitcoin/bitcoin · GitHub
 89 2017-12-15 11:39:18	0|fanquake|Reminds me, building depends boost is currently broken on osx 10.13
 90 2017-12-15 12:51:31	0|wumpus|fanquake: any idea why? do we have an issue open for that?
 91 2017-12-15 12:53:35	0|bitcoin-git|13bitcoin/06master 14c79d73d 15Matt Corallo: Clarify getbalance meaning a tiny bit in response to questions.
 92 2017-12-15 12:53:35	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8585bb8f0584...df7181952436
 93 2017-12-15 12:53:36	0|bitcoin-git|13bitcoin/06master 14df71819 15Wladimir J. van der Laan: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions....
 94 2017-12-15 12:54:11	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11886: Clarify getbalance meaning a tiny bit in response to questions. (06master...062017-12-getbalance-docs) 02https://github.com/bitcoin/bitcoin/pull/11886
 95 2017-12-15 12:58:19	0|fanquake|wumpus I don't think so. I'll have a look again tonight and open an issue with some more info.
 96 2017-12-15 12:58:29	0|wumpus|thanks!
 97 2017-12-15 12:58:38	0|fanquake|I have a few depends changes I need to PR as well, will do it at the same time.
 98 2017-12-15 14:20:01	0|SopaXorzTaker|I want to propose using Bech32 for private keys
 99 2017-12-15 14:20:20	0|SopaXorzTaker|it would be quite useful, and if we want to phase Base58 out, we must do so everywhere we can
100 2017-12-15 14:31:10	0|wumpus|there would be no point in defining a new format for normal private keys, but for a new format representing private key + segwit metadata, sure
101 2017-12-15 14:44:37	0|bitcoin-git|[13bitcoin] 15johnBuffer opened pull request #11908: Used pragma once instead of defines (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11908
102 2017-12-15 14:44:57	0|SopaXorzTaker|wumpus, bech32 is better than b58
103 2017-12-15 14:45:12	0|SopaXorzTaker|so encoding the private keys in the better encoding would make sense
104 2017-12-15 14:45:56	0|wumpus|what is 'better'? I think a standard that exists is better, just thinking up new encodings because you can is a waste of everyone's time
105 2017-12-15 14:47:53	0|wumpus|so unless there's a use case for making it incompatible with what people are used to, e.g. segwit address type, don't.
106 2017-12-15 14:48:42	0|wumpus|anyhow that's my opinion, feel free to propose a BIP
107 2017-12-15 14:50:55	0|SopaXorzTaker|wumpus, how to propose a BIP?
108 2017-12-15 14:51:13	0|SopaXorzTaker|(I really want you to throw some documentation in my face)
109 2017-12-15 14:52:10	0|wumpus|https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki
110 2017-12-15 14:52:14	0|timothy|SopaXorzTaker: https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki ?
111 2017-12-15 14:54:24	0|SopaXorzTaker|hmm, that seems useful
112 2017-12-15 15:20:55	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11908: Used pragma once instead of defines (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11908
113 2017-12-15 16:50:39	0|xmsx|Hi guys, could you tell me please, is it safe to send RBF transactions from bitcoin-qt? Sent a tx with 50 sat/byte instead of 500 sat/byte :'(
114 2017-12-15 18:13:15	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11909: Gitian: Move keys to sigs repo (06master...06Mf1712-gitianKeysDel) 02https://github.com/bitcoin/bitcoin/pull/11909
115 2017-12-15 18:28:05	0|bitcoin-git|[13bitcoin] 15snomofomo opened pull request #11910: Merge pull request #1 from bitcoin/master (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11910
116 2017-12-15 18:29:54	0|bitcoin-git|[13bitcoin] 15snomofomo closed pull request #11910: Mistake, please remove, sorry (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11910
117 2017-12-15 18:59:49	0|xmsx|I went full retard and thought I'm using RBF by default..:/ Does CPFP work atm?
118 2017-12-15 19:00:47	0|sipa|yes
119 2017-12-15 19:00:49	0|sipa|#bitcoin
120 2017-12-15 19:01:21	0|xmsx|Thanks a lot :)
121 2017-12-15 19:19:03	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #11911: Free CDBEnv instances when not in use (06master...06pr/countenv) 02https://github.com/bitcoin/bitcoin/pull/11911
122 2017-12-15 19:36:14	0|jonasschnelli|full sync against random peers (height: 499414) in 2h57min on AMD Ryzen 5 1600X / SSD
123 2017-12-15 19:38:03	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11912: travis: Post result to irc on failure (06master...06Mf1712-travisIRCfail) 02https://github.com/bitcoin/bitcoin/pull/11912
124 2017-12-15 21:04:15	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #11913: Avoid cs_main during ReadBlockFromDisk Calls (06master...062017-12-no-readblockfromdisk-csmain) 02https://github.com/bitcoin/bitcoin/pull/11913
125 2017-12-15 21:54:47	0|jonasschnelli|BlueMatt: yeah.. not sure...
126 2017-12-15 21:55:14	0|jonasschnelli|You can test it with the GUI abort rescan PR from achow101
127 2017-12-15 21:57:51	0|BlueMatt|test what?