1 2017-12-22 01:35:59	0|fanquake|Can someone add zeromq 4.2.2 & 4.2.3 to /depends-sources on bitcoincore.org
  2 2017-12-22 04:49:04	0|spence|I have a noob-ish question.  How does the code determine the buffer size when reading the blocks, like in reindexing?  I'm playing around with adding my own custom data structure to blocks, and I'm getting an ioerror "read attempted past buffer limit".
  3 2017-12-22 04:59:17	0|sipa|?
  4 2017-12-22 05:05:57	0|spence|sipa is that in response to me?
  5 2017-12-22 05:25:54	0|meshcollider|spence: I would imagine so :) adding custom data structure to blocks sounds like ##altcoin-dev rather than this channel I think?
  6 2017-12-22 05:27:03	0|Varunram|meshcollider: he quit :/
  7 2017-12-22 05:27:14	0|meshcollider|Heh oh well
  8 2017-12-22 07:00:54	0|viru|hi
  9 2017-12-22 07:15:22	0|meshcollider|viru: hi
 10 2017-12-22 07:56:56	0|echeveria|wish list: getmempoolinfo should show the size of the extra transactions pool.
 11 2017-12-22 08:00:44	0|wumpus|what is the 'extra transaction pool'?
 12 2017-12-22 08:01:35	0|echeveria|the compact blocks rejected transaction cache.
 13 2017-12-22 08:06:25	0|wumpus|oh that, yes was confused with the mempool relationship, but sure you could add the size of that structure on some RPC
 14 2017-12-22 08:06:27	0|gmaxwell|echeveria: patches welcome, that would be a oneline change.
 15 2017-12-22 08:10:35	0|wumpus|maybe three lines; would need to add a function to net_processing.cpp to query it from outside, too. But yeah definitely a good first PR.
 16 2017-12-22 08:23:14	0|wumpus|zelest: great to hear that the second try worked :)
 17 2017-12-22 08:23:44	0|bitcoin-git|13bitcoin/06master 14a6365c5 15Cory Fields: depends: fix libzmq's needless linking against libstdc++...
 18 2017-12-22 08:23:44	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/711d16ca4a91...180a25596a29
 19 2017-12-22 08:23:45	0|bitcoin-git|13bitcoin/06master 14180a255 15Wladimir J. van der Laan: Merge #11981: Fix gitian build after libzmq bump...
 20 2017-12-22 08:24:29	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11981: Fix gitian build after libzmq bump (06master...06fix-gitian-build) 02https://github.com/bitcoin/bitcoin/pull/11981
 21 2017-12-22 08:35:18	0|zelest|wumpus, now it failed on Qt though.. :P
 22 2017-12-22 08:35:41	0|zelest|wumpus, but I get the same errors from electrum when I start it.. I think it's related to how X is compiled :/
 23 2017-12-22 08:35:54	0|wumpus|I don't think anyone ever got the GUI to work on openbsd
 24 2017-12-22 08:36:25	0|wumpus|personally I've never used it with a graphical environment of any kind at all, just as server, so I don't know
 25 2017-12-22 08:36:39	0|wumpus|(openbsd, that is.)
 26 2017-12-22 08:37:18	0|wumpus|but please let us know (and add instructions to the openbsd build guide) if you do get it to work
 27 2017-12-22 08:37:30	0|zelest|I'll do my best :)
 28 2017-12-22 08:37:39	0|zelest|I use it as my primary OS since 1.5 year back so
 29 2017-12-22 08:38:10	0|wumpus|I still use linux for that
 30 2017-12-22 08:39:07	0|zelest|:)
 31 2017-12-22 08:40:12	0|Lauda|wumpus kick in #11976, stupidly missed 1 link
 32 2017-12-22 08:40:14	0|gribble|https://github.com/bitcoin/bitcoin/issues/11976 | [Doc] Fix link to installation script by laudaa · Pull Request #11976 · bitcoin/bitcoin · GitHub
 33 2017-12-22 08:41:05	0|zelest|Lauda, i should've reported that myself :D
 34 2017-12-22 08:41:27	0|Lauda|If you do find more errors in the docs, please do
 35 2017-12-22 08:41:32	0|Lauda|this was broken for about a month I think :x
 36 2017-12-22 08:41:49	0|zelest|as wumpus said, not many people use openbsd as their desktop OS :)
 37 2017-12-22 08:42:08	0|zelest|also, this build fail is OpenBSD related..
 38 2017-12-22 08:42:19	0|Lauda|True, but when I found the error I was checking other files for broken links
 39 2017-12-22 08:43:06	0|zelest|https://pastebin.com/Drxb6mY4 :)
 40 2017-12-22 08:43:11	0|zelest|Lauda, yeah :)
 41 2017-12-22 08:43:38	0|luke-jr|will zelest become our new OpenBSD support dev? :P
 42 2017-12-22 08:43:55	0|Lauda|uh oh, that would be nice
 43 2017-12-22 08:44:09	0|zelest|Haha, if I only knew enough about coding :P
 44 2017-12-22 08:44:41	0|zelest|However, I'll do my best :) OpenBSD does have some nice malloc features.. which basically make it a rather unpleasant OS for poorly written software..
 45 2017-12-22 08:44:48	0|zelest|So it's nice to find bugs with :)
 46 2017-12-22 08:47:28	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #11984: doc: Update OpenBSD build instructions for 6.2 (06master...062017_12_openbsd_build_update) 02https://github.com/bitcoin/bitcoin/pull/11984
 47 2017-12-22 08:48:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11976: [Doc] Fix link to installation script (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11976
 48 2017-12-22 09:47:49	0|bitcoin-git|[13bitcoin] 15fanquake opened pull request #11986: [depends] zeromq 4.2.3 (06master...06zeromq-4-2-3) 02https://github.com/bitcoin/bitcoin/pull/11986
 49 2017-12-22 09:47:54	0|zelest|aha! success!
 50 2017-12-22 09:56:56	0|jonasschnelli|zelest: thanks
 51 2017-12-22 09:59:21	0|wumpus|zelest: please base it on https://github.com/bitcoin/bitcoin/pull/11984, so we can do the changes in one go
 52 2017-12-22 09:59:23	0|zelest|just need to read up on the routines and such regarding forking and creating pull requests.. sadly at work atm as well :)
 53 2017-12-22 09:59:34	0|zelest|ahh
 54 2017-12-22 10:00:05	0|wumpus|you can also just comment on the review then I'll update the document
 55 2017-12-22 10:00:40	0|zelest|I will setup a VM with a fresh install and verify all steps though
 56 2017-12-22 10:00:52	0|zelest|as there's a few more packages that needs in (if one wish to run GUI)
 57 2017-12-22 10:03:36	0|wumpus|GUI is not currently part of the description at all, would add that in a separate section at least
 58 2017-12-22 10:05:29	0|zelest|yeah
 59 2017-12-22 10:17:37	0|bitcoin-git|[13bitcoin] 15janstary opened pull request #11987: Tweak the OSX build instructions (06master...06macos) 02https://github.com/bitcoin/bitcoin/pull/11987
 60 2017-12-22 11:26:10	0|bitcoin-git|[13bitcoin] 15AkioNak opened pull request #11988: Reduce redundant code of prevector and speed it up (06master...06prevector) 02https://github.com/bitcoin/bitcoin/pull/11988
 61 2017-12-22 11:40:38	0|locus_|What happen to Bitcoin network ? no block since 12 hours,  Is the price is falling due this issue?
 62 2017-12-22 11:41:42	0|jouke|I just received a block a couple of minutes ago.
 63 2017-12-22 11:41:50	0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #11989: [build] .gitignore: add QT Creator artifacts (06master...06ignore-qt-creator-artifacts) 02https://github.com/bitcoin/bitcoin/pull/11989
 64 2017-12-22 11:42:12	0|jouke|It's not that uncommom to wait for a block for more than an hour.
 65 2017-12-22 11:42:32	0|provoostenator|loucs_: #bitcoin is more appropriate for these questions.
 66 2017-12-22 11:43:16	0|provoostenator|I mean locus_
 67 2017-12-22 11:47:28	0|wumpus|Last block was 500527, on Fri Dec 22 11:41:18 2017
 68 2017-12-22 11:47:59	0|wumpus|well if it was bitcoin core he's running and it's stuck for 12 hours that might be a bug report, but he's already left
 69 2017-12-22 12:04:42	0|meshcollider|where should the actual code to register args for each module go do you think
 70 2017-12-22 12:05:25	0|meshcollider|the RPC stuff has a separate rpc/register.h header for the registration functions, and then the functions are spread over multiple files
 71 2017-12-22 12:06:05	0|meshcollider|but using a struct to hold the globals for the args for each module was suggested right? So where would be the best place for each struct and the corresponding registration code
 72 2017-12-22 12:06:05	0|zelest|When downloading and synking the full blockchain, is it the bandwidth that's the bottleneck or is it computationally heavy to validate it all?
 73 2017-12-22 12:06:14	0|zelest|syncing*
 74 2017-12-22 12:06:20	0|meshcollider|zelest: computationally heavy, verifying the signatures
 75 2017-12-22 12:06:32	0|zelest|Ah, gotcha :)
 76 2017-12-22 12:08:38	0|wumpus|meshcollider: in an init function per module, I guess
 77 2017-12-22 12:08:48	0|wumpus|meshcollider: same as how the RPC registration works
 78 2017-12-22 12:12:02	0|meshcollider|wumpus: I imagine all registration should happen during init and then call parseparameters, but how does that interact with -help, because -help should be checked before init proceeds further right?
 79 2017-12-22 12:12:23	0|meshcollider|so really -help needs to be checked before the registration of args and thus before parseparameters?
 80 2017-12-22 12:12:41	0|wumpus|meshcollider: I guess the registration needs to happen before -help handling
 81 2017-12-22 12:13:13	0|meshcollider|wumpus: alright, seemed a little unnatural to me to put arg registration for everything even before that, but I guess it makes sense
 82 2017-12-22 12:13:14	0|wumpus|meshcollider: that is kind of annoying, but no way around it, as -help is an argument itself *and* it needs access to all the registered other arguments
 83 2017-12-22 12:14:05	0|wumpus|yes it seems kind of unnatural, but the alternative would be to make -help handling special, in that it separately calls the registration functions, I don't think that's better
 84 2017-12-22 12:14:18	0|meshcollider|wumpus: no, I agree
 85 2017-12-22 12:15:56	0|meshcollider|wumpus: So when you refer to "modules", do you mean like bitcoind, wallet, bitcoin-cli, bitcoin-qt and bitcoin-tx?
 86 2017-12-22 12:15:58	0|bitcoin-git|13bitcoin/06master 145cbbbd7 15Sjors Provoost: [Wallet] Use RBF by default in QT only...
 87 2017-12-22 12:15:58	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/180a25596a29...f19ca129ffd7
 88 2017-12-22 12:15:59	0|bitcoin-git|13bitcoin/06master 14f19ca12 15Wladimir J. van der Laan: Merge #11605: [Wallet] Enable RBF by default in QT...
 89 2017-12-22 12:16:19	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11605: [Wallet] Enable RBF by default in QT (06master...06rbf-default) 02https://github.com/bitcoin/bitcoin/pull/11605
 90 2017-12-22 12:16:20	0|meshcollider|wumpus: or more like wallet stuff, blockchain stuff, meta stuff like help/debug, etc.
 91 2017-12-22 12:16:36	0|meshcollider|in terms of dividing up the structs of globals
 92 2017-12-22 12:16:41	0|wumpus|meshcollider: I mean separate implementation units
 93 2017-12-22 12:17:06	0|wumpus|meshcollider: yes, the second
 94 2017-12-22 12:17:40	0|wumpus|the idea is keep the options as close to the code that uses them as possible
 95 2017-12-22 12:18:09	0|wumpus|this allows for localized changes, without generating merge hotspots
 96 2017-12-22 12:18:26	0|meshcollider|wumpus: does a new directory for arg files, which contains one for each "type" of args along with the function to register it all make sense?
 97 2017-12-22 12:18:35	0|meshcollider|a bit like the rpc/ dir with register.h header
 98 2017-12-22 12:18:56	0|wumpus|no, definitely not
 99 2017-12-22 12:19:04	0|wumpus|you don't want to group the args together
100 2017-12-22 12:19:11	0|wumpus|you want to group the args with the code that uses them
101 2017-12-22 12:19:37	0|meshcollider|ah I see, hmm
102 2017-12-22 12:19:53	0|wumpus|creating a directory 'arg' would be like creating a directory 'types' which contains all types. It's not a useful semantic grouping :)
103 2017-12-22 12:20:08	0|meshcollider|wumpus: true haha
104 2017-12-22 12:20:30	0|meshcollider|I feel like this is going to be quite messy to decide where each arg goes though and what groupings make sense
105 2017-12-22 12:20:58	0|meshcollider|especially if certain args are used in multiple places
106 2017-12-22 12:21:09	0|wumpus|I agree it's a bit funny in the rpc case, why would rpcblockchain be under rpc and not under 'block chain functionality' but beh
107 2017-12-22 12:21:45	0|wumpus|grouping things is hard
108 2017-12-22 12:22:06	0|wumpus|meshcollider: yes...
109 2017-12-22 12:23:53	0|meshcollider|wumpus: and also, I have not thought much yet about how to replace SoftSetArg and ForceSetArg, the former being difficult to tell if a value has been set or not using just a pointer to a variable
110 2017-12-22 12:24:17	0|meshcollider|ForceSetArg should be ok I think
111 2017-12-22 12:25:21	0|wumpus|yes, this is quite an annoying project in that regard, having handle so many concerns at the same time
112 2017-12-22 12:26:48	0|meshcollider|mhm its a little overwhelming compared to what I have worked on up to this point :) good experience though
113 2017-12-22 12:51:01	0|ryanofsky|meshcollider, there should be no need for arg registration init functions in typical case. just declaring an arg could add it to global list of args as in https://gflags.github.io/gflags/#define
114 2017-12-22 12:52:15	0|ryanofsky|maybe you should describe what the proposed interface for registering and accessing args somewhere, before going to refactor all the code
115 2017-12-22 12:56:52	0|meshcollider|I was thinking to have a function like gArgs.RegisterArg("-foo", {"-foo", "does something", ARG_BOOL, &foo, false});
116 2017-12-22 12:57:13	0|meshcollider|Where second parameter is an enum with the info needed
117 2017-12-22 12:58:50	0|meshcollider|Then ParseParameters is called as normal which populate all the variables, and then those variables can be used directly without needing gArgs anymore?
118 2017-12-22 13:51:38	0|ryanofsky|meshcollider, that seems ok, but it is a little more verbose compared to gflags where you can just declare a global variable anywhere you want and don't need to write manual init code
119 2017-12-22 13:52:18	0|ryanofsky|also unclear why "-foo" option name needs to be repeated twice and why ARG_BOOL couldn't be derived from the type of &foo
120 2017-12-22 14:54:49	0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #11991: Segwit qt bech32 receive (06master...06segwit-qt-bech32-receive) 02https://github.com/bitcoin/bitcoin/pull/11991
121 2017-12-22 19:49:50	0|bitcoin-git|13bitcoin/06master 1431a0135 15Jonas Schnelli: Add required package dependencies for depends cross compilation...
122 2017-12-22 19:49:50	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f19ca129ffd7...8f68fd281eec
123 2017-12-22 19:49:51	0|bitcoin-git|13bitcoin/06master 148f68fd2 15Jonas Schnelli: Merge #11903: [trivial] Add required package dependencies for depends cross compilation...
124 2017-12-22 19:50:24	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11903: [trivial] Add required package dependencies for depends cross compilation (06master...062017/12/depends_pkg) 02https://github.com/bitcoin/bitcoin/pull/11903
125 2017-12-22 22:51:37	0|phantomcircuit|im not sure how i did this
126 2017-12-22 22:51:44	0|phantomcircuit|but everytime i issue the help rpc command
127 2017-12-22 22:51:49	0|phantomcircuit|my wallet is rescanned
128 2017-12-22 22:52:30	0|achow101|lol
129 2017-12-22 22:52:56	0|achow101|phantomcircuit: did you change any of the code?
130 2017-12-22 22:55:59	0|phantomcircuit|nope
131 2017-12-22 22:56:22	0|phantomcircuit|18a1bbad98bd4321f15e7921d9aec91661499d90
132 2017-12-22 22:56:38	0|phantomcircuit|2017-12-22 22:51:08 RescanFromTime: Rescanning last 500604 blocks
133 2017-12-22 22:58:17	0|achow101|That happens every time you use the help command?
134 2017-12-22 22:59:14	0|phantomcircuit|yeah
135 2017-12-22 22:59:26	0|phantomcircuit|actually i wonder if this binary is the one where i added my own rescan command
136 2017-12-22 22:59:27	0|phantomcircuit|hmm
137 2017-12-22 22:59:59	0|gmaxwell|did you add it to the wrong place?
138 2017-12-22 23:27:50	0|phantomcircuit|gmaxwell, nope
139 2017-12-22 23:27:57	0|phantomcircuit|i did not acquire locks correctly
140 2017-12-22 23:27:58	0|phantomcircuit|so
141 2017-12-22 23:28:03	0|phantomcircuit|rng behavior i guess?
142 2017-12-22 23:53:56	0|ryanw|just getting spun up for the first time, do people use qt as their ide like it mentions in the install docs?