1 2018-01-17 00:28:23	0|promag|is #12194 something to go in the next version?
  2 2018-01-17 00:28:24	0|gribble|https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
  3 2018-01-17 00:53:06	0|meshcollider|do we want #11708 in 0.16 as well for better P2SH-P2WSH support or no
  4 2018-01-17 00:53:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub
  5 2018-01-17 01:18:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12206: qa: Have wallet wait for TransactionAddedToMempool (06master...06Mf1801-qaWalletMempoolAsync) 02https://github.com/bitcoin/bitcoin/pull/12206
  6 2018-01-17 05:18:27	0|meshcollider|poor travis is still having a rest
  7 2018-01-17 06:20:13	0|bitcoin-git|[13bitcoin] 15CryptAxe opened pull request #12207: Start renaming functional tests & update test runner (06master...06updateTests) 02https://github.com/bitcoin/bitcoin/pull/12207
  8 2018-01-17 06:33:48	0|bitcoin-git|[13bitcoin] 15CryptAxe closed pull request #12207: Start renaming functional tests & update test runner (06master...06updateTests) 02https://github.com/bitcoin/bitcoin/pull/12207
  9 2018-01-17 06:49:05	0|bitcoin-git|13bitcoin/06master 14062c8b6 15Jonas Schnelli: Merge #11991: [qt] Receive: checkbox for bech32 address...
 10 2018-01-17 06:49:05	0|bitcoin-git|13bitcoin/06master 1463ac890 15Sjors Provoost: [qt] receive tab: bech32 address opt-in checkbox...
 11 2018-01-17 06:49:05	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/cad504bf4c30...062c8b69f4cc
 12 2018-01-17 06:49:48	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11991: [qt] Receive: checkbox for bech32 address (06master...06segwit-qt-bech32-receive) 02https://github.com/bitcoin/bitcoin/pull/11991
 13 2018-01-17 07:03:54	0|luke-jr|… that tooltip kinda sucks. people don't spend from addresses :/
 14 2018-01-17 07:10:57	0|sipa|luke-jr: improve it!
 15 2018-01-17 07:11:12	0|luke-jr|working on it ;)
 16 2018-01-17 07:12:08	0|luke-jr|I wonder if there's a nicer name than "Bech32" to use here
 17 2018-01-17 07:13:32	0|jonasschnelli|luke-jr: 11937 uses "Native SegWit (Bech32)"
 18 2018-01-17 07:13:46	0|jonasschnelli|s/B/b
 19 2018-01-17 07:14:53	0|luke-jr|sgtm
 20 2018-01-17 07:15:06	0|jonasschnelli|sipa: since you have commented on #11281 (0.16 milestone), I'd like to see your ack there...
 21 2018-01-17 07:15:09	0|gribble|https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
 22 2018-01-17 07:18:02	0|sipa|jonasschnelli: about to pack and fly, but i'm fine with the split of the cs if it's documented
 23 2018-01-17 07:18:20	0|jonasschnelli|sipa: Okay. No hurry... thanks
 24 2018-01-17 07:26:11	0|bitcoin-git|[13bitcoin] 15luke-jr opened pull request #12208: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default (06master...06gui_legacy_bech32) 02https://github.com/bitcoin/bitcoin/pull/12208
 25 2018-01-17 07:32:51	0|meshcollider|sipa: may want to delete the weird comment here  https://github.com/bitcoin/bitcoin/commit/d4aa54c5af925bd0ed81c7a9ffab457149e5d682#commitcomment-26900790
 26 2018-01-17 07:32:52	0|jonasschnelli|luke-jrl: whats the reason to do that: https://github.com/bitcoin/bitcoin/pull/12208/files#diff-dd8e54f9b8311348e3abf1ecb65eda10R151?
 27 2018-01-17 07:33:15	0|jonasschnelli|If someone wants Bech32, why override to OUTPUT_TYPE_P2SH_SEGWIT?
 28 2018-01-17 07:34:43	0|sipa|meshcollider: can't do that right now (on phone)
 29 2018-01-17 07:34:55	0|luke-jr|jonasschnelli: that's if the checkbox is unchecked
 30 2018-01-17 07:35:04	0|luke-jr|if they have it set to Bech32, the checkbox is checked by default
 31 2018-01-17 07:35:05	0|meshcollider|sipa: all good, sorry I posted that before I read your message about packing :)
 32 2018-01-17 07:35:12	0|meshcollider|maybe jonasschnelli can then
 33 2018-01-17 07:35:38	0|jonasschnelli|meshcollider: done
 34 2018-01-17 07:48:21	0|luke-jr|should we bump libsecp256k1 for 0.16? not sure how big a deal the optimisations are
 35 2018-01-17 07:53:14	0|sipa|i don't think there is anything very important
 36 2018-01-17 07:54:42	0|jonasschnelli|luke-jr: I was just confuse that you called OUTPUT_TYPE_P2SH_SEGWIT legacy
 37 2018-01-17 07:55:42	0|luke-jr|jonasschnelli: I did?
 38 2018-01-17 07:56:02	0|jonasschnelli|<bitcoin-git>	[bitcoin] luke-jr opened pull request #12208: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default
 39 2018-01-17 07:56:04	0|gribble|https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
 40 2018-01-17 07:56:20	0|luke-jr|jonasschnelli: that's referring to the ability to use Bech32, if your addresstype=legacy
 41 2018-01-17 07:57:04	0|jonasschnelli|Ah.. now I see.
 42 2018-01-17 07:59:02	0|luke-jr|jonasschnelli: squashed
 43 2018-01-17 08:22:58	0|gmaxwell|sipa: https://github.com/bitcoin/bitcoin/pull/11991#issuecomment-357039103  < this QR encoded Bech32 address is apparently truncated in the QR code itself and it doesn't appear to be in allcaps.
 44 2018-01-17 08:24:57	0|gmaxwell|oh, I see, it's regtest, that threw me.
 45 2018-01-17 08:25:37	0|gmaxwell|but it still isn't allcaps and should be.
 46 2018-01-17 08:33:58	0|gmaxwell|nevermind, I see there is a PR for that
 47 2018-01-17 08:36:10	0|wumpus|only an issue
 48 2018-01-17 08:36:41	0|gmaxwell|oh I see, issue. (ah, thats why I didn't previously see it on the PR list-- I was wondering how I missed it!)
 49 2018-01-17 08:43:15	0|jonasschnelli|gmaxwell: The QRCode truncation should be fixed in master
 50 2018-01-17 08:43:27	0|jonasschnelli|#12173
 51 2018-01-17 08:43:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/12173 | [Qt] Use flexible font size for QRCode image address by jonasschnelli · Pull Request #12173 · bitcoin/bitcoin · GitHub
 52 2018-01-17 08:43:55	0|jonasschnelli|allcaps is a different thing
 53 2018-01-17 08:45:25	0|gmaxwell|jonasschnelli: I was confused by the regtest prefix and thought the prefix was getting truncated.
 54 2018-01-17 08:47:12	0|wumpus|probably want only the URL encoding to capitalize it, and not in other places like below the image
 55 2018-01-17 08:48:55	0|gmaxwell|Personally I think allcaps monospace addresses usually look nicer, at least when presented in isolation. might want to look at it both ways before deciding.
 56 2018-01-17 08:49:20	0|wumpus|but I think caps are wider so it'd have to use an even smaller font
 57 2018-01-17 08:49:54	0|gmaxwell|they're the same size in monospace font.
 58 2018-01-17 08:50:07	0|wumpus|yes
 59 2018-01-17 11:09:23	0|bitcoin-git|13bitcoin/06master 1449e5f3f 15Wladimir J. van der Laan: rpc: Add deprecation error for `getinfo`...
 60 2018-01-17 11:09:23	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/062c8b69f4cc...adce1de9a6ce
 61 2018-01-17 11:09:24	0|bitcoin-git|13bitcoin/06master 14adce1de 15Wladimir J. van der Laan: Merge #12198: rpc: Add deprecation error for `getinfo`...
 62 2018-01-17 11:10:13	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12198: rpc: Add deprecation error for `getinfo` (06master...062018_01_getinfo_deprecation_message) 02https://github.com/bitcoin/bitcoin/pull/12198
 63 2018-01-17 11:16:26	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/adce1de9a6ce...c7978be89964
 64 2018-01-17 11:16:27	0|bitcoin-git|13bitcoin/06master 140b63e3c 15Andrew Chow: Clamp walletpassphrase timeout to 2^(30) seconds and check its bounds...
 65 2018-01-17 11:16:27	0|bitcoin-git|13bitcoin/06master 14134cdc7 15Andrew Chow: Test walletpassphrase timeout bounds and clamping
 66 2018-01-17 11:16:28	0|bitcoin-git|13bitcoin/06master 14c7978be 15Wladimir J. van der Laan: Merge #12101: Clamp walletpassphrase timeout to 2^30 seconds and check its bounds...
 67 2018-01-17 11:17:05	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12101: Clamp walletpassphrase timeout to 2^30 seconds and check its bounds (06master...06wallet-unlock-time-int32) 02https://github.com/bitcoin/bitcoin/pull/12101
 68 2018-01-17 11:52:17	0|meshcollider|What actually needs to be done for #11048, since its in the 0.16 milestone
 69 2018-01-17 11:52:18	0|gribble|https://github.com/bitcoin/bitcoin/issues/11048 | Weird gettransaction details on testnet with segwit · Issue #11048 · bitcoin/bitcoin · GitHub
 70 2018-01-17 11:52:35	0|meshcollider|do the current PRs resolve that or does it still need work
 71 2018-01-17 11:56:20	0|gmaxwell|I think thats a non-issue.
 72 2018-01-17 11:56:31	0|gmaxwell|non-change send to selfs are not hidden.
 73 2018-01-17 11:57:03	0|gmaxwell|otherwise a service with multiple users which sends funds on user commands would lose payments when one user sends to another user by address.
 74 2018-01-17 11:59:56	0|luke-jr|I agree that looks as expected in RPC
 75 2018-01-17 12:00:21	0|gmaxwell|(and 'custom change' to a non-change address is not treated as change)
 76 2018-01-17 12:01:09	0|meshcollider|ok, wumpus or someone can remove it from the milestone then :)
 77 2018-01-17 12:01:19	0|luke-jr|I really don't see the use case for 'custom change'.
 78 2018-01-17 12:02:16	0|gmaxwell|I whined a bit about it when implemented. I could contrive up some for you, e.g. you're slowly migrating from one old wallet to a new one, and want all your change to go to the new one.
 79 2018-01-17 12:02:53	0|gmaxwell|it's certantly an advanced feature.
 80 2018-01-17 12:03:15	0|luke-jr|hmm, that's an interesting idea
 81 2018-01-17 12:03:45	0|gmaxwell|I can't think of any other usecase.
 82 2018-01-17 12:04:05	0|gmaxwell|oh sorry, I know another one but its bad.
 83 2018-01-17 12:04:17	0|gmaxwell|E.g. user really insistant on keeping all their funds on a single address.
 84 2018-01-17 12:04:27	0|gmaxwell|Which there can be justifications for, but they're still bad. :)
 85 2018-01-17 12:05:08	0|wumpus|meshcollider: ok
 86 2018-01-17 12:10:42	0|sipa|i can't ooen an issue now, but we should mark addwitnessaddress as deprecated
 87 2018-01-17 12:14:18	0|gmaxwell|Does it do anything anymore?
 88 2018-01-17 12:14:59	0|gmaxwell|meshcollider: I went and added some explination to that issue with the sends to self.
 89 2018-01-17 12:15:13	0|meshcollider|gmaxwell: sounds good, thanks
 90 2018-01-17 12:15:44	0|gmaxwell|meshcollider: thanks for bringing attention to it.
 91 2018-01-17 12:20:01	0|sipa|gmaxwell: it probably at least resets the address label
 92 2018-01-17 12:22:19	0|wumpus|something like  #12210?
 93 2018-01-17 12:22:20	0|gribble|https://github.com/bitcoin/bitcoin/issues/12210 | wallet: Deprecate addwitnessaddress by laanwj · Pull Request #12210 · bitcoin/bitcoin · GitHub
 94 2018-01-17 12:22:22	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #12210: wallet: Deprecate addwitnessaddress (06master...062018_01_deprecate_addwitnessaddress) 02https://github.com/bitcoin/bitcoin/pull/12210
 95 2018-01-17 12:29:45	0|meshcollider|ping kallewoof: are you going to reopen #11489 for 0.16?
 96 2018-01-17 12:29:47	0|gribble|https://github.com/bitcoin/bitcoin/issues/11489 | [wallet] sendtoaddress style argument by kallewoof · Pull Request #11489 · bitcoin/bitcoin · GitHub
 97 2018-01-17 12:29:57	0|meshcollider|to close #11134
 98 2018-01-17 12:29:58	0|gribble|https://github.com/bitcoin/bitcoin/issues/11134 | Sendtoaddress flag for sending change to a segwit address? · Issue #11134 · bitcoin/bitcoin · GitHub
 99 2018-01-17 12:33:32	0|meshcollider|wumpus: is that !IsDeprecatedRPCEnabled() stuff overkill for this case
100 2018-01-17 12:34:09	0|gmaxwell|probably, but uniformity is cheap.
101 2018-01-17 12:34:37	0|meshcollider|gmaxwell: I mean he hasn't currently used it, was wondering if that was a deliberate choice :)
102 2018-01-17 12:34:48	0|gmaxwell|ah!
103 2018-01-17 12:35:48	0|wumpus|meshcollider: how does that work?
104 2018-01-17 12:36:13	0|wumpus|FWIW I've added it to the release notes as well now
105 2018-01-17 12:36:20	0|meshcollider|wumpus: its the stuff which forces you to use -deprecatedrpc=addwitnessaddress argument to use it
106 2018-01-17 12:36:45	0|meshcollider|like estimatefee uses
107 2018-01-17 12:36:53	0|wumpus|oh I see, sure
108 2018-01-17 12:36:56	0|gmaxwell|might be premature to do that?
109 2018-01-17 12:37:05	0|gmaxwell|do we want it to immediately stop working without settings?
110 2018-01-17 12:37:15	0|gmaxwell|(I'm asking, no strong opinions)
111 2018-01-17 12:37:19	0|meshcollider|are we planning on removing it in 0.17?
112 2018-01-17 12:37:40	0|wumpus|I was assuming it would be removed in next major release, if not, should update the release notes :)
113 2018-01-17 12:37:57	0|meshcollider|It should be a trivial transition for most use cases I'd imagine, and it was always advertised as experimental so I'd say its fine how it is
114 2018-01-17 12:38:02	0|wumpus|waiting another release and going for 0.18 is fine with me too
115 2018-01-17 12:38:09	0|gmaxwell|yea, I suppose! if we're going to remove it in 0.17 then the disruptive choice is probably the right one.
116 2018-01-17 12:38:25	0|meshcollider|nah it shouldn't have gained enough use in this short timeframe to be necessary waiting another whole release
117 2018-01-17 12:38:30	0|meshcollider|i vote remove in 17
118 2018-01-17 12:38:54	0|gmaxwell|strangly I don't feel any cosmic force hurrying the removal of no-op RPCs.  Perhaps one GOOD argument for going faster is this: people are going to keep following old "how to segwit" guides.
119 2018-01-17 12:39:35	0|wumpus|gmaxwell: which is another good reason to use the IsDeprecatedRPCEnabled()  stuff, I guess, as otherwise it will seem to just keep working a s intended
120 2018-01-17 12:39:49	0|gmaxwell|yes, exactly, sorry "going faster" wasn't clear.
121 2018-01-17 12:39:59	0|meshcollider|yeah users tend to ignore help text even if it is in caps ;)
122 2018-01-17 12:40:12	0|gmaxwell|banner blindness.
123 2018-01-17 12:40:30	0|wumpus|well, more that they'll not look at the help if they 'help' is some online or wiki guide
124 2018-01-17 12:41:54	0|gmaxwell|right, which is why its important to fail.  I would sort of like if in general we start breaking interfaces a little faster, at least until we cause complaints. we've gone to far in the never breaking things direction for too long. :) and IsDeprecatedRPCEnabled is a pretty nice middle ground.
125 2018-01-17 12:56:04	0|UnderDog_|good morning
126 2018-01-17 12:57:09	0|meshcollider|UnderDog_: maybe for some ;)
127 2018-01-17 12:57:32	0|UnderDog_|work got cancled today
128 2018-01-17 12:57:35	0|UnderDog_|bad freeze
129 2018-01-17 12:58:08	0|UnderDog_|i still woke up at 4am and so i decided to make a whiskey and do laundry
130 2018-01-17 12:59:45	0|UnderDog_|i haven't used IRC in almost 20 years
131 2018-01-17 13:00:31	0|meshcollider|UnderDog_: I think you might be in the wrong channel, maybe try #bitcoin for general discussion on it, this channel is just for bitcoin core development
132 2018-01-17 13:02:22	0|UnderDog_|well i'm not part of the development team but I did not see another IRC available and thought I might be likely to find similar persons of interest here.
133 2018-01-17 13:03:31	0|sipa|#bitcoin may be a better place
134 2018-01-17 13:04:19	0|UnderDog_|ok
135 2018-01-17 13:05:12	0|UnderDog_|only think I might be able to help with is thermodynamic's and heat extraction designs for your servers
136 2018-01-17 13:05:27	0|UnderDog_|no need ofr  's
137 2018-01-17 13:05:30	0|UnderDog_|for*
138 2018-01-17 14:07:55	0|waseem|/UNIGNORE a5m0
139 2018-01-17 15:27:56	0|Pritty_Kitty|Hello and thank you to all good Core developers for what you do.
140 2018-01-17 15:28:03	0|Pritty_Kitty|I'm trying to learn the system and use it but hope to get answer for a question:
141 2018-01-17 15:28:12	0|Pritty_Kitty|I have a 0.15.1 node with a "testnet=true" setting. getblocktemplate gives me a template where "txid" and "hash" field are identical for transaction.
142 2018-01-17 15:28:20	0|Pritty_Kitty|Should they not be different for SegWit is running on testnet?
143 2018-01-17 15:28:30	0|Pritty_Kitty|Will i use the "hash" field to create my witness hash tree and put a commit in my coinbase value? Do i put this commit value AFTER the BIP34 blockheight value?
144 2018-01-17 15:29:33	0|Pritty_Kitty|I am trying to make blocks.
145 2018-01-17 15:29:48	0|Pritty_Kitty|I want them SegWit compatible
146 2018-01-17 16:06:28	0|wxss|t
147 2018-01-17 16:25:59	0|Randolf|Pritty_Kitty:  You seem to be asking a "how to use Bitcoin" type of question.  You'll likely find that such questions are better suited for the #bitcoin channel as this one you're asking in now is specifically focused on Bitcoin core software development.
148 2018-01-17 17:15:18	0|Pritty_Kitty|No no i am a developer asking technical questions about bitcoin. I have built php code to deserialize transactions and build a merkle tree. Now i am working on the witness tree.
149 2018-01-17 17:17:00	0|Pritty_Kitty|But i could just mine regular blocks without SegWit. But I know you want SegWit so i hope for answers to my questions
150 2018-01-17 17:23:06	0|instagibbs|Pritty_Kitty, this isn't a question for Bitcoin Core development though. maybe #bitcoin-dev
151 2018-01-17 17:23:28	0|Pritty_Kitty|ok ty i will try there
152 2018-01-17 18:30:49	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #12211: Avoid potential null dereference in ReceiveCoinsDialog constructor (06master...06pr/nullrecv) 02https://github.com/bitcoin/bitcoin/pull/12211
153 2018-01-17 20:00:56	0|jojeyh|Can anyboyd give me a brief explanation for "struct zero_after_free_allocator" ?
154 2018-01-17 20:01:20	0|jojeyh|What is the point of this object instead of a traditional std::allocator ?
155 2018-01-17 20:01:50	0|jojeyh|in file "bitcoin/src/support/allocators/zeroafterfree.h"
156 2018-01-17 20:06:39	0|luke-jr|jojeyh: std::allocator probably doesn't zero when freeing
157 2018-01-17 20:06:50	0|jojeyh|can you explain what this means?
158 2018-01-17 20:06:53	0|luke-jr|jojeyh: in other words, it leaves the data in memory
159 2018-01-17 20:07:20	0|luke-jr|which means when something else is allocated (hypothetically even in another program), it might have the data in its new memory
160 2018-01-17 20:07:29	0|jojeyh|luke-jr: ok, so basically if a std::allocator were used then even after the memory is freed the bits will still be nonzero ?
161 2018-01-17 20:07:34	0|luke-jr|right
162 2018-01-17 20:07:42	0|jojeyh|k thanks
163 2018-01-17 20:08:01	0|luke-jr|this is particularly bad if the memory might contain private key or passphrase info
164 2018-01-17 20:08:37	0|jojeyh|ah that makes sense
165 2018-01-17 22:38:28	0|bitcoin-git|[13bitcoin] 15bitspill opened pull request #12212: fix spelling (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12212
166 2018-01-17 22:40:17	0|mrannanay|#11227 seems to have both milestones covered. Needs rebase.
167 2018-01-17 22:40:19	0|gribble|https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
168 2018-01-17 22:50:11	0|promag|sipa: addmultisigaddress should have address_type option?
169 2018-01-17 23:40:49	0|bitcoin-git|[13bitcoin] 15promag opened pull request #12213: 2018 01 addmultisigaddress address type (06master...062018-01-addmultisigaddress-address-type) 02https://github.com/bitcoin/bitcoin/pull/12213