1 2018-01-22 03:03:09	0|Varunram|gmaxwell: I think kalle stumbled upon the bug a long while back, doesn't seem to be fixed yet
  2 2018-01-22 04:59:22	0|bitcoin-git|[13bitcoin] 15jangck303 opened pull request #12238: testing#1 (06master...06bitcoin_testing) 02https://github.com/bitcoin/bitcoin/pull/12238
  3 2018-01-22 05:01:47	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12238: testing#1 (06master...06bitcoin_testing) 02https://github.com/bitcoin/bitcoin/pull/12238
  4 2018-01-22 05:30:13	0|mryandao|when calling getrawmempool true, should all fees be in sats or btc? because nFee field is in BTC while the others (ancestorfees, decendentfees) are in sats.
  5 2018-01-22 05:33:12	0|sipa|that sounds like a bug
  6 2018-01-22 06:23:29	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12149: Unlock Wallet Implemented. (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12149
  7 2018-01-22 06:27:14	0|Randolf|mryandao:  Consistency in that area seems like a good idea to me.
  8 2018-01-22 08:28:29	0|bitcoin-git|[13bitcoin] 15mryandao opened pull request #12240: changed fee to be in sats instead of btc (06master...06fix-getrawmempool-fee-representation) 02https://github.com/bitcoin/bitcoin/pull/12240
  9 2018-01-22 08:45:18	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10437: [WIP] Implement BIP135 (generalized versionbits) (06master...06bip135-core-dev-clean1) 02https://github.com/bitcoin/bitcoin/pull/10437
 10 2018-01-22 09:17:18	0|sidd_|hey guys,
 11 2018-01-22 09:17:24	0|sidd_|do you know Satoshi Nakamoto
 12 2018-01-22 09:17:50	0|sidd_|plz tell me who he is in realty
 13 2018-01-22 09:18:03	0|sidd_|i have not slept for so many dys
 14 2018-01-22 09:18:15	0|sidd_|this question has been eating me inside
 15 2018-01-22 09:19:20	0|sidd_|i have 10000 bit coins
 16 2018-01-22 09:19:36	0|sidd_|which i bought way back in 2012
 17 2018-01-22 09:20:04	0|meshcollider|sidd_: you're in the wrong channel, please take this to #bitcoin
 18 2018-01-22 10:22:09	0|mryandao|heh, so with fees, the reason why the test are failing is because the `getnetworkinfo` rpc endpoint reports minrelayfees in btc denominations as well
 19 2018-01-22 10:22:30	0|mryandao|is there a convention as to what denomination fees should be in?
 20 2018-01-22 10:22:40	0|wumpus|the idea is that all amounts on the RPC interface should be in BTC
 21 2018-01-22 10:23:01	0|wumpus|there are some exceptions which have to do with specific BIPs (getblocktemplate etc)
 22 2018-01-22 10:23:13	0|mryandao|so `ancestorFee` and `decendentFee` should be in BTC instead?
 23 2018-01-22 10:23:26	0|wumpus|but the guideline is to use AmountFromValue and ValueFromAmount for all monetary amounts unless there is a really good reason otherwise
 24 2018-01-22 10:23:49	0|wumpus|I guess - though changing the interface is dangerous
 25 2018-01-22 10:23:55	0|mryandao|the two fields report in satoshis when you make a `getrawmempool true`
 26 2018-01-22 10:23:56	0|promag|what output format should createmultisig use if wallet is not enabled?
 27 2018-01-22 10:24:10	0|wumpus|if people have already built software that makes the assumption that values are in a certain unit, changing it can lead to enormous funds loss
 28 2018-01-22 10:24:45	0|wumpus|but so can having mixed units on one call, so I don't know...
 29 2018-01-22 10:25:17	0|mryandao|uhh, i'll leave the PR there and wait for more comments?
 30 2018-01-22 10:41:38	0|promag|mryandao: which PR?
 31 2018-01-22 10:44:06	0|meshcollider|promag: #12240 I assume
 32 2018-01-22 10:44:07	0|gribble|https://github.com/bitcoin/bitcoin/issues/12240 | changed fee to be in sats instead of btc by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub
 33 2018-01-22 10:44:19	0|promag|ty
 34 2018-01-22 10:44:56	0|promag|I guess that's breaking change
 35 2018-01-22 10:46:06	0|promag|mryandao: you can't simply change a field unit
 36 2018-01-22 10:46:30	0|meshcollider|promag: it was assumed to be a bug though, discussed slightly above ^
 37 2018-01-22 10:47:02	0|promag|meshcollider: bug or not
 38 2018-01-22 10:47:25	0|meshcollider|promag: yeah I know, just clarifying :)
 39 2018-01-22 10:47:47	0|promag|mryandao: I suggest to add a new field and signal that as deprecated
 40 2018-01-22 10:48:49	0|promag|like add "fees": { "value": ..., "modified": ... }
 41 2018-01-22 10:54:53	0|bitcoin-git|[13bitcoin] 15fanquake opened pull request #12241: [trivial][docs] Fix incorrect link in /test/ README.md (06master...06trivial-fix-util-link) 02https://github.com/bitcoin/bitcoin/pull/12241
 42 2018-01-22 10:56:28	0|mryandao|promag: ok, i'll note that for future reference -- not breaking changes in RPC.
 43 2018-01-22 10:57:02	0|mryandao|but wumpus did mention that fees shown in RPC calls should be in BTC.
 44 2018-01-22 10:57:24	0|mryandao|so i'm thinking of changing `ancestor/decendentFees` to btc-denominations instead.
 45 2018-01-22 11:01:06	0|promag|mryandao: that is also a no-go
 46 2018-01-22 11:03:28	0|promag|mryandao: you can add breaking change behind a flag. bad example: `bitcoind -fixrpcunits` - the user knows what he is doing so we can expect he fixes his software
 47 2018-01-22 11:04:05	0|wumpus|meh, I wouldn't add flags
 48 2018-01-22 11:04:12	0|wumpus|the way to do this would be to add fields
 49 2018-01-22 11:04:20	0|wumpus|then deprecate the old ones at some point in the far future
 50 2018-01-22 11:04:34	0|promag|wumpus: yes I also prefer that
 51 2018-01-22 11:04:42	0|fanquake|Afternoon
 52 2018-01-22 11:04:49	0|promag|o/
 53 2018-01-22 11:04:53	0|promag|Morning
 54 2018-01-22 11:04:56	0|wumpus|new options need to have a very good rationale, there are too many of them already
 55 2018-01-22 11:05:06	0|wumpus|o\
 56 2018-01-22 11:05:40	0|mryandao|alright, i'll add new fields
 57 2018-01-22 11:05:44	0|mryandao|what should I call them?
 58 2018-01-22 11:05:53	0|mryandao|`ancestorFeeInBTC`?
 59 2018-01-22 11:06:55	0|promag|I tend to like structured json, so "fees": { ..., "ancestor": ..., ... }
 60 2018-01-22 11:07:10	0|wumpus|no opinion on names...
 61 2018-01-22 11:07:13	0|meshcollider|agree with promag, new fees object would be cleaner
 62 2018-01-22 11:07:18	0|mryandao|that's a pretty big breaking change
 63 2018-01-22 11:07:29	0|wumpus|adding fields is never a breaking change
 64 2018-01-22 11:07:33	0|mryandao|oh, but i leave existing fields intact.
 65 2018-01-22 11:07:33	0|mryandao|right
 66 2018-01-22 11:07:35	0|promag|the docs would say units in "fees" are BTC
 67 2018-01-22 11:07:43	0|mryandao|gotcha
 68 2018-01-22 11:07:49	0|wumpus|promag: exactly, the unit should be in the doc, not the name/handle
 69 2018-01-22 11:08:43	0|wumpus|removing the fields at some point would be a big breaking change, but let's wait a few major versions for that... if it's just for consistency there's no hurry to break software
 70 2018-01-22 11:11:06	0|fanquake|wumpus I see more wormhole activity from you :p
 71 2018-01-22 11:14:39	0|wumpus|fanquake: how, exotic particle leaks, is the shielding failing? :p
 72 2018-01-22 11:17:46	0|fanquake|wumpus it's not quite magic ;)
 73 2018-01-22 11:29:48	0|zelest|I think I just had a quite clever idea... What about showing bitcoin addresses in certain colors? E.g, convert it to hex and pick the 6 values (like, 2 form the beginning, 2 from the middle, 2 from the last) and use it as RGB and color it..
 74 2018-01-22 11:30:19	0|zelest|That way people can quickly verify if an address is wrong :)
 75 2018-01-22 11:35:57	0|wumpus|isn't blockchair (the block exporer) doing that?
 76 2018-01-22 11:36:06	0|zelest|It is?
 77 2018-01-22 11:41:27	0|fanquake|There is an issue open for something similar. I cannot find it.
 78 2018-01-22 11:41:44	0|fanquake|Similar to #11642
 79 2018-01-22 11:41:45	0|gribble|https://github.com/bitcoin/bitcoin/issues/11642 | Visual Hashes for Bitcoin Addresses · Issue #11642 · bitcoin/bitcoin · GitHub
 80 2018-01-22 11:54:40	0|athator|Getting a graphic designer / GUI designer on board to spruce it up would be optimal as well from a user perspective
 81 2018-01-22 11:54:40	0|athator|https://en.bitcoin.it/wiki/User:Gmaxwell/visual_fingerprint_comparison
 82 2018-01-22 13:23:02	0|bitcoin-git|13bitcoin/06master 14bf18977 15fanquake: [trivial][docs] Fix incorrect link in /test/ README.md
 83 2018-01-22 13:23:02	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f4c942e36154...b03013396cb2
 84 2018-01-22 13:23:03	0|bitcoin-git|13bitcoin/06master 14b030133 15MarcoFalke: Merge #12241: [trivial][docs] Fix incorrect link in /test/ README.md...
 85 2018-01-22 13:23:57	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12241: [trivial][docs] Fix incorrect link in /test/ README.md (06master...06trivial-fix-util-link) 02https://github.com/bitcoin/bitcoin/pull/12241
 86 2018-01-22 13:30:45	0|bitcoin-git|13bitcoin/06master 14ac96e78 15Russell Yanofsky: test_runner: Readable output if create_cache.py fails...
 87 2018-01-22 13:30:45	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b03013396cb2...b987ca4ee495
 88 2018-01-22 13:30:46	0|bitcoin-git|13bitcoin/06master 14b987ca4 15MarcoFalke: Merge #12227: test_runner: Readable output if create_cache.py fails...
 89 2018-01-22 13:31:35	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12227: test_runner: Readable output if create_cache.py fails (06master...06pr/runcache) 02https://github.com/bitcoin/bitcoin/pull/12227
 90 2018-01-22 13:47:24	0|bitcoin-git|13bitcoin/06master 14b21244e 15Jeff Rade: Updating benchmarkmarking.md with an updated sample output and help options
 91 2018-01-22 13:47:24	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b987ca4ee495...b5e4b9b5100e
 92 2018-01-22 13:47:25	0|bitcoin-git|13bitcoin/06master 14b5e4b9b 15MarcoFalke: Merge #12187: [Docs] Updating benchmarkmarking.md with an updated sample output...
 93 2018-01-22 13:48:14	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12187: [Docs] Updating benchmarkmarking.md with an updated sample output (06master...06benchmark_output) 02https://github.com/bitcoin/bitcoin/pull/12187
 94 2018-01-22 14:25:33	0|bitcoin-git|[13bitcoin] 15russhianhere opened pull request #12242: 0.8 (060.8...060.8) 02https://github.com/bitcoin/bitcoin/pull/12242
 95 2018-01-22 14:26:49	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12242: 0.8 (060.8...060.8) 02https://github.com/bitcoin/bitcoin/pull/12242
 96 2018-01-22 17:28:31	0|bill09086|Here's a few cryptocurrencies I invested in that made me $265,000 with a small investment https://tinyurl.com/yad8khq9
 97 2018-01-22 17:30:29	0|eu-Robert|lol
 98 2018-01-22 17:50:35	0|PiedPiper|i clicked
 99 2018-01-22 20:02:00	0|joel_k_lashbrook|exir
100 2018-01-22 20:02:02	0|joel_k_lashbrook|exit