1 2018-02-02 00:58:17	0|meshcollider|wumpus: I think I've finished off the release notes
  2 2018-02-02 00:58:35	0|meshcollider|If others could double check I haven't made any stupid mistakes or left anything out that'd be good
  3 2018-02-02 00:58:47	0|meshcollider|https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
  4 2018-02-02 01:01:29	0|sipa|meshcollider: address_type is also added to getnewaddress
  5 2018-02-02 01:01:54	0|meshcollider|sipa: but that RPC is deprecated now so should we even bother adding that?
  6 2018-02-02 01:02:22	0|sipa|what?
  7 2018-02-02 01:02:43	0|meshcollider|oh sorry I misread and thought you said addwitnessaddress
  8 2018-02-02 01:02:44	0|sipa|you're confusing getnewaddress with addwitnessaddress, i think?
  9 2018-02-02 01:02:47	0|meshcollider|yeah
 10 2018-02-02 01:03:15	0|sipa|also, with the inclusion of scripts in dump/import, i think those RPCs may just work fine
 11 2018-02-02 01:04:05	0|meshcollider|sipa: true, we should test it properly first before claiming though IMO?
 12 2018-02-02 01:04:33	0|sipa|meshcollider: yes, absolutely
 13 2018-02-02 01:04:48	0|sipa|but i think there's a good chance it just works now
 14 2018-02-02 01:04:49	0|meshcollider|Oh I'll just remove mention of those RPCs altogether for now rather than saying they are or are not supported
 15 2018-02-02 01:05:07	0|sipa|sign/verify and importmulti definitely don't support segwit addresses
 16 2018-02-02 01:08:49	0|promag|s/segwit/SegWit ?
 17 2018-02-02 01:09:02	0|promag|or who cares?
 18 2018-02-02 01:12:08	0|promag|#low-level-rpc-changes should mention fundrawtransaction change type and addmultisigaddress address type ?
 19 2018-02-02 01:13:25	0|sipa|meshcollider: validateaddress has had many changes
 20 2018-02-02 01:13:42	0|meshcollider|promag: you can change them all if you want :)
 21 2018-02-02 01:13:56	0|sipa|just mentioning it now in case someone wants to do a writeup
 22 2018-02-02 01:14:01	0|sipa|if not, i'll do so in a few days
 23 2018-02-02 01:14:26	0|meshcollider|promag: I added them to the segwit sections rather than the low level RPC changes, IMO no point duplicating the info as long as its in a logical place
 24 2018-02-02 01:15:01	0|promag|ok cool
 25 2018-02-02 01:15:02	0|meshcollider|sipa: what kind of changes, andrews PR hasnt been merged yet has it
 26 2018-02-02 01:15:10	0|meshcollider|I must have missed something
 27 2018-02-02 01:15:52	0|sipa|meshcollider: included in 11403
 28 2018-02-02 01:16:17	0|sipa|commit 3eaa003c8
 29 2018-02-02 01:16:56	0|fanquake|In the SHA256 ASM section. s/has/have s/this was/they were s/but is/but are and remove "is no" .
 30 2018-02-02 01:17:13	0|fanquake|Can we get conflicts when editing the wiki? I don't want to touch it in case I mess up your good work.
 31 2018-02-02 01:17:32	0|sipa|meshcollider: specifically, there are new "embedded" and "pubkeys" fields that apply to non-segwit as well
 32 2018-02-02 01:18:15	0|meshcollider|fanquake: I guess there might be conflicts if we edited the same part but I'm not currently editing so it should be ok
 33 2018-02-02 01:18:28	0|meshcollider|sipa: ooh ok I missed those, will add then
 34 2018-02-02 01:19:21	0|sipa|also, validateaddress has new functionality related to P2SH-P2WPKH, so that doesn't fit under BIP173 support
 35 2018-02-02 01:23:46	0|promag|do we have any idea what are the top 5 of most called RPC
 36 2018-02-02 01:27:25	0|gmaxwell|it's very different for different users.
 37 2018-02-02 01:27:45	0|gmaxwell|getblocktemplate and listtransactions are probably the most common rpcs (for miners, and people getting payments, respectively)
 38 2018-02-02 01:28:14	0|gmaxwell|and then other than a few status things, I'd expect everything else to be basically insubstantial compared to those.
 39 2018-02-02 01:38:54	0|promag|gmaxwell: listunspent?
 40 2018-02-02 01:39:41	0|gmaxwell|I wouldn't expect listunspent to be called more than sendrawtransaction, which would be rare since we know that network wide there is only a certian amount of that.
 41 2018-02-02 01:46:41	0|promag|ok ty
 42 2018-02-02 02:02:07	0|promag|gmaxwell: does this make sense https://github.com/promag/bitcoin/commit/c409b1adac59329b78b8c48f131f8ca032988412 ?
 43 2018-02-02 02:04:27	0|gmaxwell|I don't think so-- at least if I understand it correctly. listtransactions should be atomic with the blockchain. If the chain reorgs you shouldn't get mixed data on transactions. An example of how this could result in funds loss, say I pay you with a transaction then doublespend it to pay more fees with another txn also paying you.  If you see a reorg that goes from one to the other during a lis
 44 2018-02-02 02:04:33	0|gmaxwell|ttransactions, they you might see both payments as confirmed and credit the user twice.
 45 2018-02-02 02:07:06	0|promag|gmaxwell: it's still atomic
 46 2018-02-02 02:07:29	0|promag|sorting the output is done without the locks
 47 2018-02-02 02:08:48	0|gmaxwell|hm? is it copying all the data then? otherwise confirm counts and whatnot would get updated, no?
 48 2018-02-02 02:09:05	0|promag|i think so, AcentryToJSON
 49 2018-02-02 02:09:57	0|gmaxwell|oh I see how I was misreading it.
 50 2018-02-02 02:10:03	0|gmaxwell|okay thats plausable
 51 2018-02-02 02:10:39	0|promag|I guess this is easy to bench
 52 2018-02-02 02:13:23	0|bitcoin-git|[13bitcoin] 15promag opened pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (06master...062018-02-listtransactions) 02https://github.com/bitcoin/bitcoin/pull/12330
 53 2018-02-02 03:46:21	0|Franklin_|does anyone have examples of cross chain atomic swap script(s) for onchain swaps?
 54 2018-02-02 04:15:34	0|dafuq|could someone who knows unix/linux possibly chime in on PR #12322?
 55 2018-02-02 04:15:35	0|gribble|https://github.com/bitcoin/bitcoin/issues/12322 | Docs: Remove step making cloned repository world-writable for Windows build. by murrayn · Pull Request #12322 · bitcoin/bitcoin · GitHub
 56 2018-02-02 05:45:35	0|gmaxwell|wumpus: I think the FD issue is likely fixed.  I ran RC1 in valgrind and after a few minutes of running had a branch on uninitilized in socket close.
 57 2018-02-02 05:45:56	0|gmaxwell|I pulled up to master, compiled, restarted, and now hours later no such error.
 58 2018-02-02 05:46:26	0|gmaxwell|As suspected, an uninitilied close was closing random FDs.
 59 2018-02-02 06:11:01	0|meshcollider|That's good \o/
 60 2018-02-02 07:43:33	0|bitcoin-git|[13bitcoin] 15murrayn opened pull request #12331: Docs: Properly alphabetize output of CLI --help option. (06master...06help_changes) 02https://github.com/bitcoin/bitcoin/pull/12331
 61 2018-02-02 08:51:24	0|bitcoin-git|13bitcoin/06master 14660f5f1 15Cory Fields: net: don't retry failed oneshot connections forever
 62 2018-02-02 08:51:24	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/41363fe11df5...aa360e76a74b
 63 2018-02-02 08:51:25	0|bitcoin-git|13bitcoin/06master 14aa360e7 15Wladimir J. van der Laan: Merge #12329: net: don't retry failed oneshot connections forever...
 64 2018-02-02 08:52:03	0|bitcoin-git|13bitcoin/060.16 140dc6a30 15João Barbosa: [gui] Defer coin control instancing...
 65 2018-02-02 08:52:03	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 060.16: 02https://github.com/bitcoin/bitcoin/compare/e54c1ac11066...5303970c26a5
 66 2018-02-02 08:52:04	0|bitcoin-git|13bitcoin/060.16 145303970 15Cory Fields: net: don't retry failed oneshot connections forever...
 67 2018-02-02 08:52:14	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12329: net: don't retry failed oneshot connections forever (06master...06no-infinite-oneshot) 02https://github.com/bitcoin/bitcoin/pull/12329
 68 2018-02-02 09:04:08	0|bitcoin-git|13bitcoin/060.16 14f17942a 15Wladimir J. van der Laan: qt: Pre-rc2 translations update...
 69 2018-02-02 09:04:08	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/f17942a3bc810d981724228bb5c99b5fb572efbe
 70 2018-02-02 09:13:48	0|wumpus|rc2 coming up, please interrupt me asap if I forgot something
 71 2018-02-02 09:18:11	0|wumpus|so we have: fix for the fd issue (cfields, confirmed by gmaxwell above), fix for eternal retry of onetries (cfields), and fix for coin-control-bechs32-change (promag) in. I've updated the translations from transifex. Should be good to go.
 72 2018-02-02 09:18:29	0|promag|ok
 73 2018-02-02 09:40:43	0|wumpus|* [new tag]         v0.16.0rc2 -> v0.16.0rc2
 74 2018-02-02 10:22:38	0|promag|gmaxwell: see #12330
 75 2018-02-02 10:22:39	0|gribble|https://github.com/bitcoin/bitcoin/issues/12330 | Reduce scope of cs_main and cs_wallet locks in listtransactions by promag · Pull Request #12330 · bitcoin/bitcoin · GitHub
 76 2018-02-02 10:23:39	0|wumpus|how do we want to call it in the release notes, SegWit, Segwit, segwit? it's kind of inconsistent at the moment
 77 2018-02-02 10:24:34	0|gmaxwell|SeGwIt
 78 2018-02-02 10:24:59	0|luke-jr|maybe markdown can be extended to randomize the case per view
 79 2018-02-02 10:25:06	0|aj|it's "segwit" in --help
 80 2018-02-02 10:25:18	0|luke-jr|"segwit" does seem to be the most common
 81 2018-02-02 10:26:54	0|aj|"SegWit" in "addnode -help" rpc
 82 2018-02-02 10:27:11	0|wumpus|ok so "segwit" captilized only as necessary?
 83 2018-02-02 10:27:21	0|promag|https://bitcoincore.org/en/2016/01/26/segwit-benefits/ lowercase unless start of sentence
 84 2018-02-02 10:27:35	0|gmaxwell|+1
 85 2018-02-02 10:27:36	0|wumpus|right
 86 2018-02-02 10:27:47	0|gmaxwell|or SeGregAteDWitness as appropriate.
 87 2018-02-02 10:28:21	0|aj|greg should stop eating witnesses
 88 2018-02-02 10:28:31	0|promag|aj: should we fix that?
 89 2018-02-02 10:28:45	0|promag|"fix"
 90 2018-02-02 10:28:56	0|gmaxwell|it's okay, I'm full.
 91 2018-02-02 10:29:17	0|wumpus|hehehe
 92 2018-02-02 10:31:25	0|sipa|wumpus: any of those three are fine, but concistency is nice
 93 2018-02-02 10:31:41	0|sipa|i'm not such a fan of gmaxwell's capitalization preferences
 94 2018-02-02 10:32:04	0|wumpus|yep, I've updated the wiki page to use "segwit" consistently
 95 2018-02-02 10:32:15	0|wumpus|https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
 96 2018-02-02 10:33:10	0|midnightmagic|heh so greg ate de witness.
 97 2018-02-02 10:33:52	0|gmaxwell|no sogregatede is something else, I'm pretty sure.
 98 2018-02-02 10:34:01	0|luke-jr|Ated might have been better there.
 99 2018-02-02 10:34:19	0|midnightmagic|not if you're quebecois
100 2018-02-02 10:37:12	0|wumpus|another word consistency issue (sorry) is it BIP 123 or BIP123?
101 2018-02-02 10:38:17	0|wumpus|sometimes it says BIP 173, then BIP173, there is even a BIP-125
102 2018-02-02 10:38:26	0|wumpus|but BIP123 style seems most common
103 2018-02-02 10:39:09	0|aj|BIP123 seems most common in the code
104 2018-02-02 10:39:20	0|fanquake|I'll claim squashing "SSE" and 4 earlier today :p
105 2018-02-02 10:39:22	0|mesh_|I know I was a bit sloppy with the consistency there sorry, was copying and pasting things from all over the place
106 2018-02-02 10:39:26	0|wumpus|yes, ok, let's standardize on that
107 2018-02-02 10:40:02	0|bitcoin-git|13bitcoin/06master 141340eda 15practicalswift: Fix typos
108 2018-02-02 10:40:02	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/aa360e76a74b...1b06ed136f17
109 2018-02-02 10:40:03	0|bitcoin-git|13bitcoin/06master 141b06ed1 15MarcoFalke: Merge #12283: Fix typos...
110 2018-02-02 10:40:04	0|meshcollider|Yep no space is probably most sensible, slightly less neat than space though IMO
111 2018-02-02 10:40:07	0|aj|yeah, it's BIP123 in src/qt/locale/* in particular.
112 2018-02-02 10:40:08	0|wumpus|mesh_: no worries, this is mostly editorializing, the content is most important :)
113 2018-02-02 10:40:40	0|fanquake|Last I checked dropping the 0. was most important ;)
114 2018-02-02 10:40:45	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12283: Fix typos (06master...06typos-20180128) 02https://github.com/bitcoin/bitcoin/pull/12283
115 2018-02-02 10:40:49	0|meshcollider|wumpus: has anyone addresses sipa's validateaddress changes earlier, I ran out of time
116 2018-02-02 10:40:55	0|meshcollider|Addressed*
117 2018-02-02 10:43:07	0|wumpus|the only mention of validateaddress is in BIP173 support
118 2018-02-02 10:43:54	0|provoostenator|Re release notes: "When launched with -addresstype=legacy it is unchecked and disabled." -> it's actually hidden.
119 2018-02-02 10:44:26	0|meshcollider|provoostenator: oh ok, I got that from the PR description ;)
120 2018-02-02 10:44:54	0|provoostenator|I changed it based on feedback, but probably forgot to update that part of the descrioption.
121 2018-02-02 10:44:57	0|meshcollider|wumpus: ok that's a to-do then, move it out of the BIP 173 section and write about all the other changes that happened to it
122 2018-02-02 10:45:22	0|meshcollider|I'll do it tomorrow, more of a mental note unless someone else does
123 2018-02-02 10:45:54	0|meshcollider|provoostenator: that's all good
124 2018-02-02 10:45:56	0|provoostenator|The behavior around (change) address types is currently spread accross several parts of the release notes. Maybe better to just have one section Address Types and discuss the various defaults, launch flags and RPC params there.
125 2018-02-02 10:47:18	0|bitcoin-git|13bitcoin/06master 149bb59cf 15Jorge Timón: QA: segwit.py: s/find_unspent/find_spendable_utxo/
126 2018-02-02 10:47:18	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1b06ed136f17...4cad91663df3
127 2018-02-02 10:47:19	0|bitcoin-git|13bitcoin/06master 144cad916 15MarcoFalke: Merge #11869: QA: segwit.py: s/find_unspent/find_spendable_utxo/...
128 2018-02-02 10:47:20	0|wumpus|provoostenator: right; I've lazily grouped the address changes under wallet changes, because that's where people will be looking for them. I know some non-wallet utility functions are also affected.
129 2018-02-02 10:47:26	0|meshcollider|Btw wumpus it'd be cool if we added sjors to the github org, I mentioned it a while back and it got lost :)
130 2018-02-02 10:47:38	0|wumpus|meshcollider: yes
131 2018-02-02 10:47:51	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11869:  QA: segwit.py: s/find_unspent/find_spendable_utxo/ (06master...06b16-segwit-test-fix) 02https://github.com/bitcoin/bitcoin/pull/11869
132 2018-02-02 10:48:16	0|wumpus|but explaining the types of addresses in a separate section wouldn't hurt
133 2018-02-02 10:48:52	0|wumpus|I'm done editing the wiki for now, so if anyone wants to have a go
134 2018-02-02 10:48:54	0|provoostenator|Being part of the github org is what gets you the T-Shirt, right?
135 2018-02-02 10:49:00	0|gmaxwell|do mention 'bc1' when talking about BIP173 addresses, since thats how users will identify them.
136 2018-02-02 10:51:08	0|wumpus|provoostenator: I'm not sure; maybe someone still has a stack of bitcoin core t-shirts from one of the real life dev meetings
137 2018-02-02 10:51:24	0|wumpus|I do have a lot of bitcoin core stickers
138 2018-02-02 10:51:43	0|provoostenator|I was kidding, but good to know there actually _are_ T-Shirts.
139 2018-02-02 10:52:27	0|meshcollider|provoostenator: there'll be t-shirts at coredev apparently :)
140 2018-02-02 10:52:45	0|meshcollider|wumpus: you should bring some stickers too then hehe
141 2018-02-02 10:53:46	0|meshcollider|provoostenator: I assume the t-shirts look like John's one on twitter
142 2018-02-02 10:56:18	0|wumpus|invited provoostenator for bitcoin and bitcoin-core orgs
143 2018-02-02 10:56:31	0|wumpus|meshcollider:sure!
144 2018-02-02 10:56:58	0|meshcollider|wumpus: can I join bitcoin-core too
145 2018-02-02 10:57:01	0|wumpus|meshcollider:  there is a photo from coredev zurich somewhere where almost everyone is wearing one
146 2018-02-02 10:57:07	0|wumpus|meshcollider: oh I forgot that?
147 2018-02-02 10:57:18	0|meshcollider|Oh nice!
148 2018-02-02 10:57:21	0|meshcollider|Yah haha
149 2018-02-02 10:59:38	0|meshcollider|Thanks :)
150 2018-02-02 11:01:15	0|provoostenator|wumpus: received invite, thanks
151 2018-02-02 11:04:43	0|provoostenator|"Uses of "µBTC" in the GUI now use the more colloquial term "bits". -> clarify that this is _in addition to_ uBTC, otherwise people might go mad without actually checking the app.
152 2018-02-02 11:05:55	0|gmaxwell|hah I was annoyed before I got to the end of provoostenator's message.
153 2018-02-02 11:07:28	0|provoostenator|gmaxwell: that's why I always nag about screenshots: https://github.com/bitcoin/bitcoin/pull/12035#issuecomment-354297195
154 2018-02-02 11:07:34	0|sipa|a 100 megabit/s network connection sounds very expensive now
155 2018-02-02 11:07:51	0|sipa|crap.
156 2018-02-02 11:08:01	0|gmaxwell|lol
157 2018-02-02 11:12:35	0|meshcollider|provoostenator: is it *always* in addition to, or sometimes? Because the code had like a "short" and "long" version
158 2018-02-02 11:12:43	0|gmaxwell|somewhere some french altcoiners people are cacking at bitcoiners trying get everyone to measure their bitcoin in millièmebite.
159 2018-02-02 11:13:34	0|provoostenator|meshcollider: sometimes. See the screenshots in that link. Dropdown menus show both terms, which is where it matters the most I think. But there's some places where it just says "bits" now.
160 2018-02-02 11:13:57	0|wumpus|sipa: so does it always cost 100 megabit/s or is that just the channel capacity and based on use? :)
161 2018-02-02 11:14:13	0|meshcollider|provoostenator: ah yep I see, cool
162 2018-02-02 11:14:30	0|meshcollider|A megabit is 1 bitcoin?
163 2018-02-02 11:15:08	0|wumpus|meshcollider: yes :-)
164 2018-02-02 11:15:26	0|gmaxwell|now I'll at least remember what unit 'bits' is.
165 2018-02-02 11:15:27	0|meshcollider|At least I can still do basic math then :)
166 2018-02-02 11:15:28	0|wumpus|even 80's mobile data must have been cheaper
167 2018-02-02 11:15:29	0|provoostenator|Yeah, nobody liked my idea of redefining 1 satoshi as 10^-9 BTC :-)
168 2018-02-02 11:15:41	0|gmaxwell|provoostenator: is 10 nanobitcoin so hard to use?
169 2018-02-02 11:15:57	0|provoostenator|And then just use kilosat instead of uBTC or bits
170 2018-02-02 11:17:07	0|meshcollider|A satoshi is just 10 microbits
171 2018-02-02 11:17:17	0|provoostenator|Say "That'll be twenty three nanobitcoin and three hundred third five  picobitcoin please" 20 times out loud and I'll consider it.
172 2018-02-02 11:17:35	0|aj|meshcollider: millibits?
173 2018-02-02 11:17:40	0|meshcollider|Milli* yes oops
174 2018-02-02 11:18:11	0|sipa|millibitcoins = mils, microbitcoins = mikes, nanobitcoins = nans, picobitcoins = pikes
175 2018-02-02 11:18:15	0|sipa|was that so hard?
176 2018-02-02 11:18:17	0|sipa|;)
177 2018-02-02 11:18:33	0|provoostenator|nans is nice
178 2018-02-02 11:18:57	0|gmaxwell|ten nans walk into a bar.
179 2018-02-02 11:18:57	0|meshcollider|brb, changing my twitter name to something like [NO BIP176][MIKES]
180 2018-02-02 11:18:59	0|provoostenator|NaN nans please
181 2018-02-02 11:19:04	0|aj|sipa: because "mils" isn't already used for enough different measurements
182 2018-02-02 11:19:08	0|wumpus|provoostenator: standardizing SI units in common language would be awesome, but not my fight
183 2018-02-02 11:20:12	0|wumpus|nan bread
184 2018-02-02 11:20:36	0|sipa|aj: oh?
185 2018-02-02 11:21:18	0|promag|who loves univalue raise hand
186 2018-02-02 11:21:23	0|provoostenator|There's also no point in standardizing these things when prices can change by an order of magnitude every year. If and when it becomes a unit of account, people will come with words for it.
187 2018-02-02 11:21:32	0|aj|sipa: oh, mostly just still bitter over discovering that when an american says "mils" that's not a nickname for millimetres
188 2018-02-02 11:21:39	0|wumpus|univalue?
189 2018-02-02 11:22:10	0|gmaxwell|provoostenator: well I suppose it's poor form to complain that people are coming up with words with the argument that they'll come up with words. :) (or perhaps I misunderstood)
190 2018-02-02 11:22:16	0|provoostenator|aj: they do for guns though, right?
191 2018-02-02 11:22:24	0|promag|wumpus: src/univalue/include/univalue.h :P
192 2018-02-02 11:22:41	0|promag|seems so slow
193 2018-02-02 11:22:43	0|wumpus|promag: oh, I think we were still in the context of units
194 2018-02-02 11:22:53	0|promag|sorry for the interrupt :P
195 2018-02-02 11:22:57	0|meshcollider|milliunivalue
196 2018-02-02 11:23:15	0|provoostenator|gmaxwell: I think it's fine that people come with words. I mean there's not much use in "centrally" dictating those words.
197 2018-02-02 11:23:15	0|wumpus|deprecate SI units and unify all units to, univalue!
198 2018-02-02 11:23:21	0|wumpus|that's 100 univalue please
199 2018-02-02 11:23:37	0|gmaxwell|promag: it was an order of magnitude speedup from jsonspirit as we were using it before, and eliminated problems with number mangling.
200 2018-02-02 11:23:57	0|aj|provoostenator: yeah, as i understand it, guns and drugs, at the forefront of bringing SI measurements to the US
201 2018-02-02 11:24:10	0|sipa|wumpus: yes, i wish people would learn SI units for daily life usage... but indeed, not something i'm going to waste my time on
202 2018-02-02 11:24:14	0|meshcollider|Well sipa has his own unit, we could call uBTC the laan
203 2018-02-02 11:24:15	0|wumpus|for a mass of 123 univalue of 100 univalue capacitors
204 2018-02-02 11:24:52	0|sipa|also, as the SI unit for weight is the kilogram, should it not be millikilogram instead of gram?
205 2018-02-02 11:25:07	0|wumpus|promag: we're basically its maintainers, feel free to optimize it
206 2018-02-02 11:25:28	0|provoostenator|The nice thing about computers is that they allow standards to just exist in the background. Precise time measurement is crucial, but most people don't need to think in UTC because their phone handles the conversion.
207 2018-02-02 11:25:32	0|meshcollider|sipa: unfortunately so lol
208 2018-02-02 11:25:47	0|aj|oh no, not time measurement
209 2018-02-02 11:26:18	0|provoostenator|In fact, we could just go back to each city having a time based on where the sun is. Though coordinating meetings would be a pain without good tools.
210 2018-02-02 11:26:23	0|gmaxwell|provoostenator: irony... considering that we have to hold our meetings here in UTC times to avoid having people witness multiple DST changes per year
211 2018-02-02 11:26:26	0|aj|sipa: that'll improve morale
212 2018-02-02 11:26:52	0|gmaxwell|(and at random seeming different times than their local dst changes)
213 2018-02-02 11:27:42	0|provoostenator|Right, that's because coordinating meeting times is still generally done with words.
214 2018-02-02 11:27:51	0|meshcollider|I prefer to measure time in microfortnights
215 2018-02-02 11:28:11	0|wumpus|my preference is kiloseconds, megaseconds, gigaseconds
216 2018-02-02 11:28:28	0|sipa|gigaseconds are kinda bulky
217 2018-02-02 11:28:41	0|wumpus|do away with planet or solar-system-specific time units
218 2018-02-02 11:28:45	0|sipa|few people see more than 3 in their lifetime
219 2018-02-02 11:28:49	0|gmaxwell|provoostenator: the time can't be set in any timezone with dst regardless of how you communicate about it, because if it is, people in other zones will witness their own time change as well as the other one.
220 2018-02-02 11:28:54	0|wumpus|agreed, it's a big milestone
221 2018-02-02 11:29:06	0|provoostenator|DST needs to die.
222 2018-02-02 11:29:16	0|sipa|wumpus: a *kilometerstone*
223 2018-02-02 11:29:24	0|wumpus|sipa: oooh yes, sorry
224 2018-02-02 11:29:26	0|gmaxwell|(since north and souther hemispheres dst in opposing directions, and US and europe on different dates)
225 2018-02-02 11:30:51	0|sipa|wumpus: i think we should do everything in planck units
226 2018-02-02 11:46:04	0|bitcoin-git|[13bitcoin] 15promag opened pull request #12333: Make CWallet::ListCoins atomic (06master...062018-02-atomic-listcoins) 02https://github.com/bitcoin/bitcoin/pull/12333
227 2018-02-02 12:31:28	0|fanquake|pushed some rc2 sigs up
228 2018-02-02 13:19:03	0|wumpus|sipa: yes, planck units would be even better, at least then we could stop using floating point/decimal and account all physics in discrete units in 128 or 256 bit integers
229 2018-02-02 13:19:48	0|wumpus|also it's based on a constant of nature instead of an arbitrary human measure
230 2018-02-02 13:20:48	0|wumpus|we're going to need larger SI-prefixes though
231 2018-02-02 13:39:57	0|wumpus|fanquake: also pushed my sigs, you were first though!
232 2018-02-02 16:02:58	0|esotericnonsense|hm. how much space should test_runner.py require? seems it can't run in tmpfs on my laptop (only has 2GB /tmp, got to 1.9GB then started giving space errors)
233 2018-02-02 16:04:45	0|esotericnonsense|found the --tmpdirprefix switch. :)
234 2018-02-02 17:02:29	0|AndyS2|Newbie to C++ and bitcoin core here. I've been looking at EvalScript in interpreter.cpp, and from what I gathered it seems to push things onto 'stack' or return an error if something isn't kosher. But when/where is the stack actually 'executed'. EvalScript doesn't seem to evaluate the script anywhere I could see.
235 2018-02-02 17:03:30	0|AndyS2|And functions calling EvalScript didn't seem to immediately get to work on that stack, either, but I might have missed something
236 2018-02-02 17:06:59	0|achow101|AndyS2: the stack is not something where code is executed. It is just a place to store data temporarily
237 2018-02-02 17:07:15	0|achow101|Opcodes execute things typically by popping things off of the stack
238 2018-02-02 17:07:22	0|achow101|those opcodes do not actually get pushed to the stack
239 2018-02-02 17:17:06	0|luke-jr|well, they do for p2sh and segwit
240 2018-02-02 17:26:01	0|bitcoin-git|13bitcoin/06master 147444149 15John Newbery: Document method for reviewers to verify chainTxData...
241 2018-02-02 17:26:01	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4cad91663df3...85123be78df5
242 2018-02-02 17:26:02	0|bitcoin-git|13bitcoin/06master 1485123be 15Wladimir J. van der Laan: Merge #12317: Document method for reviewers to verify chainTxData...
243 2018-02-02 17:26:51	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12317: Document method for reviewers to verify chainTxData (06master...06verify_chainTxData) 02https://github.com/bitcoin/bitcoin/pull/12317
244 2018-02-02 17:45:24	0|AndyS2|achow101: you are right, I don't know how I could mis-read all that code. Thanks for the correction. So EvalScript is actually where the script is evaluated, and the name fits :)
245 2018-02-02 17:46:10	0|AndyS2|I'll look at p2sh specialities later, thanks for the hint.
246 2018-02-02 18:37:04	0|esotericnonsense|never mind DST. the fact that timezones don't change with latitude is absurd
247 2018-02-02 18:41:07	0|sipa|esotericnonsense: iceland has no dst for a reason :)
248 2018-02-02 18:43:03	0|esotericnonsense|it's more that spain is utc+1 and the UK is utc which is just odd
249 2018-02-02 18:43:08	0|esotericnonsense|there is probably some historical reason
250 2018-02-02 18:48:06	0|esotericnonsense|apparently it was for political alignment with central europe, heh
251 2018-02-02 19:46:10	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #12336: Remove deprecated rpc options (06master...06remove_deprecated_rpcs) 02https://github.com/bitcoin/bitcoin/pull/12336
252 2018-02-02 20:17:11	0|GitHub24|[13bitcoin-detached-sigs] 15jonasschnelli opened pull request #2: 0.16: osx signatures for 0.16.0rc2 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
253 2018-02-02 20:40:18	0|cfields|uh
254 2018-02-02 20:40:25	0|cfields|well that's shitty timing...
255 2018-02-02 20:40:46	0|cfields|I just ran my last sanity check on rc2 before pushing the sigs, and hit an asserstion at shutdown :(
256 2018-02-02 20:51:09	0|GitHub149|[13bitcoin-detached-sigs] 15theuni closed pull request #2: 0.16: osx signatures for 0.16.0rc2 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
257 2018-02-02 20:53:45	0|cfields|gitian builders: v0.16.0rc2 sigs are pushed
258 2018-02-02 20:53:53	0|cfields|also, #12337
259 2018-02-02 20:53:54	0|gribble|https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
260 2018-02-02 20:53:58	0|cfields|BlueMatt: ^^
261 2018-02-02 20:55:41	0|BlueMatt|oh ffs
262 2018-02-02 21:03:22	0|BlueMatt|weird, that would imply Shutdown() wasnt called
263 2018-02-02 21:04:05	0|cfields|hmm?
264 2018-02-02 21:05:33	0|BlueMatt|Shutdown() waits for the threadGroup to exit fully, and a long time ago due to some other bug I made sure Shutdown() gets acalled always in bitcoind shutdown, and I thought i did for qt too
265 2018-02-02 21:05:40	0|BlueMatt|but I dont have a good understanding of how that works
266 2018-02-02 21:05:57	0|BlueMatt|I assume you did a pretty quick shutdown and not a full init, cfields?
267 2018-02-02 21:06:23	0|cfields|yes, just long enough to display the version#
268 2018-02-02 21:07:14	0|cfields|BlueMatt: there's a note somewhere in init.cpp about aborting halfway through. Not sure if it's stale or not.
269 2018-02-02 21:09:13	0|cfields|nm, not relevant
270 2018-02-02 21:10:00	0|BlueMatt|not if you finish AppInitMain
271 2018-02-02 21:18:35	0|BlueMatt|does anyone actually understand qt init/shutdown?
272 2018-02-02 21:22:36	0|cfields|BlueMatt: I managed to grab the log, AppInitMain indeed doesn't finish. It caught the shutdown check at init.cpp:1578
273 2018-02-02 21:25:17	0|BlueMatt|cfields: in bitcoind (and I was very sure bitcoin-qt) if AppInitMain ever *enters* it should still call Shutdown()
274 2018-02-02 21:27:33	0|cfields|BlueMatt: yes, I see that for bitcoind. Looking at qt with you.
275 2018-02-02 21:27:36	0|BlueMatt|hmm, it looks like maybe qt doesnt call Shutdown there, fucking qt/bitcoind init differences :(
276 2018-02-02 21:27:55	0|BlueMatt|i guess quit() doesnt call shutdown() when called from initializeResult
277 2018-02-02 21:28:06	0|BlueMatt|I'll wait for jonasschnelli or someone who knows how the fuck qt works to figure out how to fix
278 2018-02-02 21:30:11	0|BlueMatt|cfields: https://github.com/bitcoin/bitcoin/issues/12337#issuecomment-362713279 <-- seem reasonable?
279 2018-02-02 21:31:05	0|cfields|BlueMatt: yes, though I'm a few min behind you
280 2018-02-02 21:34:27	0|cfields|BlueMatt: hmm. As a hack, I wonder if we can just add a "StartShutdown();" before every "return false" in AppInitMain
281 2018-02-02 21:35:32	0|cfields|blah, we'd still have to get qt to wait on that, which is basically the same problem. nm.
282 2018-02-02 21:36:15	0|BlueMatt|cfields: no, but we could change AppInitMain to { bool ret = AppInitMainReal(); if (!ret) Shutdown(); return ret }
283 2018-02-02 21:36:34	0|cfields|heh
284 2018-02-02 21:37:00	0|BlueMatt|but we shouldnt do that, we should fucking fix qt to actually have the same goddamned init/shutdown process as bitcoind, otherwise we're just keep going with this constant stream of init/shutdown problems on one or the other cause the person writing the code was only considering one or the other and assumed the other did the same thing
285 2018-02-02 21:37:02	0|BlueMatt|cause....duh
286 2018-02-02 21:37:04	0|cfields|looking at all of the qt shutdown signals, I'm afraid that would screw something up
287 2018-02-02 21:37:26	0|BlueMatt|i mean we can do a different fix on master vs qt
288 2018-02-02 21:37:35	0|BlueMatt|but lets see what someone who knows the qt init/shutdown stuff says
289 2018-02-02 21:37:40	0|BlueMatt|err, vs 16
290 2018-02-02 21:38:00	0|cfields|yes, agreed on sharing behavior as much as possible. Some is beyond our control, though.
291 2018-02-02 21:39:23	0|achow101|so 0.16 rc2 is DOA
292 2018-02-02 21:40:53	0|cfields|nah, I think we should urge people to test it
293 2018-02-02 21:42:02	0|cfields|rc1 had a bug that was so bad that _any_ bug report would've been unhelpful. For rc2, there's just a unlikely, known, startup issue
294 2018-02-02 21:42:57	0|mlz|what's the difference between "origin/0.16" and "v0.16.0rc2" and which one should i test?
295 2018-02-02 21:45:02	0|cfields|miz: former is branch, latter is tag. You probably want the tag.
296 2018-02-02 21:46:24	0|achow101|cfields: does the assertion always happen or just sometimes?
297 2018-02-02 21:46:49	0|mlz|cfields, ok, thank you
298 2018-02-02 21:47:16	0|cfields|BlueMatt: for 0.16, can we not just start the scheduler thread until last thing in AppInitMain? Surely nothing depends on it running in there
299 2018-02-02 21:47:34	0|cfields|grr.. or does reindexing and crap rely on the callbacks?
300 2018-02-02 21:47:56	0|cfields|achow101: I only ran it once, but it only triggered because I shutdown immediately
301 2018-02-02 21:48:04	0|achow101|ah, ok
302 2018-02-02 21:49:11	0|BlueMatt|cfields: hmmm, I dont *think* anything depends on it, but i was trying to keep the diff when compared to previously where the scheduler is started early low
303 2018-02-02 21:49:18	0|BlueMatt|and at least that change is harder to audit
304 2018-02-02 21:49:28	0|BlueMatt|achow101: it should always crash if you quit bitcoin-qt while its loading
305 2018-02-02 21:49:36	0|BlueMatt|if it finishes loading you should be fine
306 2018-02-02 21:54:07	0|achow101|is the issue present on master?
307 2018-02-02 21:54:13	0|cfields|yes
308 2018-02-02 21:54:53	0|cfields|BlueMatt: actually, starting the thread last-thing sounds like a good idea anyway. Exactly to ensure that the scheduler isn't used at startup.
309 2018-02-02 21:55:30	0|achow101|is it windows only? I can't seem to replicate on Ubuntu
310 2018-02-02 21:55:30	0|cfields|i'll track down potential users
311 2018-02-02 21:55:41	0|cfields|achow101: testing bitcoin-qt ?
312 2018-02-02 21:55:46	0|achow101|yeah
313 2018-02-02 21:56:09	0|cfields|I don't see anything that would make it win only...
314 2018-02-02 21:56:22	0|cfields|you should be able to force it by throwing a "return false" into init
315 2018-02-02 21:57:11	0|BlueMatt|cfields: hmmm...I mean maybe? I dont really want to go read through everything that AppInitMain calls recursively to ensure that is actually the case, but if we want to do that for 17 it seems reasonable
316 2018-02-02 21:57:34	0|cfields|achow101: at init.cpp:1576, s/fRequestShutdown/true/
317 2018-02-02 22:06:58	0|achow101|cfields: nope, didn't work
318 2018-02-02 22:11:49	0|cfields|achow101: hmm, not sure why
319 2018-02-02 22:12:05	0|achow101|I'm trying rc2 now, instead of master
320 2018-02-02 22:13:01	0|achow101|nope, not even that had an error
321 2018-02-02 22:13:22	0|cfields|BlueMatt: i think i might see the issue
322 2018-02-02 22:15:06	0|cfields|BlueMatt: BitcoinApplication connects requestedShutdown to shutdown(), but SplashScreen connects it to close()
323 2018-02-02 22:15:40	0|cfields|so it looks like we should re-route that after AppInitMain has started
324 2018-02-02 22:26:35	0|BlueMatt|lol