1 2018-02-05 02:50:33	0|conman|will 0.16.0 have bech32 support? I don't see it in the readme
  2 2018-02-05 02:51:08	0|gmaxwell|conman: yes, it has BIP173 support for sending; and if you request it, for recieving too.
  3 2018-02-05 02:51:29	0|conman|great, so validateaddress will return true for it too then
  4 2018-02-05 02:51:33	0|gmaxwell|it won't use it for rx by default, but you can set the default wallet wide, or request BC1 addresses on a case by case basis.
  5 2018-02-05 02:51:36	0|gmaxwell|Yes.
  6 2018-02-05 02:51:41	0|conman|ack
  7 2018-02-05 02:51:51	0|conman|thanks
  8 2018-02-05 02:52:05	0|conman|guess I better add support in my pools for it soon then
  9 2018-02-05 02:53:05	0|gmaxwell|would be nice, ... though we were expecting the rollout to take a long time.
 10 2018-02-05 02:53:18	0|gmaxwell|Electrum has pushed it forward by making their segwit mode require it.
 11 2018-02-05 02:53:29	0|conman|nod
 12 2018-02-05 02:54:22	0|conman|my pool code asks bitcoin core to validate addresses so if I upgrade to .16 without adding support it will likely create corrupt generation transactions for bech32
 13 2018-02-05 02:54:49	0|conman|should look to see what new rpc commands are in .16...
 14 2018-02-05 02:54:55	0|gmaxwell|hm. how would it end up corrupt?
 15 2018-02-05 02:55:15	0|conman|I hard code to look for a 3x address and it does p2sh output on that
 16 2018-02-05 02:55:43	0|conman|if it doesn't see 3 it will assume it's a p2pkh and just code up the bech32 directly into that which will be of course a mess
 17 2018-02-05 02:56:09	0|gmaxwell|how would it do that? the bech32 won't decode as base58.
 18 2018-02-05 02:56:19	0|gmaxwell|even with an invalid checksum.
 19 2018-02-05 02:56:22	0|conman|yeah that's what I mean, it will explode
 20 2018-02-05 02:56:28	0|gmaxwell|okay, fair enough.
 21 2018-02-05 02:56:39	0|gmaxwell|I could see paying to an empty address or 0x00 or something as a result.
 22 2018-02-05 02:57:03	0|conman|exploding is actually preferable to that :P
 23 2018-02-05 02:57:03	0|gmaxwell|(though man, that would be fragile!)
 24 2018-02-05 02:57:12	0|conman|heh
 25 2018-02-05 02:57:50	0|gmaxwell|in any case, it's pretty straight forward to convert BC1 addressesto scriptpubkeys.
 26 2018-02-05 02:58:02	0|conman|yeah that's what I need to figure out how to do
 27 2018-02-05 02:58:30	0|gmaxwell|about the only gotcha is that the v0 vs other versions gap due to script.  There are test vectors that tell you what the resulting scriptpubkey should be.
 28 2018-02-05 02:58:43	0|conman|ty
 29 2018-02-05 02:59:28	0|conman|hmm is there a core rpc that converts it to scriptpubkeys?
 30 2018-02-05 02:59:45	0|conman|I guess I need to investigate for myself
 31 2018-02-05 03:04:45	0|conman|ok decode is one function, no rpc for it tho afaics
 32 2018-02-05 03:26:53	0|sipa|conman: validateaddress will give you the scriptpubkey iirc
 33 2018-02-05 03:27:12	0|conman|oh? That's awesome
 34 2018-02-05 03:30:05	0|conman|indeed it does
 35 2018-02-05 03:31:12	0|conman|I should pay attention :P
 36 2018-02-05 03:33:00	0|conman|I seem to be duplicating work already done
 37 2018-02-05 03:33:35	0|conman|oh and it returns the decoded address already
 38 2018-02-05 03:34:25	0|sipa|what do you mean by decoded address?
 39 2018-02-05 03:34:45	0|conman|bech32
 40 2018-02-05 03:34:52	0|conman|no?
 41 2018-02-05 03:35:09	0|conman|I'm looking at the function, not actually trying it
 42 2018-02-05 03:35:26	0|sipa|if you give it a p2sh-p2wpkh, and it knows the script (which means it's your own address, really), it will report the embedded p2wpkh address
 43 2018-02-05 03:37:41	0|conman|okty
 44 2018-02-05 04:29:49	0|conman|ok this should be easy, check the validateaddress return value of "isscript" and then use the pubkey it returns with it
 45 2018-02-05 04:30:09	0|conman|can consolidate and remove some of my duplicate code
 46 2018-02-05 04:31:33	0|sipa|conman: why do you need to know of something is a script?
 47 2018-02-05 04:31:44	0|sipa|isscript will also return true for p2wsh
 48 2018-02-05 04:32:25	0|conman|sipa: because I'm generating transactions
 49 2018-02-05 04:32:43	0|conman|sec
 50 2018-02-05 04:33:20	0|sipa|i'd expect that you'd need to put the scriptPubKey in the output?
 51 2018-02-05 04:33:52	0|conman|I have two functions to determine what to put into the coinbase generation transaction
 52 2018-02-05 04:34:13	0|conman|only 10 lines of code, so hopefully you wont mind me showing you? https://bitbucket.org/ckolivas/ckpool/src/0ab1e33e8193a28c7a4d9c89b5f6193fe926e7f2/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1733
 53 2018-02-05 04:34:25	0|conman|address_to_pubkeytxn and address_to_scripttxn is what I currently use
 54 2018-02-05 04:34:40	0|conman|it's extremely braindead
 55 2018-02-05 04:35:01	0|sipa|right, but for p2wsh and p2wpkh you'll need more
 56 2018-02-05 04:35:12	0|conman|hrm that's what I feared
 57 2018-02-05 04:35:23	0|sipa|there is reference c code for doing that, btw
 58 2018-02-05 04:35:36	0|conman|I must be looking in the wrong places
 59 2018-02-05 04:35:37	0|sipa|https://github.com/sipa/bech32
 60 2018-02-05 04:35:42	0|conman|ty
 61 2018-02-05 04:35:42	0|sipa|it's listed in the bip
 62 2018-02-05 04:38:34	0|conman|that's to decode, understood thanks
 63 2018-02-05 04:38:57	0|sipa|it does both
 64 2018-02-05 04:39:25	0|conman|but I'm still fuzzy on what extra is needed on creating a generation transaction from a decoded segwit address as opposed to a p2sh address
 65 2018-02-05 04:40:13	0|conman|you say I'll need more
 66 2018-02-05 04:41:05	0|sipa|yes, it needs to be a segwit output
 67 2018-02-05 04:41:09	0|sipa|it's not hard
 68 2018-02-05 04:41:15	0|sipa|but it will be different logic
 69 2018-02-05 04:41:29	0|sipa|it OP_0 + 20-byte push for P2WPKH
 70 2018-02-05 04:41:41	0|sipa|and OP_0 + 32-byte push for P2WSH
 71 2018-02-05 04:42:22	0|conman|ah
 72 2018-02-05 04:44:16	0|conman|so if there was a current p2wsh address in the coinbase txn in my current code's form it would go to a random nowhere
 73 2018-02-05 04:45:10	0|sipa|presumably
 74 2018-02-05 04:45:15	0|sipa|i didn't look very closely
 75 2018-02-05 04:45:25	0|conman|:\
 76 2018-02-05 04:45:29	0|conman|that's okay
 77 2018-02-05 04:46:10	0|luke-jr|how would a p2wsh address get in the txn if you don't put it there?
 78 2018-02-05 04:46:42	0|conman|huh?
 79 2018-02-05 04:47:10	0|conman|it just applies the existing logic for any 3x address to all 3x addresses
 80 2018-02-05 04:47:16	0|conman|in a braindead fashion
 81 2018-02-05 04:47:32	0|luke-jr|all 3x addresses should work with your code; I think sipa is talking about the new bc1 addresses
 82 2018-02-05 04:47:40	0|conman|hrm
 83 2018-02-05 04:48:26	0|sipa|yes,p2sh-p2wpkh addresses are for the sender indistinguishable from p2sh addresses, by design
 84 2018-02-05 04:48:34	0|conman|okay so it's still okay
 85 2018-02-05 04:48:59	0|sipa|i'm talking about bech32 address, which encode p2wsh and p2wpkh addresses, without bech32
 86 2018-02-05 04:49:28	0|conman|yeah so once bech32 is decoded, what to do with it then is what I'm still coming to grips with
 87 2018-02-05 04:51:59	0|luke-jr|sipa's reference code has: int segwit_addr_decode(int* witver, uint8_t* witdata, size_t* witdata_len, const char* hrp, const char* addr)
 88 2018-02-05 04:52:17	0|luke-jr|test to be sure, but I think you can just concatenate the witver, witdata_len, and witdata
 89 2018-02-05 04:52:34	0|luke-jr|to make the scriptpubkey
 90 2018-02-05 04:52:59	0|sipa|the unit test code even demosnstrates that, actually
 91 2018-02-05 04:53:29	0|sipa|it's not part of the reference itaelf, because in production wallet code it would likely tie in with existing scriot creation code already
 92 2018-02-05 04:56:33	0|luke-jr|oh, right, you need to add 0x50 to any witver != 0
 93 2018-02-05 05:03:06	0|conman|bech32 automatically guarantees it is a p2w* address?
 94 2018-02-05 05:03:44	0|conman|oh my UPS hit
 95 2018-02-05 05:04:01	0|luke-jr|it guaranteed it's a native segwit address, at least
 96 2018-02-05 05:04:03	0|luke-jr|conman: yes
 97 2018-02-05 05:04:18	0|conman|thanks, it's coming and going
 98 2018-02-05 05:04:28	0|luke-jr|if there's a p2w-random-other-mode added in the future, bech32 will probably support that too without change
 99 2018-02-05 05:07:16	0|conman|ok
100 2018-02-05 06:57:02	0|bitcoin-git|[13bitcoin] 15kien999 opened pull request #12350: i want (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12350
101 2018-02-05 06:57:51	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12350: i want (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12350
102 2018-02-05 08:17:05	0|kallewoof|wumpus: we are in feature freeze right now, right? (was thinking of #10267)
103 2018-02-05 08:17:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
104 2018-02-05 08:20:45	0|sipa|kallewoof: 0.16 is branched ofd
105 2018-02-05 08:21:06	0|sipa|so i don't think there is any freeze on the master branch, just not a lot of focus
106 2018-02-05 08:31:32	0|kallewoof|sipa: ah, okay, cool :)
107 2018-02-05 08:52:43	0|Randolf|https://github.com/bitcoin/bitcoin/pull/12348
108 2018-02-05 08:52:43	0|Randolf|We need to be careful about updating copyright dates, and extending "2017" to a range of "2017-2018" instead of merely replacing with a new year of "2018."  I made these comments in this PR, but also mention it here in case someone else also encounters a year that needs updating elsewhere:
109 2018-02-05 08:57:58	0|FTBCraig|ho
110 2018-02-05 08:58:08	0|Randolf|FTBCraig:  ?
111 2018-02-05 08:58:17	0|FTBCraig|hi
112 2018-02-05 08:58:26	0|Randolf|Hello.
113 2018-02-05 09:00:16	0|dafuq|is it possible to get a log with the full output of a build? to see "g++ -Wall -whatever -o foo.o foo.c" instead of just "CXX     foo.o"
114 2018-02-05 09:01:00	0|dafuq|also ho
115 2018-02-05 09:02:06	0|Randolf|dafuq:  Do you have access to a tool called "script" (Unix, probably in Linux too)?  If so, that should capture everything for you.
116 2018-02-05 09:03:18	0|dafuq|no the problem is I don't see the "g++ ...", just "CXX ..." (which is cleaner admittedly)
117 2018-02-05 09:03:53	0|kallewoof|dafuq: do V=1 make
118 2018-02-05 09:04:18	0|dafuq|cool, V for verbose?
119 2018-02-05 09:04:21	0|kallewoof|Yeah
120 2018-02-05 09:04:36	0|Randolf|You're asking to see the full commands.  That's actually quite interesting to know that V=1 will expose that.
121 2018-02-05 09:04:59	0|dafuq|thanks kallewoof what I was looking for
122 2018-02-05 09:14:41	0|kallewoof|dafuq: great! :)
123 2018-02-05 09:31:24	0|wumpus|rc2 executables up https://bitcoincore.org/bin/bitcoin-core-0.16.0/test.rc2/
124 2018-02-05 09:54:47	0|Randolf|Nice!
125 2018-02-05 10:48:08	0|dafuq|a pull request that changes the type of a variable in the code would fall under what prefix?
126 2018-02-05 10:48:27	0|dafuq|not really trivial?
127 2018-02-05 10:58:29	0|bitcoin-git|[13bitcoin] 15murrayn opened pull request #12351: Libraries: Use type more precisely indicating usage and avoid compilers warnings. (06master...06ptrdiff_t) 02https://github.com/bitcoin/bitcoin/pull/12351
128 2018-02-05 12:21:51	0|bitcoin-git|[13bitcoin] 15murrayn opened pull request #12352: Libraries: Get rid of compiler warning (06master...06logging_warning_fix) 02https://github.com/bitcoin/bitcoin/pull/12352
129 2018-02-05 12:23:16	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12352: Libraries: Get rid of compiler warning (06master...06logging_warning_fix) 02https://github.com/bitcoin/bitcoin/pull/12352
130 2018-02-05 12:45:46	0|bitcoin-git|[13bitcoin] 15fivepiece opened pull request #12353: Add fivepiece gpg key (06master...06add-fivepiece-gpg-key) 02https://github.com/bitcoin/bitcoin/pull/12353
131 2018-02-05 12:46:01	0|bitcoin-git|[13bitcoin] 15fivepiece closed pull request #12353: Add fivepiece gpg key (06master...06add-fivepiece-gpg-key) 02https://github.com/bitcoin/bitcoin/pull/12353
132 2018-02-05 12:46:12	0|arubi|err sorry, wrong branch
133 2018-02-05 12:49:56	0|bitcoin-git|[13bitcoin] 15fivepiece opened pull request #12354: add gpg key for fivepiece (06master...06add-fivepiece-gpg-key) 02https://github.com/bitcoin/bitcoin/pull/12354
134 2018-02-05 12:50:17	0|arubi|there we go
135 2018-02-05 15:55:42	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12356: Fix 'mempool min fee not met' debug output (06master...06minfee-message) 02https://github.com/bitcoin/bitcoin/pull/12356
136 2018-02-05 15:59:09	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (06master...06validation-state-corrupt) 02https://github.com/bitcoin/bitcoin/pull/12357
137 2018-02-05 16:55:30	0|bitcoin-git|[13bitcoin] 15filips123 opened pull request #12359: Update license year range to 2018 (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12359
138 2018-02-05 16:59:39	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12348: Update year to 2018 (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12348
139 2018-02-05 17:23:30	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #12360: Bury bip9 deployments (06master...06bury_bip9_deployments) 02https://github.com/bitcoin/bitcoin/pull/12360
140 2018-02-05 19:48:03	0|sipa|wumpus, mesh_: i went over the release notes and added some things about validateaddress
141 2018-02-05 19:48:09	0|sipa|and made some more edits
142 2018-02-05 19:48:50	0|sipa|https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes/_compare/8b4da4b6acc70361c00eaea5cc3929127f3733f0...024b9407344717a0c55ec48698c38328dad617c8
143 2018-02-05 20:20:06	0|BlueMatt|cfields: #12349 isnt a regression, right?
144 2018-02-05 20:20:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
145 2018-02-05 20:20:16	0|BlueMatt|afaict you should absolutely be able to hit that same case in 0.15.1
146 2018-02-05 20:20:30	0|BlueMatt|just as long as your disk is somewhat slow to get the first block loaded before you can quit
147 2018-02-05 20:23:17	0|BlueMatt|oh, err...wow that's one hell of a race, you have to manage to kill right after pcoinsTip is created after the db is loaded and emptied and before the ActivateBestChain call in LoadChainTip (so that it returns from the ShutdownRequested() check)
148 2018-02-05 20:27:32	0|jtimon|so jnewbery, regarding #12360, do we want to remove bip9? don't we want to reuse that code for bip8 ?
149 2018-02-05 20:27:34	0|gribble|https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery · Pull Request #12360 · bitcoin/bitcoin · GitHub
150 2018-02-05 20:30:06	0|jtimon|nevermind you're just removing tests related to csv it seems, perhaps conserve some parts of feature_bip9_softforks with the dummy deployment?
151 2018-02-05 20:46:18	0|cfields|BlueMatt: unsure. I hit it last night and didn't have time to look at it deeply, I just didn't want to forget about it. Looking now
152 2018-02-05 20:46:52	0|cfields|BlueMatt: I assumed it was a regression caused by the FlushStateToDisk changes in init, but sure, maybe it's unrelated
153 2018-02-05 21:03:58	0|jnewbery|jtimon: feature_bip9_softforks only tests CSV. it was never extended to test other bip9 deployments. It's also written using the comparison test framework, so i think it should just be removed
154 2018-02-05 21:06:25	0|jtimon|jnewbery: makes sense, thanks, we have the unittests for the dummy deployment anyway
155 2018-02-05 21:18:04	0|arubi|if anybody's got some spare time for more review on #12315 or #12321, I'd appreciate your input
156 2018-02-05 21:18:06	0|gribble|https://github.com/bitcoin/bitcoin/issues/12315 | Bech32 addresses in dumpwallet by fivepiece · Pull Request #12315 · bitcoin/bitcoin · GitHub
157 2018-02-05 21:18:07	0|gribble|https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
158 2018-02-05 21:19:43	0|bitcoin-git|13bitcoin/06master 14c409b1a 15João Barbosa: [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions
159 2018-02-05 21:19:43	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d32528e733f2...2a30e67d20f7
160 2018-02-05 21:19:44	0|bitcoin-git|13bitcoin/06master 142a30e67 15MarcoFalke: Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions...
161 2018-02-05 21:20:41	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (06master...062018-02-listtransactions) 02https://github.com/bitcoin/bitcoin/pull/12330
162 2018-02-05 21:30:54	0|BlueMatt|cfields: I dont recall any such changes in 0.16, though we did do a few late in 0.15
163 2018-02-05 21:33:18	0|cfields|BlueMatt: looks like you're right, I was thinking commit 3192975 was new for 0.16
164 2018-02-05 22:24:26	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11398: Hardcode CSV and SEGWIT deployment (06master...06csvburied) 02https://github.com/bitcoin/bitcoin/pull/11398
165 2018-02-05 22:27:44	0|bitcoin-git|[13bitcoin] 15promag opened pull request #12361: Replace unreachable error handling with assertions in feebumber (06master...062018-02-feebumper) 02https://github.com/bitcoin/bitcoin/pull/12361
166 2018-02-05 23:13:43	0|promag|ryanofsky: are you aiming at me?