1 2018-02-08 00:00:14	0|sipa|happy thursday
  2 2018-02-08 00:01:57	0|gmaxwell|so then at least we'd have some amount of base diversity, without any offers to support crazy stuff.
  3 2018-02-08 00:02:14	0|gmaxwell|"Why won't it bootstrap on BeOS???????"
  4 2018-02-08 00:06:57	0|cfields|gmaxwell: I'd just feel honored to be the preimage for BeOS :p
  5 2018-02-08 00:08:05	0|gmaxwell|I used to have a BeOS machine in jenkins CI for opus, it was interesting to test on because it made some pretty different calls from linux on optional extensions beyond pure posix.
  6 2018-02-08 00:08:38	0|cfields|erm, when was this?
  7 2018-02-08 00:09:13	0|gmaxwell|ten years ago. (it was long dead by then too, of course)
  8 2018-02-08 00:09:49	0|cfields|ah, ok. I was trying to figure out the overlap between Jenkins and BeOS.
  9 2018-02-08 00:10:46	0|gmaxwell|since jenkins uses java you can run most anything java will run on as a remote build target.
 10 2018-02-08 00:44:07	0|contrapumpkin|have y'all looked at the Nix builds of bitcoin at all?
 11 2018-02-08 00:44:23	0|contrapumpkin|roconnor wrote most of them, but it's a nice baseline to start with
 12 2018-02-08 00:44:33	0|sipa|i don't think they're deterministic?
 13 2018-02-08 00:44:46	0|contrapumpkin|I don't think so either
 14 2018-02-08 00:45:02	0|contrapumpkin|but it's a less heavyweight starting point than a VM for the determinism
 15 2018-02-08 00:45:22	0|contrapumpkin|when all your inputs are effectively deterministic modulo meaningless shit
 16 2018-02-08 00:45:51	0|sipa|contrapumpkin: i think we pretty much already have all that that does through the depends build system
 17 2018-02-08 00:58:47	0|Randolf|contrapumpkin:  I recently made a minor contribution by adding instructions for NetBSD support, and there were many developers who took an interest in what I was doing and helped to make it even better.
 18 2018-02-08 00:59:26	0|Randolf|contrapumpkin:  It seems to me that Unix/Linux support is very good, but I guess you've got some improvements in mind?  (If so, great!)
 19 2018-02-08 01:17:30	0|bitcoin-git|[13bitcoin] 15theuni opened pull request #12381: Remove more boost threads (06master...06boost-threads-again) 02https://github.com/bitcoin/bitcoin/pull/12381
 20 2018-02-08 02:17:25	0|bitcoin-git|[13bitcoin] 15pristantyo opened pull request #12382: Request Source Code Pull (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12382
 21 2018-02-08 02:18:35	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12382: Request Source Code Pull (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12382
 22 2018-02-08 07:41:59	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0277173b1def...7217ea2cc8dd
 23 2018-02-08 07:42:00	0|bitcoin-git|13bitcoin/06master 141c9394a 15Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait...
 24 2018-02-08 07:42:00	0|bitcoin-git|13bitcoin/06master 14dd2de47 15Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded...
 25 2018-02-08 07:42:01	0|bitcoin-git|13bitcoin/06master 147217ea2 15Wladimir J. van der Laan: Merge #12367: Fix two fast-shutdown bugs...
 26 2018-02-08 07:42:43	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12367: Fix two fast-shutdown bugs (06master...062018-02-wait-genesis-exit) 02https://github.com/bitcoin/bitcoin/pull/12367
 27 2018-02-08 07:52:01	0|bitcoin-git|13bitcoin/06master 142222bf0 15MarcoFalke: qt: Poll ShutdownTimer after init is done
 28 2018-02-08 07:52:01	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7217ea2cc8dd...36a927c52585
 29 2018-02-08 07:52:02	0|bitcoin-git|13bitcoin/06master 1436a927c 15Wladimir J. van der Laan: Merge #12377: qt: Poll ShutdownTimer after init is done...
 30 2018-02-08 07:52:56	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12377: qt: Poll ShutdownTimer after init is done (06master...06Mf1802-qtInitShutdown) 02https://github.com/bitcoin/bitcoin/pull/12377
 31 2018-02-08 07:52:59	0|sipa|woohoo
 32 2018-02-08 07:53:39	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/36a927c52585...11f3eac79334
 33 2018-02-08 07:53:40	0|bitcoin-git|13bitcoin/06master 141e5d14b 15Wladimir J. van der Laan: qt: Clarify some comments...
 34 2018-02-08 07:53:40	0|bitcoin-git|13bitcoin/06master 14f5a4c3d 15Wladimir J. van der Laan: qt: Make sure splash screen is freed on AppInitMain fail...
 35 2018-02-08 07:53:41	0|bitcoin-git|13bitcoin/06master 1411f3eac 15Wladimir J. van der Laan: Merge #12374: qt: Make sure splash screen is freed on AppInitMain fail...
 36 2018-02-08 07:54:25	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12374: qt: Make sure splash screen is freed on AppInitMain fail (06master...062017_02_splash_abort) 02https://github.com/bitcoin/bitcoin/pull/12374
 37 2018-02-08 08:22:21	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/11f3eac79334...6db4fa7ad329
 38 2018-02-08 08:22:22	0|bitcoin-git|13bitcoin/06master 14b1c2370 15Wladimir J. van der Laan: http: Join worker threads before deleting work queue...
 39 2018-02-08 08:22:22	0|bitcoin-git|13bitcoin/06master 14f946654 15Wladimir J. van der Laan: http: Remove WaitExit from WorkQueue...
 40 2018-02-08 08:22:23	0|bitcoin-git|13bitcoin/06master 1411e0151 15Wladimir J. van der Laan: http: Remove numThreads and ThreadCounter...
 41 2018-02-08 08:23:08	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12366: http: Join worker threads before deleting work queue (06master...062017_02_httpserver_join) 02https://github.com/bitcoin/bitcoin/pull/12366
 42 2018-02-08 08:25:54	0|bitcoin-git|13bitcoin/060.16 14d56355a 15MarcoFalke: 0.16: Check in current release notes draft
 43 2018-02-08 08:25:54	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 060.16: 02https://github.com/bitcoin/bitcoin/compare/f17942a3bc81...da84760701dc
 44 2018-02-08 08:25:55	0|bitcoin-git|13bitcoin/060.16 14da84760 15Wladimir J. van der Laan: Merge #12380: 0.16: Check in current release notes draft...
 45 2018-02-08 08:32:38	0|bitcoin-git|[13bitcoin] 15Willtech opened pull request #12384: Docs: Edited /doc/tor.md (06master...06tor.md) 02https://github.com/bitcoin/bitcoin/pull/12384
 46 2018-02-08 08:40:06	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6db4fa7ad329...d57d10ee96a6
 47 2018-02-08 08:40:07	0|bitcoin-git|13bitcoin/06master 1402fc886 15Matt Corallo: Add braces to meet code style on line-after-the-one-changed.
 48 2018-02-08 08:40:07	0|bitcoin-git|13bitcoin/06master 1485aa839 15Matt Corallo: Hold mempool.cs for the duration of ATMP....
 49 2018-02-08 08:40:08	0|bitcoin-git|13bitcoin/06master 14d57d10e 15Wladimir J. van der Laan: Merge #12368: Hold mempool.cs for the duration of ATMP....
 50 2018-02-08 08:40:59	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12368: Hold mempool.cs for the duration of ATMP. (06master...062018-02-getrawmempool-race) 02https://github.com/bitcoin/bitcoin/pull/12368
 51 2018-02-08 08:41:39	0|gmaxwell|FWIW, I've had that stack of patches running for a few hours without issue, plus some restart cycles in valgrind.
 52 2018-02-08 08:56:42	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d57d10ee96a6...ab4ee6e69242
 53 2018-02-08 08:56:43	0|bitcoin-git|13bitcoin/06master 1445eea40 15fivepiece: Bech32 addresses in dumpwallet...
 54 2018-02-08 08:56:43	0|bitcoin-git|13bitcoin/06master 14ab4ee6e 15Wladimir J. van der Laan: Merge #12315: Bech32 addresses in dumpwallet...
 55 2018-02-08 08:57:28	0|arubi|yay :)
 56 2018-02-08 08:57:36	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12315: Bech32 addresses in dumpwallet (06master...06dumpwallet-bech32) 02https://github.com/bitcoin/bitcoin/pull/12315
 57 2018-02-08 08:57:37	0|gmaxwell|okay, that one I didn't test.
 58 2018-02-08 09:11:03	0|wumpus|yeah, the bech32 dumpwallet one is the one of the bunch that isn't completely straightforward and might require more testing - luckily this will be rc3, not final
 59 2018-02-08 09:12:52	0|wumpus|the "address type is whatever there is a label for" part is interesting
 60 2018-02-08 09:13:32	0|wumpus|though correct, I think
 61 2018-02-08 09:18:47	0|gmaxwell|the alternative construction would be to emit duplicate lines, one with each address we'd accept.
 62 2018-02-08 09:19:50	0|sipa|it's just in a comment anyway
 63 2018-02-08 09:19:56	0|wumpus|yes
 64 2018-02-08 09:25:34	0|bitcoin-git|[13bitcoin] 15laanwj pushed 11 new commits to 060.16: 02https://github.com/bitcoin/bitcoin/compare/da84760701dc...758a41e10045
 65 2018-02-08 09:25:35	0|bitcoin-git|13bitcoin/060.16 1409fc859 15Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait...
 66 2018-02-08 09:25:35	0|bitcoin-git|13bitcoin/060.16 140f207c4 15Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded...
 67 2018-02-08 09:25:36	0|bitcoin-git|13bitcoin/060.16 14604f289 15MarcoFalke: qt: Poll ShutdownTimer after init is done...
 68 2018-02-08 09:35:24	0|bitcoin-git|13bitcoin/060.16 144f63a43 15Wladimir J. van der Laan: qt: Pre-rc3 translations update...
 69 2018-02-08 09:35:24	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/4f63a43f6b0425b4cdd9211283017af375e18c90
 70 2018-02-08 09:50:41	0|bitcoin-git|13bitcoin/060.16 14a5e3d44 15Wladimir J. van der Laan: doc: Update release notes from wiki (for rc3 PRs)...
 71 2018-02-08 09:50:41	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/a5e3d44cc8f61f03a94d57302ff8c33c8f8a8689
 72 2018-02-08 09:53:08	0|wumpus|okay, anything I forgot before tagging rc3?
 73 2018-02-08 09:58:22	0|midnightmagic|YES WAIT..
 74 2018-02-08 09:58:27	0|midnightmagic|j/k
 75 2018-02-08 10:04:31	0|wumpus|hehe
 76 2018-02-08 10:05:26	0|wumpus|* [new tag]         v0.16.0rc3 -> v0.16.0rc3
 77 2018-02-08 10:11:59	0|bitcoin-git|13bitcoin/06master 14b947d38 15Akira Takizawa: Add gitian PGP key: akx20000
 78 2018-02-08 10:11:59	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ab4ee6e69242...c9ca4f6024e0
 79 2018-02-08 10:12:00	0|bitcoin-git|13bitcoin/06master 14c9ca4f6 15Wladimir J. van der Laan: Merge #12371: Add gitian PGP key: akx20000...
 80 2018-02-08 10:12:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12371: Add gitian PGP key: akx20000 (06master...06gitian-key) 02https://github.com/bitcoin/bitcoin/pull/12371
 81 2018-02-08 10:25:46	0|promag|wumpus: no more theme release right?
 82 2018-02-08 10:26:02	0|wumpus|hopefully not
 83 2018-02-08 10:29:10	0|promag|wumpus: if you find the time #12333
 84 2018-02-08 10:29:35	0|gribble|https://github.com/bitcoin/bitcoin/issues/12333 | Make CWallet::ListCoins atomic by promag · Pull Request #12333 · bitcoin/bitcoin · GitHub
 85 2018-02-08 10:29:43	0|promag|add ?w=1
 86 2018-02-08 10:55:23	0|promag|wumpus: this should be ready #12298
 87 2018-02-08 11:20:49	0|provoostenator|Time to ssh into my computer, start the gitian VM, ssh into that and then have it build the vm that builds rc3. Must go deeper!
 88 2018-02-08 11:22:38	0|promag|provoostenator: and play this https://www.youtube.com/watch?v=imamcajBEJs
 89 2018-02-08 11:22:59	0|provoostenator|No, I'm tethering...
 90 2018-02-08 11:25:10	0|promag|IMO we should add the version when something is deprecated, like DEPRECATED(0.16.0)
 91 2018-02-08 11:26:08	0|promag|without that a reviewer must blame to see when it was deprecated
 92 2018-02-08 11:26:15	0|promag|context 12336
 93 2018-02-08 11:42:01	0|promag|Close 12387..
 94 2018-02-08 11:50:24	0|arubi|comments on #12321 ?
 95 2018-02-08 11:50:25	0|gribble|https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh and p2sh-p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
 96 2018-02-08 12:04:41	0|arubi|oh actually I could use GetScriptForWitness() right?
 97 2018-02-08 12:07:48	0|arubi|well not blindly, it might return a p2wpkh instead
 98 2018-02-08 12:17:06	0|wumpus|0.04s$ if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/git-subtree-check.sh src/crypto/ctaes; fi ERROR: src/crypto/ctaes is not a subtree
 99 2018-02-08 12:17:06	0|wumpus|what's wrong with travis on rc3?
100 2018-02-08 12:17:13	0|wumpus|https://travis-ci.org/bitcoin/bitcoin/jobs/338906244
101 2018-02-08 12:17:49	0|wumpus|I cannot reproduce that error locally
102 2018-02-08 12:21:18	0|promag|cache?
103 2018-02-08 12:24:41	0|wumpus|deleted the cache for the 0.16 branch, we'll see
104 2018-02-08 12:27:16	0|wumpus|same issue
105 2018-02-08 12:31:46	0|promag|wumpus: https://github.com/bitcoin/bitcoin/commits/0.16
106 2018-02-08 12:31:49	0|bitcoin-git|13bitcoin/06master 145bdbbdc 15João Barbosa: Refactor HaveKeys to early return on false result
107 2018-02-08 12:31:49	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c9ca4f6024e0...a1ffddb90d1b
108 2018-02-08 12:31:50	0|bitcoin-git|13bitcoin/06master 14a1ffddb 15Wladimir J. van der Laan: Merge #12298: Refactor HaveKeys to early return on false result...
109 2018-02-08 12:32:44	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12298: Refactor HaveKeys to early return on false result (06master...062018-01-ismine-havekeys) 02https://github.com/bitcoin/bitcoin/pull/12298
110 2018-02-08 12:32:47	0|promag|this happened before https://travis-ci.org/bitcoin/bitcoin/jobs/338892886
111 2018-02-08 12:36:32	0|wumpus|"git log src/crypto/ctaes" shows the last change to ctaes was made a year and two months ago
112 2018-02-08 12:37:29	0|wumpus|maybe it has to do with "git clone --depth=50 --branch=0.16" , will try that
113 2018-02-08 12:39:05	0|wumpus|that's it: at depth 50, it cannot see that it is a subtree
114 2018-02-08 12:39:57	0|wumpus|e.g. the last change to ctaes was more than 50 commits ago, so for a shallow checkout, it's "lost"
115 2018-02-08 12:40:55	0|wumpus|the obvious solution would be to clone deeper, I guess, though it might be kicking the can down the road, I'd say to be robust the check needs to generate a warning in this case but continue
116 2018-02-08 12:42:04	0|wumpus|anyow I'll create a github issue, good to know at least this signals nothing important
117 2018-02-08 12:47:28	0|wumpus|https://github.com/bitcoin/bitcoin/issues/12388
118 2018-02-08 12:51:39	0|bitcoin-git|13bitcoin/06master 1427736f2 15fivepiece: add fivepiece key fingerprint
119 2018-02-08 12:51:39	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a1ffddb90d1b...b2645286745b
120 2018-02-08 12:51:40	0|bitcoin-git|13bitcoin/06master 14b264528 15Wladimir J. van der Laan: Merge #12354: add gpg key for fivepiece...
121 2018-02-08 12:52:10	0|arubi|oh thanks, I was about to mention after pushing rc3 sigs
122 2018-02-08 12:52:29	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12354: add gpg key for fivepiece (06master...06add-fivepiece-gpg-key) 02https://github.com/bitcoin/bitcoin/pull/12354
123 2018-02-08 14:38:52	0|bitcoin-git|[13bitcoin] 15laanwj pushed 9 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b2645286745b...3843780fd8e0
124 2018-02-08 14:38:53	0|bitcoin-git|13bitcoin/06master 14a5623b1 15John Newbery: [tests] Remove tests for deprecated estimatefee RPC
125 2018-02-08 14:38:53	0|bitcoin-git|13bitcoin/06master 14d119f2e 15John Newbery: [tests] Fix style warnings in feature_fee_estimation.py
126 2018-02-08 14:38:54	0|bitcoin-git|13bitcoin/06master 14a8e437a 15John Newbery: [tests] Remove estimatefee from rpc_deprecated.py test
127 2018-02-08 14:39:45	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12336: Remove deprecated rpc options (06master...06remove_deprecated_rpcs) 02https://github.com/bitcoin/bitcoin/pull/12336
128 2018-02-08 14:53:19	0|BlueMatt|wumpus: where are we managing release notes for 16? (or do you want to just make sure that they mention the change in regtest consensus rules causing a CheckBlockIndex() failure on upgrade)
129 2018-02-08 14:53:25	0|BlueMatt|ie #11782
130 2018-02-08 14:53:26	0|gribble|https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub
131 2018-02-08 14:54:32	0|wumpus|BlueMatt: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
132 2018-02-08 14:54:48	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3843780fd8e0...935eb8de039d
133 2018-02-08 14:54:49	0|bitcoin-git|13bitcoin/06master 140b9207e 15practicalswift: Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812)
134 2018-02-08 14:54:49	0|bitcoin-git|13bitcoin/06master 144cbab15 15practicalswift: tests: Fix accidental redefinition of previously defined variable via list comprehension
135 2018-02-08 14:54:50	0|bitcoin-git|13bitcoin/06master 14a9d0ebc 15practicalswift: Enable flake8 warnings for all currently non-violated rules
136 2018-02-08 14:55:06	0|wumpus|it's currently the same as the one on the 0.16 branch, but you should do editing on the wiki
137 2018-02-08 14:56:03	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12295: Enable flake8 warnings for all currently non-violated rules (06master...06accidental-redefinition-of-variable) 02https://github.com/bitcoin/bitcoin/pull/12295
138 2018-02-08 15:05:09	0|BlueMatt|thanks!
139 2018-02-08 15:06:06	0|instagibbs|i was able to do a couple gitian runs, now compiling rc3 and getting: ./bin/gbuild:21:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
140 2018-02-08 15:06:19	0|instagibbs|ideas?
141 2018-02-08 15:19:54	0|bitcoin-git|[13bitcoin] 15MajorFireball opened pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (06master...060.16) 02https://github.com/bitcoin/bitcoin/pull/12390
142 2018-02-08 15:20:41	0|wumpus|instagibbs: anything in build.log?
143 2018-02-08 15:22:20	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (06master...060.16) 02https://github.com/bitcoin/bitcoin/pull/12390
144 2018-02-08 15:32:43	0|bitcoin-git|13bitcoin/06master 14fa795cf 15MarcoFalke: wallet: Disallow abandon of conflicted txes
145 2018-02-08 15:32:43	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/935eb8de039d...663911ed581d
146 2018-02-08 15:32:44	0|bitcoin-git|13bitcoin/06master 14663911e 15Wladimir J. van der Laan: Merge #12282: wallet: Disallow abandon of conflicted txes...
147 2018-02-08 15:33:09	0|instagibbs|re-running with just linux build to get saner log
148 2018-02-08 15:33:30	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12282: wallet: Disallow abandon of conflicted txes (06master...06Mf1801-walletBumpAbandonOnlyNonConflictedTxes) 02https://github.com/bitcoin/bitcoin/pull/12282
149 2018-02-08 15:39:06	0|instagibbs|wumpus, pages and pages of file timestamps being from the future, and "Check your system clock" message, followed by exit
150 2018-02-08 15:43:16	0|wumpus|instagibbs: strange, never seen that before
151 2018-02-08 15:53:33	0|wumpus|gitian seems like a gambling machine sometimes
152 2018-02-08 15:54:20	0|wumpus|(though, maybe as a surprising anecdote, here it's been 100% reliable for a long time)
153 2018-02-08 16:01:26	0|wumpus|oh crap, I've just apt-get-upgraded the VM running gitian, this might have been the last time that ^
154 2018-02-08 16:04:59	0|achow101|wumpus: I highly suggest that you never do that because it will break gitian
155 2018-02-08 16:05:35	0|wumpus|so this went to debian 8.x now, not 9
156 2018-02-08 16:09:57	0|wumpus|oh, wrong, /etc/debian_version says 9.3
157 2018-02-08 16:11:37	0|wumpus|no it is 8.10 alright, checked the wrong VM, phew. It would have been really surprising to end up with 9 when just upgrading packages on 8.x. Now let's see if the build still works.
158 2018-02-08 16:14:14	0|instagibbs|running 8.10 here as well hm
159 2018-02-08 16:17:06	0|MarcoFalke|debian 9 should work after the fix https://github.com/bitcoin-core/docs/pull/22
160 2018-02-08 16:32:45	0|provoostenator|instagibbs: I'm also getting " failed to run on-target setarch x86_64 "
161 2018-02-08 16:33:14	0|provoostenator|And that's a fresh Debian 8 that I used for rc2 two days ago.
162 2018-02-08 16:36:33	0|provoostenator|Though I used --setup that time, using -b this time.
163 2018-02-08 16:38:52	0|wumpus|buliding on (upgraded) 8.10 seems to be going ok here
164 2018-02-08 16:39:53	0|provoostenator|My VM clock is totally wrong though, why doesn't Debian sync it?
165 2018-02-08 16:40:50	0|Sentineo|is it just an offset ? it does it for me on lxc ... always gmt
166 2018-02-08 16:41:14	0|wumpus|debian doesn't install as many packages by default as ubuntu does, maybe you need to install the ntp stuff
167 2018-02-08 16:42:17	0|provoostenator|I just installed ntp. Trying gitian again.
168 2018-02-08 16:42:17	0|wumpus|always compare date -u against UTC, the timezone shouldn't matter
169 2018-02-08 16:43:42	0|instagibbs|i thought mocktime somethingsomething was under the hood for these builds
170 2018-02-08 16:44:00	0|MarcoFalke|yeah, why would wall clock time matter
171 2018-02-08 16:47:27	0|instagibbs|provoostenator, please report back, ill hold out
172 2018-02-08 16:49:26	0|provoostenator|That seems to have done the trick.
173 2018-02-08 16:49:45	0|provoostenator|So let's just add installation instructions for ntp to the docs and not worry about why :-P
174 2018-02-08 16:51:31	0|achow101|instagibbs: MarcoFalke I'm guessing that the time of the vm and the time of the lxc container need to be the same so that the vm can send commands to the container
175 2018-02-08 16:51:37	0|achow101|the container has mocktime for the build itself
176 2018-02-08 16:52:02	0|wumpus|yes, having working instruction is more important than knowing why, I've found that usually with time-related problems it's something with SSL certificates or other network communications getting confused about large time differences
177 2018-02-08 16:52:27	0|provoostenator|I wonder what made suddenly made it picky though; I never paid much attention to the time on my gitian machines thus far, and I certainly didn't leave them on non-stop.
178 2018-02-08 16:52:32	0|wumpus|also if your time is too far in the past, any .tar.gz you unpack will have dates in the future, causing problems with make
179 2018-02-08 16:53:00	0|provoostenator|I may however have frozen the state, rather than shutting it down.
180 2018-02-08 16:55:23	0|Sentineo|some daemons refuse to start when time is not going forward, especially network daemons
181 2018-02-08 17:05:42	0|instagibbs|yeah looks like it's fixed
182 2018-02-08 17:55:37	0|promag|jnewbery: do you think bitcoind should auto-set LIBC_FATAL_STDERR_?
183 2018-02-08 17:59:00	0|wumpus|no, bitcoind should not set that, if desired it's intended to be set in the environment by calling process
184 2018-02-08 18:01:02	0|promag|ok, I didn't know that env var
185 2018-02-08 18:01:45	0|wumpus|me neither; it's specific to glibc so will likely not work on other OSes
186 2018-02-08 18:02:34	0|wumpus|or at least other C libraries
187 2018-02-08 18:03:44	0|promag|jnewbery: https://github.com/bitcoin/bitcoin/pull/12379/commits/f70e7997d26e3e456486ab0a351b8a352de07935 s/stdout/stderr in commit message?
188 2018-02-08 18:14:48	0|jnewbery|promag: yes indeed. Thanks - can you leave review comments on the PR please?
189 2018-02-08 18:20:10	0|promag|jnewbery: no problem
190 2018-02-08 18:48:46	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/663911ed581d...d405beea26c1
191 2018-02-08 18:48:47	0|bitcoin-git|13bitcoin/06master 141beea7a 15João Barbosa: [wallet] Make CWallet::ListCoins atomic
192 2018-02-08 18:48:47	0|bitcoin-git|13bitcoin/06master 142f960b5 15João Barbosa: [wallet] Indent only change of CWallet::AvailableCoins
193 2018-02-08 18:48:48	0|bitcoin-git|13bitcoin/06master 14d405bee 15Wladimir J. van der Laan: Merge #12333: Make CWallet::ListCoins atomic...
194 2018-02-08 18:49:30	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12333: Make CWallet::ListCoins atomic (06master...062018-02-atomic-listcoins) 02https://github.com/bitcoin/bitcoin/pull/12333
195 2018-02-08 19:00:12	0|achow101|meeting?
196 2018-02-08 19:00:15	0|sipa|*PLING*
197 2018-02-08 19:00:28	0|lightningbot|Meeting started Thu Feb  8 19:00:27 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
198 2018-02-08 19:00:28	0|lightningbot|Useful Commands: #action #agreed #help #info #idea #link #topic.
199 2018-02-08 19:00:28	0|wumpus|#startmeeting
200 2018-02-08 19:00:47	0|instagibbs|hi
201 2018-02-08 19:00:51	0|cfields|hi
202 2018-02-08 19:00:51	0|wumpus|#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
203 2018-02-08 19:01:04	0|sdaftuar|hi
204 2018-02-08 19:01:06	0|jnewbery|hi
205 2018-02-08 19:01:16	0|achow101|hi
206 2018-02-08 19:01:21	0|wumpus|PSA: rc3 was tagged earlier today, if you haven't started your gitian build yet, please do so :)
207 2018-02-08 19:01:29	0|promag|topic suggestion, next high priority stuff
208 2018-02-08 19:01:40	0|wumpus|yes
209 2018-02-08 19:01:44	0|instagibbs|provoostenator, you filed an issue for timestamps right?
210 2018-02-08 19:01:47	0|wumpus|#topic high priority for review
211 2018-02-08 19:02:39	0|wumpus|we still have plenty of things in https://github.com/bitcoin/bitcoin/projects/8, but it hasn't been updated for a few weeks because we've effectively used the 0.16 milestone for that, so now that 0.16 has branched it's up for discussion to add/remove things
212 2018-02-08 19:02:41	0|kanzure|hi.
213 2018-02-08 19:03:08	0|promag|for instance #11383
214 2018-02-08 19:03:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
215 2018-02-08 19:03:38	0|jtimon|https://github.com/bitcoin/bitcoin/pull/12172 could use some tested acks, even if it's a small bug
216 2018-02-08 19:04:19	0|wumpus|jtimon: you have a comment by MarcoFalke to remove a commit IIRC
217 2018-02-08 19:04:22	0|jnewbery|#10740 needs rebase so it can be removed for now (and I think it makes sense to wait for after 11383 is in)
218 2018-02-08 19:04:25	0|gribble|https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
219 2018-02-08 19:04:40	0|wumpus|but yes, #12172 should stay
220 2018-02-08 19:04:43	0|gribble|https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub
221 2018-02-08 19:04:44	0|jtimon|wumpus: yes, does anyone agree? I agree with removing it. just waiting for feedback
222 2018-02-08 19:04:45	0|Randolf|Hello.
223 2018-02-08 19:05:13	0|wumpus|jtimon: well he's the tests maintainer so I tend to agree with him regarding tests things, by default
224 2018-02-08 19:05:25	0|achow101|It would be nice to get #10583 and #10579 in
225 2018-02-08 19:05:28	0|gribble|https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
226 2018-02-08 19:05:31	0|gribble|https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
227 2018-02-08 19:05:44	0|wumpus|jtimon: I haven't looked closely though
228 2018-02-08 19:05:48	0|jnewbery|fyi MarcoFalke, ryanofsky and bluematt are away from keyboard
229 2018-02-08 19:05:49	0|jtimon|ok, I'll remove it, no problem, it will still need some tested acks then
230 2018-02-08 19:05:49	0|promag|jtimon: I'll check it too
231 2018-02-08 19:06:21	0|jtimon|promag: thanks!
232 2018-02-08 19:06:30	0|jnewbery|achow101: +1 a few more ACKs please - those PRs have been rebased too many times
233 2018-02-08 19:06:41	0|wumpus|10740 removed
234 2018-02-08 19:06:43	0|instagibbs|will takea  look achow101
235 2018-02-08 19:06:58	0|wumpus|jtimon: but yes I'll take a look soon
236 2018-02-08 19:07:07	0|jtimon|awesome
237 2018-02-08 19:07:13	0|cfields|topic suggestion: PR purge before ramping up for 0.17
238 2018-02-08 19:07:31	0|instagibbs|purge as in closing?
239 2018-02-08 19:07:43	0|promag|#11882
240 2018-02-08 19:07:46	0|gribble|https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub
241 2018-02-08 19:08:02	0|cfields|well, I looked at my open PR list yesterday and noticed quite a few that I should probably just close. I suspect I'm not alone...
242 2018-02-08 19:08:25	0|wumpus|that could be a next topic, the current topic is high priority :)
243 2018-02-08 19:08:27	0|cfields|now seems like a good time to go through their own and close things that are stale
244 2018-02-08 19:08:36	0|wumpus|bjut yes I agree
245 2018-02-08 19:09:06	0|promag|Also #11913
246 2018-02-08 19:09:09	0|gribble|https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub
247 2018-02-08 19:09:19	0|cfields|ok, sorry
248 2018-02-08 19:09:34	0|jnewbery|cfields: perhaps the upcoming Core dev tech days is a good opportunity to go through and clear out old PRs?
249 2018-02-08 19:09:38	0|wumpus|achow101: I've added 10583, you already have the coin selection one I think two high prio per person is a good limit
250 2018-02-08 19:09:40	0|jtimon|yeah, there have been no interest in https://github.com/bitcoin/bitcoin/pull/9608 for a while so I'm more inclined to close it than to rebase it at this point unless  someone changes my mind
251 2018-02-08 19:10:43	0|meshcollider|hi
252 2018-02-08 19:11:19	0|sipa|could i have some comments on #10785 ?
253 2018-02-08 19:11:20	0|instagibbs|jnewbery, PR triage/close session sounds like a good idea
254 2018-02-08 19:11:22	0|gribble|https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
255 2018-02-08 19:11:31	0|achow101|wumpus: ok
256 2018-02-08 19:11:32	0|wumpus|#topic PR purge
257 2018-02-08 19:12:26	0|achow101|close old PRs?
258 2018-02-08 19:12:28	0|wumpus|if PRs should be closed you can always let me know, you don't really need to wait until a meeting
259 2018-02-08 19:12:36	0|cfields|jnewbery: agreed, as a rally. But I was really just hinting that everyone should clean up their stale pulls to get the count down.
260 2018-02-08 19:12:58	0|cfields|jnewbery: but yes, a kinda "i'm not sure if anyone cares about this or not" session in NYC would be great
261 2018-02-08 19:13:24	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10434: [WIP] 3072-bit MuHash based hash_serialized (06master...06muhash) 02https://github.com/bitcoin/bitcoin/pull/10434
262 2018-02-08 19:13:33	0|wumpus|as I've said again and again, it's impossible for me to keep track of all PRs, so if there is something with a PR, just notify me
263 2018-02-08 19:13:37	0|bitcoin-git|[13bitcoin] 15achow101 closed pull request #9504: [RPC] dumpmasterprivkey command (06master...06dumpmasterprivkey) 02https://github.com/bitcoin/bitcoin/pull/9504
264 2018-02-08 19:13:45	0|jnewbery|It feels like in-person is the most efficient way to do a bulk purge. Probably most efficient if a set of us make lists beforehand for what we think can be closed
265 2018-02-08 19:14:43	0|wumpus|yes
266 2018-02-08 19:14:56	0|bitcoin-git|[13bitcoin] 15promag closed pull request #11563: Improve CheckBlockIndex performance (06master...062017-10-improve-checkblockindex) 02https://github.com/bitcoin/bitcoin/pull/11563
267 2018-02-08 19:15:00	0|cfields|sgtm
268 2018-02-08 19:15:33	0|cfields|</topic>
269 2018-02-08 19:15:40	0|wumpus|any other topics?
270 2018-02-08 19:15:42	0|bitcoin-git|[13bitcoin] 15jtimon closed pull request #9608: Net: Divide ProcessMessage in smaller functions (06master...062017-01-split-processmessages) 02https://github.com/bitcoin/bitcoin/pull/9608
271 2018-02-08 19:16:14	0|bitcoin-git|[13bitcoin] 15instagibbs closed pull request #10360: [WIP] [Wallet] Target effective value during transaction creation (06master...06feedo) 02https://github.com/bitcoin/bitcoin/pull/10360
272 2018-02-08 19:16:29	0|cfields|maybe that should've been the last topic :p
273 2018-02-08 19:16:31	0|wumpus|so ocongratulations everyone on rc3! we were reallly fast with the fixes this time
274 2018-02-08 19:17:09	0|achow101|hopefully this will be the last rc
275 2018-02-08 19:17:23	0|wumpus|hopefully, yes
276 2018-02-08 19:18:01	0|wumpus|cfields: at least the closes end up in the meeting log now
277 2018-02-08 19:18:03	0|Randolf|wumpus:  Is rc3 available for download?
278 2018-02-08 19:18:20	0|wumpus|Randolf: no, it's just tagged earlier today
279 2018-02-08 19:18:36	0|Randolf|Okay.  Thanks.
280 2018-02-08 19:18:51	0|wumpus|but if you have no problems with rc2, it should be ok, rc3 mostly fixed some edge cases
281 2018-02-08 19:19:05	0|wumpus|(to do with initialization and shutdown)
282 2018-02-08 19:19:16	0|cfields|wumpus: heh
283 2018-02-08 19:19:23	0|Randolf|I was planning to try rc2 this weekend.  If rc3 comes out first though, then rc3 is where I'll start.
284 2018-02-08 19:20:28	0|wumpus|I think it'll be possible to upload binaries for rc3 tomorrow
285 2018-02-08 19:20:55	0|achow101|have we gotten anywhere with the MPC RSA signing thing?
286 2018-02-08 19:21:00	0|Randolf|That will be great.
287 2018-02-08 19:21:25	0|wumpus|already lots of rc3 gitian sigs
288 2018-02-08 19:21:38	0|cfields|achow101: oh, right
289 2018-02-08 19:21:48	0|cfields|gmaxwell: ping ^^. Any update?
290 2018-02-08 19:23:17	0|achow101|I'm gonna guess that gmaxwell is not here right now
291 2018-02-08 19:23:24	0|wumpus|I guess so too
292 2018-02-08 19:23:35	0|instagibbs|busy with ___root
293 2018-02-08 19:23:42	0|wumpus|I'm also not hearing any other proposals for topics, so this will be a short meeting I suppose
294 2018-02-08 19:23:58	0|Randolf|instagibbs:  ...or fork (if he has kids).  ;)
295 2018-02-08 19:24:35	0|Randolf|wumpus:  Moving away from Boost libraries?
296 2018-02-08 19:24:40	0|achow101|Randolf: he doesn't have kids. I'm pretty sure he hates children
297 2018-02-08 19:24:41	0|Randolf|wumpus:  ...as a topic?
298 2018-02-08 19:24:55	0|cfields|wumpus: mine just finished building. We can do binaries today if we get the osx sig :)
299 2018-02-08 19:24:58	0|wumpus|Randolf: is there anything specific to discuss about that? it's been going on, slowly, for a long time
300 2018-02-08 19:25:09	0|wumpus|Randolf: review cfields's PRs!
301 2018-02-08 19:25:27	0|Randolf|wumpus:  Well, it seems to me a good idea because Boost libraries have been a problem with getting numerous things compiled on NetBSD.  I guess I'm just wondering how things are going on that front.
302 2018-02-08 19:25:32	0|Randolf|More general.
303 2018-02-08 19:25:35	0|arubi|craig satoshi
304 2018-02-08 19:25:36	0|sipa|Randolf: it will be years
305 2018-02-08 19:25:40	0|arubi|holy shit roger is stupid
306 2018-02-08 19:25:47	0|cfields|Randolf: https://github.com/bitcoin/bitcoin/projects/3
307 2018-02-08 19:25:47	0|sipa|arubi: not here
308 2018-02-08 19:25:49	0|arubi|oh man sorry, wrong channel
309 2018-02-08 19:25:50	0|Randolf|sipa:  Oh, so there must be a lot of things tied to it then.
310 2018-02-08 19:25:59	0|arubi|yea, missed the ctrl :)
311 2018-02-08 19:26:32	0|Randolf|cfields:  Thanks.  Wow, there's quite a lot to do there, and I wonder if that's everything that needs to be done.
312 2018-02-08 19:26:39	0|wumpus|there's no hurry in any case
313 2018-02-08 19:26:42	0|cfields|Randolf: short version: I think we'll be able to get rid of a few parts of boost for 0.17, but things like the unit tests will keep it hanging around for a while
314 2018-02-08 19:26:45	0|Randolf|Sure, because it's working.
315 2018-02-08 19:27:07	0|Randolf|cfields:  That seems reasonable.
316 2018-02-08 19:27:09	0|wumpus|boost::filesystem can only be replaced in c++17 or so
317 2018-02-08 19:27:10	0|cfields|anyway, we can discuss after the meeting
318 2018-02-08 19:27:22	0|Randolf|Okay.
319 2018-02-08 19:27:23	0|wumpus|will be a while until we can start using that
320 2018-02-08 19:27:25	0|cfields|wumpus: right
321 2018-02-08 19:28:04	0|wumpus|or at least, mandating it, it could theoretically be an option, but meh. I'd recommend you just solve whatever build problems you have with boost and put it behind you for now
322 2018-02-08 19:28:19	0|wumpus|yes, let's close the meeting
323 2018-02-08 19:28:21	0|lightningbot|Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.log.html
324 2018-02-08 19:28:21	0|lightningbot|Meeting ended Thu Feb  8 19:28:21 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
325 2018-02-08 19:28:21	0|lightningbot|Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.html
326 2018-02-08 19:28:21	0|lightningbot|Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.txt
327 2018-02-08 19:28:21	0|wumpus|#endmeeting
328 2018-02-08 19:28:22	0|Randolf|Already did that.
329 2018-02-08 19:29:01	0|cfields|Randolf: fwiw, I think threads are probably the biggest portability issue. And it looks like we'll be rid of boost::thread very soon.
330 2018-02-08 19:30:00	0|Randolf|cfields:  Indeed.  And I did notice this PR:  https://github.com/bitcoin/bitcoin/pull/12381
331 2018-02-08 19:30:34	0|cfields|<-- TheUni
332 2018-02-08 19:30:38	0|Randolf|Oh, that's you!
333 2018-02-08 19:30:41	0|cfields|:)
334 2018-02-08 19:32:06	0|Randolf|I had a terrible problem with Boost many years ago on NetBSD when I was trying to get two different software projects compiled.  They both needed different versions of Boost that had conflicting APIs.  Backward compabitility seems to be a problem because I ultimately had to either run one of the
335 2018-02-08 19:32:19	0|Randolf|applications under a chroot or in a VM, or on a different system.
336 2018-02-08 19:32:19	0|Randolf|So, I tend to favour the idea of getting rid of stuff like that.
337 2018-02-08 19:32:57	0|wumpus|that's terrible, bitcoind shouldn't have problems like that though, it works with a wide range of boost versions
338 2018-02-08 19:33:11	0|Randolf|Oh, Bitcoin wasn't one of the applications.
339 2018-02-08 19:34:58	0|cfields|Randolf: sounds familiar. Boost is basically the testing project for c++-next. So it's kinda like adding "#include <c++-unstable>" to your project :(
340 2018-02-08 19:35:10	0|Randolf|Oh.  Wow.
341 2018-02-08 19:45:32	0|jonasschnelli|Sorry,.. missed the meeting... new timezone. :(
342 2018-02-08 19:46:18	0|Randolf|jonasschnelli:  Lots of PRs were closed.  It was quick.
343 2018-02-08 19:46:46	0|jonasschnelli|Randolf: Perfect!
344 2018-02-08 19:47:10	0|Randolf|http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.html
345 2018-02-08 19:49:07	0|jtimon|we're now on c++11 and the next is c++14, right? what stops us from moving to c++14 ?
346 2018-02-08 19:50:27	0|jonasschnelli|jtimon: too early I'd say
347 2018-02-08 19:50:44	0|jonasschnelli|jtimon: compiler support, stability
348 2018-02-08 19:50:50	0|jonasschnelli|(I would guess)
349 2018-02-08 19:52:13	0|jtimon|but for C++11 we needed to get rid of some things before worring about changing the build, no? or am I missremembering? my question is more, is there something like that?
350 2018-02-08 19:52:35	0|jtimon|some prerriquisite before even considering moving?
351 2018-02-08 19:54:26	0|wumpus|FWIW a few months ago I built bitcoind with c++17, and there were a few small changes necessary to get it to compile, I can try to find the patch, but nothing serious
352 2018-02-08 19:55:03	0|jtimon|wumpus: awesome, what kind of change ? can I have a look?
353 2018-02-08 19:56:39	0|wumpus|https://github.com/laanwj/bitcoin/commit/6df31f4c26805009734a620aa2d584e3936d4690 https://github.com/laanwj/bitcoin/commit/3f6bcfa283416182f2602dce357bdaedfc84efe7 https://github.com/laanwj/bitcoin/commit/efeec33d19752de7480f1e8d0fbcd79e49548910
354 2018-02-08 19:56:49	0|wumpus|especially the last one; the rest is build system
355 2018-02-08 19:57:29	0|wumpus|I am not sure all of those changes are still necessary, or that it was just working around a compiler bug
356 2018-02-08 19:57:47	0|jtimon|either way they seem pretty minimal
357 2018-02-08 19:57:51	0|wumpus|yep
358 2018-02-08 19:58:04	0|jtimon|cool
359 2018-02-08 19:59:30	0|wumpus|of course, changing to actually use any c++17 stuff will involve more changes
360 2018-02-08 19:59:50	0|wumpus|I'm not sure boost::filesystem to std::filesystem is just a drop in replacement, for exmple
361 2018-02-08 20:00:22	0|jtimon|well, yeah, but that could be considered later
362 2018-02-08 20:01:11	0|cfields|wumpus: I wrote an adapter at some point. IIRC you didn't like it, but I don't remember the exact reason
363 2018-02-08 20:01:48	0|wumpus|cfields: oh?!
364 2018-02-08 20:02:20	0|cfields|wumpus: yea, so that fs::foo would worth whether fs was std or boost
365 2018-02-08 20:02:34	0|cfields|let me see if I still have it
366 2018-02-08 20:03:05	0|wumpus|cfields: I think that's a nice idea at least, it's one of the reasons I introduced fs in the first place
367 2018-02-08 20:03:42	0|cfields|wumpus: right. I'm kinda on the fence about it, I maily just wanted to see how compatible they were
368 2018-02-08 20:04:07	0|cfields|*mainly
369 2018-02-08 20:04:38	0|cfields|wumpus: also, I believe you can use std::fs pre-c++17 as a compiler extension
370 2018-02-08 20:05:07	0|wumpus|but I guess that will still require a c++17 compiler
371 2018-02-08 20:05:14	0|wumpus|it will just work in non-c++17 mode?
372 2018-02-08 20:05:41	0|cfields|wumpus: https://github.com/theuni/bitcoin/commits/filesystem
373 2018-02-08 20:06:13	0|wumpus|I don't remember seeing that before
374 2018-02-08 20:07:17	0|wumpus|I'm surprised if this are all the changes needed: https://github.com/theuni/bitcoin/commit/b208705020118d2be6962c0bf7b6fcfd702f576e
375 2018-02-08 20:07:42	0|wumpus|kind of nice
376 2018-02-08 20:09:45	0|cfields|yes, I was pleasantly surprised as well
377 2018-02-08 20:11:14	0|wumpus|I guess there isn't much reason to do it yet before we even got rid of boost::thread fully, but it's good to know
378 2018-02-08 20:13:16	0|wumpus|at some point we could offer a choice with a configure option, either use boost, or c++17/experimental
379 2018-02-08 20:14:41	0|cfields|right
380 2018-02-08 20:16:42	0|wumpus|I don't understand why I didn't like it, the only thing I can think of is that I thought it was too early to do it
381 2018-02-08 20:20:38	0|cfields|wumpus: ah, you objected to the idea of our own impl. You were pretty pro std impl: https://github.com/bitcoin/bitcoin/pull/9902#issuecomment-283764371
382 2018-02-08 20:21:43	0|wumpus|cfields: yes, I remember now, one idea was to wrap the entire thing, which is a lot of code, thanks
383 2018-02-08 20:22:32	0|cfields|right
384 2018-02-08 20:26:55	0|GitHub158|[13bitcoin-detached-sigs] 15jonasschnelli opened pull request #3: 0.16: osx signatures for 0.16.0rc3 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3
385 2018-02-08 20:32:36	0|instagibbs|achow101, ill review #10579 and #10583 if they get rebased(sorry for your rebasing)
386 2018-02-08 20:32:40	0|gribble|https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
387 2018-02-08 20:32:44	0|gribble|https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
388 2018-02-08 20:34:11	0|achow101|instagibbs: do they need rebasing again? I rebased them last week!
389 2018-02-08 20:34:27	0|instagibbs|says merged conflict with tests <_<
390 2018-02-08 20:35:16	0|achow101|bleh
391 2018-02-08 20:36:06	0|GitHub126|[13bitcoin-detached-sigs] 15theuni closed pull request #3: 0.16: osx signatures for 0.16.0rc3 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3
392 2018-02-08 20:40:38	0|cfields|woohoo, no crashes during sanity checks this time :)
393 2018-02-08 20:42:15	0|wumpus|awesome :)
394 2018-02-08 20:44:50	0|cfields|gitian builders: v0.16.0rc3 detached sigs are up
395 2018-02-08 20:50:23	0|achow101|instagibbs: rebased those again
396 2018-02-08 20:51:47	0|wumpus|cfields: thanks
397 2018-02-08 20:52:10	0|cfields|ofc
398 2018-02-08 21:20:17	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d405beea26c1...67447ba06057
399 2018-02-08 21:20:18	0|bitcoin-git|13bitcoin/06master 140975406 15Suhas Daftuar: Correct mempool mapTx comment
400 2018-02-08 21:20:18	0|bitcoin-git|13bitcoin/06master 14e868b22 15Suhas Daftuar: fee estimator: avoid sorting mempool on shutdown
401 2018-02-08 21:20:19	0|bitcoin-git|13bitcoin/06master 14669c943 15Suhas Daftuar: Avoid leaking prioritization information when relaying transactions
402 2018-02-08 21:21:03	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12225: Mempool cleanups (06master...062018-01-mempool-cleanups) 02https://github.com/bitcoin/bitcoin/pull/12225
403 2018-02-08 21:58:15	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12286: Wallet: Resolve compiler warnings in ec_privkey_import_der (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12286
404 2018-02-08 23:34:59	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (06master...062018-02-fix-fpausesend-getdata-resp) 02https://github.com/bitcoin/bitcoin/pull/12392