1 2018-02-09 00:54:26	0|bitcoin-git|[13bitcoin] 15promag closed pull request #12361: Replace unreachable error handling with assertions in feebumper (06master...062018-02-feebumper) 02https://github.com/bitcoin/bitcoin/pull/12361
 2 2018-02-09 04:22:19	0|MrBruceWayne|#bitcoin
 3 2018-02-09 05:52:58	0|sipa|achow101: the "Known issue" you added to the release notes, wasn't that fixed?
 4 2018-02-09 09:10:51	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12393: Fix a-vs-an typos (06master...06a-vs-an-typos) 02https://github.com/bitcoin/bitcoin/pull/12393
 5 2018-02-09 09:14:20	0|provoostenator|instagibbs: yes, I filed an issue to add NTP support to gitian
 6 2018-02-09 09:54:40	0|bitcoin-git|13bitcoin/06master 14c8edc2c 15Sjors Provoost: [docs] initial QT documentation, move Qt Creator instructions
 7 2018-02-09 09:54:40	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/67447ba06057...89005ddad1c4
 8 2018-02-09 09:54:41	0|bitcoin-git|13bitcoin/06master 1489005dd 15Wladimir J. van der Laan: Merge #11761: [docs] initial QT documentation...
 9 2018-02-09 09:55:14	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11761: [docs] initial QT documentation (06master...06qt-docs) 02https://github.com/bitcoin/bitcoin/pull/11761
10 2018-02-09 09:56:29	0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #12394: gitian-builder.sh: fix --setup doc, since lxc is default (06master...062018/02/gitian-build-setup-lxc) 02https://github.com/bitcoin/bitcoin/pull/12394
11 2018-02-09 10:01:57	0|wumpus|rc3 executables up https://bitcoincore.org/bin/bitcoin-core-0.16.0/test.rc3/
12 2018-02-09 11:03:51	0|provoostenator|I made an attempt at simplifying the gitian instructions: https://github.com/bitcoin-core/docs/pull/25
13 2018-02-09 11:22:11	0|dongcarl|provoostenator: Super helpful
14 2018-02-09 12:30:04	0|promag|wumpus: rc4 #12392 ?
15 2018-02-09 12:30:06	0|gribble|https://github.com/bitcoin/bitcoin/issues/12392 | Fix ignoring tx data requests when fPauseSend is set on a peer by TheBlueMatt · Pull Request #12392 · bitcoin/bitcoin · GitHub
16 2018-02-09 12:39:26	0|wumpus|really?
17 2018-02-09 12:40:09	0|wumpus|I don't think it's worth doing yet another rc just because of that, but we still have a week to go I suppose
18 2018-02-09 12:46:23	0|promag|ah maybe he means 0.16.1
19 2018-02-09 12:54:04	0|promag|#12287 is a simple and nice cleanup
20 2018-02-09 12:54:06	0|gribble|https://github.com/bitcoin/bitcoin/issues/12287 | Optimise lock behaviour for GuessVerificationProgress() by jonasschnelli · Pull Request #12287 · bitcoin/bitcoin · GitHub
21 2018-02-09 14:07:05	0|bitcoin-git|[13bitcoin] 15azuchi opened pull request #12396: [Doc] Fix typo (060.16...060.16) 02https://github.com/bitcoin/bitcoin/pull/12396
22 2018-02-09 15:02:22	0|provoostenator|I tried #11857, deleted the indexes folder, swichted back to master and then tried to use index=1.  If I agree to rebuilding the block database I get "Error opening block database". Any ideas?
23 2018-02-09 15:02:25	0|gribble|https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
24 2018-02-09 15:02:48	0|provoostenator|(technically master from yesterday)
25 2018-02-09 15:05:44	0|provoostenator|Master from today has the same issue. Seems to works fine with txindex=0.  Seems to be QT specific, bitcoind does reindex.
26 2018-02-09 15:07:15	0|provoostenator|In fact, if I let bitcoind do its thing for a minute, stop it and then start QT, it's happy.
27 2018-02-09 15:07:29	0|provoostenator|(by happy I mean that it takes over the reindex work)
28 2018-02-09 15:08:21	0|wumpus|hmm strange
29 2018-02-09 15:48:19	0|achow101|sipa: yeah, that was fixed. Originally we weren't going to fix it but then we did
30 2018-02-09 16:26:10	0|provoostenator|It's actually happening on master: "testnet3/blocks/index/LOCK: already held by process"
31 2018-02-09 16:26:28	0|provoostenator|I'm pretty sure I quit QT cleanly, so don't know why that lock file doesn't get removed.
32 2018-02-09 16:28:10	0|provoostenator|Also I think I'm confused about the difference between chainstate, blocks/index and the proposed /indexes directory.
33 2018-02-09 16:36:51	0|provoostenator|If I delete blocks/index and start QT, it immedidately creates a fresh directory with a LOCK file. It then complains "Error initializing block database [rebuild?]". If I say OK I get error building block database and the log compalins "LOCK: already held by process"
34 2018-02-09 16:38:22	0|provoostenator|If instead I click on Abort, it also doesn't clean up the LOCK file.
35 2018-02-09 16:39:44	0|provoostenator|Launching with -reindex avoids the error message.
36 2018-02-09 16:58:51	0|provoostenator|Deleting the LOCK file before agreeing to "Do you want to rebuild the block database now?" doesn't help either; it just creates a new one and throws the above error
37 2018-02-09 18:17:17	0|provoostenator|This seems to be the problem: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L1428 (fReset=true here)
38 2018-02-09 18:19:52	0|provoostenator|Which then calls CDBWrapper::CDBWrapper with fWipe = true, which calls leveldb::DestroyDB which fails if the file is locked.
39 2018-02-09 18:20:25	0|jimpo|Why would that be QT specific then?
40 2018-02-09 18:20:49	0|provoostenator|Because bitcoind refuses to start withotu -reindex
41 2018-02-09 18:21:23	0|provoostenator|Whereas QT will first open the levelDB file, then find a problem and then run the loop again trying to wipe it.
42 2018-02-09 18:21:45	0|provoostenator|I think it needs to close the DB file first
43 2018-02-09 18:28:10	0|jimpo|I'll try to reproduce on master
44 2018-02-09 18:29:00	0|provoostenator|Deleting blocks/index is probably the easiest way to produce the issue
45 2018-02-09 18:32:25	0|provoostenator|I "fixed" the issue by adding one line above: if (fReset) { pblocktree.reset(); }
46 2018-02-09 18:39:14	0|provoostenator|jimpo: actually, I had to use the chainstate dir generated by your branch  (though possibly corrupted due to some other mistake on my end) to get the error
47 2018-02-09 18:40:33	0|jimpo|I think my testnet chain is corrupt anyway, so I need to deal with that first
48 2018-02-09 18:55:27	0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #12401: Reset pblocktree before deleting LevelDB file (06master...062018/02/reset-pblocktree) 02https://github.com/bitcoin/bitcoin/pull/12401
49 2018-02-09 20:13:42	0|berndj|why were dev keys removed from contrib/gitian-keys/ and replaced with a list of fingerprints? isn't this dangerous now that SHA1 is on its last legs?
50 2018-02-09 21:47:24	0|mesh_|berndj: well, finding collisions is much easier than preimage attacks
51 2018-02-09 21:48:48	0|meshcollider|berndj: see #11909 for reasoning
52 2018-02-09 21:48:49	0|gribble|https://github.com/bitcoin/bitcoin/issues/11909 | contrib: Replace developer keys with list of pgp fingerprints by MarcoFalke · Pull Request #11909 · bitcoin/bitcoin · GitHub
53 2018-02-09 21:54:13	0|berndj|i wonder how long it'll be before sha1 preimage attacks are $100bn-level feasible