1 2018-02-11 02:29:19	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12408: wallet: Change output type globals to members (06master...06Mf1802-walletChangeTypeMember) 02https://github.com/bitcoin/bitcoin/pull/12408
 2 2018-02-11 03:12:52	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12409: rpc: Reject deprecated reserveChangeKey in fundrawtransaction (06master...06Mf1802-rpcFundRawDeprecatedOption) 02https://github.com/bitcoin/bitcoin/pull/12409
 3 2018-02-11 03:28:25	0|bitcoin-git|[13bitcoin] 15Willtech opened pull request #12410: [Docs] Updated examples in CONTRIBUTING.md (06master...06CONTRIBUTING.md) 02https://github.com/bitcoin/bitcoin/pull/12410
 4 2018-02-11 06:48:39	0|murrayn|i've got all the $DataDir\blocks\*.dat files, is the fastest way to get back up running to use --reindex-chainstate ?
 5 2018-02-11 06:49:06	0|murrayn|Because it's taking forever, and no CPU load. WTF is it doing?
 6 2018-02-11 07:10:53	0|gmaxwell|network has been clearing a lot of 1s/vbyte txn...
 7 2018-02-11 10:33:22	0|provoostenator|#12406 "chainstate\160320.ldb: Data error (cyclic redundancy check)" and such strangeness...
 8 2018-02-11 10:33:23	0|gribble|https://github.com/bitcoin/bitcoin/issues/12406 | QT Core wallet crash when starting with "-txindex" · Issue #12406 · bitcoin/bitcoin · GitHub
 9 2018-02-11 10:37:34	0|wumpus|usually that's some kind of i/o corruption, detected by leveldb as it CRCs everything
10 2018-02-11 10:38:18	0|wumpus|you could ask the user to send the ldb to see if something can be learnt from the kind of corruption (e.g. was a block overwritten, or a bit toggled, etc)
11 2018-02-11 10:39:43	0|provoostenator|you mean chainstate/*.ldb? Where should they upload that?
12 2018-02-11 10:39:57	0|wumpus|it's why I did  #11674
13 2018-02-11 10:39:59	0|gribble|https://github.com/bitcoin/bitcoin/issues/11674 | leveldb: Add filename to corruption errors by laanwj · Pull Request #11674 · bitcoin/bitcoin · GitHub
14 2018-02-11 10:40:13	0|wumpus|not all the ldbs, just the one that is corrupted
15 2018-02-11 10:40:27	0|wumpus|I don't know where people upload files nowadays, honestly
16 2018-02-11 10:40:58	0|provoostenator|How would he know which one is corrupted? Is there a command to find out?
17 2018-02-11 10:41:52	0|wumpus|it's in the error message
18 2018-02-11 10:42:06	0|wumpus|2018-02-10 10:07:17 IO error: f:\BitCoinData\chainstate\160320.ldb: Data error (cyclic redundancy check).
19 2018-02-11 10:42:20	0|provoostenator|Ah, ok, I'll ask. Github shold be able to handle 2MB
20 2018-02-11 10:42:26	0|provoostenator|(or less if it's the last one)
21 2018-02-11 10:46:04	0|provoostenator|Shouldn't Windows create a wallets directory if no wallet.dat is found?
22 2018-02-11 10:46:39	0|wumpus|no, it creates a wallets directory for a new datadir
23 2018-02-11 10:46:49	0|provoostenator|Ok, I'll try that.
24 2018-02-11 10:47:04	0|wumpus|creating it when wallet.dat is not found is problematic because the user might have a wallets with other names around
25 2018-02-11 10:47:21	0|wumpus|the only time we know it's safe to use wallets/ is for a new data dir
26 2018-02-11 10:47:23	0|provoostenator|I'll do a couple of IBD's to see if more high energy particles from the universe hit that VM
27 2018-02-11 10:47:44	0|provoostenator|That makes sense
28 2018-02-11 10:48:57	0|provoostenator|Would be nice though if it worked on an _empty_ data dir as well as a new one, so the user can create bitcoin.conf before the first launch.
29 2018-02-11 10:49:19	0|wumpus|they can make wallets directory themselves if they want
30 2018-02-11 10:49:26	0|wumpus|and move the wallets, if any, there
31 2018-02-11 10:51:16	0|wumpus|the data directory is not empty if a bitcoin.conf is there, it'd have to have some specialized, twisted definition of 'empty'
32 2018-02-11 10:52:01	0|provoostenator|Yeah, I just realized that I was trying to turn the idea in a todo. Probably too convoluted. And there's the walletdir option now too.
33 2018-02-11 10:52:16	0|provoostenator|*that as I was
34 2018-02-11 15:08:07	0|sipa|murrayn: it's verifying all transactions in history
35 2018-02-11 15:38:30	0|bitcoin-git|[13bitcoin] 15jameshilliard opened pull request #12412: Enable spectre mitigations when supported by compiler. (06master...06spectre-mitigation) 02https://github.com/bitcoin/bitcoin/pull/12412
36 2018-02-11 16:18:57	0|Lightsword|hmm, so apparently retpolineplt linker is causes breakage test_bitcoin: key.cpp:324: void ECC_Start(): Assertion `secp256k1_context_sign == nullptr' failed.
37 2018-02-11 16:19:45	0|BlueMatt|fun!
38 2018-02-11 19:12:56	0|luke-jr|Lightsword: no problems with GCC's..
39 2018-02-11 19:14:13	0|Lightsword|luke-jr, seems to be failing under GCC’s https://travis-ci.org/bitcoin/bitcoin/jobs/340156264
40 2018-02-11 19:16:11	0|luke-jr|Lightsword: Travis doesn't even have GCC w/ retpoline support..
41 2018-02-11 19:16:44	0|Lightsword|weird “checking whether the linker accepts -Wl,-z,retpolineplt... yes”
42 2018-02-11 19:16:49	0|Lightsword|maybe I did the test wrong?
43 2018-02-11 19:17:15	0|Lightsword|https://github.com/bitcoin/bitcoin/pull/12412/files#diff-67e997bcfdac55191033d57a16d1408aR580
44 2018-02-11 19:17:21	0|luke-jr|Why does the linker need to do anything?
45 2018-02-11 19:17:27	0|luke-jr|I'm talking about GCC
46 2018-02-11 19:18:33	0|luke-jr|retpolineplt seems to be some LLVM thing
47 2018-02-11 19:19:18	0|Lightsword|hmm, not sure, I kinda just copied the autoconf stuff from openssh
48 2018-02-11 19:28:04	0|sipa|it looks like it can be done by the linker
49 2018-02-11 19:28:49	0|sipa|but it basically introduces a stub function between every caller and callee
50 2018-02-11 19:39:54	0|Lightsword|“For dynamic executables, you must compile *all* libraries with -mretpoline and additionally link the dynamic executable and all shared libraries with LLD and pass -z retpolineplt (or use similar functionality from some other linker).”
51 2018-02-11 19:40:40	0|Lightsword|“For kernels or other freestanding or fully static executables, the compiler switch -mretpoline is sufficient to fully mitigate this particular attack.“
52 2018-02-11 19:41:54	0|Lightsword|do we build fully statically or still do some dynamic linking that would need -retpolineplt?
53 2018-02-11 19:48:20	0|sipa|ping cfields
54 2018-02-11 19:50:28	0|sasha_|hello, i am having an issue with bitcoin core
55 2018-02-11 19:51:00	0|sasha_|i started synchronizing the block but sent bitcoin to the wallet before it was done
56 2018-02-11 19:51:22	0|sasha_|since it has to synchronize before i can use my bitcoin, i want to move it to omniwallet
57 2018-02-11 19:51:37	0|sasha_|however, it wont let me dump my private key
58 2018-02-11 20:15:50	0|luke-jr|Lightsword: that's LLVM; GCC doesn't use the same options at all
59 2018-02-11 20:17:19	0|Lightsword|so travis is using LLVM’s linker?
60 2018-02-11 20:17:22	0|Lightsword|but GCC compiler?
61 2018-02-11 20:19:21	0|Lightsword|“checking if the linker (/usr/bin/ld) is GNU ld... yes”
62 2018-02-11 20:24:58	0|ProfMac|Is there an archive of the discussion when the version 2 block was defined, and the blockheight was included?
63 2018-02-11 20:25:27	0|sipa|bip34
64 2018-02-11 20:25:35	0|ProfMac|thanks.
65 2018-02-11 20:30:52	0|luke-jr|Lightsword: no idea what Travis is doing.. GNU ld doesn't support retpolineplt though..
66 2018-02-11 20:31:43	0|luke-jr|I'm reading that without -O2, the compiler options don't do the job, so maybe my test is inconclusive
67 2018-02-11 21:23:34	0|ProfMac|Do I understand correctly that the ExtraNonce in a block is located in the coinbase vin?
68 2018-02-11 21:23:43	0|sipa|yes
69 2018-02-11 21:23:52	0|ProfMac|thank you.
70 2018-02-11 21:23:54	0|luke-jr|well, it's not a special field… it *can* be anywhere
71 2018-02-11 21:23:59	0|sipa|right
72 2018-02-11 21:24:07	0|luke-jr|some pools use the generation transaction's lock time for example
73 2018-02-11 21:24:14	0|sipa|it's just conventionally what is used to add variance to a block
74 2018-02-11 21:25:59	0|ProfMac|I just had the idea that it was an extra field in the block header, but then I was looking at this code snippet.
75 2018-02-11 21:26:15	0|ProfMac|pblock->vtx[0].vin[0].scriptSig = (CScript() << nHeight << CBigNum(nExtraNonce)) + COINBASE_FLAGS;
76 2018-02-11 21:26:28	0|sipa|no
77 2018-02-11 21:26:40	0|sipa|anything can be used to add variance to a block
78 2018-02-11 21:26:50	0|sipa|including just changing the order of transactions or so
79 2018-02-11 21:27:02	0|ProfMac|ok.  Thanks.
80 2018-02-11 21:27:02	0|sipa|extranonce is not a protocol level things
81 2018-02-11 21:27:10	0|sipa|just a conventional way to add variance