1 2018-02-15 01:05:10	0|bitcoin-git|[13bitcoin] 15251Labs opened pull request #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output (06master...06issue/11561/test-negative-transaction-version-numbers) 02https://github.com/bitcoin/bitcoin/pull/12436
  2 2018-02-15 01:49:27	0|bitcoin-git|[13bitcoin] 15jeffrade opened pull request #12437: [Trivial] Simplify if-else blocks and more descriptive variable naming (06master...06test_runner_refactor) 02https://github.com/bitcoin/bitcoin/pull/12437
  3 2018-02-15 02:10:05	0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #12438: [Tests] Fix trivial typo in test_runner.py causing error (06master...06201802_fix_testrunner_typo) 02https://github.com/bitcoin/bitcoin/pull/12438
  4 2018-02-15 03:29:27	0|esotericnonsense|are the tx in getblocktemplate ordered according to the highest feerate of the packages?
  5 2018-02-15 03:30:12	0|gmaxwell|packages are ordered by package feerate.
  6 2018-02-15 03:31:04	0|gmaxwell|it causes a triangle wave shape in the transaction feerate in blocks.
  7 2018-02-15 03:32:05	0|esotericnonsense|yeah. that's what I thought (just guessing based on eyeballing the pattern without looking at txids)
  8 2018-02-15 03:38:03	0|gmaxwell|because coinbase txn size is not known when a block is being constructed we've generally tried to preserve the property that a truncation of a block is about as good of a solution as if you targeted a smaller block.
  9 2018-02-15 03:39:07	0|gmaxwell|I think probably in the future we should give up on that property, and instead have mining protocols where the size of the coinbase txn will be known exactly.
 10 2018-02-15 03:40:42	0|esotericnonsense|why is the coinbase size not known? can't think of anything off the top of my head that would make its' size vary
 11 2018-02-15 03:41:07	0|esotericnonsense|aside from adding extra outputs etc, but then it's still known, you'd just need to tell gbt
 12 2018-02-15 03:41:15	0|gmaxwell|coinbase transaction, none of it is known to gbt... how many outputs will it make? what scriptpubkey styles will they be?
 13 2018-02-15 03:41:33	0|gmaxwell|how much extra-nonce space will you have?  none of that is provided to GBT.
 14 2018-02-15 03:42:13	0|esotericnonsense|right yeah that makes sense. I misinterpreted what you were saying. coinbase size isn't known _by gbt_ but it can be known by the miner.
 15 2018-02-15 03:43:59	0|grafcaps|gbt = get block template?
 16 2018-02-15 03:44:04	0|esotericnonsense|is anyone out there charting gbt feerates live? would it be useful to anyone?
 17 2018-02-15 03:44:20	0|esotericnonsense|(i've got a flask table thing working but making it into a chart probably wouldn't be much effort)
 18 2018-02-15 03:51:28	0|gmaxwell|esotericnonsense: right, it's known by the miner.
 19 2018-02-15 03:51:54	0|gmaxwell|it's just an interface design thing. in a lot of ways GBT reflects how eligius used to work.
 20 2018-02-15 03:52:11	0|gmaxwell|coinbases were produced by their payout algorihim and changed very rapidly in realtime.
 21 2018-02-15 03:53:38	0|gmaxwell|It _could_ have worked so that the size was known to GBT and just the specific outputs and amounts changed... but there wasn't any obvious gain in doing that back then... blocks were not full due to hardcoded underuse, fees were negligible.
 22 2018-02-15 04:13:03	0|bitcoin-git|13bitcoin/06master 14ada1af6 15MeshCollider: Fix typo in test_runner.py causing error
 23 2018-02-15 04:13:03	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e782099a151a...b2089c51cc4a
 24 2018-02-15 04:13:04	0|bitcoin-git|13bitcoin/06master 14b2089c5 15MarcoFalke: Merge #12438: [Tests] Fix trivial typo in test_runner.py causing error...
 25 2018-02-15 04:14:06	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12438: [Tests] Fix trivial typo in test_runner.py causing error (06master...06201802_fix_testrunner_typo) 02https://github.com/bitcoin/bitcoin/pull/12438
 26 2018-02-15 04:36:43	0|esotericnonsense|heh, watching this is crazy. i've never really looked before. there's a tx here with 2300 satoshi per byte ? wtf
 27 2018-02-15 04:37:54	0|esotericnonsense|i suppose that's "only" $60 or so.
 28 2018-02-15 05:17:53	0|esotericnonsense|could be improved by log scale but whatever. https://esotericnonsense.com/dev/ url will probably change etc.
 29 2018-02-15 05:44:28	0|meshcollider|esotericnonsense: that looks cool
 30 2018-02-15 06:03:43	0|booyah|fyi, enemies of bitcoin at r/btc claim also that "you" kept commiting changes to "trunk", prohibiting poor Gavin from getting his changes in (cos he needed to constantly rebase?). what the ;)
 31 2018-02-15 06:17:32	0|Randolf|Oh, isn't r/btc that Reddit community that Roger Ver runs from a distance?
 32 2018-02-15 06:18:19	0|booyah|Randolf: yes
 33 2018-02-15 06:19:32	0|Randolf|When it comes to "enemies of Bitcoin," it seems that the only name that ever comes up is Roger Ver.
 34 2018-02-15 06:19:59	0|booyah|Randolf: yes (also he is openly it's owner). That's why it's just FYI, no one pays attention to it. Just thought it's funny, idea of "buuu huuu evil developers keep develoing stuff and I need to rebase my PR". ( https://www.reddit.com/r/btc/comments/7xjy03/did_you_know_that_before_the_scaling_debate_got/du9g889/ )
 35 2018-02-15 06:22:04	0|luke-jr|esotericnonsense: there is no guarantee on order of transactions in GBT, other than that they are valid
 36 2018-02-15 06:33:20	0|sipa|Randolf, booyah: please stick to technical topics here
 37 2018-02-15 08:24:25	0|wumpus|booyah: lol! people kept contributing to the project, so the poor guy couldn't get his changes in :(
 38 2018-02-15 08:27:35	0|wumpus|booyah: one thing seems to be consistent, they never really get open source development
 39 2018-02-15 08:35:39	0|wumpus|or what Gavin's task was in the first place. for that matter
 40 2018-02-15 09:29:35	0|wumpus|cfields: our level of misunderanding of boost::interprocess::file_lock is phenomenal, can't we just delete that function :/
 41 2018-02-15 09:30:35	0|wumpus|cfields: I think I'll just revert #12422 to the OpenBSD compile fix that it was, for 0.16, and leave the rest for master/0.17
 42 2018-02-15 09:30:38	0|gribble|https://github.com/bitcoin/bitcoin/issues/12422 | util: Make LockDirectory thread-safe, consistent, and fix OpenBSD 6.2 build by laanwj · Pull Request #12422 · bitcoin/bitcoin · GitHub
 43 2018-02-15 09:33:51	0|wumpus|cfields: the 'other process' test likely should have another case, that after process A giving up the locks (e.g. if it was only probing), B should succeed in getting it
 44 2018-02-15 10:22:26	0|fanquake|wumpus I have a fix for the miniupnpc compile issue, will push up shortly
 45 2018-02-15 10:22:35	0|wumpus|fanquake: great!
 46 2018-02-15 11:31:23	0|fanquake|wumpus 12417 Should be able to go in now
 47 2018-02-15 11:39:52	0|provoostenator|Rebasing is a pain, but my impression so far is that most of the time the stuff that's ready first goes in first.
 48 2018-02-15 11:42:12	0|fanquake|provoostenator Are you just talking generally, or in regards to specific PR?
 49 2018-02-15 11:42:34	0|provoostenator|I mean in general.
 50 2018-02-15 11:43:25	0|meshcollider|yeah PRs which need rebasing or are failing travis tests tend to get fewer reviews than those which are ready from what I've seen
 51 2018-02-15 11:44:15	0|provoostenator|That was ambiguous. Rebasing is a pain for some types of PR's and if Travis is having a bad day, but often a simple chore. In general when a PR has had enough review and feedback is addressed quickly enough, it goes in quickly, and then other PR's need to rebase.
 52 2018-02-15 11:44:49	0|meshcollider|Oh I see what you meant
 53 2018-02-15 11:48:36	0|provoostenator|4 open PR's on 0.16.0. I'll try to test #12427
 54 2018-02-15 11:48:38	0|gribble|https://github.com/bitcoin/bitcoin/issues/12427 | Make signrawtransaction accept P2SH-P2WSH redeemscripts by sipa · Pull Request #12427 · bitcoin/bitcoin · GitHub
 55 2018-02-15 12:09:10	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b2089c51cc4a...ae0fbf09817f
 56 2018-02-15 12:09:11	0|bitcoin-git|13bitcoin/06master 14deee216 15Douglas Roark: Delete mac_alias patch...
 57 2018-02-15 12:09:11	0|bitcoin-git|13bitcoin/06master 14fc1bfcf 15Douglas Roark: Update mac_alias to 2.0.7
 58 2018-02-15 12:09:12	0|bitcoin-git|13bitcoin/06master 14ae0fbf0 15Wladimir J. van der Laan: Merge #12417: Upgrade mac_alias to 2.0.7...
 59 2018-02-15 12:09:56	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12417: Upgrade mac_alias to 2.0.7 (06master...06master_del_mac_alias) 02https://github.com/bitcoin/bitcoin/pull/12417
 60 2018-02-15 13:26:28	0|wumpus|cfields: so I think you're right on the longer run - then we likely want the wallets (and init, for the main data dir) themselves to carry a RAII lock on the data directory instead of the funky map
 61 2018-02-15 13:34:13	0|bitcoin-git|13bitcoin/06master 142e9406c 15João Barbosa: Interrupt loading thread after shutdown request
 62 2018-02-15 13:34:13	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ae0fbf09817f...737ed8bb77d1
 63 2018-02-15 13:34:14	0|bitcoin-git|13bitcoin/06master 14737ed8b 15Wladimir J. van der Laan: Merge #12415: Interrupt loading thread after shutdown request...
 64 2018-02-15 13:35:00	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12415: Interrupt loading thread after shutdown request (06master...062018-02-shutdown) 02https://github.com/bitcoin/bitcoin/pull/12415
 65 2018-02-15 13:43:03	0|bitcoin-git|13bitcoin/060.16 14f893824 15João Barbosa: Interrupt loading thread after shutdown request...
 66 2018-02-15 13:43:03	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/f8938248ef37f67986e36ef897a548123b2d7a36
 67 2018-02-15 13:46:32	0|wumpus|re: #12349, can we be sure this issue is really solved after that?
 68 2018-02-15 13:46:33	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
 69 2018-02-15 13:48:22	0|wumpus|if not, I think we should think about it somewhat longer how to effectively fix it, and remove the 0.16.0 tag, we shouldn't merge fix after fix to different parts of the code without a clear idea if it's really fixed
 70 2018-02-15 14:04:51	0|wumpus|let's discuss it at the meeting
 71 2018-02-15 14:32:08	0|promag|wumpus: will look #12349
 72 2018-02-15 14:32:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
 73 2018-02-15 14:36:44	0|promag|what is the idea to fix "ERROR: src/crypto/ctaes is not a subtree"? full clone?
 74 2018-02-15 14:37:18	0|wumpus|promag: I really hate that solution, but yes, that'd solve it
 75 2018-02-15 14:37:46	0|promag|is there an alternative?
 76 2018-02-15 14:39:12	0|promag|git fetch commit_id && git reset --hard FETCH_HEAD ?
 77 2018-02-15 14:39:39	0|wumpus|see #12388
 78 2018-02-15 14:39:40	0|gribble|https://github.com/bitcoin/bitcoin/issues/12388 | travis failure on rc3: "src/crypto/ctaes is not a subtree" · Issue #12388 · bitcoin/bitcoin · GitHub
 79 2018-02-15 14:45:31	0|wumpus|I think the scalable solution would be to skip the subtree check when the subtree is buried deeper than the shallow checkout
 80 2018-02-15 14:46:09	0|wumpus|after all, the check is there to catch PRs that make changes to subtrees in the wrong way
 81 2018-02-15 14:46:39	0|wumpus|if a change is buried below many other PRs then we can already be sure there's nothing to check
 82 2018-02-15 14:46:50	0|wumpus|otherwise they wouldn'th ave been merged...
 83 2018-02-15 15:01:06	0|bitcoin-git|13bitcoin/060.16 14e2431d1 15MarcoFalke: travis: Full clone for git subtree check...
 84 2018-02-15 15:01:06	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/e2431d144aa84909b106a767634126ad5821dc90
 85 2018-02-15 15:02:03	0|wumpus|but I'll cherry pick that for now to the 0.16 branch
 86 2018-02-15 15:11:03	0|bitcoin-git|13bitcoin/06master 14fa27623 15MarcoFalke: qt: Initialize members in WalletModel
 87 2018-02-15 15:11:03	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/737ed8bb77d1...bfa39114e2cf
 88 2018-02-15 15:11:04	0|bitcoin-git|13bitcoin/06master 14bfa3911 15Wladimir J. van der Laan: Merge #12426: qt: Initialize members in WalletModel...
 89 2018-02-15 15:11:52	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12426: qt: Initialize members in WalletModel (06master...06Mf1802-qtInitializeMembersWalletModel) 02https://github.com/bitcoin/bitcoin/pull/12426
 90 2018-02-15 15:36:09	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/bfa39114e2cf...fd65937ec601
 91 2018-02-15 15:36:10	0|bitcoin-git|13bitcoin/06master 148b8a1c4 15Ben Woosley: Add test for 'mempool min fee not met' rpc error
 92 2018-02-15 15:36:10	0|bitcoin-git|13bitcoin/06master 14c04e0f6 15Ben Woosley: Fix 'mempool min fee not met' debug output...
 93 2018-02-15 15:36:11	0|bitcoin-git|13bitcoin/06master 14bb00c95 15Ben Woosley: Consistently use FormatStateMessage in RPC error output...
 94 2018-02-15 15:36:57	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12356: Fix 'mempool min fee not met' debug output (06master...06minfee-message) 02https://github.com/bitcoin/bitcoin/pull/12356
 95 2018-02-15 15:43:34	0|bitcoin-git|13bitcoin/060.16 145e40e64 15Wladimir J. van der Laan: travis: Don't fetch --unshallow when no longer shallow-cloning...
 96 2018-02-15 15:43:34	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/5e40e64face29169ef355856dc0db46a98061046
 97 2018-02-15 16:06:36	0|provoostenator|Just got another whitespace error back from Travis. Anyone have a chance to bless or find problems with #12098 and #12097 so I can trivially prevent that on MacOS?
 98 2018-02-15 16:06:38	0|gribble|https://github.com/bitcoin/bitcoin/issues/12098 | [scripts] lint-whitespace: add param to check last N commits by Sjors · Pull Request #12098 · bitcoin/bitcoin · GitHub
 99 2018-02-15 16:06:39	0|gribble|https://github.com/bitcoin/bitcoin/issues/12097 | [scripts] lint-whitespace: use perl instead of grep -P by Sjors · Pull Request #12097 · bitcoin/bitcoin · GitHub
100 2018-02-15 16:07:46	0|ProfMac|I think the code lets us generate a block with any prev-block-hash.  That is, generate a fork at any block.  In practice, this seems to occur only at the best tip when two block arrive nearby in time.  Is it improper to think more restrictive thoughts that a new block can only point back to a tip?
101 2018-02-15 16:08:28	0|sipa|"the code" ?
102 2018-02-15 16:08:49	0|ProfMac|reference client, satoshi client ...
103 2018-02-15 16:08:58	0|sipa|in what context?
104 2018-02-15 16:09:08	0|sipa|there are many tests that mine forks
105 2018-02-15 16:09:50	0|ProfMac|Do those tests only grow existing forks, or do they create new forks somewhere on the backbone?
106 2018-02-15 16:10:05	0|sipa|backbone?
107 2018-02-15 16:10:21	0|ProfMac|Yeah, backbone.  "best chain"
108 2018-02-15 16:11:14	0|sipa|oh
109 2018-02-15 16:11:17	0|sipa|arbitrary
110 2018-02-15 16:11:32	0|sipa|look at p2p-fullnode.py
111 2018-02-15 16:12:04	0|ProfMac|I haven't looked into the test software source yet.  Thanks, I'll read that.
112 2018-02-15 16:13:19	0|sipa|but i don't understand your question at all
113 2018-02-15 16:14:05	0|sipa|forks happen all the time in the network
114 2018-02-15 16:14:13	0|sipa|and we need to deal with them
115 2018-02-15 16:15:04	0|sipa|even if only software existed that extended the tip, this would still be the case, simply due to the finite speed of communication
116 2018-02-15 16:15:28	0|sipa|(you may not have heard about the latest block someone created)
117 2018-02-15 16:15:46	0|ProfMac|Yes.  And yes.  I just wondered, in practice, do blocks show up that fork back 6 or 8 blocks from the best top.
118 2018-02-15 16:15:56	0|ProfMac|*tip
119 2018-02-15 16:16:43	0|sipa|yes
120 2018-02-15 16:16:50	0|ProfMac|meaning, create a new fork 6 or 8 blocks back.  Not create a fork that ages to become that far back.
121 2018-02-15 16:16:59	0|sipa|very rarely though
122 2018-02-15 16:17:18	0|ProfMac|Yes, well, they would seem to be a bit pointless.
123 2018-02-15 16:17:40	0|sipa|let's move this to #bitcoin
124 2018-02-15 16:17:48	0|ProfMac|ok.
125 2018-02-15 16:22:29	0|promag|jonasschnelli: friendly ping #11882
126 2018-02-15 16:22:32	0|gribble|https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub
127 2018-02-15 16:59:38	0|promag|cfields: ignore my comment
128 2018-02-15 17:17:42	0|bitcoin-git|13bitcoin/06master 1465682da 15Sjors Provoost: [tests] bind functional test nodes to 127.0.0.1
129 2018-02-15 17:17:42	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/fd65937ec601...d09968f4d006
130 2018-02-15 17:17:43	0|bitcoin-git|13bitcoin/06master 14d09968f 15Wladimir J. van der Laan: Merge #12200: Bind functional test nodes to 127.0.0.1...
131 2018-02-15 17:18:30	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12200: Bind functional test nodes to 127.0.0.1 (06master...06test-framework-bind) 02https://github.com/bitcoin/bitcoin/pull/12200
132 2018-02-15 18:26:24	0|cfields|wumpus: here now. my sleep schedule is all out of whack :\
133 2018-02-15 18:26:44	0|sipa|morning!
134 2018-02-15 18:26:53	0|cfields|heh
135 2018-02-15 18:27:07	0|cfields|wumpus: yes, every time I think I understand it, something new pops up and totally confuses me again. Sorry for dragging you down with me :)
136 2018-02-15 18:29:44	0|cfields|wumpus: glad to see that we agree about longer-term. I was also thinking that we should move the wallet locks out of the map and into wallet as a follow-up.
137 2018-02-15 18:31:12	0|cfields|wumpus: re #12349, I'll test with current master now
138 2018-02-15 18:31:13	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
139 2018-02-15 18:31:47	0|wumpus|cfields: I feel the same about programming, and c++ in particular, there's always some new and unexpected situation that comes up
140 2018-02-15 18:32:05	0|wumpus|I also have the feeling boost doesn't help here :-)
141 2018-02-15 18:32:23	0|cfields|heh
142 2018-02-15 18:33:42	0|wumpus|might make sense to implement this using the posix and win32 API at some point so that we actually know for sure what it's doing
143 2018-02-15 18:34:55	0|wumpus|for now, having a test helps
144 2018-02-15 18:46:39	0|cfields|no clue. I assume something 100% winapi with no resemblence to posix :(
145 2018-02-15 18:48:24	0|wumpus|oh cool, we can do 90's style winapi with WM_* messages
146 2018-02-15 18:49:55	0|cfields|heh. Probably something like LockFile2Ex3Real()
147 2018-02-15 18:50:22	0|cfields|Where obviously LockFileEx might still work, but only up to Win3.1.
148 2018-02-15 18:51:02	0|cfields|it was dark days, dealing with that crap :)
149 2018-02-15 18:52:51	0|wumpus|yes :-)
150 2018-02-15 19:00:33	0|achow101|Meeting?
151 2018-02-15 19:00:40	0|Murch|aye
152 2018-02-15 19:01:13	0|wumpus|#startmeeting
153 2018-02-15 19:01:14	0|lightningbot|Meeting started Thu Feb 15 19:01:13 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
154 2018-02-15 19:01:14	0|lightningbot|Useful Commands: #action #agreed #help #info #idea #link #topic.
155 2018-02-15 19:01:35	0|wumpus|#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
156 2018-02-15 19:02:04	0|cfields|hi
157 2018-02-15 19:02:18	0|wumpus|we're almost ready to tag rc4, the still open PRs could still use some review https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.16.0
158 2018-02-15 19:02:32	0|promag|hi
159 2018-02-15 19:02:39	0|kanzure|hi.
160 2018-02-15 19:03:21	0|luke-jr|hi
161 2018-02-15 19:03:45	0|cfields|I'm not sure if I'm happy to see people testing the RCs, or scared of how many things keep cropping up :\
162 2018-02-15 19:03:55	0|BlueMatt|heh
163 2018-02-15 19:04:02	0|BlueMatt|yea
164 2018-02-15 19:04:06	0|wumpus|I'd like to discuss #12349
165 2018-02-15 19:04:07	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
166 2018-02-15 19:04:20	0|BlueMatt|i hate that fix, but it should be sufficient :(
167 2018-02-15 19:04:37	0|wumpus|#topic reindex-chainstate crash
168 2018-02-15 19:04:45	0|sipa|present
169 2018-02-15 19:04:58	0|wumpus|so we committed a fix for that in an earlier rc, but apparently the issue still exists
170 2018-02-15 19:05:17	0|BlueMatt|yes, the fix was for a highly-related bug
171 2018-02-15 19:05:52	0|BlueMatt|well, ok, essentially, either the same crash triggered by doing reindex, or the crash triggered by simply quickly quitting
172 2018-02-15 19:06:02	0|BlueMatt|so its already fixed for fast-quit
173 2018-02-15 19:06:06	0|wumpus|is it clear what the issue is in the first place? it seems it's causing workarounds to be spread over the code to 'fix' it
174 2018-02-15 19:06:16	0|wumpus|I'm not really happy to see that
175 2018-02-15 19:06:34	0|BlueMatt|yes, the issue is that we call Flush during shutdown before we've loaded genesis block
176 2018-02-15 19:06:37	0|cfields|wumpus: I just commented on the PR, I'll re-paste here for a little context:
177 2018-02-15 19:06:43	0|cfields|"As a small data point, though, we believed this to be qt only and couldn't hit it with rc3. It was @eklitzke's bitcoind backtrace that made it easy to reproduce."
178 2018-02-15 19:06:51	0|BlueMatt|so the flush assert(false)s because we have no "tip block" which we are flushing towards
179 2018-02-15 19:07:03	0|BlueMatt|huh? no?
180 2018-02-15 19:07:14	0|BlueMatt|I did not believe it to only be bitcoin-qt?
181 2018-02-15 19:07:20	0|BlueMatt|not sure where you got that
182 2018-02-15 19:07:29	0|wumpus|oh, and the flush assumes that the genesis block is there?
183 2018-02-15 19:08:00	0|BlueMatt|the flush assumes there is a tip block, including gensis
184 2018-02-15 19:08:09	0|promag|bitcoind crashed too
185 2018-02-15 19:08:26	0|MarcoFalke|^
186 2018-02-15 19:08:36	0|cfields|BlueMatt: huh, I was definitely working under that impression
187 2018-02-15 19:08:47	0|BlueMatt|there are several largely-unrelated bugs in qt
188 2018-02-15 19:08:56	0|BlueMatt|and there were other init-fast-shutdown-crash bugs in bitcoind
189 2018-02-15 19:09:02	0|cfields|not anymore ofc, now that we can hit it with bitcoind.
190 2018-02-15 19:09:06	0|BlueMatt|that trying to reproduce this and other issues dug up
191 2018-02-15 19:09:22	0|cfields|right, ok
192 2018-02-15 19:09:58	0|wumpus|there's no automatic test coverage for these paths, so problems are only found incidentally
193 2018-02-15 19:10:17	0|BlueMatt|yes, one thing I did during testing was just make ShutdownRequested() start shutdown after being called N times
194 2018-02-15 19:10:22	0|BlueMatt|and just restart with an incrementing N
195 2018-02-15 19:10:31	0|BlueMatt|this is something we could automate, but would largely not have caught the qt issues
196 2018-02-15 19:10:42	0|wumpus|nice idea
197 2018-02-15 19:10:56	0|wumpus|no, testing qt is a whole different can of worms
198 2018-02-15 19:11:20	0|promag|true
199 2018-02-15 19:11:56	0|wumpus|we solved some long-running bugs there recently :)
200 2018-02-15 19:12:07	0|promag|but do we care to flush if shutdown is requested?
201 2018-02-15 19:12:11	0|cfields|BlueMatt: I like that too. We'd just want to remember to grind hard on the tests before release
202 2018-02-15 19:12:19	0|BlueMatt|to make it actually have good coverage we need to drop all direct accesses to fShutdownRequested and replace with ShutdownRequested()
203 2018-02-15 19:12:19	0|promag|(on init)
204 2018-02-15 19:12:25	0|BlueMatt|which is why I missed the current incantation of the bug
205 2018-02-15 19:12:35	0|BlueMatt|cfields: its super fast, you could run it in travis
206 2018-02-15 19:12:41	0|MarcoFalke|I can do that
207 2018-02-15 19:13:23	0|wumpus|drop all direct accesses to fShutdownRequested and replace with ShutdownRequested() -> that sounds like a good idea for encapsulation in any case
208 2018-02-15 19:13:29	0|BlueMatt|yes
209 2018-02-15 19:13:48	0|cfields|can optimize the atomic too :p
210 2018-02-15 19:14:02	0|promag|what does that solve?
211 2018-02-15 19:14:10	0|BlueMatt|anyway, as for the current bug, I think #12349 is likely fine for 0.16, though I'd prefer it skips more of the FlushStateToDisk codepaths in the case that we've clearly never written anything we need to flush (morcos just pointed out it'd be nice to skip the wallet best chain setting, though unlikely thats a bug)
212 2018-02-15 19:14:11	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
213 2018-02-15 19:14:23	0|promag|maybe we should replace atomic var with a mutex? so that some blocks can hold the mutex and prevent others to continue?
214 2018-02-15 19:15:13	0|BlueMatt|promag: wat, why would you do that?
215 2018-02-15 19:15:23	0|cfields|promag: that's a different long discussion :). It was really just a joke in this context
216 2018-02-15 19:15:23	0|wumpus|looks like problem that has spooked us for a long time, that much of the code cannot cope without genesis block set
217 2018-02-15 19:15:52	0|wumpus|it should only be a problem in shutdown() because we don't exit AppInit() succesfully in that ase
218 2018-02-15 19:16:03	0|wumpus|AppInitMain()
219 2018-02-15 19:16:10	0|BlueMatt|wumpus: yes, one other thing to be done is to move fucking ThreadImport up inside init, but  regular old reindex is hard to work with to fix this issue
220 2018-02-15 19:16:22	0|BlueMatt|unless you want to re-introduce the bug where we write a copy of genesis every time we load.......
221 2018-02-15 19:16:27	0|wumpus|but other sneaky things come up all the time
222 2018-02-15 19:16:40	0|promag|BlueMatt: because once you request the shutdown other threads can start the tear down, which can mess other stuff
223 2018-02-15 19:16:57	0|BlueMatt|promag: shutdown can happen at any point, you shouldnt be able to block shutdown by taking a lock.....
224 2018-02-15 19:17:01	0|wumpus|BlueMatt: let's at least have a test for that, that if someone regresses that we'd at least detect it
225 2018-02-15 19:17:05	0|BlueMatt|subsystem separation should work.......
226 2018-02-15 19:17:35	0|BlueMatt|wumpus: yes, agreed....didnt MarcoFalke just say he'd build it? =D
227 2018-02-15 19:17:36	0|cfields|BlueMatt: yea, my earlier iterations skipped more of FlushStateToDisk, but I figured it was best to not tangle that logic up with init's
228 2018-02-15 19:17:42	0|wumpus|promag: we don't really have that issue afaik
229 2018-02-15 19:18:15	0|BlueMatt|cfields: hmm, ugh
230 2018-02-15 19:18:15	0|wumpus|but ok, then we keep #12349 for 0.16
231 2018-02-15 19:18:17	0|gribble|https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
232 2018-02-15 19:18:31	0|BlueMatt|cfields: cant we literally skip the entire function in that case?
233 2018-02-15 19:18:37	0|BlueMatt|we clear the dbs on load themselves
234 2018-02-15 19:18:41	0|wumpus|please pray let it be fixed now
235 2018-02-15 19:18:43	0|BlueMatt|so its not like we have anything at all whatsoever to flush
236 2018-02-15 19:18:47	0|wumpus|:P
237 2018-02-15 19:18:50	0|BlueMatt|lol
238 2018-02-15 19:19:07	0|cfields|BlueMatt: yes, but that involves locking changes
239 2018-02-15 19:19:15	0|cfields|(possibly only one teeny tiny one)
240 2018-02-15 19:19:20	0|wumpus|noooooo
241 2018-02-15 19:19:37	0|BlueMatt|ugh, I still want to go back to my CChainState::fWeveDoneAnythingAtAll idea
242 2018-02-15 19:19:39	0|wumpus|we saw what happened last time we tried "locking changes" :-)
243 2018-02-15 19:19:40	0|cfields|right, hence _this_ approach :)
244 2018-02-15 19:19:43	0|BlueMatt|and just insert that and skip flush if its false
245 2018-02-15 19:19:51	0|promag|next topic suggestion #11913
246 2018-02-15 19:19:53	0|gribble|https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub
247 2018-02-15 19:19:58	0|BlueMatt|wumpus: yea, we ended up with a super-long 0.16 release process.....sorry :(
248 2018-02-15 19:20:01	0|cfields|BlueMatt: +1 for master. Completely agree.
249 2018-02-15 19:20:20	0|wumpus|BlueMatt: it's not your fault, the code is just completely crazy in that regard
250 2018-02-15 19:20:34	0|BlueMatt|wumpus: no, I meant the validationinterface queue garbage, that had a few last-minute bugs as well
251 2018-02-15 19:21:09	0|wumpus|promag: sure
252 2018-02-15 19:21:16	0|wumpus|#topic Avoid cs_main during ReadBlockFromDisk Calls
253 2018-02-15 19:21:30	0|BlueMatt|what about it?
254 2018-02-15 19:21:50	0|wumpus|yes, what about it
255 2018-02-15 19:21:51	0|BlueMatt|I mean needs a ton of rebase due to merging of a dep, but I can do that whenever folks are ready to review
256 2018-02-15 19:22:09	0|wumpus|it's obviously a concept ack
257 2018-02-15 19:22:13	0|promag|is this going forward?
258 2018-02-15 19:22:24	0|promag|I mean, it's in priority review
259 2018-02-15 19:22:28	0|BlueMatt|I dont see why not, I mean my name's on the tin, but...
260 2018-02-15 19:22:54	0|wumpus|it's not going backward at least!
261 2018-02-15 19:22:58	0|BlueMatt|oh, you're saying I should rebase
262 2018-02-15 19:22:59	0|BlueMatt|yea, k
263 2018-02-15 19:23:07	0|BlueMatt|I mean IIRC it shoudl be reviewable if you just ignore the first few commits
264 2018-02-15 19:23:10	0|BlueMatt|which are since merged
265 2018-02-15 19:23:12	0|BlueMatt|but whatever
266 2018-02-15 19:23:24	0|promag|like that, there are others that avoid cs_main
267 2018-02-15 19:23:25	0|BlueMatt|it appears I have two things in high-priority though, which is not ok
268 2018-02-15 19:23:26	0|wumpus|if some commits are merged you can say it has been going forward
269 2018-02-15 19:23:49	0|BlueMatt|anyway, next topic?
270 2018-02-15 19:23:58	0|wumpus|any other topics?
271 2018-02-15 19:24:15	0|BlueMatt|Bitcoin!
272 2018-02-15 19:24:19	0|sipa|Bitcoin!
273 2018-02-15 19:24:20	0|achow101|encrypting wallets without restarting
274 2018-02-15 19:24:39	0|wumpus|what about it?
275 2018-02-15 19:25:00	0|cfields|wumpus: It's this new cryptocurrency...
276 2018-02-15 19:25:07	0|sipa|LOL
277 2018-02-15 19:25:08	0|wumpus|aren't bitcoins those big, golden coins with 1's and 0's on them?
278 2018-02-15 19:25:25	0|wumpus|I think they're too heavy to ever be practical
279 2018-02-15 19:25:42	0|cfields|haha
280 2018-02-15 19:25:44	0|wumpus|#topic encrypting wallets without restarting (achow101)
281 2018-02-15 19:25:58	0|achow101|relevant PR is #11678
282 2018-02-15 19:26:00	0|gribble|https://github.com/bitcoin/bitcoin/issues/11678 | [wallet] Dont shut down after encrypting the wallet by achow101 · Pull Request #11678 · bitcoin/bitcoin · GitHub
283 2018-02-15 19:26:04	0|BlueMatt|yea, you have to carry around a computer to spend them....arent those those things that take up like a whole basement and you have to hire a few people to maintain it?
284 2018-02-15 19:26:47	0|achow101|there's a really really really ugly hack in that pr to make it work from the rpcconsole
285 2018-02-15 19:27:22	0|achow101|but I'm kinda stuck on a better way to let people encrypt from the rpcconsole and not have the gui get all screwed up
286 2018-02-15 19:28:20	0|promag|achow101: with dynamic wallet loading this should be easier?
287 2018-02-15 19:28:23	0|wumpus|BlueMatt: a computer?! oh no, I heard there wil never be demand for more than 10 of them in the whole world
288 2018-02-15 19:28:28	0|achow101|promag: I don't think so
289 2018-02-15 19:28:28	0|kanzure|what is the problem with a restart?
290 2018-02-15 19:28:55	0|achow101|I noted in the dynamic reloading pr that it actually has a similar problem if you try to reload the wallet that is currently used by the gui
291 2018-02-15 19:28:56	0|wumpus|kanzure: for multiwallet it can be kind of annoying, I guess
292 2018-02-15 19:29:14	0|wumpus|kanzure: if you want to encrypt 10 wallets and need to restart 10 times
293 2018-02-15 19:29:23	0|BlueMatt|I mean, yea, question is how it gets handled in dynamic multiwallet gui, handle it the same way........
294 2018-02-15 19:29:38	0|BlueMatt|all that code is gonna have to get written one way or another
295 2018-02-15 19:29:49	0|BlueMatt|de-init'ing the whole gui wallet stuff and re-init'ing it is gonna have to exist
296 2018-02-15 19:29:53	0|achow101|BlueMatt: the thing is, dynamic multiwallet doesn't handle it at all
297 2018-02-15 19:29:55	0|BlueMatt|not that I have any opinion on *how*
298 2018-02-15 19:30:05	0|cfields|maybe an unpopular opinion, but forcing the inconvenience of a shutdown for this doesn't seem terrible to me...
299 2018-02-15 19:30:08	0|BlueMatt|achow101: well that just sounds downright broken
300 2018-02-15 19:30:12	0|kanzure|wumpus: perhaps just do it all at once and do only one restart.
301 2018-02-15 19:30:21	0|BlueMatt|cfields: see wumpus note on encrypting multiple wallets
302 2018-02-15 19:30:21	0|wumpus|cfields: I don't think it's particularly urgent either, no
303 2018-02-15 19:30:36	0|cfields|in fact, seems like it should really be handled by a tool outside of bitcoind
304 2018-02-15 19:30:39	0|wumpus|but I never encrypt wallets so don't listen to me
305 2018-02-15 19:30:53	0|BlueMatt|sounds good, lets remove encrypted wallet support!
306 2018-02-15 19:31:13	0|promag|achow101: it needs fixing then, between dyn wallet, your pr and #11383
307 2018-02-15 19:31:15	0|wumpus|(well obviously I encrypt backups, but I don't use bitcoin's encrypted wallet stuff)
308 2018-02-15 19:31:17	0|gribble|https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
309 2018-02-15 19:31:23	0|sipa|cfields: i think that we're struggling to do so is probably a sign of some problems internally, regardless of whether it's a desired feature or not
310 2018-02-15 19:31:32	0|achow101|My plan for doing wallet encryption by default needed to do something like this, so I went and did it as a separate thing
311 2018-02-15 19:31:48	0|BlueMatt|sipa: that was my point...we're gonna have to handle it wrt dynamic multiwallet
312 2018-02-15 19:31:48	0|wumpus|but yes, once we have dynamic wallet unloading and loading, it shoudl be straightforward
313 2018-02-15 19:31:50	0|wumpus|so focus on that first
314 2018-02-15 19:31:54	0|achow101|but I kinda got stuck at how the hell to get the rpcconsole to tell the gui to reload the wallet
315 2018-02-15 19:32:00	0|sipa|BlueMatt: yup, agree
316 2018-02-15 19:32:05	0|wumpus|just unload the wallet ,resilver/rewrite it, then reopen it, voila
317 2018-02-15 19:32:07	0|cfields|sipa: fair point.
318 2018-02-15 19:32:15	0|promag|wumpus: +1
319 2018-02-15 19:32:22	0|achow101|wumpus: that's what I thought. but then qt got in the way
320 2018-02-15 19:32:23	0|promag|the gui should react
321 2018-02-15 19:32:31	0|promag|some signals etc
322 2018-02-15 19:32:32	0|wumpus|achow101: GUI should subscribe to wallet unload events
323 2018-02-15 19:32:36	0|achow101|wumpus: qt and the rpcconsole donn't interact particularly well
324 2018-02-15 19:32:40	0|achow101|apparently
325 2018-02-15 19:32:43	0|wumpus|achow101: and delete the associated state from the GUI
326 2018-02-15 19:32:50	0|wumpus|promag: yes exactly
327 2018-02-15 19:33:05	0|BlueMatt|achow101: I'm confused, so this is an open issue to solve for dynamic multiwallet gui, no?
328 2018-02-15 19:33:12	0|achow101|BlueMatt: it is
329 2018-02-15 19:33:25	0|BlueMatt|ok, so the question is how to handle it properly in that case?
330 2018-02-15 19:33:27	0|wumpus|wallets have an associated GUI object (walletmodel) which then needs to be deleted, as well as the tabs/other stuff associated with that wallet
331 2018-02-15 19:33:28	0|promag|what's the deal with rpcconsole? because of the target wallet of wallet commands?
332 2018-02-15 19:34:08	0|achow101|BlueMatt: the issue that needs to be handled is how to get the gui to reload a wallet from actions that happened over rpc
333 2018-02-15 19:34:08	0|wumpus|how is the console a problem? does it care about wallets?
334 2018-02-15 19:34:14	0|promag|I think #11383 deals with changing wallets, it's a matter to change to null wallet
335 2018-02-15 19:34:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
336 2018-02-15 19:34:17	0|wumpus|it just interprets commands and sends them to the RPC interface IIRC
337 2018-02-15 19:34:29	0|wumpus|oh the wallet selectbox thing
338 2018-02-15 19:34:38	0|wumpus|yes, that needs to listen to wallet removal events too, then...
339 2018-02-15 19:34:41	0|achow101|wumpus: things that happen over rpc need to be reflected in the gui
340 2018-02-15 19:35:06	0|wumpus|so I'd say first implement it in the RPC
341 2018-02-15 19:35:08	0|kanzure|are the relevant qt signal hooks not implemented..?
342 2018-02-15 19:35:12	0|wumpus|then later make a PR to do it for the GUI
343 2018-02-15 19:35:13	0|promag|both gui and rpc should load/unload wallets in the same place, and only then the gui reacts
344 2018-02-15 19:35:23	0|wumpus|that's usually the order in which we do things
345 2018-02-15 19:35:45	0|achow101|wumpus: but then people may use the rpcconsole which just does the rpc things, and that will just break the gui.
346 2018-02-15 19:35:48	0|achow101|it segfaults
347 2018-02-15 19:35:49	0|wumpus|GUI is usually a hairier business, and needs different reviewers
348 2018-02-15 19:36:04	0|wumpus|oh yes it should certainly not segfault..
349 2018-02-15 19:36:32	0|achow101|e.g. for the encrypting the wallet without restarting, it works over rpc and in the gui if you encrypt from gui
350 2018-02-15 19:36:41	0|achow101|but if you call encryptwallet from the rpcconsole, it will segfault
351 2018-02-15 19:37:07	0|achow101|because rpc cannot tell gui to reload the wallet
352 2018-02-15 19:37:13	0|wumpus|so that's because we don't have the hooks in place for dynamic wallet loading/unloading yet
353 2018-02-15 19:37:14	0|wumpus|we need that first
354 2018-02-15 19:37:17	0|achow101|yes
355 2018-02-15 19:37:36	0|promag|rpc and gui don't know each other
356 2018-02-15 19:37:39	0|achow101|I guess the question is really *how*
357 2018-02-15 19:37:46	0|achow101|since rpc and gui don't really talk to each other
358 2018-02-15 19:37:49	0|wumpus|ay other topics?
359 2018-02-15 19:37:59	0|wumpus|achow101: using signals, conencting the GUI to them
360 2018-02-15 19:38:00	0|promag|achow101: let's discuss this later
361 2018-02-15 19:38:18	0|wumpus|achow101: the same as it works for other ClientModel. WalletModel signals
362 2018-02-15 19:38:34	0|jnewbery|dynamic wallet loading (#10740) is very much a work in progress. I haven't touched it for a while because it felt like we would want multiwallet in the GUI to go in first
363 2018-02-15 19:38:36	0|gribble|https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
364 2018-02-15 19:39:03	0|wumpus|so there's a signal WalletAboutToBeUnloaded, and a signal NewWallet, the GUI can handle those and take appropriate action
365 2018-02-15 19:39:04	0|promag|jnewbery: right, that was the last conclusion iirc
366 2018-02-15 19:40:10	0|wumpus|other topics?
367 2018-02-15 19:40:15	0|kanzure|please send me your topic suggestions for my collection for march things, including short-term (like specific issues or merge requests) and long-term (future stuff)
368 2018-02-15 19:40:59	0|wumpus|#action please send kanzure your topic suggestions for my collection for march things, including short-term (like specific issues or merge requests) and long-term (future stuff)
369 2018-02-15 19:41:28	0|kanzure|i could also just randomly assign issues :-)
370 2018-02-15 19:41:38	0|cfields|kanzure: thanks for doing that
371 2018-02-15 19:41:55	0|luke-jr|#12208 should still be in 0.16, somehow not tagged/merged yet
372 2018-02-15 19:41:57	0|gribble|https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
373 2018-02-15 19:42:15	0|achow101|any news on the mpc rsa signing key?
374 2018-02-15 19:43:08	0|wumpus|luke-jr: doing a string change in a rc would be really unwise, we can tag it 0.16.1 though
375 2018-02-15 19:43:21	0|luke-jr|wumpus: more unwise than having confusing strings?
376 2018-02-15 19:43:28	0|wumpus|luke-jr: yes
377 2018-02-15 19:43:40	0|wumpus|it's too late, translators have no chance to even look at it anymore
378 2018-02-15 19:43:55	0|luke-jr|could copy the translations to it, but whatever
379 2018-02-15 19:44:19	0|luke-jr|long-term, I guess that could result in confusing translations persisting XD
380 2018-02-15 19:44:54	0|cfields|I'm sure we'll learn a lot about bech32 confusion with 0.16.0. We'll be in better shape to clean it up for 0.16.1 with that feedback, I think.
381 2018-02-15 19:45:02	0|wumpus|&
382 2018-02-15 19:45:05	0|wumpus|^
383 2018-02-15 19:45:29	0|luke-jr|well, as-is, it seems to affirm the myth that there is a from address
384 2018-02-15 19:46:22	0|booyah|if it's like 1 string I bet on #bitcoin + reddit community has someone ready for any lang
385 2018-02-15 19:46:49	0|achow101|meta topic: meeeting notes
386 2018-02-15 19:47:03	0|wumpus|#topic meeting notes
387 2018-02-15 19:47:19	0|achow101|the person I got to write the meeting notes got bored with it so they aren't happening anymore :(
388 2018-02-15 19:47:36	0|sipa|can't blame them, i guess..
389 2018-02-15 19:47:37	0|wumpus|oh :(
390 2018-02-15 19:48:07	0|cfields|sex.
391 2018-02-15 19:48:16	0|cfields|there, fixed. next topic?
392 2018-02-15 19:48:30	0|wumpus|heh
393 2018-02-15 19:48:36	0|wumpus|I think we're out of topics
394 2018-02-15 19:48:53	0|wumpus|#endmeeting
395 2018-02-15 19:48:54	0|lightningbot|Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-15-19.01.log.html
396 2018-02-15 19:48:54	0|lightningbot|Meeting ended Thu Feb 15 19:48:53 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
397 2018-02-15 19:48:54	0|lightningbot|Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-15-19.01.html
398 2018-02-15 19:48:54	0|lightningbot|Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-15-19.01.txt
399 2018-02-15 19:49:09	0|kanzure|for march topics, send your topics or someone else's topics. it's fair game to insist that someone else talks about a thing >:-).
400 2018-02-15 19:49:11	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12442: devtools: Exclude patches from lint-whitespace (06master...06Mf1802-devtoolsLintWhitespaceExcludePatches) 02https://github.com/bitcoin/bitcoin/pull/12442
401 2018-02-15 19:49:52	0|achow101|kanzure: what's the current list of topics?
402 2018-02-15 19:50:09	0|kanzure|achow101: i have a few items, might post it in public soon. i've done this a few times in the past before meetups.
403 2018-02-15 19:50:56	0|kanzure|usually i just write down a wishlist of what i want people to talk about, but i definitely overlook some items just out of sheer ignorance or something
404 2018-02-15 19:51:22	0|kanzure|or what i know people are working on
405 2018-02-15 19:52:08	0|promag|achow101: fyi later I'm going to test 11678
406 2018-02-15 19:52:29	0|achow101|kanzure: ah, I thought the list might be published already
407 2018-02-15 19:52:33	0|achow101|promag: ok
408 2018-02-15 19:52:44	0|achow101|promag: that current implementation is really bad
409 2018-02-15 20:22:47	0|jonasschnelli|sorry. missed the meeting. currently UTC+10.5
410 2018-02-15 20:28:08	0|wumpus|jonasschnelli: you didn't miss that much, though please join in our prayer that rc4 will be final :)
411 2018-02-15 20:29:23	0|sipa|i guess it will be an alleged rc4? :p
412 2018-02-15 20:29:59	0|gmaxwell|You need to discard it's initial output if you want it to be good.
413 2018-02-15 20:30:03	0|morcos|i think thats what the c stands for
414 2018-02-15 21:11:04	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d09968f4d006...58715f6d073f
415 2018-02-15 21:11:05	0|bitcoin-git|13bitcoin/06master 141d4cbd2 15Wladimir J. van der Laan: test: Add unit test for LockDirectory...
416 2018-02-15 21:11:05	0|bitcoin-git|13bitcoin/06master 14fc888bf 15Wladimir J. van der Laan: util: Fix multiple use of LockDirectory...
417 2018-02-15 21:11:06	0|bitcoin-git|13bitcoin/06master 1458715f6 15Wladimir J. van der Laan: Merge #12422: util: Make LockDirectory thread-safe, consistent, and fix OpenBSD 6.2 build...
418 2018-02-15 21:11:59	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12422: util: Make LockDirectory thread-safe, consistent, and fix OpenBSD 6.2 build (06master...062018_01_openbsd_util_fix) 02https://github.com/bitcoin/bitcoin/pull/12422
419 2018-02-15 21:22:25	0|bitcoin-git|13bitcoin/06master 14ceaefdd 15Cory Fields: fix possible shutdown assertion with -reindex-shutdown...
420 2018-02-15 21:22:25	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/58715f6d073f...5eff1c748d56
421 2018-02-15 21:22:26	0|bitcoin-git|13bitcoin/06master 145eff1c7 15Wladimir J. van der Laan: Merge #12349: shutdown: fix crash on shutdown with reindex-chainstate...
422 2018-02-15 21:23:19	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (06master...06fix-qt-shutdown) 02https://github.com/bitcoin/bitcoin/pull/12349
423 2018-02-15 21:31:54	0|promag|achow101: nack on those __Model::ReloadWallet()
424 2018-02-15 21:32:18	0|promag|by design an __Model instance is tied to the wallet received in the constructor
425 2018-02-15 21:33:10	0|promag|the same for WalletModel
426 2018-02-15 21:33:37	0|achow101|promag: yeah, I'll probably ditch all of that once I figure out how to use boost signals
427 2018-02-15 21:34:02	0|bitcoin-git|13bitcoin/06master 145f605e1 15Pieter Wuille: Make signrawtransaction accept P2SH-P2WSH redeemscripts
428 2018-02-15 21:34:02	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5eff1c748d56...3fa556aee203
429 2018-02-15 21:34:03	0|bitcoin-git|13bitcoin/06master 143fa556a 15Wladimir J. van der Laan: Merge #12427: Make signrawtransaction accept P2SH-P2WSH redeemscripts...
430 2018-02-15 21:34:15	0|promag|I really think you should wait for jnewbery or try to rebase his PR and build from there
431 2018-02-15 21:34:47	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12427: Make signrawtransaction accept P2SH-P2WSH redeemscripts (06master...06201802_signrawp2shp2wsh) 02https://github.com/bitcoin/bitcoin/pull/12427
432 2018-02-15 21:36:15	0|promag|you should consider TransactionTableModel::wallet const (the same for other models)
433 2018-02-15 21:55:17	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 060.16: 02https://github.com/bitcoin/bitcoin/compare/5e40e64face2...3762ac127aec
434 2018-02-15 21:55:18	0|bitcoin-git|13bitcoin/060.16 1432a7268 15Wladimir J. van der Laan: util: Fix multiple use of LockDirectory...
435 2018-02-15 21:55:18	0|bitcoin-git|13bitcoin/060.16 144d54e7a 15Wladimir J. van der Laan: test: Add unit test for LockDirectory...
436 2018-02-15 21:55:19	0|bitcoin-git|13bitcoin/060.16 14ad10b90 15Cory Fields: fix possible shutdown assertion with -reindex-shutdown...
437 2018-02-15 22:10:04	0|promag|wumpus: if you are up to merges see #12083
438 2018-02-15 22:10:06	0|gribble|https://github.com/bitcoin/bitcoin/issues/12083 | Improve getchaintxstats test coverage by promag · Pull Request #12083 · bitcoin/bitcoin · GitHub
439 2018-02-15 22:10:21	0|wumpus|sorry, I'm busy at the moment
440 2018-02-15 22:12:34	0|bitcoin-git|13bitcoin/060.16 145109347 15Wladimir J. van der Laan: qt: Pre-rc4 translations update...
441 2018-02-15 22:12:34	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/51093478c0e1d79b2aa4296c5f93dcf41c1ea92f
442 2018-02-15 22:12:44	0|promag|np, it's mainly a test pr with 2 utack
443 2018-02-15 22:27:47	0|cfields|wumpus: preparing to tag tonight?
444 2018-02-15 22:28:01	0|wumpus|cfields: yep
445 2018-02-15 22:28:06	0|cfields|great :)
446 2018-02-15 22:32:30	0|sipa|"the same thing we do every night, pinky"
447 2018-02-15 22:32:56	0|wumpus|pinky and the brain brain brain
448 2018-02-15 22:33:05	0|bitcoin-git|13bitcoin/060.16 14a8e62a8 15Wladimir J. van der Laan: doc: Update release notes from wiki for rc3...
449 2018-02-15 22:33:05	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/a8e62a842615d338d41caf1603de4263a7f4bad8
450 2018-02-15 22:33:35	0|bitcoin-git|[13bitcoin] 15theuni opened pull request #12444: gitian: bump descriptors for (0.)17 (06master...06gitian-bump) 02https://github.com/bitcoin/bitcoin/pull/12444
451 2018-02-15 22:34:20	0|cfields|haha
452 2018-02-15 22:38:00	0|wumpus|* [new tag]         v0.16.0rc4 -> v0.16.0rc4
453 2018-02-15 22:41:31	0|cfields|woohoo
454 2018-02-15 22:41:40	0|cfields|now go relax :)
455 2018-02-15 22:45:14	0|wumpus|:)
456 2018-02-15 23:20:05	0|meshcollider|Oh I missed the meeting
457 2018-02-15 23:20:12	0|meshcollider|rc4 \o/
458 2018-02-15 23:53:25	0|dx25|@sipa, did you write the cashaddr.h/cpp module in bitcoin-abc?
459 2018-02-15 23:54:10	0|dx25|because if so, that's hilarious.
460 2018-02-15 23:54:16	0|sipa|no, but it was adapted from the bech32.cpp module in bitcoin core
461 2018-02-15 23:54:19	0|dx25|oh ok
462 2018-02-15 23:54:19	0|sipa|which i did write