1 2018-02-16 00:28:34	0|achow101|at least they kept the copyright header this time
  2 2018-02-16 00:30:31	0|bitcoin-git|13bitcoin/06master 14fafbf7f 15MarcoFalke: devtools: Exclude patches from lint-whitespace
  3 2018-02-16 00:30:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3fa556aee203...a233fb4f1d03
  4 2018-02-16 00:30:32	0|bitcoin-git|13bitcoin/06master 14a233fb4 15MarcoFalke: Merge #12442: devtools: Exclude patches from lint-whitespace...
  5 2018-02-16 00:30:54	0|gmaxwell|yea, they changed their strategy from removing the attribution to leaving it and falsely announcing that people were contributing to their project: https://twitter.com/jimmysong/status/952611979742601216
  6 2018-02-16 00:31:32	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12442: devtools: Exclude patches from lint-whitespace (06master...06Mf1802-devtoolsLintWhitespaceExcludePatches) 02https://github.com/bitcoin/bitcoin/pull/12442
  7 2018-02-16 00:32:05	0|jimmysong|for what it's worth, deadalnix told me that one was specific to me because he wanted me to "choose sides"
  8 2018-02-16 00:32:25	0|jimmysong|no interest in aligning there
  9 2018-02-16 00:35:56	0|Emcy_|lolol
 10 2018-02-16 00:36:06	0|Emcy_|pick a side or we will pick one for you
 11 2018-02-16 00:36:47	0|esotericnonsense|well, there is the flip side
 12 2018-02-16 00:37:13	0|gmaxwell|:(
 13 2018-02-16 00:37:23	0|Emcy_|youll have to bunk with rog if you choose the flip side
 14 2018-02-16 00:37:23	0|esotericnonsense|as a bitcoin ABC contributor, I can go ahead and claim expert authority on the project being a nonsense
 15 2018-02-16 00:37:28	0|gmaxwell|how did he expect that to work
 16 2018-02-16 00:37:39	0|gmaxwell|meh, sorry I'm being offtopic
 17 2018-02-16 00:39:01	0|Emcy_|jimmysong isnt deadlnix one of them libertarian voluntaryists ive heard so much about
 18 2018-02-16 00:39:06	0|Emcy_|really interesting praxis
 19 2018-02-16 00:40:24	0|jimmysong|i guess he wanted me to say "yes i'm a contributor to bch"
 20 2018-02-16 00:40:27	0|jimmysong|or something like that
 21 2018-02-16 00:40:55	0|esotericnonsense|heh
 22 2018-02-16 00:41:07	0|Emcy_|bolster the 'multiple independent developers' rhetoric id guess
 23 2018-02-16 00:41:14	0|jimmysong|something like that
 24 2018-02-16 00:41:21	0|jimmysong|still don't understand why he did it that way
 25 2018-02-16 00:41:28	0|jimmysong|just makes him look bad
 26 2018-02-16 00:41:39	0|Emcy_|because hes a prick
 27 2018-02-16 00:41:43	0|Emcy_|applying occams razor
 28 2018-02-16 00:42:00	0|sipa|please, can we stick to technical topics relating to bitcoin core here
 29 2018-02-16 00:42:05	0|jimmysong|sorry
 30 2018-02-16 01:15:53	0|Emcy|whoops i thought this was forks sorry
 31 2018-02-16 04:15:28	0|fanquake|meshcollider could you do that script testing on your own repo?
 32 2018-02-16 04:16:25	0|meshcollider|fanquake: sorry, is it emailing you? Just finished testing it on my repo so its done anyway :)
 33 2018-02-16 04:18:55	0|fanquake|meshcollider yes, ok
 34 2018-02-16 04:19:35	0|meshcollider|fanquake: why is it emailing you if travis isn't even enabled on the repo? Or does it notify you of all PR changes?
 35 2018-02-16 04:21:17	0|fanquake|meshcolllier you get notified of PR changes
 36 2018-02-16 06:32:19	0|GitHub1|[13bitcoin-detached-sigs] 15jonasschnelli opened pull request #4: 0.16: osx signatures for 0.16.0rc4 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
 37 2018-02-16 07:36:20	0|denis2342|I have a small build regression on freebsd with 0.16.0rc4: https://pastebin.com/i9zPDKXd
 38 2018-02-16 07:36:34	0|denis2342|seems a header is missing
 39 2018-02-16 07:48:11	0|denis2342|adding #include <signal.h> to src/test/util_tests.cpp fixes the problem
 40 2018-02-16 08:07:25	0|bitcoin-git|13bitcoin/06master 14d7f438a 15Cory Fields: gitian: bump descriptors for (0.)17
 41 2018-02-16 08:07:25	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a233fb4f1d03...1f055ef9d798
 42 2018-02-16 08:07:26	0|bitcoin-git|13bitcoin/06master 141f055ef 15Wladimir J. van der Laan: Merge #12444: gitian: bump descriptors for (0.)17...
 43 2018-02-16 08:08:21	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12444: gitian: bump descriptors for (0.)17 (06master...06gitian-bump) 02https://github.com/bitcoin/bitcoin/pull/12444
 44 2018-02-16 08:10:15	0|bitcoin-git|13bitcoin/06master 14be45a67 15Richard Kiss: Add some script tests related to BOOL ops and odd values like negative 0.
 45 2018-02-16 08:10:15	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1f055ef9d798...26dc2daf82d2
 46 2018-02-16 08:10:16	0|bitcoin-git|13bitcoin/06master 1426dc2da 15Wladimir J. van der Laan: Merge #12425: Add some script tests...
 47 2018-02-16 08:11:04	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12425: Add some script tests (06master...06feature/bool_tests) 02https://github.com/bitcoin/bitcoin/pull/12425
 48 2018-02-16 08:19:18	0|wumpus|denis2342: hrm, I'll try rebuildilng my freebsd node and see if I run into the same
 49 2018-02-16 08:48:54	0|tma98|hi
 50 2018-02-16 10:26:34	0|fanquake|wumpus I agree with closing https://github.com/bitcoin-core/gitian.sigs/pull/614
 51 2018-02-16 10:27:58	0|fanquake|#678 is more interesting as a quick check, making sure that submitters are only modifying a single dir. However that is still a trivial thing to check anyways.
 52 2018-02-16 10:27:59	0|gribble|https://github.com/bitcoin/bitcoin/issues/678 | changing the GUI language · Issue #678 · bitcoin/bitcoin · GitHub
 53 2018-02-16 10:29:32	0|wumpus|fanquake: I think it's difficult, I mwan from a user perspective it's useful to be alerted when signatures diverge, what "m less convinced about is that travis is always the right hammer for the job
 54 2018-02-16 10:30:17	0|fanquake|I also agree that diverging/"incorrect" signatures should be merged regardless.
 55 2018-02-16 10:30:17	0|wumpus|FWIW this is the same feeling that I have with hooking all kinds of things like whitespace linters into travis. If there was a better way to customize the message/icon that appears in the github issue it'd be better.
 56 2018-02-16 10:30:30	0|wumpus|yep, something could warn after merging
 57 2018-02-16 10:39:20	0|promag|wumpus: https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159
 58 2018-02-16 10:39:46	0|promag|circle does what you want https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159
 59 2018-02-16 11:02:41	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #12447: test: Add missing signal.h header (06master...062018_02_freebsd_compile_fix) 02https://github.com/bitcoin/bitcoin/pull/12447
 60 2018-02-16 11:08:38	0|wumpus|promag: interesting!
 61 2018-02-16 13:03:33	0|bitcoin-git|[13bitcoin] 15promag opened pull request #12448: Interrupt block generation on shutdown request (06master...062018-02-interrupt-generate-blocks) 02https://github.com/bitcoin/bitcoin/pull/12448
 62 2018-02-16 13:09:30	0|promag|wumpus: what kind of test?
 63 2018-02-16 13:09:55	0|promag|generate bigcount and in parallel quit?
 64 2018-02-16 13:10:16	0|wumpus|well in this case a test that does generateblock 10000 then sends an interrupt request and checks that bitcoin shuts down cleanly
 65 2018-02-16 13:10:24	0|wumpus|though I'd argue this is not an important one to test
 66 2018-02-16 13:10:49	0|wumpus|the early-outs in init, are
 67 2018-02-16 13:11:25	0|promag|right
 68 2018-02-16 13:11:54	0|promag|I was benchmarking stuff and did generate 100000
 69 2018-02-16 13:11:59	0|wumpus|(that is where we had two fixes for, in the rc cycle... because early-outs leave the process in an inconsistent, or at least unpexpected state that may cause trouble later)
 70 2018-02-16 13:12:09	0|promag|and then I had to kill -9 otherwise it didn't stop
 71 2018-02-16 13:12:53	0|wumpus|which is fine, no one does software development perfectly, seeing all potential conseequences to a change (if only!), but illustrates tests are needed
 72 2018-02-16 13:13:32	0|promag|and generateBlocks is non main net right?
 73 2018-02-16 13:19:04	0|wumpus|if you can use it for mainnet, interrupting *between* blocks isn't going to help you
 74 2018-02-16 13:20:03	0|wumpus|even generating one block at the current difficulty with the naive, single-threaded miner meant for regtest is going to take a million years
 75 2018-02-16 14:03:03	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12451: Bump leveldb subtree (06master...06Mf1802-leveldbSubtreeBump) 02https://github.com/bitcoin/bitcoin/pull/12451
 76 2018-02-16 14:18:14	0|bitcoin-git|13bitcoin/06master 14dd7e42c 15Wladimir J. van der Laan: test: Add missing signal.h header...
 77 2018-02-16 14:18:14	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/26dc2daf82d2...4a62ddd01873
 78 2018-02-16 14:18:15	0|bitcoin-git|13bitcoin/06master 144a62ddd 15MarcoFalke: Merge #12447: test: Add missing signal.h header...
 79 2018-02-16 14:19:05	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12447: test: Add missing signal.h header (06master...062018_02_freebsd_compile_fix) 02https://github.com/bitcoin/bitcoin/pull/12447
 80 2018-02-16 14:37:42	0|provoostenator|I added an #ifdef ENABLE_WALLET in guiutil.h, but the compiler seems to think this is undefined for this particular file even though I configured with the wallet enabled.
 81 2018-02-16 14:45:40	0|kallewoof|provoostenator: you may need to do the HAVE_CONFIG_H deal first? (e.g. compat.h style)
 82 2018-02-16 14:49:08	0|provoostenator|kallewoof: thanks, that did the trick. What does it do?
 83 2018-02-16 15:23:12	0|kallewoof|provoostenator: it pulls in defines from autoconf etc, I believe
 84 2018-02-16 16:36:31	0|cfields|yep
 85 2018-02-16 16:36:45	0|cfields|it's so that you can tell the difference between autoconf'd builds and non
 86 2018-02-16 16:37:39	0|cfields|for ex, you can (or could at one point) build bitcoind with MSVC, you just have to define all of the stuff that autoconf would've detected for you
 87 2018-02-16 16:40:39	0|bitcoin-git|[13bitcoin] 15laanwj pushed 6 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4a62ddd01873...59e032b43cea
 88 2018-02-16 16:40:40	0|bitcoin-git|13bitcoin/06master 145a10859 15fanquake: [depends] expat 2.2.5
 89 2018-02-16 16:40:40	0|bitcoin-git|13bitcoin/06master 1461647a4 15fanquake: [depends] ccache 3.4.1
 90 2018-02-16 16:40:41	0|bitcoin-git|13bitcoin/06master 1441550d6 15fanquake: [depends] miniupnpc 2.0.20180203
 91 2018-02-16 16:41:27	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12402: [depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203 (06master...06depends-02-2018) 02https://github.com/bitcoin/bitcoin/pull/12402
 92 2018-02-16 16:42:13	0|cfields|wumpus: that one wasn't ready yet :\
 93 2018-02-16 17:04:34	0|wumpus|cfields: what's the problem?
 94 2018-02-16 17:56:37	0|gmaxwell|Someone noticed again that cross chain swaps can be broken due to different size limits on different systems https://bitcointalk.org/index.php?topic=2960023.0
 95 2018-02-16 17:56:45	0|gmaxwell|sipa: do you recall where this was previously pointed out?
 96 2018-02-16 18:21:56	0|GitHub194|[13bitcoin-detached-sigs] 15theuni closed pull request #4: 0.16: osx signatures for 0.16.0rc4 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
 97 2018-02-16 18:23:02	0|cfields|gitian builders: v0.16.0rc4 detached sigs are pushed
 98 2018-02-16 18:23:35	0|cfields|wumpus: the darwin define for miniupnpc is done universally
 99 2018-02-16 18:23:47	0|cfields|I'll nag on the PR
100 2018-02-16 18:25:26	0|wumpus|cfields: whoops so that define is for upnp itself, not a hint to darwin. I thought it was the latter so defining it universally wouldn't hurt.
101 2018-02-16 18:26:22	0|cfields|right. it's unlikely to be an issue, but if it turned out to manifest somewhere, it'd be really nasty to track down
102 2018-02-16 18:34:54	0|jcorgan|is there a how-to-do-gitian-builds-for-fun-and-profit-and-mental-health.md somewhere?
103 2018-02-16 18:36:23	0|achow101|jcorgan: https://github.com/bitcoin-core/docs/tree/master/gitian-building and https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md
104 2018-02-16 18:36:25	0|achow101|good luck
105 2018-02-16 18:38:27	0|jcorgan|if you don't hear from me in 72 hours send out the search teams
106 2018-02-16 18:39:10	0|wumpus|achow101: he's gonna need it
107 2018-02-16 18:49:52	0|jnewbery|review beg: #10583 . achow101 has rebased about a squillion times
108 2018-02-16 18:49:57	0|gribble|https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
109 2018-02-16 18:50:37	0|bitcoin-git|[13bitcoin] 15DaveFromBinary opened pull request #12452: [Docs] Clarified systemd installation instructions in init.md for Ubuntu users. (06master...06doc-init-updates) 02https://github.com/bitcoin/bitcoin/pull/12452
110 2018-02-16 19:06:32	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (06master...06fix-bip68-test) 02https://github.com/bitcoin/bitcoin/pull/12455
111 2018-02-16 19:29:55	0|ProfMac|I did a gitian build back in 0.14.xx.  The process was not well documented, and I could not reproduce whatever I did from my notes.  Is the documentation process any better now?
112 2018-02-16 19:39:12	0|wumpus|https://github.com/bitcoin-core/docs/blob/master/gitian-building.md
113 2018-02-16 19:39:25	0|wumpus|improvements are always welcome
114 2018-02-16 19:40:48	0|achow101|I don't think the problem is documentation but rather that gitian doesn't always work
115 2018-02-16 19:46:14	0|MarcoFalke|It is like Jenga. All the virtualizations or OSes that it depends on pull out sticks and you wait until it breaks
116 2018-02-16 20:11:50	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12458: Enforce that amount is provided for signrawtransaction prevtxs (06master...06rawtransaction-amount-required) 02https://github.com/bitcoin/bitcoin/pull/12458
117 2018-02-16 20:28:58	0|esotericnonsense|is univalue compiled seperately without C++11 ? i'm struggling with my make-fu
118 2018-02-16 20:29:06	0|esotericnonsense|it disagrees with my use of nullptr
119 2018-02-16 20:33:51	0|esotericnonsense|yeah, that's it.
120 2018-02-16 20:37:53	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12459: Assert compressed / compact keys and sigs are strictly shorter than regular (06master...06assert-compressed-smaller) 02https://github.com/bitcoin/bitcoin/pull/12459
121 2018-02-16 20:38:01	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12460: Assert CPubKey::ValidLength to the pubkey's header-relevent size (06master...06key-size-check-header) 02https://github.com/bitcoin/bitcoin/pull/12460
122 2018-02-16 20:39:41	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12461: Refactor key / signature size consts to be relative to their relevant class (06master...06key-size-consts) 02https://github.com/bitcoin/bitcoin/pull/12461
123 2018-02-16 20:40:58	0|bitcoin-git|[13bitcoin] 15Empact closed pull request #12319: Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references (06master...06pubkeysize) 02https://github.com/bitcoin/bitcoin/pull/12319
124 2018-02-16 20:42:02	0|cfields|esotericnonsense: "yeah, that's it" ?
125 2018-02-16 20:43:49	0|esotericnonsense|cfields: if I hack in g++ -std=c++11 into the makefile for univalue that works (I'm currently trying to figure out how to do this properly and fixing up some other compilation errors)
126 2018-02-16 20:44:04	0|cfields|yikes!
127 2018-02-16 20:44:31	0|esotericnonsense|what's yikes? that we weren't using c++11 for univalue? the concept of using it? :)
128 2018-02-16 20:44:59	0|cfields|yikes that we're possibly mixing ABIs in our binaries
129 2018-02-16 20:45:16	0|cfields|I'm surprised we haven't seen issues from that yet
130 2018-02-16 20:45:54	0|esotericnonsense|mmm. unfortunately my knowledge of this stuff has kind of faded after spending years in python-land. slowly getting there again.
131 2018-02-16 20:46:32	0|cfields|heh, no worries
132 2018-02-16 20:46:52	0|cfields|I'll PR a fix, unless you want to drill down into it
133 2018-02-16 20:48:17	0|esotericnonsense|up to you. i'm making a small change to univalue that requires it, but my knowledge of make is very limited (i'
134 2018-02-16 20:48:33	0|esotericnonsense|(i'd just be hacking in -std=c+11 into flags until it works on my box)
135 2018-02-16 20:49:02	0|esotericnonsense|well it doesn't require it because I don't _need_ to use nullptr it's just consistent that way
136 2018-02-16 20:49:12	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12463: Drop the return argument from CValidationState::DoS and Invalid (06master...06drop-dos-return) 02https://github.com/bitcoin/bitcoin/pull/12463
137 2018-02-16 20:49:46	0|bitcoin-git|[13bitcoin] 15Empact closed pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (06master...06validation-state-corrupt) 02https://github.com/bitcoin/bitcoin/pull/12357
138 2018-02-16 20:51:03	0|cfields|well, we haven't discussed it afaik, but it makes sense to keep univalue c++03 simply because it already is
139 2018-02-16 20:53:16	0|sipa|cfields: using c++11 may be more efficient
140 2018-02-16 20:53:56	0|sipa|because it gives stl automagival rvalue support
141 2018-02-16 20:54:02	0|sipa|*automagical
142 2018-02-16 20:54:09	0|cfields|sipa: sure. I think it makes sense to discuss bumping. It'd just be senseless to bump for some trivial change
143 2018-02-16 20:54:29	0|cfields|sipa: or did you mean just compiling as c++11?
144 2018-02-16 20:54:55	0|jnewbery|second review beg: #10579 for the same reasons as 10583. (Obviously not as important as anything v0.16 related, but I think for achow's sanity we should merge soon)
145 2018-02-16 20:54:57	0|cfields|'cause, yea, we'd see the rvalue optims from that alone
146 2018-02-16 20:54:59	0|gribble|https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
147 2018-02-16 20:55:30	0|sipa|jnewbery: yes, absolutely
148 2018-02-16 20:55:34	0|cfields|beg threshold hit, will review :)
149 2018-02-16 20:56:12	0|cfields|sipa: my immediate concern is catching exceptions across ABIs, though
150 2018-02-16 20:57:02	0|jnewbery|thanks sipa, thanks cfields!
151 2018-02-16 20:58:37	0|instagibbs|i know I've reviewed that PR before... no comments, hm. Will do again.
152 2018-02-16 21:01:41	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #12464: Revert "[tests] bind functional test nodes to 127.0.0.1" (06master...06revert_12200) 02https://github.com/bitcoin/bitcoin/pull/12464
153 2018-02-16 21:08:52	0|achow101|jnewbery: sanity? What's that?
154 2018-02-16 21:12:28	0|bitcoin-git|13bitcoin/06master 14df47afb 15John Newbery: Revert "[tests] bind functional test nodes to 127.0.0.1"...
155 2018-02-16 21:12:28	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/59e032b43cea...27c59dc502f2
156 2018-02-16 21:12:29	0|bitcoin-git|13bitcoin/06master 1427c59dc 15MarcoFalke: Merge #12464: Revert "[tests] bind functional test nodes to 127.0.0.1"...
157 2018-02-16 21:13:24	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12464: Revert "[tests] bind functional test nodes to 127.0.0.1" (06master...06revert_12200) 02https://github.com/bitcoin/bitcoin/pull/12464
158 2018-02-16 21:18:29	0|jnewbery|:)
159 2018-02-16 21:23:59	0|bitcoin-git|13bitcoin/06master 14e710387 15Ben Woosley: test: Fix bip68 sequence test to reflect updated rpc error message...
160 2018-02-16 21:23:59	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/27c59dc502f2...23481fa50301
161 2018-02-16 21:24:00	0|bitcoin-git|13bitcoin/06master 1423481fa 15MarcoFalke: Merge #12455: Fix bip68 sequence test to reflect updated rpc error message...
162 2018-02-16 21:24:54	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (06master...06fix-bip68-test) 02https://github.com/bitcoin/bitcoin/pull/12455
163 2018-02-16 21:33:36	0|esotericnonsense|cfields: changed the univalue stuff to just use NULL instead of nullptr