1 2018-02-21 00:05:34	0|mryandao|i've re-based #12240, would someone please have a look :)?
 2 2018-02-21 00:05:36	0|gribble|https://github.com/bitcoin/bitcoin/issues/12240 | [rpc] For consistency, changed Satoshi fee denominations to BTC by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub
 3 2018-02-21 00:49:42	0|promag|mryandao: there you go
 4 2018-02-21 02:34:37	0|achow101|ryanofsky: how do I use condition_variable with our locks?
 5 2018-02-21 02:35:22	0|achow101|I'm not very familiar with the locks stuff we use
 6 2018-02-21 03:27:26	0|luke-jr|achow101: GBT long polling does it
 7 2018-02-21 13:17:33	0|mrannanay|sipa: I ran make clean and then make again, the sync.cpp error is gone. Thanks!
 8 2018-02-21 13:18:06	0|mrannanay|How can I run unit tests for src/net.cpp ?
 9 2018-02-21 13:18:38	0|mrannanay|make check seems to pass despite (known, deliberate) errors in src/net.cpp
10 2018-02-21 14:02:34	0|drizztbsd|hi, is rc4 the final candidate?
11 2018-02-21 14:39:36	0|hasish|is there a way to stop incoming packets from the network, other then "setnetworkactive false" ?
12 2018-02-21 15:34:48	0|cfields|hasish: you can prevent incoming connections with -listen=0
13 2018-02-21 15:34:53	0|cfields|not sure if that's what you meant
14 2018-02-21 15:50:48	0|bitcoin-git|[13bitcoin] 15randolf opened pull request #12501: [qt] Improved "custom fee" explanation in tooltip (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/12501
15 2018-02-21 15:54:34	0|Lauda|timothy: if no new bugs are found, I believe yes
16 2018-02-21 16:09:40	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #12503: [RPC] createmultisig no longer takes addresses (06master...06createmultikey) 02https://github.com/bitcoin/bitcoin/pull/12503
17 2018-02-21 20:45:37	0|bitcoin-git|13bitcoin/06master 14eacc5b2 15Ben Woosley: Declare CMutableTransaction a struct in rawtransaction.h...
18 2018-02-21 20:45:37	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e117cfe45eee...e4ffcacc2187
19 2018-02-21 20:45:38	0|bitcoin-git|13bitcoin/06master 14e4ffcac 15MarcoFalke: Merge #12494: Declare CMutableTransaction a struct in rawtransaction.h...
20 2018-02-21 20:46:35	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12494: Declare CMutableTransaction a struct in rawtransaction.h (06master...06mutabletransaction-struct) 02https://github.com/bitcoin/bitcoin/pull/12494
21 2018-02-21 22:01:08	0|promag|mryandao: I don't see any verbosity argument or flag
22 2018-02-21 22:04:17	0|bitcoin-git|13bitcoin/06master 14e4c924c 15Gregory Sanders: createmultisig no longer takes addresses
23 2018-02-21 22:04:17	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e4ffcacc2187...0e265916d1c6
24 2018-02-21 22:04:18	0|bitcoin-git|13bitcoin/06master 140e26591 15MarcoFalke: Merge #12503: [RPC] createmultisig no longer takes addresses...
25 2018-02-21 22:05:06	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12503: [RPC] createmultisig no longer takes addresses (06master...06createmultikey) 02https://github.com/bitcoin/bitcoin/pull/12503
26 2018-02-21 22:38:56	0|mryandao|promag: getrawmempool ( verbose )
27 2018-02-21 22:39:29	0|mryandao|getmempoolancestors txid (verbose)
28 2018-02-21 22:39:48	0|mryandao|the only RPC command without the verbosity argument is getmempoolentry.
29 2018-02-21 22:39:59	0|mryandao|for all the getmempool* rpc commands
30 2018-02-21 23:08:33	0|bitcoin-git|[13bitcoin] 15sauldrod opened pull request #12506: Update new qt.mk download url (060.10...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12506
31 2018-02-21 23:15:23	0|mryandao|promag: did you see what I posted? ^
32 2018-02-21 23:16:05	0|promag|no
33 2018-02-21 23:16:16	0|promag|sorry
34 2018-02-21 23:16:41	0|mryandao|so w.r.t verbosity argument: there's getrawmempool (verbose), getmempoolancestors txid (verbose) and etc.
35 2018-02-21 23:16:44	0|mryandao|that was what I meant.
36 2018-02-21 23:17:36	0|mryandao|promag: ^
37 2018-02-21 23:20:43	0|promag|ah getmempoolentry doesn't have it
38 2018-02-21 23:21:04	0|mryandao|yeah, just that one.
39 2018-02-21 23:21:16	0|mryandao|i've updated the release notes again to exclude getmempoolentry.
40 2018-02-21 23:22:15	0|promag|ok, I was going to suggest to not mention that in the release note, it's a detail I guess, but others may think otherwise
41 2018-02-21 23:23:00	0|mryandao|have you had a look at the mempool_packages test already?
42 2018-02-21 23:23:46	0|promag|mryandao: could you point the test where the others rpcs are tested against getrawmempool?
43 2018-02-21 23:26:04	0|mryandao|give me a sec
44 2018-02-21 23:29:49	0|promag|tks
45 2018-02-21 23:32:40	0|mryandao|my clipboard is broken on this setup, so i'll just give you the line numbers in mempool_packages
46 2018-02-21 23:32:47	0|mryandao|T.T
47 2018-02-21 23:33:43	0|mryandao|promag, on master, in mempool_package, line 82 - 86 & 89 - 92
48 2018-02-21 23:34:16	0|mryandao|for getmempoolentry, line 63.
49 2018-02-21 23:42:31	0|promag|ty