1 2018-02-22 01:01:48	0|bitcoin-git|[13bitcoin] 15promag opened pull request #12507: Interrupt rescan on shutdown request (06master...062018-02-shutdown-on-rescan) 02https://github.com/bitcoin/bitcoin/pull/12507
  2 2018-02-22 02:21:43	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12506: Update new qt.mk download url (060.10...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12506
  3 2018-02-22 04:42:08	0|kallewoof|luke-jr: is #8471 still relevant?
  4 2018-02-22 04:42:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/8471 | Key origin metadata, with HD wallet support by luke-jr · Pull Request #8471 · bitcoin/bitcoin · GitHub
  5 2018-02-22 05:05:16	0|luke-jr|kallewoof: why wouldn't it be?
  6 2018-02-22 05:11:18	0|kallewoof|luke-jr: no response to BlueMatt's question asking the same thing. thought maybe you forgot about it.
  7 2018-02-22 05:25:46	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #12508: IsAllFromMe (06master...06feature-isallfromme) 02https://github.com/bitcoin/bitcoin/pull/12508
  8 2018-02-22 06:13:17	0|Randolf|I'm trying to squash my commits in Pull Request 12501 ( https://github.com/bitcoin/bitcoin/pull/12501 ), but when I attempt to do this the "git rebase -i HEAD~1" command seems to be working on the wrong Pull Request (which was already merged a while ago).
  9 2018-02-22 06:13:40	0|Randolf|I had trouble squashing my PR in the past, and I'm hoping someone can help me figure this out.  Thanks in advance.
 10 2018-02-22 06:17:21	0|Randolf|It seems that git is trying to squash PR 12125.
 11 2018-02-22 06:33:26	0|kallewoof|Randolf: git status first line which branch does it say?
 12 2018-02-22 06:34:37	0|Randolf|The "git status" command returns:  On branch master
 13 2018-02-22 06:35:13	0|kallewoof|Randolf: do git checkout patch-2, then git rebase -i HEAD~1
 14 2018-02-22 06:35:35	0|Randolf|Oh, okay, I'll try that then.
 15 2018-02-22 06:39:08	0|Randolf|changes.  Is this normal?
 16 2018-02-22 06:39:08	0|Randolf|Okay, so I actually have 3 commits now, so I used "git rebase -i HEAD~2" instead.  But, even though I only had two commits to squash, which I recognized as mine, I'm now seeing that two files will be included even though I only changed one file.  The other file's changes have nothing to do with my
 17 2018-02-22 06:39:47	0|Randolf|It's almost as if there are three commits involved in this.
 18 2018-02-22 06:39:49	0|kallewoof|That sounds wrong. What does git log show?
 19 2018-02-22 06:41:54	0|Randolf|I'm just trying to find the logs.  (I'm not quite sure what I'm looking for, but I don't see git.log.)
 20 2018-02-22 06:43:10	0|kallewoof|type: git log
 21 2018-02-22 06:44:24	0|Randolf|At the top of the screen I see this:  commit adb0c9e509a3bf1ccbfca5c8d04e9e150af566f7 (HEAD -> patch-2)
 22 2018-02-22 06:44:32	0|Randolf|Followed by:  Author: Jonas Schnelli <dev@jonasschnelli.ch>
 23 2018-02-22 06:44:43	0|Randolf|I'm "Randolf Richardson" though.
 24 2018-02-22 06:46:00	0|Randolf|Maybe if I delete and then clone it all in again.
 25 2018-02-22 06:46:02	0|kallewoof|wait, so this shows someone else's commit? git show HEAD
 26 2018-02-22 06:46:47	0|Randolf|Okay, so "git show HEAD" looks like my changes.
 27 2018-02-22 06:47:06	0|Randolf|But before mine I see this:  Bugfix: respect user defined configuration file (-conf) when open conf. file from QT settings
 28 2018-02-22 06:47:15	0|Randolf|Then the next line is from my PR:  [qt] Improved "custom fee" explanation in tooltip
 29 2018-02-22 06:47:20	0|kallewoof|Did you do 'git merge' by any chance?
 30 2018-02-22 06:47:24	0|Randolf|No.
 31 2018-02-22 06:47:40	0|Randolf|I'm new to git, but I was following the instructions at https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
 32 2018-02-22 06:48:03	0|kallewoof|Looks like you screwed up somewhere. Do this: git reset --hard origin/patch-2
 33 2018-02-22 06:48:18	0|Randolf|The "git checkout" stuff didn't work for me before, so I always had to use "git clone" to get the files in.
 34 2018-02-22 06:48:21	0|Randolf|I'll try that.
 35 2018-02-22 06:50:01	0|kallewoof|Getting spammy, let's do PMs.
 36 2018-02-22 06:50:03	0|Randolf|After "Rebasing (2/2)" I'm still seeing the wrong PR:  [detached HEAD ac6368aa1] Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings
 37 2018-02-22 06:50:05	0|gribble|https://github.com/bitcoin/bitcoin/issues/12489 | Bugfix: respect user defined configuration file (-conf) in QT settings by jonasschnelli · Pull Request #12489 · bitcoin/bitcoin · GitHub
 38 2018-02-22 07:14:25	0|Randolf|Thanks for all your help kallewoof.  I appreciate it.
 39 2018-02-22 07:18:29	0|bitcoin-git|13bitcoin/06master 14d2ee6e3 15Wladimir J. van der Laan: init: Remove translation for `-blockmaxsize` option help...
 40 2018-02-22 07:18:29	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0e265916d1c6...4528f74fc202
 41 2018-02-22 07:18:30	0|bitcoin-git|13bitcoin/06master 144528f74 15Wladimir J. van der Laan: Merge #12487: init: Remove translation for `-blockmaxsize` option help...
 42 2018-02-22 07:19:23	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12487: init: Remove translation for `-blockmaxsize` option help (06master...062018_02_translation_nightmare) 02https://github.com/bitcoin/bitcoin/pull/12487
 43 2018-02-22 14:45:25	0|bitcoin-git|[13bitcoin] 15ahmetanbar opened pull request #12509: describtion bitcoin (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12509
 44 2018-02-22 14:47:13	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12509: describtion bitcoin (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12509
 45 2018-02-22 14:48:30	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #12510: test: Add rpc_bind test to default-run tests (06master...062018_02_reinstate_rpcbind_test) 02https://github.com/bitcoin/bitcoin/pull/12510
 46 2018-02-22 14:50:26	0|bitcoin-git|[13bitcoin] 15morcos closed pull request #9167: IsAllFromMe (06master...06IsAllFromMe) 02https://github.com/bitcoin/bitcoin/pull/9167
 47 2018-02-22 15:05:10	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4528f74fc202...aae64a21ba25
 48 2018-02-22 15:05:11	0|bitcoin-git|13bitcoin/06master 14835a21b 15MarcoFalke: Squashed 'src/leveldb/' changes from c521b3ac65..64052c76c5...
 49 2018-02-22 15:05:11	0|bitcoin-git|13bitcoin/06master 14faa6dd2 15MarcoFalke: Bump leveldb subtree
 50 2018-02-22 15:05:12	0|bitcoin-git|13bitcoin/06master 14aae64a2 15Wladimir J. van der Laan: Merge #12451: Bump leveldb subtree...
 51 2018-02-22 15:06:01	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12451: Bump leveldb subtree (06master...06Mf1802-leveldbSubtreeBump) 02https://github.com/bitcoin/bitcoin/pull/12451
 52 2018-02-22 17:30:41	0|arubi|a plea for some more review again : #12321
 53 2018-02-22 17:30:42	0|gribble|https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh and p2sh-p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
 54 2018-02-22 18:27:33	0|provoostenator|These instructions are outdated, right? Except for cases where bumpfee doesn't work: https://en.bitcoin.it/wiki/Fee_bumping#I_sent_the_stuck_transaction
 55 2018-02-22 18:30:04	0|Randolf|provoostenator:  I can help with updating them.
 56 2018-02-22 18:30:16	0|Randolf|What needs to be changed?
 57 2018-02-22 18:30:46	0|provoostenator|It should increase instructions on how to use the `bumpfee` RPC method.
 58 2018-02-22 18:30:50	0|wumpus|it's still valid as a worst-case fallback, I guess, if bumpfee doesn't work
 59 2018-02-22 18:31:18	0|provoostenator|That could go on top. The rest would be valid still.
 60 2018-02-22 18:31:28	0|provoostenator|Although I think ther'es a command to purge the mempool now.
 61 2018-02-22 18:32:03	0|provoostenator|And maybe there's a way to make it stop listening that doesn't involve confguring a fake proxy?
 62 2018-02-22 18:32:14	0|wumpus|-nolisten -noconnect would do it
 63 2018-02-22 18:32:29	0|Randolf|Well, we could leave the instructions for 0.13.2 on there as is, and add instructions for newer versions.
 64 2018-02-22 18:32:33	0|provoostenator|Anyway, I'm going to try these manual steps myself to motivate me to pay more attention to RBF related tickets...
 65 2018-02-22 18:33:04	0|Randolf|provoostenator:  If you don't have edit access to that page, just let me know and I'd be happy to help with adding some instructions.
 66 2018-02-22 18:34:07	0|Randolf|...then we can also include wumpus' point with the older instructions and note that they can also serve as a worst-case fallback.
 67 2018-02-22 18:34:52	0|provoostenator|I would just relay on RPC methods that work for 0.16, maybe link back to an old version of the page. Too much text makes it look even more daunting than it is.
 68 2018-02-22 18:35:02	0|provoostenator|relay -> rely
 69 2018-02-22 18:35:06	0|wumpus|provoostenator: -persistmempool=0 will stop reading the mempool at startup (and writing it back), should be preferable to deleting the mempool file if it's supposed to be temporary, otoh that'd bring back the old mempool with the old transaction so I'm not sure
 70 2018-02-22 18:35:26	0|Randolf|provoostenator:  That's a good idea.
 71 2018-02-22 18:35:57	0|provoostenator|wumpus: I don't think we should rely on launch flags, as those are really hard to use for QT users
 72 2018-02-22 18:36:16	0|wumpus|supporting 0.15+ should be ok, 0.16 is still way too new
 73 2018-02-22 18:36:17	0|provoostenator|But I guess the current instructions already do that...
 74 2018-02-22 18:36:26	0|wumpus|provoostenator: there's no other way
 75 2018-02-22 18:36:47	0|provoostenator|0.15 users probably didn't set the RBF flag anyway
 76 2018-02-22 18:37:26	0|provoostenator|But I agree the instructions should cover that version too.
 77 2018-02-22 18:58:25	0|provoostenator|I used the following approach: quit QT, start with -persistmempool=0 and immedidately disconnect using the network icon. Make new transaction as per 11&12. Maybe unneeded: copy raw transaction connect again and use sendrawtransaction. Quit and relaunch normally.
 78 2018-02-22 19:00:18	0|wumpus|meeting?
 79 2018-02-22 19:00:45	0|Randolf|provoostenator:  If you can provide some specific instructions, then I'd be happy to put them up onto the wiki.
 80 2018-02-22 19:01:04	0|Randolf|wumpus:  Oh, yeah, it is that time of the week!  :)
 81 2018-02-22 19:01:10	0|lightningbot|Meeting started Thu Feb 22 19:01:09 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
 82 2018-02-22 19:01:10	0|lightningbot|Useful Commands: #action #agreed #help #info #idea #link #topic.
 83 2018-02-22 19:01:10	0|wumpus|#startmeeting
 84 2018-02-22 19:01:22	0|wumpus|Randolf: for a moment I thought I was confused :)
 85 2018-02-22 19:01:30	0|promag|hi
 86 2018-02-22 19:01:35	0|wumpus|#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
 87 2018-02-22 19:01:36	0|Randolf|Well, the weekend is on its way.
 88 2018-02-22 19:01:51	0|Randolf|Hello promag.
 89 2018-02-22 19:01:54	0|cfields|hi
 90 2018-02-22 19:01:55	0|wumpus|I've been sick this week so didn't do much
 91 2018-02-22 19:02:10	0|provoostenator|Obvious topic suggestion: ship 0.16?
 92 2018-02-22 19:02:13	0|wumpus|how is rc4 doing?
 93 2018-02-22 19:02:17	0|promag|take care wumpus
 94 2018-02-22 19:02:31	0|cfields|wumpus: sorry to hear :(
 95 2018-02-22 19:02:32	0|Randolf|For me, rc4 is still synchronizing the blockchain.  It seems fine though.
 96 2018-02-22 19:02:57	0|wumpus|cfields: promag: thanks, it's getting better at least
 97 2018-02-22 19:03:28	0|wumpus|no new reported issues with it?
 98 2018-02-22 19:03:53	0|wumpus|then yay, I'd say let's tag final after the meeting
 99 2018-02-22 19:04:12	0|BlueMatt|regressions? no, issues still cropping up in 0.15.1 :/
100 2018-02-22 19:04:35	0|achow101|hello
101 2018-02-22 19:05:07	0|achow101|yay
102 2018-02-22 19:05:21	0|wumpus|there's lots of already existing issues, but if we had to wait for all 599  of them to be closed before a release we should postpone it for a few years at least
103 2018-02-22 19:05:29	0|BlueMatt|yes
104 2018-02-22 19:05:44	0|BlueMatt|I was not suggesting delaying 0.16, only commenting
105 2018-02-22 19:05:48	0|wumpus|or a billion years maybe, it seems the number is only ever increasing
106 2018-02-22 19:05:57	0|wumpus|any proposed topics?
107 2018-02-22 19:05:59	0|BlueMatt|though I dont like #12498
108 2018-02-22 19:06:01	0|gribble|https://github.com/bitcoin/bitcoin/issues/12498 | bitcoin-qt crashes after clearing proxy info · Issue #12498 · bitcoin/bitcoin · GitHub
109 2018-02-22 19:06:06	0|BlueMatt|havent looked into it yet, only just noticed it
110 2018-02-22 19:06:29	0|BlueMatt|anyway, topics are mostly "submit topics for coredev.tech" :p
111 2018-02-22 19:06:42	0|Randolf|Someone reported trouble importing an Electrum Private Key into 0.16 in issue #12397 but it looks like it may be resolved.
112 2018-02-22 19:06:43	0|gribble|https://github.com/bitcoin/bitcoin/issues/12397 | Unable to import Electrum private key to 0.16.0 · Issue #12397 · bitcoin/bitcoin · GitHub
113 2018-02-22 19:07:21	0|wumpus|BlueMatt: I remember a vaguely similar issue being solved recently, might be that that is already fixed in 0.16
114 2018-02-22 19:07:28	0|BlueMatt|fair
115 2018-02-22 19:08:19	0|wumpus|e.g. #11809
116 2018-02-22 19:08:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/11809 | gui: Fix proxy setting options dialog crash by laanwj · Pull Request #11809 · bitcoin/bitcoin · GitHub
117 2018-02-22 19:08:50	0|BlueMatt|Randolf: that issue is colsed after discussion
118 2018-02-22 19:09:43	0|Randolf|BlueMatt:  That's good.  (GitHub is showing me that it's open.)
119 2018-02-22 19:10:12	0|Randolf|Now it shows closed.
120 2018-02-22 19:10:29	0|BlueMatt|so sounds like no topic
121 2018-02-22 19:10:31	0|BlueMatt|s
122 2018-02-22 19:10:35	0|BlueMatt|meeting over?
123 2018-02-22 19:10:40	0|BlueMatt|tag 16
124 2018-02-22 19:10:41	0|wumpus|seems so
125 2018-02-22 19:10:57	0|adiabat|that was quick
126 2018-02-22 19:11:23	0|BlueMatt|everyone is saving their topics for coredev.tech, I guess
127 2018-02-22 19:11:33	0|provoostenator|Maybe wait 4 more minutes for topic suggestions?
128 2018-02-22 19:11:47	0|BlueMatt|we've already waited 10
129 2018-02-22 19:11:51	0|BlueMatt|I think thats sufficient
130 2018-02-22 19:11:52	0|wumpus|is there some illuminati meeting going on right now? where is everybody :D
131 2018-02-22 19:12:03	0|BlueMatt|yes, sipa is currently explaining musigs
132 2018-02-22 19:12:14	0|Murch|NYC ;)
133 2018-02-22 19:12:19	0|BlueMatt|so MarcoFalke morcos sdaftuar_ ryanofsky and jnewbery are all busy
134 2018-02-22 19:12:26	0|achow101|what's going on in nyc?
135 2018-02-22 19:12:26	0|Murch|Some others might already be traveling for Financial Crypto?
136 2018-02-22 19:12:31	0|Murch|Residency
137 2018-02-22 19:12:33	0|wumpus|okay, yes then it makes sense to close early
138 2018-02-22 19:12:36	0|achow101|oh
139 2018-02-22 19:12:56	0|Murch|achow101: I'll try to give your PR a full review before CoreDev.Tech
140 2018-02-22 19:13:59	0|lightningbot|Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-22-19.01.log.html
141 2018-02-22 19:13:59	0|lightningbot|Meeting ended Thu Feb 22 19:13:58 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
142 2018-02-22 19:13:59	0|lightningbot|Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-22-19.01.html
143 2018-02-22 19:13:59	0|lightningbot|Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-22-19.01.txt
144 2018-02-22 19:13:59	0|wumpus|#endmeeting
145 2018-02-22 19:14:14	0|Randolf|Such a useful bot.  :)
146 2018-02-22 19:16:21	0|wumpus|yes it is
147 2018-02-22 19:17:01	0|provoostenator|Should I hold my finger on the gitian build trigger?
148 2018-02-22 19:20:04	0|promag|wumpus: is there a merge queue? :P
149 2018-02-22 19:20:15	0|wumpus|merge queue?
150 2018-02-22 19:21:33	0|wumpus|I haven't been able to pay attention at least, if there's something ready for merge let me know (although right now I'm busy doing last minute checks for 0.16)
151 2018-02-22 19:22:17	0|bitcoin-git|13bitcoin/060.16 144b4d7eb 15Wladimir J. van der Laan: doc: Remove note about temporary file from release notes...
152 2018-02-22 19:22:17	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/4b4d7eb255ca8f9a94b92479e6061d129c91a991
153 2018-02-22 19:22:19	0|promag|ok, so in a couple of days we can clean some easy prs? there are a couple already with (ut)acks
154 2018-02-22 19:22:45	0|wumpus|why in a couple of days?
155 2018-02-22 19:23:00	0|wumpus|is there something special going on?
156 2018-02-22 19:23:38	0|jtimon|right, you can tell him which ones now, even if he keeps checking 0.16 first
157 2018-02-22 19:23:42	0|promag|oh no.. "couple of hours then"?
158 2018-02-22 19:23:51	0|wumpus|if it's up to me I'd prefer merging non-easy PRs with enough utACKs
159 2018-02-22 19:27:40	0|wumpus|* [new tag]         v0.16.0 -> v0.16.0
160 2018-02-22 19:27:53	0|wumpus|provoostenator: yep
161 2018-02-22 19:27:58	0|achow101|yay! \o/
162 2018-02-22 19:32:26	0|sipa|~w00000t
163 2018-02-22 19:35:03	0|Randolf|In PR #12501 I've made an attempt to improve the wording in a tooltip (I don't consider this to be a high-priority fix).  We're at a point now where I need to know whether transaction fees below the threshold are apportioned or simply counted as 1k as there seem to be two different opinions on the
164 2018-02-22 19:35:05	0|gribble|https://github.com/bitcoin/bitcoin/issues/12501 | [qt] Improved "custom fee" explanation in tooltip by randolf · Pull Request #12501 · bitcoin/bitcoin · GitHub
165 2018-02-22 19:36:23	0|wumpus|Randolf: which threshold?
166 2018-02-22 19:37:06	0|Randolf|matter.  Any insight into this would be appreciated.
167 2018-02-22 19:37:30	0|sipa|Randolf: fee calculations are always done per byte
168 2018-02-22 19:38:15	0|wumpus|right, there is no minimum absolute fee threshold
169 2018-02-22 19:38:25	0|sipa|feerates are expressed per kB, but if the feerate is 3000 sat/kB, and the transaction is 500 (v)bytes, the fee will be 1500 sat
170 2018-02-22 19:44:40	0|Randolf|sipa:  Okay, that's very helpful -- thank you.  I will update the wording accordingly and push another commit today then.
171 2018-02-22 19:45:12	0|Randolf|I want to make sure that the tooltip will be user-friendly, clear, and concise without introducing confusion.
172 2018-02-22 19:46:12	0|wumpus|yes, thanks, it's good to document things clearly and correctly
173 2018-02-22 19:48:48	0|instagibbs|\o/ *cough* in central us timezone
174 2018-02-22 19:48:53	0|instagibbs|off by one error
175 2018-02-22 19:57:13	0|esotericnonsense|wumpus |  * [new tag]         v0.16.0 -> v0.16.0 \o/
176 2018-02-22 20:00:18	0|jonasschnelli_|Oh. Did i miss the meeting again?!
177 2018-02-22 20:00:48	0|jonasschnelli_|Thought its now
178 2018-02-22 20:07:48	0|jonasschnelli|it's hard to participate when you are in UTC+8
179 2018-02-22 20:14:57	0|aj|jonasschnelli: UTC+10 isn't easy either, though lack of DST is at least a win
180 2018-02-22 20:15:47	0|jonasschnelli|aj: yes. indeed.
181 2018-02-22 21:35:43	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12512: Don't test against the mempool min fee information in mempool_limit.py (06master...06fix-min-fee-test) 02https://github.com/bitcoin/bitcoin/pull/12512
182 2018-02-22 21:46:33	0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #11226: [WIP] Add Clang thread safety analysis annotations: GUARDED_BY(lock) / EXCLUSIVE_LOCKS_REQUIRED(lock) (06master...06guarded-by-trivial) 02https://github.com/bitcoin/bitcoin/pull/11226