1 2018-02-23 00:42:30 0|mryandao|has anyone looked at https://help.github.com/articles/about-codeowners/ for the bitcoin core repo?
2 2018-02-23 01:15:38 0|bitcoin-git|[13bitcoin] 15khorben opened pull request #12513: Scripts and tools: Portability fix for the configure scripts generated (06master...06khorben/configure-portability) 02https://github.com/bitcoin/bitcoin/pull/12513
3 2018-02-23 01:38:38 0|meshcollider|mryandao: who would be set as owner of any file though? Maybe sipa as the bech32.cpp file but its probably not that useful in our case?
4 2018-02-23 01:38:59 0|meshcollider|Since anyone can review anything, and there are only like 5 people with write access
5 2018-02-23 01:40:23 0|mryandao|oh i thought the owners could be the 5 people with write access
6 2018-02-23 01:41:17 0|mryandao|it just provides extra feedback
7 2018-02-23 01:41:26 0|meshcollider|mryandao: then they'd be requested for review for all files, would just be a pain I think :)
8 2018-02-23 01:42:10 0|meshcollider|Places too much emphasis on the maintainers control of the repo too imo
9 2018-02-23 03:11:32 0|GitHub170|[13bitcoin-detached-sigs] 15jonasschnelli opened pull request #5: 0.16: osx signatures for 0.16.0 (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/5
10 2018-02-23 03:26:15 0|esotericnonsense|i'm looking at the boost signals to get a handle on what exactly validationinterface is doing.
11 2018-02-23 03:27:10 0|esotericnonsense|so my understanding is that these boost.signals2 things are just 'callback managers' you can register a number of callbacks with them, when you 'fire' a signal you're just executing those functions serially wherever you are right now.
12 2018-02-23 03:29:07 0|esotericnonsense|i haven't knocked them all off yet but NewPoWValidBlock seems to only be used in one place yet has a lot of boilerplate. some others are used "once" plus zmq as well. it feels like a lot of boilerplate, am I missing something or is it just kind of a historical quirk and/or 'here's an extension point'?
13 2018-02-23 03:29:40 0|cfields|michagogo: uh oh, mismatches
14 2018-02-23 03:31:52 0|cfields|michagogo: any idea what's up with that?
15 2018-02-23 03:33:44 0|cfields|wumpus: I'm going to hold off on signing for Win until we figure out what's going on there, or get a bunch more matching sigs
16 2018-02-23 05:22:41 0|midnightmagic|I am attempting to find some additional triangulation for all the new gpg keys doing gitian builds -- sjorsnado, meshcollider, is there somewhere else you've published your key that I could triangulate on? A twitter bio.. or .. ?
17 2018-02-23 05:23:10 0|midnightmagic|also, are akx20000, fivepiece, and wampy "known" to peeps in here?
18 2018-02-23 05:23:30 0|midnightmagic|nvm I found wampy
19 2018-02-23 05:24:26 0|meshcollider|midnightmagic: keybase.io work? https://keybase.io/meshcollider/pgp_keys.asc?fingerprint=ca03882cb1fc067b5d3acfe4d300116e1c875a3d or my github.io site? https://meshcollider.github.io/meshcollider-key.pgp
20 2018-02-23 05:24:37 0|midnightmagic|meshcollider: course. thanks.
21 2018-02-23 05:24:44 0|meshcollider|building 0.16 as we speak btw
22 2018-02-23 05:24:57 0|midnightmagic|-- catching up, still on rc3.
23 2018-02-23 05:47:37 0|midnightmagic|drat my rc3 gitian isn't matching up.
24 2018-02-23 05:48:46 0|CubicEarths|midnightmagic: You gonna build rc4 before final?
25 2018-02-23 05:48:52 0|midnightmagic|yes.
26 2018-02-23 05:49:04 0|CubicEarths|for archival purposes?
27 2018-02-23 05:49:10 0|midnightmagic|I'm gonna wait to even bother tracking it down until final succeeds/fails.
28 2018-02-23 05:49:31 0|midnightmagic|for completeness' sake. I always do it this way.
29 2018-02-23 05:53:15 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12513: Scripts and tools: Portability fix for the configure scripts generated (06master...06khorben/configure-portability) 02https://github.com/bitcoin/bitcoin/pull/12513
30 2018-02-23 06:37:01 0|meshcollider|well my 0.16 is done and matches all except michagogo too
31 2018-02-23 06:38:04 0|meshcollider|but michagogo's had a number of mismatches in the past too https://github.com/bitcoin-core/gitian.sigs/issues/658
32 2018-02-23 07:12:28 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12516: Avoid unintentional unsigned integer wraparounds in tests (06master...06unsigned-integer-wraparounds-in-tests) 02https://github.com/bitcoin/bitcoin/pull/12516
33 2018-02-23 07:39:33 0|arubi|<- fivepiece . gonna build a bit later on when I can free resources for the vm
34 2018-02-23 07:39:42 0|arubi|midnightmagic,
35 2018-02-23 07:51:35 0|bobby__|hi guys, am I right here to ask question in regards of creating a p2sh transaction?
36 2018-02-23 07:58:14 0|mmgen|bobby__: that's more a question for #bitcoin
37 2018-02-23 07:58:33 0|mmgen|bobby__: or #bitcoin-dev
38 2018-02-23 08:01:55 0|bobby__|ok cool, thanks
39 2018-02-23 08:32:54 0|midnightmagic|arubi: Oh! oh wxcellent. where do I find your key, outside of the key servers..?
40 2018-02-23 08:34:05 0|arubi|midnightmagic, I don't think it's out there anywhere. belcher has it from me and not a keyserver
41 2018-02-23 08:34:35 0|midnightmagic|okay I'll go bug him. \o
42 2018-02-23 08:34:43 0|arubi|well, from me on email, not me irl :)
43 2018-02-23 10:37:00 0|provoostenator|midnightmagic there's rumors of a key signing party in a few weeks. I've used for signing releases for the Blockchain wallet back in the day for at least a year. It's on my Twitter profile. I should put it on my slides next time I give a presentation...
44 2018-02-23 10:37:47 0|wumpus|cfields: agreed, good call
45 2018-02-23 10:39:07 0|wumpus|mryandao: I didn't know about the CODEOWNERS feature, will take a look
46 2018-02-23 10:46:16 0|midnightmagic|provoostenator: thanks!
47 2018-02-23 10:51:06 0|wumpus|mryandao: something that suggests automatically reviewers for a piece of code would be useful, they've had suggestion based on the last persons to touch the code for a while, but this seems a more formal scheme
48 2018-02-23 10:51:33 0|wumpus|(akin to MAINTAINERS in linux kernel and such)
49 2018-02-23 11:09:36 0|wumpus|ooh you can even assign certain file types to a certain reviewer
50 2018-02-23 11:12:49 0|wumpus|that could be useful to have a specific reviewer for build files, documentation, icons, etc
51 2018-02-23 11:18:50 0|wumpus|esotericnonsense: "so my understanding is that these boost.signals2 things are just 'callback managers' " yes - boost signals are an implementation of signals/slots pattern, similar to that in qt and 'delegates' in some other languages, it is a generic pattern for decoupling the sender of an event from the handler
52 2018-02-23 11:20:19 0|wumpus|one-to-many broadcasting within the thread/address space
53 2018-02-23 11:23:35 0|wumpus|we're kind of in the middle of getting rid of it, in favor of more convential c++ish dispatch using interfaces
54 2018-02-23 11:25:52 0|booyah|wumpus: why get rid of it?
55 2018-02-23 11:27:01 0|wumpus|apart from the general move away from boost, performance reasons, and annoying debugging due to huge tracebacks due to all the templating high magic happening in boost
56 2018-02-23 12:36:28 0|michagogo|cfields: really? Thatââ¬â¢s odd.
57 2018-02-23 12:36:46 0|michagogo|One sec, Iââ¬â¢ll get them out to see whatââ¬â¢s going on.
58 2018-02-23 12:47:39 0|michagogo|https://1drv.ms/f/s!AvCguGMVwWzLgxcDhVPN2iRMdHNQ
59 2018-02-23 12:47:53 0|michagogo|As soon as it finishes uploading the results will be here
60 2018-02-23 16:08:25 0|bitcoin-git|13bitcoin/06master 1442e1b5d 15Karl-Johan Alm: [test] Round target fee to 8 decimals in assert_fee_amount...
61 2018-02-23 16:08:25 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/aae64a21ba25...8c33961313d9
62 2018-02-23 16:08:26 0|bitcoin-git|13bitcoin/06master 148c33961 15Wladimir J. van der Laan: Merge #12486: [test] Round target fee to 8 decimals in assert_fee_amount...
63 2018-02-23 16:09:24 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12486: [test] Round target fee to 8 decimals in assert_fee_amount (06master...06round-assert-fee-amount-target-fee) 02https://github.com/bitcoin/bitcoin/pull/12486
64 2018-02-23 16:13:13 0|AndyS2|if I have a CPubKey via GetPubKey() and I do a Hash(pubkey.begin(), pubkey.end()) on it I'm not getting the right hash (I'm using http://gobittest.appspot.com/Address to compare). What function should I use to hash a pubkey with SHA256, like bitcoin core does it for addresses (in the first step)?
65 2018-02-23 16:13:48 0|bitcoin-git|13bitcoin/06master 14ac91ea6 15Henrik Jonsson: [depends] Allow depends system to support armv7l
66 2018-02-23 16:13:48 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8c33961313d9...28b8061d9f1c
67 2018-02-23 16:13:49 0|bitcoin-git|13bitcoin/06master 1428b8061 15Wladimir J. van der Laan: Merge #12474: [depends] Allow depends system to support armv7l...
68 2018-02-23 16:14:35 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12474: [depends] Allow depends system to support armv7l (06master...06fix-armv7-depends) 02https://github.com/bitcoin/bitcoin/pull/12474
69 2018-02-23 16:14:56 0|bitcoin-git|13bitcoin/060.16 14b0f692f 15Henrik Jonsson: [depends] Allow depends system to support armv7l...
70 2018-02-23 16:14:56 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/b0f692f81e22587ca98e893a6eb0b6246c5b62b0
71 2018-02-23 16:17:35 0|bitcoin-git|13bitcoin/06master 14fadb39c 15MarcoFalke: test: Plug memory leaks and stack-use-after-scope
72 2018-02-23 16:17:35 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/28b8061d9f1c...acd1e6155ca6
73 2018-02-23 16:17:36 0|bitcoin-git|13bitcoin/06master 14acd1e61 15Wladimir J. van der Laan: Merge #12477: test: Plug memory leaks and stack-use-after-scope...
74 2018-02-23 16:18:30 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12477: test: Plug memory leaks and stack-use-after-scope (06master...06Mf1802-qaMemLeaks) 02https://github.com/bitcoin/bitcoin/pull/12477
75 2018-02-23 16:21:14 0|wumpus|AndyS2: Hash160
76 2018-02-23 16:21:38 0|AndyS2|wumpus: but it's 256 first, 160 second, right?
77 2018-02-23 16:21:44 0|wumpus|or just GetID(), which does it for you
78 2018-02-23 16:22:38 0|AndyS2|wanted to play it through 'manually'. I only want the result after the first round, i.e. a single sha256 hash
79 2018-02-23 16:22:44 0|AndyS2|of the public key.
80 2018-02-23 16:22:50 0|wumpus|Hash160 is RIPEMD160(SHA256(x))
81 2018-02-23 16:23:11 0|AndyS2|I want SHA256(x)
82 2018-02-23 16:23:35 0|AndyS2|any chance to get that?
83 2018-02-23 16:23:59 0|wumpus|then use a SHA256? Hash and Hash160 are 'cooked' functions for the specific purposes in bitcoin
84 2018-02-23 16:24:26 0|wumpus|I'm sure there's low-level cryptography functions buried under there
85 2018-02-23 16:24:44 0|AndyS2|ah, I thought CHash256-stuff was for the bitcoin specific ones
86 2018-02-23 16:25:38 0|AndyS2|thanks. so hash.h only has the higher level but doesn't provide single hashes
87 2018-02-23 16:26:44 0|wumpus|right - crypto/sha256.h has the base algo, in CSHA256, it's named after the specific algorithm
88 2018-02-23 16:28:28 0|wumpus|hash.h is definitely bitcoin specific, apart from murmur and siphash I suppose
89 2018-02-23 16:29:15 0|AndyS2|I'll look at crypto/sha256.h then, thank you
90 2018-02-23 16:30:31 0|AndyS2|this all seems like stuff that's extremely obvious to people already familiar with the code, but to someone diving into it (and with sub-par c++ experience), he comments can be kind of misleading ^^
91 2018-02-23 16:30:35 0|AndyS2|*the comments
92 2018-02-23 16:31:39 0|wumpus|would have been borderline nicer to add low-level headers for murmur and siphash (analogous to sha256 and ripemd160) instead of embedding their interface into hash.h
93 2018-02-23 16:32:50 0|wumpus|feel free to improve the comments :) people familiar with the code likely read over them
94 2018-02-23 16:38:03 0|cfields|http://sf.snu.ac.kr/gil.hur/publications/crellvm.pdf
95 2018-02-23 16:38:30 0|cfields|I think it's too low-level to be useful for us, but still very interesting
96 2018-02-23 16:42:48 0|wumpus|cfields: right, it seems a method of checking compilers, not so much projects compiled in compilers. Indirectly useful to use if it increases the reliability of LLVM, of course.
97 2018-02-23 16:43:43 0|cfields|right. It'd be great if all compiler optims began shipping with correctness proofs :)
98 2018-02-23 16:45:14 0|wumpus|something like KLEE would be more useful if we want to do proofs about bitcoind itself
99 2018-02-23 16:46:00 0|wumpus|I agree. maybe after CPUs start shipping with correctness proofs
100 2018-02-23 16:46:53 0|cfields|heh
101 2018-02-23 16:47:29 0|wumpus|(that's not just joking, Clifford Wolf etc are working on that for RISC-V)
102 2018-02-23 16:48:40 0|cfields|oh really? that's awesome. My first thought was Intel and how fast their marketing dept. would shut that down due to non-determinism-as-a-feature
103 2018-02-23 16:49:21 0|cfields|I'll read up on the RISC-V work, that's exciting.
104 2018-02-23 16:57:31 0|wumpus|I agree, with Intel (and AMD) I wouldn't ever expect it, I'm sure they're doing all kinds of testing and verification, but no way they'll ever release such info to customers. Also not sure how realistic it is with all the cruft that x86 architecture has grown with level after level of backwards compatibility. ARM did release a machine-parseable architecture specification, that's neat.
105 2018-02-23 16:57:54 0|wumpus|yes many exciting things are happening in RISC-V
106 2018-02-23 17:35:31 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12518: [0.16] Bump leveldb subtree (060.16...06Mf1802-leveldbSubtreeBump) 02https://github.com/bitcoin/bitcoin/pull/12518
107 2018-02-23 17:40:19 0|bitcoin-git|13bitcoin/06master 14face722 15MarcoFalke: qa: Move common args to bitcoin.conf
108 2018-02-23 17:40:19 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/acd1e6155ca6...07090c533943
109 2018-02-23 17:40:20 0|bitcoin-git|13bitcoin/06master 1407090c5 15MarcoFalke: Merge #12443: qa: Move common args to bitcoin.conf...
110 2018-02-23 17:41:05 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12443: qa: Move common args to bitcoin.conf (06master...06Mf1802-qaCommonArgsToFile) 02https://github.com/bitcoin/bitcoin/pull/12443
111 2018-02-23 18:50:37 0|jojeyh|i've been git cloning to always get the newest version of bitcoin
112 2018-02-23 18:50:48 0|jojeyh|can i just git pull in my local /bitcoin repository
113 2018-02-23 18:51:02 0|jojeyh|to get 0.16.0
114 2018-02-23 19:13:03 0|jojeyh|for segwit, is voluntary malleability of a transaction possible still ?
115 2018-02-23 19:13:33 0|jojeyh|BIP141 only says segwit prevents involuntary malleability
116 2018-02-23 19:13:47 0|jojeyh|what are some possible voluntary malleabilities ?
117 2018-02-23 19:22:18 0|gmaxwell|Sure, you can still use sighash flags to set anyone can pay or whatever.
118 2018-02-23 19:29:35 0|jojeyh|cool
119 2018-02-23 19:30:31 0|jojeyh|can a transaction have multiple scriptPubKey ?
120 2018-02-23 19:33:01 0|jojeyh|nvm i need to read way more before i start asking questions
121 2018-02-23 19:33:03 0|jojeyh|will be back!
122 2018-02-23 19:33:10 0|belcher|the transaction could have multiple outputs, with a scriptPubKey in each
123 2018-02-23 19:33:17 0|belcher|also #bitcoin might be a better channel
124 2018-02-23 19:33:25 0|jojeyh|belcher, thx
125 2018-02-23 19:34:37 0|jojeyh|belcher, says i cannot join without being 'identified by services'
126 2018-02-23 19:34:54 0|jojeyh|'identified with services'
127 2018-02-23 19:35:10 0|jojeyh|is #bitcoin on freenode ?
128 2018-02-23 19:35:18 0|belcher|that's nickserv on freenode
129 2018-02-23 19:35:20 0|bitcoin-git|[13bitcoin] 15whitslack opened pull request #12519: Net: Pass MSG_MORE flag when sending non-final network messages (06master...06MSG_MORE) 02https://github.com/bitcoin/bitcoin/pull/12519
130 2018-02-23 19:35:30 0|belcher|read /msg NickServ help