1 2018-03-14 00:17:21 0|bitcoin-git|13bitcoin/06master 1433eb907 15Russell Yanofsky: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER...
2 2018-03-14 00:17:21 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0630974647da...18462960c0f1
3 2018-03-14 00:17:22 0|bitcoin-git|13bitcoin/06master 141846296 15MarcoFalke: Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER...
4 2018-03-14 00:18:10 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER (06master...06pr/locksmart) 02https://github.com/bitcoin/bitcoin/pull/12681
5 2018-03-14 00:19:06 0|bitcoin-git|[13bitcoin] 15sipa opened pull request #12683: Fix more constness violations in serialization code (06master...06201803_moreser) 02https://github.com/bitcoin/bitcoin/pull/12683
6 2018-03-14 01:30:09 0|tied2chainz|hi
7 2018-03-14 01:30:41 0|tied2chainz|just have a really quick question about version 16.
8 2018-03-14 01:32:55 0|sipa|tied2chainz: shoot
9 2018-03-14 01:33:12 0|sipa|(and generally just ask, don't ask to ask)
10 2018-03-14 01:34:18 0|Randolf|(Slow questions are okay too.)
11 2018-03-14 01:35:16 0|tied2chainz|wanted to know can I also lookup transactions outside of send and receive transactions.
12 2018-03-14 01:35:23 0|sipa|no
13 2018-03-14 01:35:57 0|tied2chainz|only transactions that I've received or sent through my wallet
14 2018-03-14 01:36:10 0|sipa|unless you enable the transaction index (run with -txindex, or put txindex=1 in bitcoin.conf; that will enable the getrawtransaction txid RPC which works for all transactions, not just your own)
15 2018-03-14 01:36:52 0|sipa|it will require a full rebuild of the database though, and slows things down significantly
16 2018-03-14 01:37:41 0|tied2chainz|yeah thanks for the heads
17 2018-03-14 01:37:46 0|eklitzke|interesting, somehow i corrupted my chainstate directory
18 2018-03-14 01:37:48 0|tied2chainz|thanks for the heads up
19 2018-03-14 01:38:15 0|sipa|eklitzke: what did you do?
20 2018-03-14 01:41:00 0|kallewoof|tied2chainz: You can look them up if you know the block hash they're in.
21 2018-03-14 01:41:21 0|kallewoof|tied2chainz: Even without -txindex.
22 2018-03-14 01:41:39 0|eklitzke|https://paste.fedoraproject.org/paste/QsExxEOQwQOAGqT1rvPkAw
23 2018-03-14 01:41:52 0|eklitzke|it looks like it shut down normally
24 2018-03-14 01:41:57 0|eklitzke|and then the next time i tried to start it
25 2018-03-14 01:42:01 0|eklitzke|corrupted database
26 2018-03-14 01:43:20 0|sipa|eklitzke: wow, with a clean shutdown? :S
27 2018-03-14 01:43:38 0|eklitzke|this is actually on v0.16.0, not from my branches
28 2018-03-14 01:43:40 0|eklitzke|hmm
29 2018-03-14 01:44:06 0|eklitzke|interesting, well i had been asking users if they could give me corrupted database files, looks like i got what i was asking for
30 2018-03-14 01:48:55 0|kallewoof|Am I right that signmessage <addr> leaks the public key of <addr> in the resulting signature?
31 2018-03-14 01:49:18 0|kallewoof|s/leaks/exposes/ I guess.
32 2018-03-14 01:51:36 0|eklitzke|actually i remember now what i was doing, the last thing i had been doing with this was running my python utxo scanning script on the data directory
33 2018-03-14 01:51:46 0|eklitzke|s/data directory/chainstate directory/
34 2018-03-14 01:51:58 0|eklitzke|which uses the python leveldb bindings
35 2018-03-14 01:52:15 0|eklitzke|i thought i had the daemon stopped but i guess i could have had it running
36 2018-03-14 01:52:19 0|eklitzke|hopefully i can reproduce
37 2018-03-14 01:55:56 0|tecneecs|sup bitcoin?
38 2018-03-14 02:06:02 0|sipa|kallewoof: every ECDSA signature leaks the pubkey (almost)
39 2018-03-14 02:17:11 0|bitcoin-git|[13bitcoin] 15sipa pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/18462960c0f1...6acd8700bc0e
40 2018-03-14 02:17:12 0|bitcoin-git|13bitcoin/06master 14a128bdc 15Russell Yanofsky: [wallet] Construct CWalletTx objects in CommitTransaction...
41 2018-03-14 02:17:12 0|bitcoin-git|13bitcoin/06master 14b4bc32a 15Russell Yanofsky: [wallet] Get rid of CWalletTx default constructor...
42 2018-03-14 02:17:13 0|bitcoin-git|13bitcoin/06master 146acd870 15Pieter Wuille: Merge #9680: Unify CWalletTx construction...
43 2018-03-14 02:17:43 0|kallewoof|sipa: Well, it's sorta like spending an UTXO vs handing out the pubkey for its PKH. One seems worse than the other (though only a little).
44 2018-03-14 02:18:59 0|sipa|kallewoof: but regardless, you can't create a signature without revealing the public key
45 2018-03-14 02:20:48 0|kallewoof|Yeah, I was initially very confused about how verifymessage could pull it off with only an address, until I realized the signature had a recoverable pubkey in it.
46 2018-03-14 02:21:30 0|kallewoof|It struck me that people may not realize they are revealing the pubkey when they signmessage a utxo. Clearly as you say, you need the pubkey to verify the sig.
47 2018-03-14 02:22:09 0|kallewoof|Perhaps it doesn't really matter that you show the pubkey (long) before spending.
48 2018-03-14 02:27:07 0|luke-jr|kallewoof: hopefully when someone gets around to replacing signmessage, it can be MAST-based with a separate key for messages
49 2018-03-14 02:32:18 0|kallewoof|luke-jr: Interesting. I'll have to think about how that would work.
50 2018-03-14 02:32:57 0|sipa|kallewoof: well a decent replacement for signmessage would be something that just uses script
51 2018-03-14 02:33:08 0|sipa|(but signs something else than a tx)
52 2018-03-14 02:33:31 0|sipa|that would automatically support any kind of output type
53 2018-03-14 02:42:59 0|kallewoof|sipa: That makes sense, yeah.
54 2018-03-14 02:46:07 0|meshcollider|Wasn't someone already working on a BIP draft for an improved signmessage, or am I imagining things
55 2018-03-14 02:46:30 0|kallewoof|sipa: Presumably it would sign H(addr||message). Not sure if addr is strictly necessary though.
56 2018-03-14 02:59:12 0|luke-jr|meshcollider: at one point, someone was talking about it at least
57 2018-03-14 03:07:48 0|sipa|kallewoof: yup, this is the way to fix it
58 2018-03-14 03:13:23 0|mrjenkins|hello!
59 2018-03-14 03:14:06 0|mrjenkins|why does github repo say that the build is failing?
60 2018-03-14 03:14:37 0|mrjenkins|does the build is really failing?
61 2018-03-14 05:10:43 0|pierre_rochard|mrjenkins https://github.com/bitcoin/bitcoin shows the build is passing
62 2018-03-14 07:05:05 0|fanquake|If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds?
63 2018-03-14 07:21:31 0|sipa|fanquake: what PR are you referring to?
64 2018-03-14 07:22:23 0|eklitzke|sipa: for #12683 did you do this manually or have a tool identify the temporary references?
65 2018-03-14 07:22:26 0|gribble|https://github.com/bitcoin/bitcoin/issues/12683 | Fix more constness violations in serialization code by sipa ÷ Pull Request #12683 ÷ bitcoin/bitcoin ÷ GitHub
66 2018-03-14 07:22:29 0|eklitzke|this is an interesting change
67 2018-03-14 07:24:15 0|sipa|eklitzke: there are only 2 dozen calls of REF, some are there as arguments to one of the wrappers (which aren't fixed yet), and some are around the wrappers (which are fixed now)
68 2018-03-14 07:24:20 0|sipa|it's quite mechanical
69 2018-03-14 07:25:03 0|sipa|eklitzke: #10785 has many more things like this
70 2018-03-14 07:25:08 0|gribble|https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa ÷ Pull Request #10785 ÷ bitcoin/bitcoin ÷ GitHub
71 2018-03-14 07:25:55 0|eklitzke|neat, i'll take a look at that too
72 2018-03-14 07:34:16 0|kallewoof|fanquake: Don't know if you're referring to me, but I may be guilty of doing that. I'll try to think of whether it's worth it with the amount of ACKs for current state in the future.
73 2018-03-14 09:14:16 0|pierre_rochard|achow101: Iââ¬â¢m taking a look at #12375 - do you have a fix in the works? I just implemented Akioââ¬â¢s solution and it works, though Iââ¬â¢d like to do more research before letting a platform-specific issue add what feels like cruft.
74 2018-03-14 09:14:17 0|gribble|https://github.com/bitcoin/bitcoin/issues/12375 | wallet_encryption.py fails on macos ÷ Issue #12375 ÷ bitcoin/bitcoin ÷ GitHub
75 2018-03-14 09:24:16 0|bitcoin-git|[13bitcoin] 15bill-walker closed pull request #12599: [gui] Use base58 script hash address as example (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12599
76 2018-03-14 09:34:41 0|bitcoin-git|[13bitcoin] 15bill-walker opened pull request #12685: [gui] script addresses for sending, not signing (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12685
77 2018-03-14 09:47:52 0|bitcoin-git|13bitcoin/06master 142b3ea39 15Vasil Dimov: Polish interfaces around PeerLogicValidation...
78 2018-03-14 09:47:52 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6acd8700bc0e...c6fc6656299b
79 2018-03-14 09:47:53 0|bitcoin-git|13bitcoin/06master 14c6fc665 15Wladimir J. van der Laan: Merge #12680: Add missing virtual destructor in PeerLogicValidation...
80 2018-03-14 09:48:38 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12680: Add missing virtual destructor in PeerLogicValidation (06master...06master-add-missing-vdtor-in-PeerLogicValidation) 02https://github.com/bitcoin/bitcoin/pull/12680
81 2018-03-14 10:09:09 0|bitcoin-git|13bitcoin/06master 14fa79016 15MarcoFalke: travis: Clone depth 1 unless $CHECK_DOC
82 2018-03-14 10:09:09 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c6fc6656299b...9f04c8e23118
83 2018-03-14 10:09:10 0|bitcoin-git|13bitcoin/06master 149f04c8e 15Wladimir J. van der Laan: Merge #12682: travis: Clone depth 1 unless $CHECK_DOC...
84 2018-03-14 10:09:59 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12682: travis: Clone depth 1 unless $CHECK_DOC (06master...06Mf1803-travisDepth1) 02https://github.com/bitcoin/bitcoin/pull/12682
85 2018-03-14 10:16:06 0|wumpus|I'm confused re: 12685
86 2018-03-14 10:16:41 0|wumpus|I don't remember the dummy address change getting merged
87 2018-03-14 10:17:59 0|wumpus|oh it wasn't (#12599)
88 2018-03-14 10:18:01 0|gribble|https://github.com/bitcoin/bitcoin/issues/12599 | [gui] Use base58 script hash address as example by bill-walker ÷ Pull Request #12599 ÷ bitcoin/bitcoin ÷ GitHub
89 2018-03-14 10:42:52 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12686: travis: Generate a trap for signed arithmetic overflows (enable -ftrapv) (06master...06trapv) 02https://github.com/bitcoin/bitcoin/pull/12686
90 2018-03-14 12:39:11 0|wumpus|<fanquake> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds? <- yeah...
91 2018-03-14 12:39:25 0|wumpus|feel free to call me out when I do that
92 2018-03-14 12:39:59 0|wumpus|usually I add "but this doesn't have to be done in this PR" in that case
93 2018-03-14 12:40:50 0|wumpus|at this point I'd be happy to have *any* multiwallet GUI in, just so that work can proceed on it in the repository
94 2018-03-14 12:42:11 0|luke-jr|well, #11383 is ready besides a new conflict in wallet_tests I could easily resolve :x
95 2018-03-14 12:42:14 0|gribble|https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr ÷ Pull Request #11383 ÷ bitcoin/bitcoin ÷ GitHub
96 2018-03-14 13:22:16 0|bitcoin-git|13bitcoin/06master 14fa23105 15MarcoFalke: qa: Cache only chain and wallet for regtest datadir
97 2018-03-14 13:22:16 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/9f04c8e23118...ce6ffe196e9b
98 2018-03-14 13:22:17 0|bitcoin-git|13bitcoin/06master 14ce6ffe1 15Wladimir J. van der Laan: Merge #12638: qa: Cache only chain and wallet for regtest datadir...
99 2018-03-14 13:23:07 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12638: qa: Cache only chain and wallet for regtest datadir (06master...06Mf1803-qaMempoolCache) 02https://github.com/bitcoin/bitcoin/pull/12638
100 2018-03-14 13:30:00 0|bitcoin-git|13bitcoin/06master 144ef82f1 15fanquake: depends: biplist 1.0.3
101 2018-03-14 13:30:00 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ce6ffe196e9b...c4219ff3786e
102 2018-03-14 13:30:01 0|bitcoin-git|13bitcoin/06master 14c4219ff 15Wladimir J. van der Laan: Merge #12625: depends: biplist 1.0.3...
103 2018-03-14 13:30:46 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12625: depends: biplist 1.0.3 (06master...06biplist-1-0-3) 02https://github.com/bitcoin/bitcoin/pull/12625
104 2018-03-14 13:40:00 0|fanquake|wumpus I think we're meant to be excluding patches already: ":(exclude)depends/patches/" Maybe the script is broken?
105 2018-03-14 13:40:10 0|wumpus|fanquake: was that ever backported
106 2018-03-14 13:40:37 0|fanquake|wumpus Good point, probably not
107 2018-03-14 13:41:32 0|wumpus|:D
108 2018-03-14 13:41:42 0|wumpus|could include it in that PR I gues
109 2018-03-14 13:43:48 0|wumpus|already had a bit of deja vu feeling about that patch exclusion
110 2018-03-14 13:44:41 0|fanquake|heh, get enough hassel from whitespace already without it complaining about things we know are "correct"
111 2018-03-14 13:44:53 0|fanquake|I'll add that commit in a minute
112 2018-03-14 13:44:57 0|wumpus|yes, agree
113 2018-03-14 13:45:20 0|fanquake|#12102 should be ready for merge
114 2018-03-14 13:45:22 0|gribble|https://github.com/bitcoin/bitcoin/issues/12102 | Apply hardening measures in bitcoind systemd service file by Flowdalic ÷ Pull Request #12102 ÷ bitcoin/bitcoin ÷ GitHub
115 2018-03-14 13:46:31 0|wumpus|I'm still not convinced adding that whitespace check to travis was a good idea. On the other hand at least it avoids PRs to "fix" whitespace!
116 2018-03-14 13:48:31 0|bitcoin-git|13bitcoin/06master 1479ddfad 15Florian Schmaus: Apply hardening measurements in bitcoind systemd service file...
117 2018-03-14 13:48:31 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c4219ff3786e...7fb8fb43a630
118 2018-03-14 13:48:32 0|bitcoin-git|13bitcoin/06master 147fb8fb4 15Wladimir J. van der Laan: Merge #12102: Apply hardening measures in bitcoind systemd service file...
119 2018-03-14 13:49:03 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12102: Apply hardening measures in bitcoind systemd service file (06master...06systemd-hardening) 02https://github.com/bitcoin/bitcoin/pull/12102
120 2018-03-14 13:51:47 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12685: [gui] script addresses for sending, not signing (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12685
121 2018-03-14 13:57:14 0|fanquake|wumpus #12460 has a bunch of utACKs, requested a review from sipa
122 2018-03-14 13:57:16 0|gribble|https://github.com/bitcoin/bitcoin/issues/12460 | Assert CPubKey::ValidLength to the pubkeys header-relevant size by Empact ÷ Pull Request #12460 ÷ bitcoin/bitcoin ÷ GitHub
123 2018-03-14 14:06:56 0|fanquake|#12316 started a QT bump, but hasn't really been followed up.
124 2018-03-14 14:06:58 0|gribble|https://github.com/bitcoin/bitcoin/issues/12316 | Upgrade depends/build system to use Qt 5.9.4 by thijstriemstra ÷ Pull Request #12316 ÷ bitcoin/bitcoin ÷ GitHub
125 2018-03-14 14:07:25 0|fanquake|After discussing with theuni 5.9.x is the way to go for the next QT bump, however the changes should be more involved than what's been done in that PR so far.
126 2018-03-14 14:07:45 0|fanquake|I think I'll close it for now. I start work on an alternate pr last week.
127 2018-03-14 14:08:13 0|wumpus|agree, better to close it if it doesn't make progress, probably the author underestimated the work involved
128 2018-03-14 14:08:55 0|wumpus|it's kind of a long haul, for a first-time contributor to try to bump qt in the depends system
129 2018-03-14 14:09:16 0|wumpus|might learn a thing if he was really involved, but it's going slow
130 2018-03-14 14:09:46 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12316
131 2018-03-14 14:11:52 0|wumpus|let's try to credit him in the commit message when we do bump qt
132 2018-03-14 14:13:47 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (06master...062018_02_reinstate_rpcbind_test) 02https://github.com/bitcoin/bitcoin/pull/12510
133 2018-03-14 14:13:49 0|fanquake|wumpus How would like to follow up with issues like #12657 ?
134 2018-03-14 14:13:51 0|gribble|https://github.com/bitcoin/bitcoin/issues/12657 | Serbian Translation / Cyrillic and Latin - Needs better distinction on Transifex ÷ Issue #12657 ÷ bitcoin/bitcoin ÷ GitHub
135 2018-03-14 14:14:08 0|fanquake|I'm not quite on top of how we are doing things on Transifex.
136 2018-03-14 14:14:44 0|wumpus|I have no idea either
137 2018-03-14 14:17:13 0|setpill|has anyone tried to test #12656 ? currently running into some problems but not sure if it's an issue in my virtualbox install or in the PR
138 2018-03-14 14:17:15 0|gribble|https://github.com/bitcoin/bitcoin/issues/12656 | Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer by maaku ÷ Pull Request #12656 ÷ bitcoin/bitcoin ÷ GitHub
139 2018-03-14 14:19:12 0|fanquake|setpill I'm planning on testing shortly. Report any issues your having to the PR.
140 2018-03-14 14:19:17 0|wumpus|I don't use virtualbox anymore (now use libvirt/virsh on my VM servers) so can't test
141 2018-03-14 14:20:07 0|fanquake|wumpus I was wondering if the /docs repo might be a better place for that PR ?
142 2018-03-14 14:21:40 0|wumpus|fanquake: at least the documentation for it should go into the docs repo, so that it's with the other menagerie of gitian building methods. If there are scripts that are more-or-less bound to the bitcoin core release schedule they can be in our repo. Not sure.
143 2018-03-14 14:22:54 0|bitcoin-git|13bitcoin/06master 148172d3a 15Luke Dashjr: configure: UniValue 1.0.4 is required for pushKV(, bool)
144 2018-03-14 14:22:54 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7fb8fb43a630...05042d38ba56
145 2018-03-14 14:22:54 0|wumpus|I think the other gitian building script is also in our repo
146 2018-03-14 14:22:55 0|bitcoin-git|13bitcoin/06master 1405042d3 15Wladimir J. van der Laan: Merge #12666: configure: UniValue 1.0.4 is required for pushKV(, bool)...
147 2018-03-14 14:23:44 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12666: configure: UniValue 1.0.4 is required for pushKV(, bool) (06master...06univalue-1.0.4-required) 02https://github.com/bitcoin/bitcoin/pull/12666
148 2018-03-14 14:25:58 0|bitcoin-git|13bitcoin/06master 14c316fdf 15João Barbosa: [qt] Add support to search the address book
149 2018-03-14 14:25:58 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/05042d38ba56...56cc022112af
150 2018-03-14 14:25:59 0|bitcoin-git|13bitcoin/06master 1456cc022 15Wladimir J. van der Laan: Merge #12080: Add support to search the address book...
151 2018-03-14 14:26:34 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12080: Add support to search the address book (06master...062018-01-searchaddressbook) 02https://github.com/bitcoin/bitcoin/pull/12080
152 2018-03-14 14:32:14 0|fanquake|wumpus I think #12668 can just go in
153 2018-03-14 14:32:17 0|gribble|https://github.com/bitcoin/bitcoin/issues/12668 | Doc: Ubuntu xenial first dependencies by nvercamm ÷ Pull Request #12668 ÷ bitcoin/bitcoin ÷ GitHub
154 2018-03-14 14:32:47 0|fanquake|If running apt update/upgrade is going to upset something, WSL is even more broken than we seem to think.
155 2018-03-14 14:33:37 0|fanquake|You could adjust the commit message though, as nothing Xenial specific.
156 2018-03-14 14:35:18 0|promag|hi, I would like some feedback on #12507, ty
157 2018-03-14 14:35:20 0|gribble|https://github.com/bitcoin/bitcoin/issues/12507 | Interrupt rescan on shutdown request by promag ÷ Pull Request #12507 ÷ bitcoin/bitcoin ÷ GitHub
158 2018-03-14 14:35:39 0|promag|in particular, if the rescan should resume or not
159 2018-03-14 14:36:38 0|instagibbs|wumpus, I must be the only one who gets triggered seeing extra whitespace on my git diff...
160 2018-03-14 14:40:19 0|wumpus|instagibbs: no, I don't think so, it's really easy to notice such things. I consciously have to push myself to ignore all kinds of small grievances while reviewing, to be able to focus at the real changes
161 2018-03-14 14:43:06 0|wumpus|and yes, sometimes I still fail at that
162 2018-03-14 14:53:45 0|achow101|pierre_rochard: I haven't really looked at that issue yet. I can't reproduce it either; I don't have a mac
163 2018-03-14 15:17:31 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12636: backport: #11995 Fix Qt build with Xcode 9 (060.16...06qt-fix-backport) 02https://github.com/bitcoin/bitcoin/pull/12636
164 2018-03-14 15:30:57 0|bitcoin-git|13bitcoin/06master 14e29c6c8 15Nick Vercammen: Ubuntu xenial first dependencies...
165 2018-03-14 15:30:57 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/56cc022112af...de2fcaa89a61
166 2018-03-14 15:30:58 0|bitcoin-git|13bitcoin/06master 14de2fcaa 15Wladimir J. van der Laan: Merge #12668: Doc: do update before fetching packages in WSL build guide...
167 2018-03-14 15:31:51 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12668: Doc: do update before fetching packages in WSL build guide (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/12668
168 2018-03-14 16:12:07 0|provoostenator|Does -testsafemode do anything other than display a warning in QT?
169 2018-03-14 16:15:03 0|wumpus|no
170 2018-03-14 16:15:40 0|wumpus|safe mode never did anything in the GUI (well besides restrict use of RPC, through the debug console)
171 2018-03-14 16:16:36 0|wumpus|it's interesting that testsafemode is not used in any of the tests, though maybe that was removed already when safe mode was deprecated
172 2018-03-14 16:29:00 0|bitcoin-git|13bitcoin/06master 1459f4795 15fanquake: docs: Update osx brew install instruction
173 2018-03-14 16:29:00 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/de2fcaa89a61...e7721e667260
174 2018-03-14 16:29:01 0|bitcoin-git|13bitcoin/06master 14e7721e6 15Wladimir J. van der Laan: Merge #12586: docs: Update osx brew install instruction...
175 2018-03-14 16:29:45 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12586: docs: Update osx brew install instruction (06master...06homebrew-python3-python) 02https://github.com/bitcoin/bitcoin/pull/12586
176 2018-03-14 16:39:15 0|provoostenator|wumpus: should I make a PR to get rid of it then?
177 2018-03-14 16:46:58 0|wumpus|provoostenator: dunno, I don't think there's really a hurry
178 2018-03-14 16:52:17 0|provoostenator|I didn't specificy when :-)
179 2018-03-14 16:53:04 0|wumpus|I don't think anyone would be opposed to just removing safe mode and everything assosicated with it, but there's probably more important things, its existence isn't blocking any developments
180 2018-03-14 16:56:09 0|wumpus|otoh it was deprecated in 0.16 so removing it in 0.17 would be sensible
181 2018-03-14 16:58:01 0|provoostenator|Afaik the parameter literraly doesn't do anything except show that message. It's not setting any (global) variable.
182 2018-03-14 16:59:57 0|wumpus|so if you run with -disablesafemode=0 -testsafemode , you should be prevented from executing various RPCs
183 2018-03-14 17:01:08 0|wumpus|(to be precise, the ones that call ObserveSafeMode)
184 2018-03-14 17:02:19 0|bitcoin-git|[13bitcoin] 15laanwj pushed 14 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e7721e667260...e057589dc67f
185 2018-03-14 17:02:20 0|bitcoin-git|13bitcoin/06master 1412ec29d 15Andrew Chow: Calculate and store the number of bytes required to spend an input
186 2018-03-14 17:02:20 0|bitcoin-git|13bitcoin/06master 14f84fed8 15Andrew Chow: Store effective value, fee, and long term fee in CInputCoin...
187 2018-03-14 17:02:21 0|bitcoin-git|13bitcoin/06master 140185939 15Andrew Chow: Implement Branch and Bound coin selection in a new file...
188 2018-03-14 17:02:34 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10637: Coin Selection with Murch's algorithm (06master...06bnb-coin-select) 02https://github.com/bitcoin/bitcoin/pull/10637
189 2018-03-14 17:03:44 0|Murch|woohoooooo! :D
190 2018-03-14 17:05:42 0|wumpus|:D
191 2018-03-14 17:06:25 0|wumpus|congratulations, thanks for sticking with this
192 2018-03-14 17:07:09 0|provoostenator|Very nice!
193 2018-03-14 17:14:46 0|Murch|Thank you achow101, instagibbs, morcos, ryanofsky, eklitzke and everyone else! :D
194 2018-03-14 17:14:53 0|Murch|This makes me really happy!
195 2018-03-14 17:14:58 0|achow101|\O/
196 2018-03-14 17:15:29 0|achow101|Time to start working on replacing the fallback strategy
197 2018-03-14 17:16:12 0|Murch|Yessir!
198 2018-03-14 17:16:26 0|Murch|Thanks wumpus
199 2018-03-14 17:21:23 0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (06master...062018-03/testsafemode) 02https://github.com/bitcoin/bitcoin/pull/12687
200 2018-03-14 17:21:31 0|provoostenator|wumpus: I figured out what I was missing...
201 2018-03-14 17:22:19 0|bitcoin-git|[13bitcoin] 15Sjors closed pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (06master...062018-03/testsafemode) 02https://github.com/bitcoin/bitcoin/pull/12687
202 2018-03-14 17:23:56 0|instagibbs|gave a whoop at taco place when i saw the email. Thanks for all the heavy lifting achow101 :)
203 2018-03-14 17:24:55 0|Murch|instagibbs: Everybody was looking at my bewilderedly when I just whooped here at the office. Had to explain what happened. :D
204 2018-03-14 17:26:22 0|instagibbs|next: rip up knapsack and crazy transaction looping...
205 2018-03-14 17:29:21 0|sipa|congrats all, and achow101 and Murch in particular
206 2018-03-14 17:56:52 0|iyahjeff|Hi there. Anyone running a full BTC node on Linux that would be kind enough to paste me the output of ââ¬Ådu -shm .bitcoin/blocks/ââ¬Â
207 2018-03-14 17:57:24 0|arubi|191199 datadir/blocks/
208 2018-03-14 17:57:51 0|arubi|oh this is #-core-dev
209 2018-03-14 17:57:52 0|iyahjeff|@arubi Thanks a lot.
210 2018-03-14 18:38:08 0|pierre_rochard|ryanofsky Iââ¬â¢m looking at the 0.17 wallet PRs to see what to review next, is #11536 the priority? It seems to precede the two other label PRs
211 2018-03-14 18:38:11 0|gribble|https://github.com/bitcoin/bitcoin/issues/11536 | Rename account to label where appropriate by ryanofsky ÷ Pull Request #11536 ÷ bitcoin/bitcoin ÷ GitHub
212 2018-03-14 18:39:46 0|ryanofsky|yes, it is meant to be followed up by #7729, then #11497
213 2018-03-14 18:39:50 0|gribble|https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj ÷ Pull Request #7729 ÷ bitcoin/bitcoin ÷ GitHub
214 2018-03-14 18:39:51 0|gribble|https://github.com/bitcoin/bitcoin/issues/11497 | Hide accounts system behind deprecation switch by achow101 ÷ Pull Request #11497 ÷ bitcoin/bitcoin ÷ GitHub
215 2018-03-14 19:18:21 0|meshcollider|Yay congrats on the coin selection merge finally achow101, Murch \o/
216 2018-03-14 19:56:26 0|bitcoin-git|[13bitcoin] 15dooglus closed pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (06master...06set_hd_seed) 02https://github.com/bitcoin/bitcoin/pull/11085
217 2018-03-14 20:26:39 0|santiago0|hello
218 2018-03-14 20:36:17 0|santiago0|I'm IT student. Never participated to bigger projects. How do you manage bitcoin source code? What IDE are you using?
219 2018-03-14 20:38:10 0|sipa|text editor
220 2018-03-14 20:39:15 0|AndyS2|I guess most people just use vim and the command line. After trying a few IDEs, I settled for Eclipse CDT with a VIM plugin for better overview. I'm just fooling around, though.
221 2018-03-14 20:39:40 0|AndyS2|Mostly because their debugger has a nice overview and seperate interfaces weren't as nice to use.
222 2018-03-14 20:40:10 0|AndyS2|oops
223 2018-03-14 20:43:12 0|santiago0|ok thanks. Until now I also used VIM for everything.
224 2018-03-14 20:44:56 0|AndyS2|It's easier to navigate unknown code with an IDE in my opinion. that said, there's probably some plugin that does just that for vim, too.
225 2018-03-14 20:45:30 0|AndyS2|I just got a vim plugin for eclipse. serves my purpose well
226 2018-03-14 20:45:43 0|jojeyh|AndyS2, grep -rnw . -e 'stuff to find'
227 2018-03-14 20:46:31 0|promag|I believe #12621 is ready to be merged
228 2018-03-14 20:46:33 0|gribble|https://github.com/bitcoin/bitcoin/issues/12621 | Avoid querying unnecessary model data when filtering transactions by promag ÷ Pull Request #12621 ÷ bitcoin/bitcoin ÷ GitHub
229 2018-03-14 21:38:21 0|intcat|jojeyh: or without w
230 2018-03-14 22:17:28 0|bitcoin-git|[13bitcoin] 15eklitzke opened pull request #12689: Smarter default behavior for -printtoconsole (06master...06console) 02https://github.com/bitcoin/bitcoin/pull/12689
231 2018-03-14 23:14:18 0|eklitzke|travis is so annoying, it looks like it doesn't properly handle bash arrays when setting up the build environment
232 2018-03-14 23:47:41 0|eklitzke|hmm, i got another corrupted chainstate database, this time on a different computer
233 2018-03-14 23:47:48 0|eklitzke|what's interesting is the crc on the block is correct
234 2018-03-14 23:50:11 0|eklitzke|it also thinks that snappy compression is enabled, which is definitely not the case