1 2018-03-20 00:35:30	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #12731: Support serialization as another type without casting (06master...06201803_astype) 02https://github.com/bitcoin/bitcoin/pull/12731
 2 2018-03-20 01:51:35	0|jimpo|ryanofsky: I still haven't had a chance to update the unit tests on #11857 based on your feedback, so maybe hold off a few more days on taking another look. I'll post on the PR when that is done.
 3 2018-03-20 01:51:40	0|gribble|https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
 4 2018-03-20 01:51:43	0|jimpo|Thanks for your review!
 5 2018-03-20 02:03:11	0|sipa|grr, it seems windows has a function called 'VarInt', conflicting with my introducing of a class with that name in #10785
 6 2018-03-20 02:03:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
 7 2018-03-20 02:08:25	0|jonasschnelli|sipa: can you comment here: https://github.com/bitcoin/bitcoin/pull/12653#issuecomment-374246044?
 8 2018-03-20 02:56:34	0|luke-jr|sipa: maybe a reason to go back to the C* prefix?
 9 2018-03-20 02:56:52	0|luke-jr|(Or start with a BC* prefix)
10 2018-03-20 02:56:56	0|sipa|luke-jr: a namespace would be better imho
11 2018-03-20 02:57:00	0|sipa|but a bit invasive
12 2018-03-20 02:57:19	0|luke-jr|maybe
13 2018-03-20 07:44:08	0|fanquake|eklitzke is running a reindex-chainstate the best way to test performance improvement in 12495?
14 2018-03-20 07:45:03	0|eklitzke|yes, that's what i would recommend
15 2018-03-20 07:45:18	0|fanquake|I'll spin something up now
16 2018-03-20 07:45:50	0|eklitzke|awesome
17 2018-03-20 07:46:21	0|fanquake|eklitze also, are you moving 12649 to the docs repo? Will ACK if you just link from the dev notes in /bitcoin
18 2018-03-20 07:46:50	0|eklitzke|yeah i'll update the issue
19 2018-03-20 07:48:02	0|fanquake|Cool, have to get them working.
20 2018-03-20 08:15:50	0|bitcoin-git|13bitcoin/06master 14d843db7 15Jonas Schnelli: Qt: remove "new" button during receive-mode in addressbook
21 2018-03-20 08:15:50	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8ee5c7b74717...e47682633817
22 2018-03-20 08:15:51	0|bitcoin-git|13bitcoin/06master 14e476826 15Wladimir J. van der Laan: Merge #12721: Qt: remove "new" button during receive-mode in addressbook...
23 2018-03-20 08:16:47	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12721: Qt: remove "new" button during receive-mode in addressbook (06master...062018/03/addr_new_btn) 02https://github.com/bitcoin/bitcoin/pull/12721
24 2018-03-20 08:38:02	0|wumpus|luke-jr: I think I can add those too, but not say, manage language teams
25 2018-03-20 08:38:45	0|wumpus|luke-jr: e.g. no access to https://www.transifex.com/bitcoin/teams/
26 2018-03-20 09:42:47	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e47682633817...55f490a79fc5
27 2018-03-20 09:42:48	0|bitcoin-git|13bitcoin/06master 14a2b2476 15practicalswift: tests: Test connecting to a non-existing server
28 2018-03-20 09:42:48	0|bitcoin-git|13bitcoin/06master 14de04fde 15practicalswift: bitcoin-cli: Provide a better error message when bitcoind is not running...
29 2018-03-20 09:42:49	0|bitcoin-git|13bitcoin/06master 148b2ef27 15practicalswift: tests: Test connecting with non-existing RPC cookie file
30 2018-03-20 09:43:26	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12652: bitcoin-cli: Provide a better error message when bitcoind is not running (06master...06bitcoin-cli-error-message-when-bitcoind-is-not-running) 02https://github.com/bitcoin/bitcoin/pull/12652
31 2018-03-20 10:46:37	0|bitcoin-git|13bitcoin/06master 14728667b 15John Newbery: scripted-diff: rename TestNode to TestP2PConn in tests...
32 2018-03-20 10:46:37	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/55f490a79fc5...4ba3d4f4393d
33 2018-03-20 10:46:38	0|bitcoin-git|13bitcoin/06master 144ba3d4f 15MarcoFalke: Merge #12728: [tests] rename TestNode to TestP2PConn in tests...
34 2018-03-20 10:47:24	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12728: [tests] rename TestNode to TestP2PConn in tests (06master...06rename_test_node) 02https://github.com/bitcoin/bitcoin/pull/12728
35 2018-03-20 12:04:10	0|luke-jr|wumpus: same here
36 2018-03-20 12:07:31	0|luke-jr|cfields: FYI, I suspect there is a problem with moc stuff and clean/rebuild; even with a full `make clean` (which shouldn't be needed), I often still end up with an obsolete src/qt/moc_paymentserver.cpp when switching between code that makes BIP70 optional and not
37 2018-03-20 15:04:24	0|bitcoin-git|[13bitcoin] 15lutangar opened pull request #12736: [RPC][Refactoring] Meaningful error code when called with wrong number of arguments (06master...06error-code-for-param-number) 02https://github.com/bitcoin/bitcoin/pull/12736
38 2018-03-20 16:13:37	0|achow101|wumpus: are you an admin on transifex?
39 2018-03-20 16:13:58	0|achow101|for the bitcoin org
40 2018-03-20 16:33:02	0|wumpus|achow101: I can do things such as remove translations, add translations, remove resources, add resources, but not change teams...
41 2018-03-20 16:33:46	0|achow101|wumpus: hmm, then who's the admin?
42 2018-03-20 16:33:49	0|wumpus|kind of half-admin maybe, I don't know
43 2018-03-20 16:34:27	0|wumpus|seone
44 2018-03-20 16:34:50	0|achow101|looking at https://docs.transifex.com/teams/understanding-user-roles, your role is project maintainer, what we need is an admin or team manager
45 2018-03-20 16:34:53	0|wumpus|(no, I don't no who that is, never talked to them, they've had that since before I was in the project)
46 2018-03-20 16:39:02	0|achow101|wumpus: on https://www.transifex.com/bitcoin/teams/, do you see a button that says "manage collaborators"?
47 2018-03-20 16:43:31	0|Randolf|achow101:  I thought it was a collaborated effort.
48 2018-03-20 16:43:59	0|achow101|Randolf: what do you mean?
49 2018-03-20 16:44:15	0|Randolf|achow101:  You mentioned that there's a need for an admin or team manager.
50 2018-03-20 16:44:51	0|achow101|yeah, we need an admin or a team manager to give people enough permissions to do things with some of the translations
51 2018-03-20 16:45:39	0|achow101|at some point some translation strings become locked and only someone with enough permissions can unlock them
52 2018-03-20 16:46:17	0|Randolf|Do you need someone who can understand all the different languages?
53 2018-03-20 16:46:26	0|achow101|Randolf: no
54 2018-03-20 16:46:52	0|achow101|we need someone who responds to requests and has enough permissions
55 2018-03-20 16:48:49	0|achow101|wumpus: it looks like tcatm (https://github.com/tcatm) was the one who set up transifex. Maybe send him an email and see if he can do something about this?
56 2018-03-20 16:49:04	0|Randolf|I may be able to help.
57 2018-03-20 16:49:32	0|Randolf|Let me know if I can.
58 2018-03-20 16:49:38	0|achow101|Randolf: how so?
59 2018-03-20 16:50:09	0|Randolf|If you need someone to put time into the administration side of things and responding to requests.  I'd need to know more about what needs to be done, but I could certainly put time into this every day.
60 2018-03-20 16:50:44	0|Randolf|I like Bitcoin, and if there's an area that needs someone to help I feel like I should.
61 2018-03-20 17:10:40	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #12737: Remove unnecessary NONNEGATIVE_SIGNED (06master...06pr/nosigned) 02https://github.com/bitcoin/bitcoin/pull/12737
62 2018-03-20 17:57:24	0|luke-jr|tcatm
63 2018-03-20 18:47:54	0|cfields|luke-jr: hmm
64 2018-03-20 18:48:02	0|cfields|luke-jr: can you describe the steps to reproduce?
65 2018-03-20 18:53:26	0|bitcoin-git|[13bitcoin] 15pedrobranco opened pull request #12739: Fix unlocking of an already spent output (06master...06bugfix/fix-lockunspent-deadlock) 02https://github.com/bitcoin/bitcoin/pull/12739
66 2018-03-20 19:02:25	0|luke-jr|cfields: it happens on its own every other build I do, it seems; I guess check out and build various branches merged into the knots/tmp branch?
67 2018-03-20 19:02:48	0|luke-jr|(presumably at some point, it would help to build the optional-BIP70 branch)
68 2018-03-20 19:02:57	0|luke-jr|only reason I notice it is because the #ifdefs in the MOC stuff
69 2018-03-20 19:10:59	0|cfields|ok
70 2018-03-20 19:24:25	0|TheCharlatan|cfields I heard you are working on bringing the entire toolchain to depends. Is any of this public yet? I want to start working on this as well.
71 2018-03-20 21:17:13	0|cfields|TheCharlatan: I'm working on getting it ready to push public.
72 2018-03-20 21:20:05	0|cfields|luke-jr: I'm not sure how that's happening
73 2018-03-20 21:20:22	0|cfields|luke-jr: if your branch makes that file optional, it would make sense that it wouldn't clean it
74 2018-03-20 21:20:42	0|cfields|er, s/wouldn't/might not/, depending on config
75 2018-03-20 22:40:23	0|cfields|eklitzke: I swear I'm not always so pedantic about build changes, you're just in hasn't-been-touched-in-years-because-it-just-works territory :)
76 2018-03-20 23:09:55	0|eklitzke|"just works"
77 2018-03-20 23:11:29	0|eklitzke|these two changes have been a valuable lesson in how the separation between the preprocessor, compiler, and linker is more of an illusion than anything else
78 2018-03-20 23:12:11	0|sipa|haha
79 2018-03-20 23:37:48	0|luke-jr|cfields: the file isn't optional; the change is to config.h and #ifdefs