1 2018-03-21 00:41:06	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #12740: Add native support for serializing char arrays without FLATDATA (06master...06201803_chararray) 02https://github.com/bitcoin/bitcoin/pull/12740
  2 2018-03-21 00:56:35	0|meshcollider|wumpus: do you think #4676 should be closed now?
  3 2018-03-21 00:56:36	0|gribble|https://github.com/bitcoin/bitcoin/issues/4676 | Follow standard Unix daemon practices · Issue #4676 · bitcoin/bitcoin · GitHub
  4 2018-03-21 02:12:39	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #12742: Make FastRandomContext support standard C++11 RNG interface (06master...06201803_stdrandom) 02https://github.com/bitcoin/bitcoin/pull/12742
  5 2018-03-21 02:21:39	0|bitcoin-git|13bitcoin/06master 1434ca750 15Russell Yanofsky: Remove unnecessary NONNEGATIVE_SIGNED...
  6 2018-03-21 02:21:39	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4ba3d4f4393d...9b8b1079ddab
  7 2018-03-21 02:21:40	0|bitcoin-git|13bitcoin/06master 149b8b107 15Pieter Wuille: Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED...
  8 2018-03-21 02:22:40	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #12737: Remove unnecessary NONNEGATIVE_SIGNED (06master...06pr/nosigned) 02https://github.com/bitcoin/bitcoin/pull/12737
  9 2018-03-21 03:46:23	0|CubicEar_|Bitcoin Devs = Heros
 10 2018-03-21 04:04:01	0|Randolf|CubicEar_:  Your sentiments are appreciated.  Are you interested in contributing?
 11 2018-03-21 04:06:26	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining (06master...06201803_waitblockchange) 02https://github.com/bitcoin/bitcoin/pull/12743
 12 2018-03-21 04:07:22	0|CubicEar_|Randolf: I am always trying to increase my knowledge to the point where I could :)
 13 2018-03-21 04:07:55	0|Randolf|CubicEar_:  Well, one good place to start, depending on your level of programming expertise, is:  https://www.github.com/bitcoin/
 14 2018-03-21 04:11:58	0|CubicEar_|I browse it from time to time
 15 2018-03-21 04:13:56	0|CubicEar_|Randolf: Thanks for being inviting. I expect that soon I will be working with a few devs in-person, so that will be nice
 16 2018-03-21 04:29:17	0|Randolf|Welcome!
 17 2018-03-21 04:29:31	0|Randolf|I've found the core developers to be very helpful.
 18 2018-03-21 04:33:32	0|jimpo|sipa: Updated #12254 with mean element size stats (consistently ~21.6 bits)
 19 2018-03-21 04:33:34	0|gribble|https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
 20 2018-03-21 04:34:03	0|jimpo|compression is abismal for small numbers of elements, which is why relative filter sizes are so large for early blocks
 21 2018-03-21 04:34:36	0|jimpo|fun graph of mean element size vs number of elements (compression efficacy): https://gateway.ipfs.io/ipfs/QmaAceymvLdiw1tv5BLVgDkfKfd21mRNx4m41D5yhXrkcq
 22 2018-03-21 04:37:16	0|sipa|jimpo: 21.6 is really good
 23 2018-03-21 04:38:15	0|sipa|using a bloom filter instead would be at least 28.85
 24 2018-03-21 04:38:43	0|jimpo|Yeah, it gets down to 22 at ~750 elements per set
 25 2018-03-21 04:39:17	0|jimpo|Also, I created filters using scriptPubKey instead of the parsed scriptPubKey and the difference in avg filter size is negligible
 26 2018-03-21 05:03:00	0|sipa|jimpo: that's expected... but just scriptPubKey seems much more predictable
 27 2018-03-21 06:04:22	0|eklitzke|just noticed that we link against boost::program_options
 28 2018-03-21 06:04:24	0|eklitzke|funny
 29 2018-03-21 06:05:47	0|eklitzke|seemingly just to use a file iterator in one line of code of util.cpp
 30 2018-03-21 06:08:11	0|eklitzke|i might try and fix that
 31 2018-03-21 06:33:17	0|sipa|eklitzke: i bekieve there's an issue about that somewhere
 32 2018-03-21 06:33:32	0|sipa|or maybe it was discussed in a meeting at some point
 33 2018-03-21 06:50:24	0|bitcoin-git|[13bitcoin] 15eklitzke opened pull request #12744: Completely eliminate dependency on boost::program_options (06master...06program_options) 02https://github.com/bitcoin/bitcoin/pull/12744
 34 2018-03-21 06:58:42	0|eklitzke|probably needs more tests too
 35 2018-03-21 07:00:39	0|fanquake|thumbs up for less Boost
 36 2018-03-21 07:01:55	0|eklitzke|we're getting pretty close to removing it
 37 2018-03-21 07:02:49	0|eklitzke|if there was a replacement ready for boost::filesystem i think we could sort out all of the other boost stuff pretty fast
 38 2018-03-21 07:04:11	0|fanquake|Maybe drop boost and qt4 at the same time heh
 39 2018-03-21 07:09:25	0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #11694: rpc: Add missing cs_main lock in getblocktemplate(...) (06master...06missing-lock-in-getblocktemplate) 02https://github.com/bitcoin/bitcoin/pull/11694
 40 2018-03-21 07:12:19	0|fanquake|If anyone wants some GUI review, #12723 is pretty much ACK ready
 41 2018-03-21 07:12:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/12723 | Qt5: Warning users about invalid-BIP21 URI bitcoin:// by krab · Pull Request #12723 · bitcoin/bitcoin · GitHub
 42 2018-03-21 07:19:28	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12745: Expose node relay fee settings in help, independent of -help-debug (06master...06expose-relay-fee-settings-help) 02https://github.com/bitcoin/bitcoin/pull/12745
 43 2018-03-21 09:45:52	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12746: tests: Remove unused argument max_invalid from check_estimates(...) (06master...06check_estimates-max_invalid) 02https://github.com/bitcoin/bitcoin/pull/12746
 44 2018-03-21 09:55:10	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12747: Fix typos (06master...06typos-201803) 02https://github.com/bitcoin/bitcoin/pull/12747
 45 2018-03-21 11:46:36	0|timothy|hi, do you think a pull request in order to add systemd notify support may be accepted?
 46 2018-03-21 11:46:51	0|timothy|currently I'm using an hack in order to start lnd after bitcoind
 47 2018-03-21 11:47:05	0|timothy|but, I think, using notify may be a better solution
 48 2018-03-21 12:11:13	0|p3tr|timothy: i think a pull request will be more than welcome
 49 2018-03-21 12:11:27	0|p3tr|anyway i'm using monit to make sure lnd starts after bitcoind is running
 50 2018-03-21 12:12:19	0|timothy|p3tr: I'm using ExecStartPost=/bin/sh -c 'while sleep 10; do /home/bitcoin/bin/bitcoin-cli ping && break; done'
 51 2018-03-21 12:12:31	0|timothy|so bitcoind.service is up only when the RPC is online
 52 2018-03-21 12:12:36	0|timothy|but it sux as solution :)
 53 2018-03-21 12:16:14	0|fanquake|timothy best way to get feedback is to just open a PR
 54 2018-03-21 15:19:54	0|bitcoin-git|13bitcoin/06master 144d9b425 15Dimitris Apostolou: Fix typos
 55 2018-03-21 15:19:54	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/9b8b1079ddab...4ad3b3c72c73
 56 2018-03-21 15:19:55	0|bitcoin-git|13bitcoin/06master 144ad3b3c 15MarcoFalke: Merge #12716: Fix typos and cleanup in various files...
 57 2018-03-21 15:20:55	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12716: Fix typos and cleanup in various files (06master...06fix-typos) 02https://github.com/bitcoin/bitcoin/pull/12716
 58 2018-03-21 15:37:01	0|fanquake|You can never truly escape all the typos.
 59 2018-03-21 15:42:01	0|Randolf|fanquake:  It's nice to get so many corrected at once though.  :)
 60 2018-03-21 15:48:03	0|bcqtsyncprob|Hi
 61 2018-03-21 15:48:27	0|bcqtsyncprob|I'm having issues with blocksync. Can anybody help me?
 62 2018-03-21 15:48:39	0|fanquake|try #bitcoin
 63 2018-03-21 15:48:43	0|bcqtsyncprob|Tried
 64 2018-03-21 15:48:54	0|bcqtsyncprob|Nobody knows there why is the client polling fd=5
 65 2018-03-21 15:49:39	0|bcqtsyncprob|I assure you, I have problems with bitcoin core, and it's not disk-space, network etc. related at all
 66 2018-03-21 15:50:49	0|fanquake|If you have info/debug logs ect, opening an issue is a good option: https://github.com/bitcoin/bitcoin/issues . Assuming you are running 0.16.0 ?
 67 2018-03-21 15:51:25	0|paffo|hello everybody, a question. is there a repository on github or a tool where i can get all the wallet information history by insert the hashof the wallet?
 68 2018-03-21 15:51:28	0|bcqtsyncprob|I can see new nodes connecting, a few million packages received, then it stops till tcp times out. In the meantime number of blocks left does not decrease
 69 2018-03-21 15:52:13	0|bcqtsyncprob|strace shows the the client does nothing, just calling poll(fd=5) in an endless loop which times out
 70 2018-03-21 15:52:46	0|bcqtsyncprob|Yes, I'm running the lates 0.16.0.0
 71 2018-03-21 15:53:19	0|bcqtsyncprob|latest
 72 2018-03-21 15:54:13	0|bcqtsyncprob|8 days ago it was working properly, I'm experiencing these problems only in the last 3 days. I've updated the kernel in the meantime, I was wondering, could that cause that?
 73 2018-03-21 15:57:30	0|bcqtsyncprob|paffo: tried blockchain.info? It will do precicely that.
 74 2018-03-21 15:57:55	0|bitcoin-git|13bitcoin/06master 14b7fbcc5 15Alexey Ivanov: Qt: Warn users about invalid-BIP21 URI bitcoin://
 75 2018-03-21 15:57:55	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4ad3b3c72c73...310dc61ea3e2
 76 2018-03-21 15:57:56	0|bitcoin-git|13bitcoin/06master 14310dc61 15Wladimir J. van der Laan: Merge #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin://...
 77 2018-03-21 15:58:47	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin:// (06master...06qt5-uri-error-message) 02https://github.com/bitcoin/bitcoin/pull/12723
 78 2018-03-21 16:02:25	0|bitcoin-git|13bitcoin/06master 14a004eb1 15practicalswift: tests: Remove unused argument max_invalid from check_estimates(...)
 79 2018-03-21 16:02:25	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/310dc61ea3e2...2405ce1df043
 80 2018-03-21 16:02:26	0|bitcoin-git|13bitcoin/06master 142405ce1 15MarcoFalke: Merge #12746: tests: Remove unused argument max_invalid from check_estimates(...)...
 81 2018-03-21 16:03:17	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12746: tests: Remove unused argument max_invalid from check_estimates(...) (06master...06check_estimates-max_invalid) 02https://github.com/bitcoin/bitcoin/pull/12746
 82 2018-03-21 18:47:41	0|achow101|review/merge beg for #12694
 83 2018-03-21 18:47:43	0|gribble|https://github.com/bitcoin/bitcoin/issues/12694 | Actually disable BnB when there are preset inputs by achow101 · Pull Request #12694 · bitcoin/bitcoin · GitHub
 84 2018-03-21 19:10:38	0|jnewbery|wumpus: can you add #10762 to priorities for review? It's a fairly small changeset and removes one of the final server->wallet dependencies
 85 2018-03-21 19:10:40	0|gribble|https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
 86 2018-03-21 19:12:58	0|arubi|importpubkey misbehaves now.  running importpubkey then validateaddress on the p2pkh\p2sh\p2wpkh addresses for that pubkey no loner returns the output that shows that the wallet knows about the pubkey for that address.  git bisect says the bad commit is 1598f323, but this commit fails to build so it might have happened in the next one, b98bfc5e .  the one before these two, 39633ecd , behaves normally
 87 2018-03-21 19:17:24	0|sipa|arubi: what do you mean by "returns the output" ?
 88 2018-03-21 19:18:50	0|arubi|I mean, calling validateaddress on an address that the wallet knows the pubkey for will list that pubkey in the output.  this no longer happens even if the wallet supposedly knows the pubkey when the pubkey was imported with importpubkey
 89 2018-03-21 19:21:53	0|arubi|sipa, paste with example : https://gist.github.com/fivepiece/5ed1140f424714850de9539c9c0c4113
 90 2018-03-21 19:34:39	0|jnewbery|arubi: the wallet parts of validateaddress have moved to getaddressinfo
 91 2018-03-21 19:35:06	0|jnewbery|You found the right commit b98bfc5e. The commit message describes the change
 92 2018-03-21 19:35:36	0|arubi|doh, let me rebuild.  I only did git show
 93 2018-03-21 19:35:39	0|sipa|arubi: run with -deprecatedrpc=validateaddress
 94 2018-03-21 19:35:58	0|arubi|oh I'll do that first
 95 2018-03-21 19:36:04	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #12749: feebumper: discard change outputs below discard rate (06master...06discardbump) 02https://github.com/bitcoin/bitcoin/pull/12749
 96 2018-03-21 19:38:59	0|arubi|getaddressinfo returns the expected output, using the -deprecated flag doesn't change the output for validateaddress
 97 2018-03-21 19:39:49	0|arubi|getaddressinfo is good enough for me :)
 98 2018-03-21 19:59:09	0|sipa|arubi: it's -deprecatedrpc
 99 2018-03-21 19:59:32	0|arubi|trying
100 2018-03-21 20:00:18	0|arubi|(I mean I'm assuming you're right but just for personal gain :) )
101 2018-03-21 20:00:31	0|sipa|well i'd very much like to know if i'm wrong!
102 2018-03-21 20:00:45	0|arubi|then I'll let you know
103 2018-03-21 20:02:20	0|arubi|`regtest-cli -deprecatedrpc=validateaddress validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ` still returns the "incomplete" output
104 2018-03-21 20:03:15	0|arubi|and `regtest-cli -deprecatedrpc validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ` too.  I hope it isn't my alias acting up..  let's see if I call it without it
105 2018-03-21 20:04:08	0|arubi|same behavior
106 2018-03-21 20:05:03	0|sipa|arubi: it's -deprecatedrpc=validateaddress
107 2018-03-21 20:05:19	0|sipa|you have to explicitly specify which RPC you want the deprecated behaviour for
108 2018-03-21 20:05:42	0|sipa|this forces users to be aware something changed, and are relying on old behaviour, but can still use it if upgrading is too hard
109 2018-03-21 20:05:44	0|arubi|right, I did try both with =validateaddress and without
110 2018-03-21 20:05:48	0|sipa|oh
111 2018-03-21 20:06:08	0|sipa|oh!
112 2018-03-21 20:06:23	0|sipa|and -deprecatedrpc=... is an option to bitcoind, not cli
113 2018-03-21 20:06:43	0|arubi|yep,  full command : `$HOME/software/install/bitcoin/regtest/bin/bitcoin-cli -deprecatedrpc=validateaddress -conf=$HOME/.bitcoin/regtest.conf -rpcuser=regtest_daemon -rpcpassword=LygXyhO0-T5g-IJOQD2TILdlbTOkrd0FCz3rbZ7jC3M= validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ`
114 2018-03-21 20:07:22	0|sipa|no, to bitcoind, not to bitcoin-cli
115 2018-03-21 20:07:27	0|sipa|you need to restart the daemon
116 2018-03-21 20:07:28	0|bitcoin-git|[13bitcoin] 15donaloconnor opened pull request #12750: Replace boost::call_once with std::call_once (06master...0621032018_call_once) 02https://github.com/bitcoin/bitcoin/pull/12750
117 2018-03-21 20:07:36	0|arubi|ohh my bad one moment
118 2018-03-21 20:08:03	0|arubi|success! :)
119 2018-03-21 20:08:19	0|sipa|"bitcoin-cli help validateaddress" should show:
120 2018-03-21 20:08:20	0|sipa|DEPRECATION WARNING: Parts of this command have been deprecated and moved to getaddressinfo. Clients must
121 2018-03-21 20:08:24	0|sipa|transition to using getaddressinfo to access this information before upgrading to v0.18. The following deprecated
122 2018-03-21 20:08:27	0|sipa|fields have moved to getaddressinfo and will only be shown here with -deprecatedrpc=validateaddress: ismine, iswatchonly,
123 2018-03-21 20:08:30	0|sipa|script, hex, pubkeys, sigsrequired, pubkey, addresses, embedded, iscompressed, account, timestamp, hdkeypath, kdmasterkeyid.
124 2018-03-21 20:09:07	0|arubi|it does indeed.  it's always the user that fails to RTFM
125 2018-03-21 20:31:38	0|cfields|<eklitzke> these two changes have been a valuable lesson in how the separation between the preprocessor, compiler, and linker is more of an illusion than anything else
126 2018-03-21 20:31:52	0|cfields|eklitzke: yes, it's nearly impossible to invoke linkers directly these days
127 2018-03-21 21:20:39	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #12752: [MOVEONLY] Move compressor utility functions out of class (06master...06201803_movecompress) 02https://github.com/bitcoin/bitcoin/pull/12752
128 2018-03-21 22:05:57	0|bitcoin-git|13bitcoin/06master 14d27327c 15practicalswift: Fix typos
129 2018-03-21 22:05:57	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2405ce1df043...2b1c50b9352a
130 2018-03-21 22:05:58	0|bitcoin-git|13bitcoin/06master 142b1c50b 15MarcoFalke: Merge #12747: Fix typos...
131 2018-03-21 22:06:57	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12747: Fix typos (06master...06typos-201803) 02https://github.com/bitcoin/bitcoin/pull/12747
132 2018-03-21 23:01:47	0|bitcoin-git|13bitcoin/06master 1457dae3f 15donaloconnor: Replace boost::call_once with std::call_once
133 2018-03-21 23:01:47	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2b1c50b9352a...e0f7515f5500
134 2018-03-21 23:01:48	0|bitcoin-git|13bitcoin/06master 14e0f7515 15Pieter Wuille: Merge #12750: Replace boost::call_once with std::call_once...
135 2018-03-21 23:02:37	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #12750: Replace boost::call_once with std::call_once (06master...0621032018_call_once) 02https://github.com/bitcoin/bitcoin/pull/12750