1 2018-03-28 06:30:46	0|bitcoin-git|[13bitcoin] 15murrayn opened pull request #12809: Formatting changes to --help code for increased readability. (06master...06help_formatting) 02https://github.com/bitcoin/bitcoin/pull/12809
  2 2018-03-28 06:53:29	0|bitcoin-git|[13bitcoin] 15romanz opened pull request #12810: [Tests] Fix a typo at assert_start_raises_init_error() and update its invocation (06master...06fix-blocksdir-test) 02https://github.com/bitcoin/bitcoin/pull/12810
  3 2018-03-28 07:34:21	0|wumpus|I've added jnewbery to the issue management team: there's now fanquake, meshcollider, cfields and jnewbery that can help with issues and PRs on github, and open/close them
  4 2018-03-28 08:10:26	0|aj|wumpus: if you haven't noticed already, #12806 is needed to fix travis failure on master
  5 2018-03-28 08:10:28	0|gribble|https://github.com/bitcoin/bitcoin/issues/12806 | qa: Fix function names in feature_blocksdir by MarcoFalke · Pull Request #12806 · bitcoin/bitcoin · GitHub
  6 2018-03-28 08:57:40	0|wumpus|aj: thanks
  7 2018-03-28 08:58:07	0|wumpus|aj: it's strange, I don't have errors while running the test suite locally
  8 2018-03-28 08:58:57	0|aj|wumpus: really? feature_blocksdir should be failing pretty trivially
  9 2018-03-28 08:59:24	0|wumpus|let me check again
 10 2018-03-28 08:59:50	0|wumpus|first want to be sure because I might have a stale file around or such
 11 2018-03-28 09:02:30	0|provoostenator|I'll run it on macOS. Though in my experience the functional test suite rarely passes in a single attempt on my machine.
 12 2018-03-28 09:04:14	0|wumpus|ok yes it's failing
 13 2018-03-28 09:06:09	0|wumpus|let's make the FAILED on the last line red when things fail
 14 2018-03-28 09:06:19	0|aj|wumpus: there's #12810 as well, but i hadn't noticed it causing a bug
 15 2018-03-28 09:06:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/12810 | [Tests] Fix a typo at assert_start_raises_init_error() by romanz · Pull Request #12810 · bitcoin/bitcoin · GitHub
 16 2018-03-28 09:06:39	0|wumpus|it must have just scrolled by yesterday as feature_blocksdir.py is one of the first in the long list, apparently didn't notice
 17 2018-03-28 09:11:32	0|bitcoin-git|13bitcoin/06master 14d71bedb 15MarcoFalke: qa: Fix function names in feature_blocksdir
 18 2018-03-28 09:11:32	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ac898b689c66...18606eb475fb
 19 2018-03-28 09:11:33	0|bitcoin-git|13bitcoin/06master 1418606eb 15Wladimir J. van der Laan: Merge #12806: qa: Fix function names in feature_blocksdir...
 20 2018-03-28 09:12:26	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12806: qa: Fix function names in feature_blocksdir (06master...06Mf1803-qaBlocksdirFixup) 02https://github.com/bitcoin/bitcoin/pull/12806
 21 2018-03-28 09:22:52	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #12811: test: Make summary row bold-red if any test failed (06master...062018_03_tests_summaryrow) 02https://github.com/bitcoin/bitcoin/pull/12811
 22 2018-03-28 09:59:54	0|aj|wumpus: if you're making test_runner nicer, might work to just report all the failed tests at the end so they're easy to find. https://github.com/laanwj/bitcoin/pull/6 has sample code
 23 2018-03-28 10:00:21	0|wumpus|yes, there's probably a ton of different things that could be done
 24 2018-03-28 10:00:36	0|wumpus|I like making the row red though
 25 2018-03-28 10:01:03	0|wumpus|though could do what you propose in addition to that, as it saves scrolling to find what failed
 26 2018-03-28 10:01:05	0|aj|wumpus: i meant as well, not instead :)
 27 2018-03-28 10:01:08	0|wumpus|right :)
 28 2018-03-28 10:03:02	0|wumpus|I'll pull in your commit
 29 2018-03-28 10:03:34	0|aj|wumpus: feel free to squash it, i didn't write a good commit message :)
 30 2018-03-28 10:04:25	0|wumpus|instead of adding a sort_key we change the natural sorting order of the object
 31 2018-03-28 10:05:05	0|wumpus|probably want to sort by 1) status, then within that 2) name
 32 2018-03-28 10:05:16	0|wumpus|oh it does
 33 2018-03-28 10:15:30	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #12812: Test ReadConfigFile (06master...06test-read-config-file) 02https://github.com/bitcoin/bitcoin/pull/12812
 34 2018-03-28 10:25:15	0|bitcoin-git|[13bitcoin] 15murrayn opened pull request #12813: Update man pages (06master...06man_pages) 02https://github.com/bitcoin/bitcoin/pull/12813
 35 2018-03-28 10:43:14	0|aj|wumpus: right, could define __lt__(self, other) by the looks; but i think dealing with status would be more painful that way
 36 2018-03-28 10:43:39	0|wumpus|yes, I looked at it and decided not to bother, it works fine like this, no use in overthinking it
 37 2018-03-28 10:44:35	0|wumpus|in a way having the sort key explicit is kind of nice instead of wondering what kind of magic makes it work
 38 2018-03-28 10:58:45	0|bitcoin-git|[13bitcoin] 15murrayn closed pull request #12813: Update man pages (06master...06man_pages) 02https://github.com/bitcoin/bitcoin/pull/12813
 39 2018-03-28 10:59:51	0|jnewbery|Is there a way to block user https://github.com/btcerichcom from opening issues/PRs?
 40 2018-03-28 11:05:27	0|wumpus|yes, I'll do it
 41 2018-03-28 11:05:55	0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #11614: ZMQ: Add decodedtx topic for JSON tx publishing (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11614
 42 2018-03-28 11:25:04	0|bitcoin-git|13bitcoin/06master 14adc2586 15MarcoFalke: doc: Refer to witness reserved value as spec. in the BIP
 43 2018-03-28 11:25:04	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/18606eb475fb...174d0160cb6b
 44 2018-03-28 11:25:05	0|bitcoin-git|13bitcoin/06master 14174d016 15Wladimir J. van der Laan: Merge #12798: doc: Refer to witness reserved value as spec. in the BIP...
 45 2018-03-28 11:25:47	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12798: doc: Refer to witness reserved value as spec. in the BIP (06master...06Mf1803-docWitnessReservedValue) 02https://github.com/bitcoin/bitcoin/pull/12798
 46 2018-03-28 11:52:28	0|provoostenator|What is bitdb in #11625 ryanofsky?
 47 2018-03-28 11:52:30	0|gribble|https://github.com/bitcoin/bitcoin/issues/11625 | WIP: Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
 48 2018-03-28 14:01:03	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/174d0160cb6b...0d8fc8de076d
 49 2018-03-28 14:01:04	0|bitcoin-git|13bitcoin/06master 14f92541f 15Wladimir J. van der Laan: test: Make summary row bold-red if any test failed...
 50 2018-03-28 14:01:04	0|bitcoin-git|13bitcoin/06master 14ffb033a 15Anthony Towns: test: List any failed tests at the end of test_runner output...
 51 2018-03-28 14:01:05	0|bitcoin-git|13bitcoin/06master 140d8fc8d 15Wladimir J. van der Laan: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table...
 52 2018-03-28 14:01:53	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table (06master...062018_03_tests_summaryrow) 02https://github.com/bitcoin/bitcoin/pull/12811
 53 2018-03-28 14:10:44	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0d8fc8de076d...624bee96597c
 54 2018-03-28 14:10:45	0|bitcoin-git|13bitcoin/06master 141874058 15Evan Klitzke: Make base58 python contrib code work with python3
 55 2018-03-28 14:10:45	0|bitcoin-git|13bitcoin/06master 14bc6fdf2 15John Newbery: Change all python files to use Python3
 56 2018-03-28 14:10:46	0|bitcoin-git|13bitcoin/06master 14624bee9 15Wladimir J. van der Laan: Merge #11881: Remove Python2 support...
 57 2018-03-28 14:11:06	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11881: Remove Python2 support (06master...06remove_python2) 02https://github.com/bitcoin/bitcoin/pull/11881
 58 2018-03-28 14:43:15	0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #12818: [qt] TransactionView: highlight replacement tx after fee bump (06master...062018/03/bump-fee-focus) 02https://github.com/bitcoin/bitcoin/pull/12818
 59 2018-03-28 15:47:16	0|BlueMatt|#10762 looks very merge-able
 60 2018-03-28 15:47:19	0|BlueMatt|wumpus: ^
 61 2018-03-28 15:47:19	0|gribble|https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
 62 2018-03-28 16:05:14	0|jnewbery|release-notes.md conflicts are really irritating. Any thoughts on how to make them stop? Perhaps have a separate release-notes file for each PR that requires them, eg release-notes-pr1234.md, and then concatenate/edit them before the release? Release notes need a lot of editing anyway, so might not add too much overhead
 63 2018-03-28 16:11:05	0|sipa|jnewbery: that doesn't seem like more overhead than the to-wiki-and-back dance we do already at the end
 64 2018-03-28 16:14:52	0|BlueMatt|jimpo: I'd really rather the paralell-txindex stuff not have its own thread
 65 2018-03-28 16:15:25	0|BlueMatt|we have too much thread proliferation already, can it not fit cleanly into just running in the scheduler/validationinterface thread(s) (and we can add another thread there when things get too full)
 66 2018-03-28 16:36:03	0|jimpo|BlueMatt the thread is just for when the index needs to catch up to the blockchain state from way behind (like behind BlockConnected callbacks).
 67 2018-03-28 16:36:25	0|jimpo|Once it gets in sync once, the thread exits and the index is kept in sync by the validation interface.
 68 2018-03-28 16:36:40	0|BlueMatt|ah, ok, right, will finish reviewing before I comment more :p
 69 2018-03-28 16:36:58	0|jimpo|\o/ Code review is happening!
 70 2018-03-28 16:39:00	0|MarcoFalke_trave|wumpus, Are you around for merges? I might send you a list of pulls
 71 2018-03-28 17:16:56	0|paulg222|with bitcoin 0.16 in regtest mode I'm seeing that coinbase transactions are not going to a segwit p2sh wrapped address, but to a regular p2pkh address. Is that expected?
 72 2018-03-28 17:21:28	0|arubi|paulg222, it's going to a p2pk, not p2pkh.  use generatetoaddress
 73 2018-03-28 17:21:47	0|arubi|(if you want a different address that is)
 74 2018-03-28 17:23:01	0|instagibbs|jnewbery, ive had to rebase a couple PRs a couple times each due to that :/
 75 2018-03-28 17:27:32	0|sipa|instagibbs: easy rebases, thankfully :)
 76 2018-03-28 17:28:25	0|instagibbs|muh acks!
 77 2018-03-28 18:04:49	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12820: contrib: Fix check-doc script regexes (06master...06Mf1803-qaCheckDocRegex) 02https://github.com/bitcoin/bitcoin/pull/12820
 78 2018-03-28 18:37:05	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12821: contrib: Remove unused import string (06master...06Mf1803-contribUnusedImportClangFormatDiff) 02https://github.com/bitcoin/bitcoin/pull/12821
 79 2018-03-28 18:44:35	0|BlueMatt|https://github.com/bitcoin/bitcoin/commit/7deba93bdc76616011a9f493cbc203d60084416f <-- wtf? we dont bump trusted-git-root when a pgp key expires...this is what allow-revsit-commits is for. let alone doing so without removing the key from trusted-keys :(
 80 2018-03-28 18:58:03	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #12822: Revert 7deba93bdc76616011a9f493cbc203d60084416f and fix expired-key-sigs properly (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12822
 81 2018-03-28 18:59:58	0|MarcoFalke_trave|BlueMatt, they keys in trusted-keys are the root keys
 82 2018-03-28 19:00:06	0|MarcoFalke_trave|Can't remove them
 83 2018-03-28 19:00:19	0|MarcoFalke_trave|Imo we should change them to the specific subkeys instead
 84 2018-03-28 19:00:38	0|BlueMatt|the key in question expired
 85 2018-03-28 19:00:42	0|MarcoFalke_trave|sipa, around? Mind to merge #12821
 86 2018-03-28 19:00:44	0|gribble|https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
 87 2018-03-28 19:00:45	0|BlueMatt|we tried that, it didnt work very well
 88 2018-03-28 19:00:52	0|BlueMatt|we started with the subkeys listed
 89 2018-03-28 19:00:55	0|BlueMatt|and things blew up regularly
 90 2018-03-28 19:01:29	0|BlueMatt|oh, you're saying your root isnt expired, yea, ok
 91 2018-03-28 19:01:36	0|BlueMatt|either way, shouldnt have updated trusted-git-root
 92 2018-03-28 19:01:42	0|BlueMatt|let alone doing so without a fucking PR
 93 2018-03-28 19:02:17	0|MarcoFalke_trave|Having the root key in there means I can't ever put a subkey on a different machine
 94 2018-03-28 19:02:47	0|MarcoFalke_trave|:s/different/slightly compromised/
 95 2018-03-28 19:02:50	0|BlueMatt|if thats your concern you should have a git-signing separate primary key
 96 2018-03-28 19:03:01	0|BlueMatt|fully-separate them instead of partially combining them
 97 2018-03-28 19:03:23	0|eklitzke|maco when you're traveling your nick should be MarcoPolo
 98 2018-03-28 19:06:01	0|instagibbs|sdaftuar the `IsDust` use in both relay and wallet policy seems like it makes reasoning about p2sh outputs weird to me. I guess you just pretend the output is p2sh-p2wpkh, and use that for relay dust calculation?
 99 2018-03-28 19:06:20	0|instagibbs|(I'm leaving it for now, just thinking aloud)
100 2018-03-28 19:06:26	0|sdaftuar|instagibbs: yeah i was wondering what effect this has on relay policy too -- but figure we might as well just make it right for our wallet at least
101 2018-03-28 19:07:19	0|instagibbs|the functional test already is pretty coarse-grained
102 2018-03-28 19:07:23	0|sdaftuar|so we could just add a way to indicate we want the p2sh-p2wpkh assumption and use that only for our wallet, if we don't want to change relay policy
103 2018-03-28 19:07:28	0|instagibbs|checks that you dump 100 satoshis
104 2018-03-28 19:07:42	0|instagibbs|right
105 2018-03-28 19:08:04	0|instagibbs|or just split the concerns to allow us to move faster with wallet stuff
106 2018-03-28 19:08:39	0|sdaftuar|oh hmm.  i guess the reason we have a discard rate in the first place is to be sure that we have a buffer above the prevailing network dust-fee
107 2018-03-28 19:08:46	0|sdaftuar|so splitting might be counter to that a little
108 2018-03-28 19:09:08	0|sdaftuar|in that we might decouple our calculation from the network-wide policy
109 2018-03-28 19:10:54	0|sdaftuar|oh.. so this is unfortunate i guess, in that current network nodes are applying a dust threshold that is "too high" for our p2sh-segwit wallet. good thing we have a discard rate in the first place i guess!  but given that it gets capped at the long term fee estimate, i'm not sure what value we're actually using now
110 2018-03-28 19:14:50	0|instagibbs|ill update the test at least to be a bit tighter
111 2018-03-28 19:26:44	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12823: doc: Add .gitattributes file for release-notes.md (06master...06Mf1803-docGitattributes) 02https://github.com/bitcoin/bitcoin/pull/12823
112 2018-03-28 19:33:20	0|BlueMatt|#12754 does not look like an "upstream" issue - the reporter indicating some things we should probably do that make upstream behave the proper way
113 2018-03-28 19:33:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/12754 | [zmq] pub/sub is not reliable at all · Issue #12754 · bitcoin/bitcoin · GitHub
114 2018-03-28 19:33:24	0|BlueMatt|should lose the upstream tag
115 2018-03-28 19:33:58	0|MarcoFalke_trave|Removed
116 2018-03-28 20:04:19	0|hkjn0|hey, maybe I'm just missing something basic here, but I had a tx which sendrawtransaction accepted and returned txid, but getrawtransaction (with txindex=1) still can't find.. how can this happen?
117 2018-03-28 20:05:32	0|hkjn0|I'm assuming that if the fee was lower than minrelaytxfee we'd return an error instead of a txid..
118 2018-03-28 20:10:55	0|jnewbery|hkjn0: #bitcoin please. This channel is for bitcoin core development
119 2018-03-28 20:41:20	0|hkjn0|yup, sorry, realized after writing it was off-topic