1 2018-04-10 00:11:13 0|bitcoin-git|[13bitcoin] 15promag opened pull request #12929: Remove CWallet dependency from CWalletTx (06master...062018-04-wallettx) 02 https://github.com/bitcoin/bitcoin/pull/12929
2 2018-04-10 08:13:18 0|bitcoin-git|[13bitcoin] 15conscott opened pull request #12930: WIP Refactor large transaction generation for tests and make generic (06master...06CRS_tests_flexible_tx_size) 02 https://github.com/bitcoin/bitcoin/pull/12930
3 2018-04-10 08:27:27 0|wumpus|jnewbery: you should be able to triage too
4 2018-04-10 08:40:36 0|bitcoin-git|[13bitcoin] 15ajtowns opened pull request #12931: Use winehq debs for i686 win32 tests (06master...06travis-win32) 02 https://github.com/bitcoin/bitcoin/pull/12931
5 2018-04-10 08:41:20 0|wumpus|I think the ideal would be to add things to 'high priority for review' only during/after the meeting, but if there's something really important it's fine to deviate from that (if you mention here)
6 2018-04-10 08:46:21 0|aj|wumpus: ^^ is a first pass at stopping 686-w32 travis builds from being constantly horrible
7 2018-04-10 08:47:35 0|wumpus|aj: thank you, will take a look
8 2018-04-10 12:10:22 0|aj|wumpus: so i think switching travis over to xenial would mean doing docker based builds?
9 2018-04-10 12:10:38 0|wumpus|I don't know
10 2018-04-10 12:12:30 0|aj|https://github.com/travis-ci/travis-ci/issues/5821#issuecomment-214452987
11 2018-04-10 12:27:45 0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/727175a08dff...dd1ca9e0b300
12 2018-04-10 12:27:46 0|bitcoin-git|13bitcoin/06master 14156db42 15Cory Fields: tests: run tests in parallel
13 2018-04-10 12:27:46 0|bitcoin-git|13bitcoin/06master 1466f3255 15Cory Fields: tests: split up actual tests and helper files
14 2018-04-10 12:27:47 0|bitcoin-git|13bitcoin/06master 14f6dfb0f 15Pieter Wuille: Reorder travis builds
15 2018-04-10 12:28:51 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12926: Run unit tests in parallel (06master...06201804_parunit) 02 https://github.com/bitcoin/bitcoin/pull/12926
16 2018-04-10 13:25:14 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged (06master...062018_04_redundant_argument) 02 https://github.com/bitcoin/bitcoin/pull/12932
17 2018-04-10 13:29:22 0|bitcoin-git|13bitcoin/06master 14fa385c3 15MarcoFalke: [doc] devtools: Setup ots git integration
18 2018-04-10 13:29:22 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/dd1ca9e0b300...ebd786b72a2a
19 2018-04-10 13:29:23 0|bitcoin-git|13bitcoin/06master 14ebd786b 15Wladimir J. van der Laan: Merge #12852: [doc] devtools: Setup ots git integration...
20 2018-04-10 13:30:17 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12852: [doc] devtools: Setup ots git integration (06master...06Mf1803-docOtsGit) 02 https://github.com/bitcoin/bitcoin/pull/12852
21 2018-04-10 13:34:19 0|bitcoin-git|13bitcoin/06master 14b63f23c 15Luke Dashjr: Add P2P, Network, and Qt categories to the desktop icon
22 2018-04-10 13:34:19 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/ebd786b72a2a...5ca1509d6af5
23 2018-04-10 13:34:21 0|bitcoin-git|13bitcoin/06master 145ca1509 15Wladimir J. van der Laan: Merge #12854: Add P2P, Network, and Qt categories to the desktop icon...
24 2018-04-10 13:34:34 0|cfields|wumpus: heh, i didn't see that you proposed the parallel tests via makefile as a joke :)
25 2018-04-10 13:34:59 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12854: Add P2P, Network, and Qt categories to the desktop icon (06master...06desktop_categories) 02 https://github.com/bitcoin/bitcoin/pull/12854
26 2018-04-10 13:35:44 0|wumpus|cfields: it seemed like a hacky low-tech way to parallelize something, but thinking about it more it's actually a good solution that integrates well with the build system
27 2018-04-10 13:36:26 0|cfields|heh, agree on both fronts
28 2018-04-10 13:48:20 0|promag|wumpus: do you think #12929 makes sense?
29 2018-04-10 13:48:23 0|gribble|https://github.com/bitcoin/bitcoin/issues/12929 | Remove CWallet dependency from CWalletTx by promag ÷ Pull Request #12929 ÷ bitcoin/bitcoin ÷ GitHub
30 2018-04-10 13:48:35 0|wumpus|haven't looked at it yet
31 2018-04-10 13:48:54 0|wumpus|I think we should get the label stuff done first now
32 2018-04-10 13:48:57 0|promag|oh ok
33 2018-04-10 14:58:27 0|bitcoin-git|13bitcoin/06master 149b9d717 15Wladimir J. van der Laan: wallet: Remove redundant lambda function arg in handleTransactionChanged...
34 2018-04-10 14:58:27 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/5ca1509d6af5...8d651ae32013
35 2018-04-10 14:58:28 0|bitcoin-git|13bitcoin/06master 148d651ae 15MarcoFalke: Merge #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged...
36 2018-04-10 14:59:26 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged (06master...062018_04_redundant_argument) 02 https://github.com/bitcoin/bitcoin/pull/12932
37 2018-04-10 15:07:48 0|promag|jnewbery: should listlabels give sorted labels? if so update help message? if not then my suggestion is valid
38 2018-04-10 15:33:54 0|jnewbery|I don't think the help message needs to be updated. What other sane way would there be to display a list of strings?
39 2018-04-10 15:34:23 0|jnewbery|dictionary sorted is the obvious choice
40 2018-04-10 15:34:55 0|jnewbery|thanks for the review BTW :)
41 2018-04-10 15:40:49 0|jnewbery|I've added a code comment to explain why the labels are added to a list and then inserted into the univalue array
42 2018-04-10 16:08:59 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12831: [WIP] Run unit tests in parallel (06master...06Mf1803-qaUnitParallel) 02 https://github.com/bitcoin/bitcoin/pull/12831
43 2018-04-10 16:15:09 0|bitcoin-git|[13bitcoin] 15sipa closed pull request #12890: [DEBUG TRAVIS] Detailed unit test report for win32 (06master...06201803_debugtravis) 02 https://github.com/bitcoin/bitcoin/pull/12890
44 2018-04-10 17:36:16 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/8d651ae32013...a84b056d5f1b
45 2018-04-10 17:36:17 0|bitcoin-git|13bitcoin/06master 145805d6f 15Gregory Sanders: feebumper: discard change outputs below discard rate
46 2018-04-10 17:36:17 0|bitcoin-git|13bitcoin/06master 14f526046 15Gregory Sanders: adapt bumpfee change discard test to be more strict and add note on p2sh discrep
47 2018-04-10 17:36:18 0|bitcoin-git|13bitcoin/06master 14a84b056 15Wladimir J. van der Laan: Merge #12749: [wallet] feebumper: discard change outputs below discard rate...
48 2018-04-10 17:37:11 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12749: [wallet] feebumper: discard change outputs below discard rate (06master...06discardbump) 02 https://github.com/bitcoin/bitcoin/pull/12749
49 2018-04-10 18:44:03 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12933: Revert "Add Travis check for duplicate includes" (06master...06Mf1804-docIncludes) 02 https://github.com/bitcoin/bitcoin/pull/12933
50 2018-04-10 18:55:12 0|bitcoin-git|13bitcoin/06master 14818dc74 15Pieter Wuille: Support serialization as another type without casting...
51 2018-04-10 18:55:12 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/a84b056d5f1b...0a8054e7cd5c
52 2018-04-10 18:55:13 0|bitcoin-git|13bitcoin/06master 140a8054e 15Wladimir J. van der Laan: Merge #12731: Support serialization as another type without casting...
53 2018-04-10 18:55:55 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12731: Support serialization as another type without casting (06master...06201803_astype) 02 https://github.com/bitcoin/bitcoin/pull/12731
54 2018-04-10 19:10:55 0|jamesob|man, travis feels a lot snapper today :)
55 2018-04-10 19:11:02 0|jamesob|*snappier
56 2018-04-10 19:11:41 0|jamesob|who'dve thought it'd be because of automake
57 2018-04-10 19:17:32 0|jamesob|sipa: oh wait - it's also because we now have 15 travis jobs :)
58 2018-04-10 19:18:02 0|jonasschnelli|Yes. Seems like the Chaincode/Travis action seems to work
59 2018-04-10 19:19:55 0|sipa|jamesob: how many did we have before?
60 2018-04-10 19:22:24 0|jamesob|sipa: they no longer show it on their pricing page, but I think it was something like 5? cc MarcoFalke
61 2018-04-10 20:23:42 0|jonasschnelli|jamesob: I guess you don't need to include src/qt/locale/bitcoin_en.ts in #12830
62 2018-04-10 20:23:44 0|gribble|https://github.com/bitcoin/bitcoin/issues/12830 | [qt] [tests] Clarify address book error messages, add tests by jamesob ÷ Pull Request #12830 ÷ bitcoin/bitcoin ÷ GitHub
63 2018-04-10 20:23:58 0|jonasschnelli|It's autogenerated by the maintainers
64 2018-04-10 20:24:32 0|jamesob|jonasschnelli: okay, will revert
65 2018-04-10 21:40:46 0|luke-jr|I don't suppose anyone knows how to make vmbuilder work with Debian stable? :/
66 2018-04-10 21:42:05 0|joshb[m]|vm...builder...?
67 2018-04-10 21:42:17 0|joshb[m]|I might ask...why...first
68 2018-04-10 21:43:44 0|luke-jr|yes, the first step to setting up gitian
69 2018-04-10 21:54:35 0|bitcoin-git|[13bitcoin] 15skeees opened pull request #12934: [WIP] [net] [validation] Call ProcessNewBlock() asynchronously (06master...06module-isolation) 02 https://github.com/bitcoin/bitcoin/pull/12934
70 2018-04-10 23:23:34 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12935: Add ProcessOrphans (move-only) (06master...06Mf1804-ProcessOrphans) 02 https://github.com/bitcoin/bitcoin/pull/12935