1 2018-04-16 03:08:49 0|fanquake|kallewoof Would you be able to share your clang static analyzer setup?
2 2018-04-16 04:11:44 0|kallewoof|fanquake: Absolutely. It was awhile ago that I set it up though, but I'll write a gist on how to get it up on a mac.
3 2018-04-16 04:23:08 0|kallewoof|fanquake: Lemme know if this works? https://gist.github.com/kallewoof/8984c56399e8d23ee54dd695d2660b7a
4 2018-04-16 05:09:14 0|fanquake|kallewoof cheers, I'll be playing around with it this arvo
5 2018-04-16 06:32:26 0|fanquake|wumpus hanging around to do a bit of merging?
6 2018-04-16 06:33:28 0|wumpus|fanquake: sure, if you have any suggestions
7 2018-04-16 06:33:49 0|fanquake|wumpus #12986 is something trivial to get started
8 2018-04-16 06:33:50 0|gribble|https://github.com/bitcoin/bitcoin/issues/12986 | Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 by okayplanet ÷ Pull Request #12986 ÷ bitcoin/bitcoin ÷ GitHub
9 2018-04-16 06:35:34 0|bitcoin-git|13bitcoin/06master 14d1b828b 15okayplanet: correcting the array name from pnSeeds6 to pnSeed6
10 2018-04-16 06:35:34 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/e76acf3384ac...3fef58c82d7a
11 2018-04-16 06:35:35 0|bitcoin-git|13bitcoin/06master 143fef58c 15Wladimir J. van der Laan: Merge #12986: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6...
12 2018-04-16 06:36:23 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12986: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 (06master...06comment_correction) 02 https://github.com/bitcoin/bitcoin/pull/12986
13 2018-04-16 06:37:03 0|fanquake|wumpus #12951 is another
14 2018-04-16 06:37:05 0|gribble|https://github.com/bitcoin/bitcoin/issues/12951 | [doc] Fix comment in FindForkInGlobalIndex by jamesob ÷ Pull Request #12951 ÷ bitcoin/bitcoin ÷ GitHub
15 2018-04-16 06:38:19 0|wumpus|thank!
16 2018-04-16 06:38:34 0|bitcoin-git|13bitcoin/06master 140ef7b40 15James O'Beirne: [doc] Fix comment in FindForkInGlobalIndex...
17 2018-04-16 06:38:34 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/3fef58c82d7a...6df0c6cb4169
18 2018-04-16 06:38:35 0|bitcoin-git|13bitcoin/06master 146df0c6c 15Wladimir J. van der Laan: Merge #12951: [doc] Fix comment in FindForkInGlobalIndex...
19 2018-04-16 06:39:18 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12951: [doc] Fix comment in FindForkInGlobalIndex (06master...062018-04-11-findforkinglobalindex-doc) 02 https://github.com/bitcoin/bitcoin/pull/12951
20 2018-04-16 06:43:25 0|fanquake|wumpus your leveldb work in #12968 does that comflict with anything being done upstream? Just looking at https://github.com/bitcoin-core/leveldb/pull/17/commits/5c39524f3639e6bf6ab49215152d24273e662986
21 2018-04-16 06:43:26 0|gribble|https://github.com/bitcoin/bitcoin/issues/12968 | leveldb: Add ARMv8 CRC32C support by laanwj ÷ Pull Request #12968 ÷ bitcoin/bitcoin ÷ GitHub
22 2018-04-16 06:43:59 0|fanquake|Wondering if we want to try and get https://github.com/bitcoin-core/leveldb/pull/17 in soon.
23 2018-04-16 06:44:11 0|wumpus|fanquake: oh, didn't know about that!
24 2018-04-16 06:44:41 0|wumpus|looks like I pretty much wasted my time there :/
25 2018-04-16 06:44:54 0|fanquake|:( I had half a thought you might be re-doing some work
26 2018-04-16 06:45:12 0|fanquake|Although Ideally you've got something to contribute back upstream?
27 2018-04-16 06:45:24 0|wumpus|that's what you get for actually trying to write some code for a change :-)
28 2018-04-16 06:45:27 0|jonasschnelli|Oh. They also did SEE CRC! :(
29 2018-04-16 06:46:20 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12968: leveldb: Add ARMv8 CRC32C support (06master...062018_04_armv8_crc32c) 02 https://github.com/bitcoin/bitcoin/pull/12968
30 2018-04-16 06:46:20 0|wumpus|jonasschnelli: yes https://github.com/google/crc32c/blob/master/src/crc32c_arm64.cc
31 2018-04-16 06:48:34 0|fanquake|I guess we should prioritze https://github.com/bitcoin-core/leveldb/pull/17 then. It also cleans up some of those annoying static analyzer warnings..
32 2018-04-16 06:49:15 0|fanquake|A shame we can't add PRs from other repos to our project lists.
33 2018-04-16 06:50:57 0|wumpus|fanquake: yes good idea i'll have a look at that
34 2018-04-16 06:52:43 0|aj|can have PRs from multiple repos if the project is an org-project, i think? https://github.com/orgs/bitcoin/projects
35 2018-04-16 06:53:42 0|fanquake|aj unfortunately all of the /bitcoin subtrees are at /bitcoin-core
36 2018-04-16 06:54:24 0|aj|ah good point
37 2018-04-16 06:55:29 0|fanquake|aj did you end up getting the static analyzer working?
38 2018-04-16 06:56:27 0|aj|fanquake: no, haven't tried the gist though (i didn't run autogen.sh through scan-build when i tried)
39 2018-04-16 06:58:05 0|fanquake|aj ok. I'll be having a look at it again shortly.
40 2018-04-16 06:59:43 0|fanquake|Thinking out load, not that we are seeing a lot more "Fix warning from analyzer X" type PRs. I think it'd be beneficial (maybe in a PR template?) to add some guidelines around opening those sort of PRs.
41 2018-04-16 07:00:39 0|wumpus|I agree
42 2018-04-16 07:00:47 0|fanquake|At least including the compiler/version, the tool/version, which flags your passing to ./configure, which commit your building etc.
43 2018-04-16 07:01:06 0|wumpus|we're only interested in seeing such PRs *if* they fix issues that would be an issue without the static analyser as well, e.g. actual problems
44 2018-04-16 07:01:14 0|fanquake|Otherwise, I look at a PR (for example) like #12882, and don't really have a quick way to just setup and atleast test the changes.
45 2018-04-16 07:01:14 0|wumpus|not 'work around bugs in my tool'
46 2018-04-16 07:01:15 0|gribble|https://github.com/bitcoin/bitcoin/issues/12882 | tests: Make test_bitcoin pass under ThreadSanitzer (clang). Fix lock-order-inversion (potential deadlock). by practicalswift ÷ Pull Request #12882 ÷ bitcoin/bitcoin ÷ GitHub
47 2018-04-16 07:01:35 0|fanquake|wumpus yes. And being able to reproduce issues quickly and easier is key to that.
48 2018-04-16 07:02:11 0|fanquake|I don't really want to waste time trying to recreate some obscure issue, and then findout they were using HEAD version of X tool, which may or may not produce correct results.
49 2018-04-16 07:02:22 0|wumpus|right
50 2018-04-16 07:02:49 0|fanquake|Or using some *older* version of a tool that spews since-fixed warnings.
51 2018-04-16 07:03:10 0|wumpus|my point is also that the kind of changes we're interested in are usually easy to inspect, I mean, the static analyser finds a bug that normal review would also have found given enough eyes on the matter
52 2018-04-16 07:03:50 0|fanquake|wumpus sure
53 2018-04-16 07:12:01 0|wumpus|if some obscure, hand-rolled analysis tool finds an important bug we'd be very thankful, but not if it comes with 20 screenfuls of false positives
54 2018-04-16 07:13:11 0|fanquake|wumpus I agree, I'm not advocating "against" people hammering the codebase with whatever tools they want. Just want to make sure that when it appears in a PR it's something useful.
55 2018-04-16 07:17:03 0|wumpus|indeed
56 2018-04-16 07:20:01 0|fanquake|I feel like if at some point we write enough bash scripts & linters, the repository will just about be able to maintain itself indefinitely
57 2018-04-16 07:20:40 0|wumpus|a kind of mutation engine for software evolution
58 2018-04-16 07:23:27 0|sipa|i think we should be able to write scripted diffs into the blockchain and have them be applied automatically to the source code
59 2018-04-16 07:25:14 0|fanquake|heh the *real* devcoin
60 2018-04-16 07:27:32 0|wumpus|hehehe
61 2018-04-16 07:29:34 0|sipa|is that really 6 years old already :o
62 2018-04-16 07:48:54 0|Kanna|any idea about soft fork ? and how to do this ?
63 2018-04-16 07:49:45 0|fanquake|Kanna in what conext?
64 2018-04-16 07:49:57 0|sipa|consensus changes to bitcoin are generally discussed on the mailing list
65 2018-04-16 07:51:57 0|Kanna|I want to do the bitcoin fork with some predefined block size for example 4mb [ Testing ]
66 2018-04-16 07:53:35 0|Kanna|<fanquake> my fork should happen on this parameter Max Blocksize 8MB Block time 2 mins or 2.5 [ to test the bitcoin fork ]
67 2018-04-16 07:57:32 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12993: tests: Remove compatibility code not needed now when we're on Python 3 (06master...06remove-python-2-compatibility-code) 02 https://github.com/bitcoin/bitcoin/pull/12993
68 2018-04-16 08:03:33 0|sipa|Kanna: other currencies are off topic here
69 2018-04-16 08:36:48 0|fanquake|Has anyone recreated #12990 ? I'm unable to on Ubuntu with GCC8.0.1 20180414
70 2018-04-16 08:36:49 0|gribble|https://github.com/bitcoin/bitcoin/issues/12990 | depends: Fix libX11 build on gcc 8 by MarcoFalke ÷ Pull Request #12990 ÷ bitcoin/bitcoin ÷ GitHub
71 2018-04-16 09:01:01 0|Kanna|How to reduce the latency of the transaction ? Do i need to consder block size on this ?
72 2018-04-16 09:04:28 0|wumpus|Kanna: off topic here, go to #bitcoin
73 2018-04-16 12:05:00 0|jonasschnelli|I just tried to run the "bitcoin-0.16.99-arm-linux-gnueabihf-debug.tar.gz" debug binaries on my arm machine but get a "cannot execute binary file: Exec format error"
74 2018-04-16 12:05:32 0|jonasschnelli|readelf -A bitcoin-tx.dbg tells me it should be executable
75 2018-04-16 12:06:20 0|jonasschnelli|I probably doing something wrong...
76 2018-04-16 12:15:57 0|jonasschnelli|Here is a typical connect block debug bench on the Odroid XU4 / SSD [USB3] (Cortex A15):
77 2018-04-16 12:15:57 0|jonasschnelli|https://0bin.net/paste/xOW+V1HiOM48zuhl#hHmGoxLA4xI7VkDv581ZVg-cm4E5D+mJdNvzqxxgWhA
78 2018-04-16 12:40:26 0|jonasschnelli|Odroid XU4 SSD via USB3 sync against random peers with 600MB dbcache maxmempool 50MB: 42 hours (2573 minutes)
79 2018-04-16 12:40:45 0|jonasschnelli|(no assumevalid point given)
80 2018-04-16 13:42:05 0|jonasschnelli|fricking github unicorn
81 2018-04-16 14:15:47 0|wumpus|github: everyone's favourite unicorn farming game
82 2018-04-16 14:16:38 0|wumpus|jonasschnelli: @I just tried to run the "bitcoin-0.16.99-arm-linux-gnueabihf-debug.tar.gz": that's expected, the debug files contain separate debug information for the main executables, they're not executable in themselves
83 2018-04-16 14:17:37 0|jonasschnelli|wumpus: Then I guess I need to run the split-debug.sh script
84 2018-04-16 14:17:38 0|fanquake|wumpus need to swap unicorns for black holes
85 2018-04-16 14:18:01 0|wumpus|fanquake: yess
86 2018-04-16 14:19:09 0|wumpus|jonasschnelli: if you wnt to debug something, gdb can cope with external debug symbols, but yes another option is to re-merge the debug information into the executable
87 2018-04-16 14:20:16 0|jonasschnelli|wumpus: I want to time profile the binary... I cross compile armv7 with -O2 -g not via depends. But callgrind is extremly (too) slow
88 2018-04-16 14:20:32 0|jonasschnelli|*cross compiled*
89 2018-04-16 14:20:36 0|wumpus|ok
90 2018-04-16 14:20:50 0|jonasschnelli|any time profiling recommendation?
91 2018-04-16 14:21:06 0|jonasschnelli|(currently trying to compile "perf")
92 2018-04-16 14:21:20 0|wumpus|perf! (@eklitzke)
93 2018-04-16 14:21:48 0|wumpus|IIRC perf is a sampling profiler instead of an instrumenting one so it has less effect on runtime speed
94 2018-04-16 14:22:12 0|jonasschnelli|yes. that is what I want... it just don't come out-of-the box for Odroid XU4
95 2018-04-16 14:22:23 0|wumpus|what rootfs do you use?
96 2018-04-16 14:23:16 0|jonasschnelli|I'm currently using the SD card they provide
97 2018-04-16 14:23:22 0|jonasschnelli|some ubuntu derivate
98 2018-04-16 14:23:36 0|wumpus|ah right, perf is part of the kernel tools, at least on ubuntu it matches the kernel version (linux-tools-x.y.z)
99 2018-04-16 14:24:45 0|wumpus|no "linux-tools-c2" package
100 2018-04-16 14:34:57 0|bitcoin-git|13bitcoin/06master 14b95f9a6 15practicalswift: tests: Remove compatibility code not needed now when we're on Python 3
101 2018-04-16 14:34:57 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/6df0c6cb4169...0d6992168c2b
102 2018-04-16 14:34:58 0|bitcoin-git|13bitcoin/06master 140d69921 15Wladimir J. van der Laan: Merge #12993: tests: Remove compatibility code not needed now when we're on Python 3...
103 2018-04-16 14:35:50 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12993: tests: Remove compatibility code not needed now when we're on Python 3 (06master...06remove-python-2-compatibility-code) 02 https://github.com/bitcoin/bitcoin/pull/12993
104 2018-04-16 15:34:30 0|sdaftuar|wumpus: #11739 could benefit from concentrated review, it's collected ACKs over several months but due to rebase and nit-fixes, there's only one ACK on the current commit. would this be a reasonable PR to tag "high priority for review"?
105 2018-04-16 15:34:33 0|gribble|https://github.com/bitcoin/bitcoin/issues/11739 | Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis by sdaftuar ÷ Pull Request #11739 ÷ bitcoin/bitcoin ÷ GitHub
106 2018-04-16 15:34:36 0|sdaftuar|wumpus: to be clear, it's not blocking me on anything
107 2018-04-16 15:35:35 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #12996: tests: Remove redundant bytes(ââ¬Â¦) calls (06master...06bytesò) 02 https://github.com/bitcoin/bitcoin/pull/12996
108 2018-04-16 15:37:54 0|jnewbery|sdaftuar: +1. It'd be good to get that one merged. I also plan to rebase #12360 on it (they conflict so there's no point in rebasing mine until yours gets in)
109 2018-04-16 15:37:56 0|gribble|https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery ÷ Pull Request #12360 ÷ bitcoin/bitcoin ÷ GitHub
110 2018-04-16 15:38:01 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #12997: [doc] build-windows: Switch to Artful, since Zesty is EOL (06master...06Mf1804-docBuildWinArtful) 02 https://github.com/bitcoin/bitcoin/pull/12997
111 2018-04-16 15:47:41 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #12998: Default to defining endian-conversion DECLs in compat w/o config (06master...062018-04-default-decls) 02 https://github.com/bitcoin/bitcoin/pull/12998
112 2018-04-16 15:51:50 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/0d6992168c2b...fe8fa22d7a4a
113 2018-04-16 15:51:51 0|bitcoin-git|13bitcoin/06master 14643aad1 15practicalswift: Enable additional flake8 rules
114 2018-04-16 15:51:51 0|bitcoin-git|13bitcoin/06master 14f020aca 15practicalswift: Minor Python cleanups to make flake8 pass with the new rules enabled
115 2018-04-16 15:51:52 0|bitcoin-git|13bitcoin/06master 14fe8fa22 15MarcoFalke: Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis...
116 2018-04-16 15:52:37 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis (06master...06enable-flake8-checks) 02 https://github.com/bitcoin/bitcoin/pull/12987
117 2018-04-16 15:55:32 0|bitcoin-git|13bitcoin/06master 149db48c5 15practicalswift: tests: Remove redundant bytesò
118 2018-04-16 15:55:32 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/fe8fa22d7a4a...6a278e064009
119 2018-04-16 15:55:33 0|bitcoin-git|13bitcoin/06master 146a278e0 15MarcoFalke: Merge #12996: tests: Remove redundant bytes(ââ¬Â¦) calls...
120 2018-04-16 15:56:22 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12996: tests: Remove redundant bytes(ââ¬Â¦) calls (06master...06bytesò) 02 https://github.com/bitcoin/bitcoin/pull/12996
121 2018-04-16 16:30:28 0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #12999: qt: Show the Window when double clicking the taskbar icon (06master...06qt-fix) 02 https://github.com/bitcoin/bitcoin/pull/12999
122 2018-04-16 16:50:02 0|jamesob|the only reason ActivateBestChain is split up into steps is to reduce cs_main contention, right?
123 2018-04-16 16:57:29 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13000: travis: Switch to xenial (06master...06Mf1804-travisXenial) 02 https://github.com/bitcoin/bitcoin/pull/13000
124 2018-04-16 17:03:01 0|sipa|jamesob: yes, note that it performs an entire reorg if necessary
125 2018-04-16 17:03:15 0|sipa|so there's no real bound on how long it takes
126 2018-04-16 17:05:16 0|jamesob|sipa: and gets a single large call during reindexing, no?
127 2018-04-16 17:05:23 0|jamesob|s/large/long
128 2018-04-16 17:06:19 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13000: travis: Switch to xenial (06master...06Mf1804-travisXenial) 02 https://github.com/bitcoin/bitcoin/pull/13000
129 2018-04-16 17:07:44 0|sipa|jamesob: right, after reindexing, it's called as part of the node startup to switch to the best chain
130 2018-04-16 17:07:47 0|jamesob|(which made, e.g., https://github.com/bitcoin/bitcoin/pull/11824 necessary)
131 2018-04-16 17:08:02 0|sipa|in case of a real reindex, that means one call does the entire activation
132 2018-04-16 17:22:06 0|wumpus|sdaftuar: sure, agree, added
133 2018-04-16 17:39:01 0|jimpo|Travis isn't running on two of my PRs :-(: 12954 & 12647.
134 2018-04-16 17:40:16 0|wumpus|isn't running? or failing?
135 2018-04-16 17:42:30 0|jimpo|Isn't running. Or at least not reporting back to GitHub.
136 2018-04-16 17:42:43 0|jimpo|I'll check if there's actually a build on travis-ci
137 2018-04-16 17:44:07 0|jimpo|I can't find them if they're there
138 2018-04-16 17:45:51 0|jonasschnelli|dcousens: where is you indexd (python index daemon) source code? Can't find it.
139 2018-04-16 17:46:31 0|jamesob|@jimpo any chance Travis has flagged your account for abuse? happened to me recently
140 2018-04-16 17:47:04 0|jimpo|Haha, I have no idea. How do you find out?
141 2018-04-16 17:56:19 0|jamesob|jimpo: https://i.imgur.com/52JpZxo.png
142 2018-04-16 17:56:30 0|jonasschnelli|happend to me before as well
143 2018-04-16 17:56:51 0|jamesob|(if you dare click an imgur link during work hours ;)
144 2018-04-16 17:58:12 0|jonasschnelli|jimpo: you can try a force push and I'll check what happend in the "requests" area in travis
145 2018-04-16 17:58:35 0|jonasschnelli|(can only see the last ~20 requests and those look good)
146 2018-04-16 18:07:51 0|jimpo|Just force pushed #12647
147 2018-04-16 18:07:52 0|gribble|https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo ÷ Pull Request #12647 ÷ bitcoin/bitcoin ÷ GitHub
148 2018-04-16 18:10:24 0|jonasschnelli|"Abuse detected" (jimpo)
149 2018-04-16 18:10:42 0|jonasschnelli|I guess your blocked... you need to write an email to the travis support team
150 2018-04-16 18:19:02 0|jimpo|:-(
151 2018-04-16 18:20:54 0|votefrac|Also Travis is slow sometimes isn't it
152 2018-04-16 18:21:15 0|votefrac|Wouldn't move to Jenkins be helpful
153 2018-04-16 18:27:23 0|jonasschnelli|no
154 2018-04-16 18:53:06 0|bitcoin-git|[13bitcoin] 15laanwj pushed 12 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/6a278e064009...4366f61cc9d4
155 2018-04-16 18:53:07 0|bitcoin-git|13bitcoin/06master 143673ca3 15Anthony Towns: ArgsManager: keep command line and config file arguments separate
156 2018-04-16 18:53:07 0|bitcoin-git|13bitcoin/06master 144d34fcc 15Anthony Towns: ArgsManager: drop m_negated_args...
157 2018-04-16 18:53:08 0|bitcoin-git|13bitcoin/06master 1495eb66d 15Anthony Towns: ArgsManager: support config file sections
158 2018-04-16 18:53:31 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11862: Network specific conf sections (06master...06netconf-sections) 02 https://github.com/bitcoin/bitcoin/pull/11862
159 2018-04-16 19:10:10 0|jnewbery|\o/
160 2018-04-16 20:05:14 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/4366f61cc9d4...07825088f9cf
161 2018-04-16 20:05:15 0|bitcoin-git|13bitcoin/06master 142bff472 15John Newbery: [contrib] convert test-security-check to python3
162 2018-04-16 20:05:15 0|bitcoin-git|13bitcoin/06master 14958bf40 15practicalswift: add lint tool to check python3 shebang
163 2018-04-16 20:05:16 0|bitcoin-git|13bitcoin/06master 140782508 15MarcoFalke: Merge #12972: Add python3 script shebang lint...
164 2018-04-16 20:06:04 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12972: Add python3 script shebang lint (06master...06explicit_python3) 02 https://github.com/bitcoin/bitcoin/pull/12972