1 2018-04-17 01:13:04	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13002: Do not treat bare multisig outputs as IsMine unless watched (06master...06201804_cleanismine) 02https://github.com/bitcoin/bitcoin/pull/13002
 2 2018-04-17 01:15:54	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #12874: Only accept bare multisig outputs after addmultisigaddress (06master...06201803_nowalletbaremultisig) 02https://github.com/bitcoin/bitcoin/pull/12874
 3 2018-04-17 03:17:28	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13003: qa: Add test for orphan handling (06master...06Mf1804-qaOrphans) 02https://github.com/bitcoin/bitcoin/pull/13003
 4 2018-04-17 03:40:59	0|bitcoin-git|[13bitcoin] 15ajtowns closed pull request #12931: Use winehq debs for win32 tests (06master...06travis-win32) 02https://github.com/bitcoin/bitcoin/pull/12931
 5 2018-04-17 05:27:26	0|fanquake|Turns out if you close/crash Bitcoin Core in the way described in #12838, it just refuses to launch again.
 6 2018-04-17 05:27:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/12838 | QT: double click bitcoin icon on the task bar with setting minimize to the tray cause a blank window · Issue #12838 · bitcoin/bitcoin · GitHub
 7 2018-04-17 05:28:09	0|fanquake|Looking at the docs for QLocalServer::removeServer, "On Windows, this function does nothing; on Unix, ...". Could be the cause of the problem.
 8 2018-04-17 05:29:07	0|aj|fanquake: the gist static analyser instructions worked fine for me btw (well, i used the clang-tools-7 package on debian rather than downloading directly)
 9 2018-04-17 05:30:21	0|fanquake|aj Cool. Found anything interesting yet :p
10 2018-04-17 05:31:14	0|aj|fanquake: no, tried tracing something back but got confused before i got to the root cause. looks good though
11 2018-04-17 06:36:08	0|jonasschnelli|Is there a way to get the CBlockIndex in the main chain from a CDiskBlockPos object?
12 2018-04-17 06:39:42	0|sipa|get the hash of the CDiskBlockPos object, look it up in mapBlockIndex ?
13 2018-04-17 06:56:10	0|jonasschnelli|sipa: I'd like to check if the CDiskTxPos object refers to a pruned block... I guess this is not possible though.
14 2018-04-17 06:56:48	0|jonasschnelli|I can check if the file exists,... though would prefer to check if HAVE_DATA
15 2018-04-17 08:03:31	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13004: Print to console by default when not run with -daemon (06master...06printtoconsole) 02https://github.com/bitcoin/bitcoin/pull/13004
16 2018-04-17 08:07:13	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12689: Smarter default behavior for -printtoconsole (06master...06console) 02https://github.com/bitcoin/bitcoin/pull/12689
17 2018-04-17 08:47:53	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13005: Make --enable-debug to pick better options (06master...06enabledebug-again) 02https://github.com/bitcoin/bitcoin/pull/13005
18 2018-04-17 08:52:48	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #12695: [build] Make --enable-debug pick better options (06master...06enabledebug) 02https://github.com/bitcoin/bitcoin/pull/12695
19 2018-04-17 08:56:27	0|jonasschnelli|Since days, I can't view #11857, always get a unicorn... anyone else?
20 2018-04-17 08:56:30	0|gribble|https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
21 2018-04-17 08:56:32	0|jonasschnelli|ping jimpo
22 2018-04-17 08:57:01	0|jonasschnelli|jimpo: maybe rebase regardless of merge conflicts... eventually its stuck in github caches
23 2018-04-17 08:59:01	0|bitcoin-git|13bitcoin/06master 142eb5036 15Akio Nakamura: macOS: Prevent Xcode 9.3 build warnings...
24 2018-04-17 08:59:01	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/07825088f9cf...307699304886
25 2018-04-17 08:59:02	0|bitcoin-git|13bitcoin/06master 143076993 15Jonas Schnelli: Merge #12899: macOS: Prevent Xcode 9.3 build warnings...
26 2018-04-17 08:59:46	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #12899: macOS: Prevent Xcode 9.3 build warnings (06master...06preventxcodebuildwarnings) 02https://github.com/bitcoin/bitcoin/pull/12899
27 2018-04-17 09:28:41	0|kallewoof|jonasschnelli: Getting unicorn too, for ^...
28 2018-04-17 11:28:13	0|jonasschnelli|Does the txindex (or txdb) support multiple values per a single key? If I use leveldb->Write(), will it overwrite a possible existing value for a key if the key already exists?
29 2018-04-17 11:28:24	0|jonasschnelli|It is probably configurable per db env?
30 2018-04-17 13:58:24	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/307699304886...434150aef798
31 2018-04-17 13:58:25	0|bitcoin-git|13bitcoin/06master 141936125 15João Barbosa: wallet: Make WalletInitInterface members const
32 2018-04-17 13:58:25	0|bitcoin-git|13bitcoin/06master 146ec78f1 15João Barbosa: wallet: Refactor g_wallet_init_interface to const reference
33 2018-04-17 13:58:26	0|bitcoin-git|13bitcoin/06master 14434150a 15Wladimir J. van der Laan: Merge #12977: Refactor g_wallet_init_interface to const reference...
34 2018-04-17 13:58:43	0|wumpus|jonasschnelli: like a map, leveldb has a strict one key to one value mapping, so yes if you Write another value to the same key it will overwrite that
35 2018-04-17 13:58:50	0|wumpus|(maybe I misunderstand your question though)
36 2018-04-17 13:59:09	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12977: Refactor g_wallet_init_interface to const reference (06master...062018-04-walletinitinterface) 02https://github.com/bitcoin/bitcoin/pull/12977
37 2018-04-17 14:00:28	0|instagibbs|"Our team are currently investigating timeouts with some pull requests and I've added your report to our list." I reported the unicorn, no ETA but at least it's in a queue...
38 2018-04-17 14:01:16	0|bitcoin-git|13bitcoin/06master 14d86edd3 15Jesse Cohen: Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip...
39 2018-04-17 14:01:16	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/434150aef798...39e0c65b29eb
40 2018-04-17 14:01:17	0|bitcoin-git|13bitcoin/06master 1439e0c65 15Wladimir J. van der Laan: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal...
41 2018-04-17 14:02:04	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12988: Hold cs_main while calling UpdatedBlockTip() signal (06master...06updatedblocktip-race) 02https://github.com/bitcoin/bitcoin/pull/12988
42 2018-04-17 14:09:05	0|jonasschnelli|wumpus: thanks. I thought writing multiple values with the same key will be accessible via a cursor with seek() and next() ... it seems to be the case for LMDB
43 2018-04-17 14:12:36	0|promag|I'd love some feedback on #12639, ty
44 2018-04-17 14:12:37	0|gribble|https://github.com/bitcoin/bitcoin/issues/12639 | Reduce cs_main lock in listunspent by promag · Pull Request #12639 · bitcoin/bitcoin · GitHub
45 2018-04-17 14:13:17	0|wumpus|jonasschnelli: TIL! apparently lmdb seems to support "dups", which I assume is multiple values per key
46 2018-04-17 14:16:17	0|jonasschnelli|wumpus: seems pretty handy for 1-to-n "relations"
47 2018-04-17 14:16:42	0|wumpus|yes - I never used it in that way, only in the same way as leveldb
48 2018-04-17 14:52:14	0|promag|jonasschnelli: do you think WalletInitInterface should be the "new wallet manager"?
49 2018-04-17 14:54:29	0|jonasschnelli|promag: I haven't look at it too closely... but I guess it could be
50 2018-04-17 14:55:15	0|promag|are you planning working on that?
51 2018-04-17 15:07:44	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/39e0c65b29eb...58bbc5521235
52 2018-04-17 15:07:45	0|bitcoin-git|13bitcoin/06master 146a3b0d3 15Evan Klitzke: Print to console by default when not run with -daemon...
53 2018-04-17 15:07:46	0|bitcoin-git|13bitcoin/06master 1458bbc55 15Wladimir J. van der Laan: Merge #13004: Print to console by default when not run with -daemon...
54 2018-04-17 15:08:34	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13004: Print to console by default when not run with -daemon (06master...06printtoconsole) 02https://github.com/bitcoin/bitcoin/pull/13004
55 2018-04-17 15:22:28	0|jonasschnelli|promag: haven't looked at it. The wallet manager seems no longer be relevant (isince the wallet interface). I think next step is dynamic creating/loading of wallets
56 2018-04-17 17:23:56	0|bitcoin-git|13bitcoin/06master 14cd0e1e9 15Russell Yanofsky: Fix inconsistent namespace formatting guidelines...
57 2018-04-17 17:23:56	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/58bbc5521235...a63b4e349346
58 2018-04-17 17:23:57	0|bitcoin-git|13bitcoin/06master 14a63b4e3 15MarcoFalke: Merge #12982: Fix inconsistent namespace formatting guidelines...
59 2018-04-17 17:24:46	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12982: Fix inconsistent namespace formatting guidelines (06master...06pr/namespace) 02https://github.com/bitcoin/bitcoin/pull/12982
60 2018-04-17 17:29:32	0|bitcoin-git|13bitcoin/06master 14fae58ec 15MarcoFalke: tests: Avoid copies of CTransaction
61 2018-04-17 17:29:32	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a63b4e349346...6b46288a0853
62 2018-04-17 17:29:33	0|bitcoin-git|13bitcoin/06master 146b46288 15MarcoFalke: Merge #12949: tests: Avoid copies of CTransaction...
63 2018-04-17 17:30:23	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12949: tests: Avoid copies of CTransaction (06master...06Mf1804-testNoCopyTx) 02https://github.com/bitcoin/bitcoin/pull/12949
64 2018-04-17 17:31:12	0|bitcoin-git|[13bitcoin] 15promag opened pull request #13007: Fix dangling wallet pointer in vpwallets (06master...062018-04-fixwallettest) 02https://github.com/bitcoin/bitcoin/pull/13007
65 2018-04-17 17:38:15	0|promag|BlueMatt: re #12897, practicalswift rushed to implement my suggestion in #12782 without further feedback. I think you are right that it's not worth it, but it's also not that bad.
66 2018-04-17 17:38:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/12897 | Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash by practicalswift · Pull Request #12897 · bitcoin/bitcoin · GitHub
67 2018-04-17 17:38:17	0|gribble|https://github.com/bitcoin/bitcoin/issues/12782 | Explicitly state our assumptions about LookupBlockIndex(...) return values by practicalswift · Pull Request #12782 · bitcoin/bitcoin · GitHub
68 2018-04-17 17:40:16	0|BlueMatt|;;later tell promag I'm not really sure either 12897 or 12782 are worth it....changing a ptr dereference to an assert, followed by a ptr dereference is just more code for no reason, its not "explicitly stating" an assumption - the assumption was already clear when we dereferenced the pointer
69 2018-04-17 17:40:17	0|gribble|The operation succeeded.
70 2018-04-17 17:54:41	0|BlueMatt|MarcoFalke: or someone wanna re-ack-and-merge #12791 ?
71 2018-04-17 17:54:42	0|gribble|https://github.com/bitcoin/bitcoin/issues/12791 | Expose a transactions weight via RPC by TheBlueMatt · Pull Request #12791 · bitcoin/bitcoin · GitHub
72 2018-04-17 18:05:28	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6b46288a0853...3a8a4dc4a130
73 2018-04-17 18:05:29	0|bitcoin-git|13bitcoin/06master 142874709 15Matt Corallo: Expose a transaction's weight via RPC
74 2018-04-17 18:05:29	0|bitcoin-git|13bitcoin/06master 14d0d9112 15Matt Corallo: Test new weight field in p2p_segwit
75 2018-04-17 18:05:30	0|bitcoin-git|13bitcoin/06master 149e50c33 15Matt Corallo: Note new weight field in release-notes.
76 2018-04-17 18:06:08	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #12791: Expose a transaction's weight via RPC (06master...062018-03-weight) 02https://github.com/bitcoin/bitcoin/pull/12791
77 2018-04-17 18:17:51	0|bitcoin-git|[13bitcoin] 15IPGlider opened pull request #13008: rpc: Rename size to vsize in mempool related calls (06master...06rename-size-to-vsize) 02https://github.com/bitcoin/bitcoin/pull/13008
78 2018-04-17 19:00:19	0|jonasschnelli|jimpo: re txindex in the background...
79 2018-04-17 19:00:36	0|jonasschnelli|my peer is sometimes blocked for 1min with "BlockUntilSyncedToCurrentChain: txindex is catching up on block notifications"
80 2018-04-17 20:31:14	0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #12897: Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash (06master...06GetBlockIndex) 02https://github.com/bitcoin/bitcoin/pull/12897
81 2018-04-17 20:31:51	0|bitcoin-git|[13bitcoin] 15wbarobinson opened pull request #13010: Trivial: Language Cleanup (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13010
82 2018-04-17 21:05:36	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13011: Cache witness hash in CTransaction (06master...06Mf1804-cacheWitnessHash) 02https://github.com/bitcoin/bitcoin/pull/13011
83 2018-04-17 21:19:46	0|bitcoin-git|[13bitcoin] 15jamesob opened pull request #13012: [doc] Add comments for chainparams.h, validation.cpp (06master...062018-04-17-doc-chainparams-validation) 02https://github.com/bitcoin/bitcoin/pull/13012
84 2018-04-17 23:53:41	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13013: bench: Amend mempool_eviction test for witness txs (06master...06Mf1804-benchWitnessMempool) 02https://github.com/bitcoin/bitcoin/pull/13013