1 2018-04-18 04:43:45	0|kallewoof|RFC: I started on a file format for storing mempool history -> https://bc-2.jp/mempool%20file%20format.txt (sorry if off-topic)
  2 2018-04-18 04:54:14	0|fanquake|kallewoof sounds on-topic
  3 2018-04-18 04:57:42	0|kallewoof|fanquake: Thanks, it felt borderline. Btw did that gist work for you?
  4 2018-04-18 05:01:14	0|fanquake|kallewoof Sorry that's the next thing I'm working on. Got stuck inside Windows reviewing :(
  5 2018-04-18 05:02:49	0|kallewoof|fanquake: NP!
  6 2018-04-18 05:04:42	0|sipa|complete.
  7 2018-04-18 05:06:11	0|aj|kallewoof: gist worked for me fwiw (i'd missed running autogen under scan-build)
  8 2018-04-18 05:26:22	0|kallewoof|aj: Great!
  9 2018-04-18 05:43:13	0|wumpus|kallewoof: IMO it' technical and specific enough to be on-topic
 10 2018-04-18 05:52:29	0|kallewoof|wumpus: Okay. Technical+specific makes sense to me.
 11 2018-04-18 05:52:59	0|kallewoof|FWIW, I made a gist version: https://gist.github.com/kallewoof/8f722c4365cdfad88b845d1f3cb1bd9f#file-mff-txt
 12 2018-04-18 05:56:10	0|wumpus|you're not the first to do this but probably the first to try to formalize the data format. There's also some synergies with e.g. the zmq notification protocol here.
 13 2018-04-18 06:01:08	0|aj|kallewoof: fwiw, i have about 12GB of compressed mempool tx data from the last few months, with the idea to some day analyse if any of the non-confirming txes display any interesting behaviour
 14 2018-04-18 06:01:31	0|aj|kallewoof: the 1-satoshi-is-plenty phase started shortly after i started keeping track though, so it's probably boring :(
 15 2018-04-18 06:01:34	0|wumpus|after all, a log format is pretty much *concatanate all the notifications*
 16 2018-04-18 06:02:15	0|aj|kallewoof: (my data is basically hexified zmq data, with a timestamp, then lz compressed)
 17 2018-04-18 06:05:09	0|aj|kallewoof: includeconf travis -- test_runner is failing travis of the warning stderr output i think?
 18 2018-04-18 06:07:30	0|kallewoof|aj: Oh, you have data? I would love to get my hands on it!
 19 2018-04-18 06:08:05	0|kallewoof|wumpus: I figured, yeah. Having a formalized format would be beneficial I think, unless the format is crap. (Hence RFC :) )
 20 2018-04-18 06:08:14	0|wumpus|kallewoof: yes
 21 2018-04-18 06:08:24	0|kallewoof|aj: Ah... of course. I'll switch to regular printf()..
 22 2018-04-18 06:09:18	0|kallewoof|wumpus: I should def look at zmq notification protocol, yeah. I forgot about that.
 23 2018-04-18 06:10:24	0|wumpus|kallewoof: but you have a good point I think the difference conceptually is that the zmq notification protocol is specific to bitcoin core, and includes some specific implementation details, while you're trying to make a more general exchange format
 24 2018-04-18 06:10:41	0|wumpus|(e.g. we have many more mempool retirement reasons, but some of those are very specific)
 25 2018-04-18 06:11:28	0|fanquake|kallewoof Followed static analyzer your steps, seems to be working correctly. Cheers.
 26 2018-04-18 06:11:38	0|kallewoof|wumpus: What other than 'old not confirmed', 'rbf-replaced', and 'double-spent-in-block'?
 27 2018-04-18 06:11:49	0|kallewoof|fanquake: Cool :)
 28 2018-04-18 06:12:10	0|wumpus|kallewoof: see MemPoolRemovalReason enum
 29 2018-04-18 06:12:43	0|kallewoof|wumpus: Will do!
 30 2018-04-18 06:12:53	0|aj|kallewoof: http://azure.erisian.com.au/~aj/tmp/kalle/ has data from yesterday (24 hours, 1000 UTC - 0959 UTC ish) and the logging script
 31 2018-04-18 06:13:28	0|aj|kallewoof: most of the data's behind my home internet which will make getting it out usefully less than easy :)
 32 2018-04-18 06:13:29	0|kallewoof|aj: Nice. Downloading
 33 2018-04-18 06:14:06	0|kallewoof|aj: Would access to an ssh machine somewhere be helpful?
 34 2018-04-18 06:14:17	0|kallewoof|s/ssh machine/ssh account/
 35 2018-04-18 06:15:31	0|aj|kallewoof: maybe? somewhere with disk to put it would be helpful; otherwise it's just upstream-b/w-bound
 36 2018-04-18 06:16:22	0|kallewoof|aj: Wasn't sure if your problem is bandwidth or simply don't have a disk online with enough space. I can give you access to a digital ocean machine somewhere.
 37 2018-04-18 06:18:41	0|kallewoof|aj: I got the files. Thanks, will check soon :)
 38 2018-04-18 06:18:51	0|aj|kallewoof: well, probably be more useful to see if the data's actually interesting; b/w and storage i can solve myself without too much hassle :)
 39 2018-04-18 06:19:20	0|kallewoof|aj: Makes sense yeah
 40 2018-04-18 07:02:46	0|jonasschnelli|If someone is interested, one of my machines does dump the mempool (mammempool 300MB) every hour since a couple of month... a lot of data though
 41 2018-04-18 07:07:30	0|wumpus|the incremental format is probably slightly more efficient in storage, sounds like dumping the entire thing every hour will get you a lot of duplicate data, though compression helps ofc
 42 2018-04-18 07:10:16	0|jonasschnelli|Yes! I had to trade off storage space vs. implementing an incremental dump solution
 43 2018-04-18 07:11:46	0|wumpus|yep
 44 2018-04-18 07:12:40	0|fanquake|jonasschnelli Thanks
 45 2018-04-18 07:13:31	0|jonasschnelli|fanquake: I need to finish my IRC bot that allows triggering a gitian build on my machine
 46 2018-04-18 07:15:19	0|jonasschnelli|Building all pull requests would require a couple of machines (=much more expensive setup)
 47 2018-04-18 07:16:30	0|wumpus|indeed, I think it's better to have it as something manually triggered, at least at first, can always be automatized if there's need for it
 48 2018-04-18 07:17:50	0|jonasschnelli|Also, there are risks running pre-built binaries...
 49 2018-04-18 07:18:54	0|wumpus|yes, there are security issues with building ,as well as hosting binaries for PRs that no human has looked at
 50 2018-04-18 07:20:45	0|fanquake|handy way for someone to submit a malicious PR and get their binaries built ready for distribution
 51 2018-04-18 07:21:09	0|wumpus|exactly
 52 2018-04-18 07:22:14	0|wumpus|it does leave one hell of an audit trail, so I doubt it's the best way to parasitize on someone else's infrastructure to host binaries, but still we really want to avoid it
 53 2018-04-18 07:22:28	0|jonasschnelli|Trigger a build could be protected over a github username (via special comment) or via an IRC handle. Both not very secure... additionally a gpg signature coule be added
 54 2018-04-18 07:24:38	0|wumpus|jonasschnelli: well as long as you check that freenode user is authenticated and using TLS, your only worry is that freenode itself is compromised, it's unlikely anyone will go that far to trigger a build :-)
 55 2018-04-18 07:24:56	0|jonasschnelli|heh,  true.
 56 2018-04-18 07:25:06	0|wumpus|same for spoofing github handles I think
 57 2018-04-18 07:25:29	0|fanquake|Probably easier to spin up some EC2 instances using credit cards before compromising the freenode infrastructure
 58 2018-04-18 07:25:37	0|fanquake|*stolen credit cards
 59 2018-04-18 07:29:44	0|fanquake|wumpus Did you want to merge #12715 tomorrow or the day after? I've just about finished testing, looks like it's ready to go. Just want to minimise disruption.
 60 2018-04-18 07:29:46	0|gribble|https://github.com/bitcoin/bitcoin/issues/12715 | depends: Add make clean rule by hkjn · Pull Request #12715 · bitcoin/bitcoin · GitHub
 61 2018-04-18 07:49:17	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #13014: Allow txindex in prune mode (06master...062018/04/txindex_prune) 02https://github.com/bitcoin/bitcoin/pull/13014
 62 2018-04-18 07:52:28	0|jonasschnelli|wow... I can load #11857 again
 63 2018-04-18 07:52:33	0|gribble|https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
 64 2018-04-18 07:52:38	0|jonasschnelli|no "github unicorn"
 65 2018-04-18 07:55:37	0|luke-jr|(I can't)
 66 2018-04-18 07:58:26	0|fanquake|(neither)
 67 2018-04-18 08:01:17	0|jonasschnelli|hmm...
 68 2018-04-18 08:01:44	0|jonasschnelli|I don't see the reason why this PR needs more time to load...
 69 2018-04-18 08:02:11	0|jonasschnelli|Maybe we reopen a new PR (could be a comment that blocks it) or jimpo tries to rebase and force push
 70 2018-04-18 08:02:36	0|jonasschnelli|It's a bit odd that we have a high-prio PR that can't be discussed.
 71 2018-04-18 08:08:08	0|fanquake|It's loading now, so it must just be some temporary issue.
 72 2018-04-18 08:08:11	0|jonasschnelli|fanquake@testing is on fire!
 73 2018-04-18 09:28:32	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3a8a4dc4a130...8fd62437c683
 74 2018-04-18 09:28:33	0|bitcoin-git|13bitcoin/06master 148fd6243 15Wladimir J. van der Laan: Merge #12715: depends: Add 'make clean' rule...
 75 2018-04-18 09:28:33	0|bitcoin-git|13bitcoin/06master 14aff16fd 15Henrik Jonsson: depends: Add 'make clean' and 'make clean-all' rules...
 76 2018-04-18 09:29:18	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12715: depends: Add 'make clean' rule (06master...06clean-depends) 02https://github.com/bitcoin/bitcoin/pull/12715
 77 2018-04-18 09:30:33	0|bitcoin-git|13bitcoin/06master 14d41a420 15João Barbosa: test: Fix dangling wallet pointer in vpwallets
 78 2018-04-18 09:30:33	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8fd62437c683...0d12570a8037
 79 2018-04-18 09:30:34	0|bitcoin-git|13bitcoin/06master 140d12570 15Wladimir J. van der Laan: Merge #13007: test: Fix dangling wallet pointer in vpwallets...
 80 2018-04-18 09:31:17	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13007: test: Fix dangling wallet pointer in vpwallets (06master...062018-04-fixwallettest) 02https://github.com/bitcoin/bitcoin/pull/13007
 81 2018-04-18 09:39:35	0|fanquake|wumpus In agreement to close #12990 ?
 82 2018-04-18 09:39:36	0|gribble|https://github.com/bitcoin/bitcoin/issues/12990 | depends: Fix libX11 build on gcc 8 by MarcoFalke · Pull Request #12990 · bitcoin/bitcoin · GitHub
 83 2018-04-18 09:40:22	0|wumpus|<jonasschnelli> fanquake@testing is on fire! <- yeah, thanks for all the testing!
 84 2018-04-18 09:40:26	0|wumpus|fanquake: will take a look
 85 2018-04-18 09:41:28	0|wumpus|fanquake: I was leaving that to marcofalke, but I guess, as we all seem to agree we can just close it, someone who needs the patch right now could always pull that branch I guess...
 86 2018-04-18 09:41:48	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12990: depends: Fix libX11 build on gcc 8 (06master...06Mf1804-dependsGCC8Fix) 02https://github.com/bitcoin/bitcoin/pull/12990
 87 2018-04-18 09:52:20	0|bitcoin-git|13bitcoin/06master 147d8a8cc 15JeremyRand: Avoid launching as admin when NSIS installer ends....
 88 2018-04-18 09:52:20	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0d12570a8037...615f7c288414
 89 2018-04-18 09:52:21	0|bitcoin-git|13bitcoin/06master 14615f7c2 15Wladimir J. van der Laan: Merge #12985: Windows: Avoid launching as admin when NSIS installer ends....
 90 2018-04-18 09:53:07	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12985: Windows: Avoid launching as admin when NSIS installer ends. (06master...06nsis-de-elevate) 02https://github.com/bitcoin/bitcoin/pull/12985
 91 2018-04-18 10:19:32	0|michagogo_|wumpus: #12985 may be problematic
 92 2018-04-18 10:19:34	0|gribble|https://github.com/bitcoin/bitcoin/issues/12985 | Windows: Avoid launching as admin when NSIS installer ends. by JeremyRand · Pull Request #12985 · bitcoin/bitcoin · GitHub
 93 2018-04-18 10:19:35	0|michagogo_|https://mdb-blog.blogspot.com/2013/01/nsis-lunch-program-as-user-from-uac.html?showComment=1388694317801#c939517856791332836
 94 2018-04-18 11:36:35	0|bitcoin-git|[13bitcoin] 15Empact closed pull request #12991: Remove unused default args to Invalid and DoS (06master...06remove-unused-default-args-dos) 02https://github.com/bitcoin/bitcoin/pull/12991
 95 2018-04-18 12:11:10	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (06master...06g-failed-blocks) 02https://github.com/bitcoin/bitcoin/pull/13016
 96 2018-04-18 12:38:24	0|bitcoin-git|[13bitcoin] 15promag opened pull request #13017: Add AddWallet, RemoveWallet, GetWallet and GetWallets (06master...062018-04-vpwallets) 02https://github.com/bitcoin/bitcoin/pull/13017
 97 2018-04-18 12:39:09	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13018: Make AbortNode function static (06master...06abort-node-static) 02https://github.com/bitcoin/bitcoin/pull/13018
 98 2018-04-18 13:04:57	0|bitcoin-git|[13bitcoin] 15Empact closed pull request #13018: Make AbortNode function static (06master...06abort-node-static) 02https://github.com/bitcoin/bitcoin/pull/13018
 99 2018-04-18 14:44:29	0|Nurlan23|Hi ya all!
100 2018-04-18 14:50:34	0|jamesob|jonasschnelli luke-jr fanquake: #11857 loads pretty reliably when emulating a mobile device using chrome's developer tools :)
101 2018-04-18 14:50:39	0|gribble|https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
102 2018-04-18 15:18:15	0|instagibbs|huh, loaded it in incognito browser, and now it just works for me
103 2018-04-18 15:18:51	0|instagibbs|oops false alarm, hit or miss
104 2018-04-18 15:19:37	0|instagibbs|incognito works reliably here
105 2018-04-18 15:32:02	0|jonasschnelli|Indeed. Private browsing mitigates. Strange!
106 2018-04-18 15:46:07	0|MarcoFalke|wumpus: minor nit: It says 15.99 on https://dev.visucore.com/bitcoin/doxygen/index.html ; I guess you'd have to run ./configure before generating the docs?
107 2018-04-18 15:51:47	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13019: Trivial: Consistently use FormatStateMessage (06master...06format-state-message) 02https://github.com/bitcoin/bitcoin/pull/13019
108 2018-04-18 16:15:34	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13020: Consistently log CValidationState on call failure (06master...06log-cvalidation-state) 02https://github.com/bitcoin/bitcoin/pull/13020
109 2018-04-18 16:29:22	0|cubancorona|hi, all
110 2018-04-18 16:30:33	0|cubancorona|I think signrawtransaction -prextxs should take the json output from decoderawtransaction.  Any reason why not?
111 2018-04-18 17:19:31	0|bitcoin-git|[13bitcoin] 15jimpo opened pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (06master...06logging-files) 02https://github.com/bitcoin/bitcoin/pull/13021
112 2018-04-18 18:19:43	0|promag|wumpus: friendly ping #12639
113 2018-04-18 18:19:45	0|gribble|https://github.com/bitcoin/bitcoin/issues/12639 | Reduce cs_main lock in listunspent by promag · Pull Request #12639 · bitcoin/bitcoin · GitHub
114 2018-04-18 18:42:49	0|jamesob|has there been any talk of moving from trusty to xenial on travis? It may be the case that we're unable to run bitcoin-qt using the functional test framework due to a bug in the version of openssl trusty uses
115 2018-04-18 18:44:07	0|jamesob|ah, just found #13000 :)
116 2018-04-18 18:44:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/13000 | travis: Switch to xenial by MarcoFalke · Pull Request #13000 · bitcoin/bitcoin · GitHub
117 2018-04-18 18:44:59	0|MarcoFalke|jamesob: Yeah, they don't have documentation on it, so it is not worth to jump into it too much right now
118 2018-04-18 18:46:29	0|luke-jr|jamesob: bionic would be more useful IMO
119 2018-04-18 18:46:42	0|luke-jr|problem is vmbuilder (and therefore make-base-vm) doesn't work with it yet :/
120 2018-04-18 18:48:05	0|MarcoFalke|luke-jr: I think it makes sense to run on a somewhat older version of gcc, which xenial provides
121 2018-04-18 18:48:25	0|MarcoFalke|iirc we don't use vmbuilder on travis?
122 2018-04-18 18:58:22	0|bitcoin-git|[13bitcoin] 15Empact closed pull request #13019: validation: Consistently use FormatStateMessage (06master...06format-state-message) 02https://github.com/bitcoin/bitcoin/pull/13019
123 2018-04-18 19:11:32	0|jamesob|MarcoFalke: I'm happy to pick up 13000 if you don't have time to investigate; looks like you may just need to obtain python's setuptools through a different package (though I'm sure there may be more problems)
124 2018-04-18 19:12:57	0|MarcoFalke|jamesob: I think I got it working with that yaml. The issue was that it would just randomly time out without output, not run at all or apt update fails due to locks
125 2018-04-18 19:13:38	0|MarcoFalke|Really it is up to travis to make it work first.
126 2018-04-18 19:13:57	0|jamesob|MarcoFalke: doesn't look like it: https://travis-ci.org/bitcoin/bitcoin/jobs/367259625
127 2018-04-18 19:15:09	0|jamesob|ah but I see other jobs in that build timed out
128 2018-04-18 19:21:50	0|bitcoin-git|[13bitcoin] 15jamesob opened pull request #13022: [qa] Attach node index to test_node AssertionError and print messages (06master...062018-04-18-func-test-debug-log) 02https://github.com/bitcoin/bitcoin/pull/13022
129 2018-04-18 20:09:27	0|bitcoin-git|[13bitcoin] 15skeees opened pull request #13023: Add unit tests for signals generated by ProcessNewBlock (06master...06event-tests) 02https://github.com/bitcoin/bitcoin/pull/13023
130 2018-04-18 20:51:04	0|jimpo|jonasshnelli: Odd that processing the validation interface queue would take so long. Are there any other log lines after that?
131 2018-04-18 21:08:34	0|jnewbery|promag: I think your #13017 could go on the high-priority for review, since it's a pre-req for dynamic wallet load/create/unload. Agree?
132 2018-04-18 21:08:36	0|gribble|https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
133 2018-04-18 21:09:07	0|jnewbery|I've overhauled `loadwallet` and rebased it on that. Ready for review at #10740 if people are interested
134 2018-04-18 21:09:09	0|gribble|https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
135 2018-04-18 21:22:26	0|promag|jnewbery: missing postInitProcess on #10740?
136 2018-04-18 21:22:28	0|gribble|https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
137 2018-04-18 21:40:36	0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13024: test: Add rpcauth pair that generated by rpcauth (06master...06rpc_test) 02https://github.com/bitcoin/bitcoin/pull/13024
138 2018-04-18 22:50:14	0|promag|sipa: can you explain IsMineSigVersion::TOP?
139 2018-04-18 22:51:07	0|sipa|promag: there's a comment!
140 2018-04-18 22:51:11	0|sipa|TOP = 0,        //! scriptPubKey execution
141 2018-04-18 23:08:51	0|promag|sipa: got it, any reason to not pick BASE?
142 2018-04-18 23:09:14	0|sipa|yes, to help review
143 2018-04-18 23:09:32	0|sipa|SigVersion::BASE means toplevel or p2sh
144 2018-04-18 23:10:02	0|sipa|IsMineSigVersion::TOP means only toplevel, and as it has a different meaning it's better to rename it
145 2018-04-18 23:10:18	0|sipa|so that as a reviewer you can easily ascertain that all sites have been addressed
146 2018-04-18 23:12:59	0|promag|only top got me confused, toplevel or root would be more clear
147 2018-04-18 23:13:29	0|promag|at least for me, as this is not the code I usually see
148 2018-04-18 23:16:48	0|sipa|meh :)
149 2018-04-18 23:16:52	0|sipa|there's a comment
150 2018-04-18 23:20:44	0|promag|yes, and the commit message is also clear about the distinction