1 2018-04-20 00:11:19	0|bitcoin-git|[13bitcoin] 15jimpo opened pull request #13033: Build txindex in parallel with validation (06master...06txindex-refactor-take2) 02https://github.com/bitcoin/bitcoin/pull/13033
 2 2018-04-20 00:12:32	0|bitcoin-git|[13bitcoin] 15jimpo closed pull request #11857: Build tx index in parallel with validation (06master...06txindex-refactor) 02https://github.com/bitcoin/bitcoin/pull/11857
 3 2018-04-20 00:55:11	0|achow101|github responded to me about 11857 and they told me that they're looking into it. apparently some other PRs in other projects are seeing similar issues
 4 2018-04-20 01:53:14	0|bitcoin-git|[13bitcoin] 15promag opened pull request #13034: Introduce WalletManager (06master...062018-04-walletmanager) 02https://github.com/bitcoin/bitcoin/pull/13034
 5 2018-04-20 04:52:55	0|jimpo|ajtown: Nice tip on --color-moved. TIL.
 6 2018-04-20 04:55:28	0|aj|jimpo: pfft, old news. i've known about it for days!
 7 2018-04-20 04:59:49	0|sipa|what is --color-moved?!
 8 2018-04-20 05:01:05	0|jimpo|aj: hahaha
 9 2018-04-20 05:05:38	0|aj|sipa: "git diff HEAD^ --color-moved=zebra"
10 2018-04-20 05:06:39	0|aj|sipa: i found it while looking for easier ways to review #12885
11 2018-04-20 05:06:39	0|sipa|doesn't work here
12 2018-04-20 05:06:41	0|gribble|https://github.com/bitcoin/bitcoin/issues/12885 | Reduce implementation code inside CScript by sipa · Pull Request #12885 · bitcoin/bitcoin · GitHub
13 2018-04-20 05:07:11	0|aj|sipa: needs to be run on a moveonly-type commit, it uses colours so might depend on your terminal
14 2018-04-20 05:07:12	0|kallewoof|Oooh, neat
15 2018-04-20 05:07:36	0|sipa|i use git diff --patience HEAD~:src/file.cpp HEAD:src/newfile.cpp
16 2018-04-20 05:08:26	0|bitcoin-git|13bitcoin/06master 14b77b6e2 15Jim Posen: MOVEONLY: Move logging code from util.{h,cpp} to new files.
17 2018-04-20 05:08:26	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0a8b7b4b33c9...8b262eb2d80b
18 2018-04-20 05:08:27	0|bitcoin-git|13bitcoin/06master 148b262eb 15Pieter Wuille: Merge #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files....
19 2018-04-20 05:09:20	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (06master...06logging-files) 02https://github.com/bitcoin/bitcoin/pull/13021
20 2018-04-20 05:10:42	0|aj|ah, needs git 2.15 which came out octoberish 2017
21 2018-04-20 05:10:57	0|sipa|seems i have 2.14
22 2018-04-20 05:23:09	0|bitcoin-git|[13bitcoin] 15macraix opened pull request #13036: PicoStocks 100TH problem (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13036
23 2018-04-20 05:23:46	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #13036: PicoStocks 100TH problem (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13036
24 2018-04-20 06:09:32	0|wumpus|--color-moved=zebra? can we pick other animals too?
25 2018-04-20 06:46:27	0|promag|wumpus: hi, do you think you can check #13017?
26 2018-04-20 06:46:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
27 2018-04-20 08:47:32	0|bitcoin-git|[13bitcoin] 15charkala opened pull request #13037: Genesis (06master...06genesis) 02https://github.com/bitcoin/bitcoin/pull/13037
28 2018-04-20 08:47:58	0|bitcoin-git|[13bitcoin] 15charkala closed pull request #13037: Genesis (06master...06genesis) 02https://github.com/bitcoin/bitcoin/pull/13037
29 2018-04-20 08:50:10	0|meshcollider|wumpus do you want to merge https://github.com/bitcoin-core/bitcoincore.org/pull/528 now its had plenty of review and has been sitting there for a while
30 2018-04-20 09:15:39	0|wumpus|meshcollider: will have a look, thanks
31 2018-04-20 09:35:17	0|promag|wumpus: not sure if I understand your argument, currently CWalletRef is narrowly used. Depending on the case it can be acceptable to use either reference, raw pointer or shared pointer. When adding shared pointer I would like to review all places where it makes sense to use it. If we had CWalletRef everywhere then that would obscure that evaluation.
32 2018-04-20 09:36:20	0|wumpus|promag: it's usually preferable to keep diffs minimal, without a type such as CWalletRef it means every usage has to be changed if the underlying type changes, the whole reason typedefs exist...
33 2018-04-20 09:36:38	0|wumpus|most users of CWalletRef won't care how it works internally
34 2018-04-20 09:36:42	0|wumpus|they just want to refer to a wallet
35 2018-04-20 09:37:02	0|promag|but my point is that not all CWallet* should be std::shared_ptr
36 2018-04-20 09:37:48	0|wumpus|maybe not, i still think an abstract reference type makes sense
37 2018-04-20 09:37:57	0|promag|I think that makes sense if CWalletRef was used where it makes sense to switch to shared pointer, but that's not the case
38 2018-04-20 09:38:24	0|wumpus|yes I agree they don't all need to be replaced
39 2018-04-20 09:38:45	0|wumpus|what annoyed me is the back and forth, one refactor introduces a certain type then the next one removes it again
40 2018-04-20 09:38:47	0|promag|even if I keep CWalletRef, switching to std::shared_ptr will cause a (not that) large diff
41 2018-04-20 09:38:53	0|wumpus|so let's just get on one page first
42 2018-04-20 09:39:33	0|promag|typedef aside, the code base must be refactored to shared pointers
43 2018-04-20 09:39:58	0|wumpus|my point was not 'this is a bad idea' but 'this needs discussion with the people involved'
44 2018-04-20 09:41:15	0|wumpus|if there is general agreement to undo the CWalletRef type again, that's ok with me
45 2018-04-20 09:41:27	0|promag|wumpus: fair enough, I can revert it too. I should have predicted this :D
46 2018-04-20 09:41:28	0|wumpus|though it makes me wonder what reasoning introduced it and what changed since
47 2018-04-20 09:41:49	0|promag|let me blame it
48 2018-04-20 09:41:57	0|wumpus|now that's a good idea
49 2018-04-20 09:44:46	0|promag|introduced in #8694 by luke-jr
50 2018-04-20 09:44:49	0|gribble|https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
51 2018-04-20 09:45:29	0|promag|https://github.com/bitcoin/bitcoin/pull/8694#discussion_r104522825
52 2018-04-20 09:46:53	0|promag|wumpus: I guess from that PR that there was little discussion
53 2018-04-20 09:46:53	0|wumpus|let's try to get luke-jr on board there, then
54 2018-04-20 09:47:14	0|promag|right
55 2018-04-20 10:15:59	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13039: Add logging and error handling for file syncing (06master...062018_04_fsync_noignore) 02https://github.com/bitcoin/bitcoin/pull/13039
56 2018-04-20 12:02:41	0|bitcoin-git|[13bitcoin] 15AsKayDevs opened pull request #13040: Update README.md (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13040
57 2018-04-20 12:45:59	0|bitcoin-git|[13bitcoin] 15qshuai opened pull request #13042: Calculated nBits will be replaced by the following GetNextWorkRequire… (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13042
58 2018-04-20 13:22:19	0|bitcoin-git|[13bitcoin] 15Sjors opened pull request #13043: [qt] OptionsDialog: add prune setting (06master...062018/04/qt-prune) 02https://github.com/bitcoin/bitcoin/pull/13043
59 2018-04-20 15:58:19	0|cfields|wumpus: with our powers combined, we've finally arrived at &= :)
60 2018-04-20 15:58:34	0|cfields|no clue what I was thinking there.
61 2018-04-20 16:09:20	0|BlueMatt|sipa: whats your current feeling on caching witness hashes/the sighash components somewhere on mempool acceptance?
62 2018-04-20 16:12:46	0|sipa|BlueMatt: caching sure, but not in the same class that is used for everything
63 2018-04-20 16:12:55	0|BlueMatt|yea, ok, fair
64 2018-04-20 16:13:03	0|BlueMatt|I thought that was rejected on the first go around :/
65 2018-04-20 16:16:57	0|BlueMatt|wumpus: re: #12998: I'm open to doing whatever to fix it, that was just the simplest thing (fix it for the narrow case when those functions are #define'd by the compiler's headers). cfields suggested moving those functions to _int, but I'm not sure making a downstream project's build scripts easier is worth the refactor for that, but up to y'all
66 2018-04-20 16:16:58	0|gribble|https://github.com/bitcoin/bitcoin/issues/12998 | Default to defining endian-conversion DECLs in compat w/o config by TheBlueMatt · Pull Request #12998 · bitcoin/bitcoin · GitHub
67 2018-04-20 16:17:09	0|BlueMatt|I just wanna figure out if I should just apply that patch downstream or what
68 2018-04-20 16:19:10	0|jcohen|i have a half completed change somewhere that makes proper types out of TxId / WTxId instead of using uint256 somewhere - i can clean up if there's to be more pervasive use of witness ids - doesn't do anything other than readability / compiler safety
69 2018-04-20 16:38:43	0|luke-jr|wumpus: CWalletRef was intentionally introduced such that it can be replaced with a shared_ptr painlessly
70 2018-04-20 16:39:07	0|luke-jr|I probably still have a branch with that change
71 2018-04-20 17:25:59	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #13045: [p2p] getblock for 1-block reorgs in response to compact block message (06master...06cmpcttie) 02https://github.com/bitcoin/bitcoin/pull/13045
72 2018-04-20 17:36:01	0|cfields|BlueMatt: I think it's fine as-is. But if you want to take it further, I think it'd be pretty trivial to switch to _int.
73 2018-04-20 17:56:04	0|bitcoin-git|[13bitcoin] 15skeees opened pull request #13046: [doc][trivial] no retargeting in regtest mode (06master...06doc-update) 02https://github.com/bitcoin/bitcoin/pull/13046
74 2018-04-20 18:18:53	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13047: [trivial] Tidy blocktools.py (06master...06tidy_blocktools) 02https://github.com/bitcoin/bitcoin/pull/13047
75 2018-04-20 18:22:27	0|jnewbery|13017 doesn't make replacing the raw pointers with shared_ptrs and easier or more difficult, so I don't think it really needs too much discussion.
76 2018-04-20 19:40:40	0|jimpo|Can I get a look on #12647? It's pretty trivial.
77 2018-04-20 19:40:41	0|gribble|https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub
78 2018-04-20 19:50:55	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13048: [tests] Fix feature_block flakiness (06master...06fix_feature_block_flakiness) 02https://github.com/bitcoin/bitcoin/pull/13048
79 2018-04-20 20:24:43	0|jtimon|updated https://github.com/bitcoin/bitcoin/pull/10757 again
80 2018-04-20 20:25:21	0|jtimon|btw aj cool your new test cached a bug
81 2018-04-20 22:07:52	0|promag|luke-jr: mind checking for the shared pointer branch, I would like to see it? There are lot of places where CWallet* must be changed to CWalletRef or std::shared_ptr<CWallet>, and IMO there are some places where CWalletRef should be CWallet* IMO. I've dropped CWalletRef so that the PR introducing shared_ptr would do it in the whole source.
82 2018-04-20 22:52:33	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13049: [0.16] qa: Backports (060.16...06Mf1804-qa16Backports) 02https://github.com/bitcoin/bitcoin/pull/13049