1 2018-04-23 05:59:03	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3e60b9cfa768...65d7083f152e
  2 2018-04-23 05:59:04	0|bitcoin-git|13bitcoin/06master 14373aee2 15João Barbosa: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets...
  3 2018-04-23 05:59:04	0|bitcoin-git|13bitcoin/06master 146efd964 15João Barbosa: refactor: Drop CWalletRef typedef
  4 2018-04-23 05:59:05	0|bitcoin-git|13bitcoin/06master 143c058fd 15João Barbosa: wallet: Add HasWallets
  5 2018-04-23 05:59:50	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13017: Add wallets management functions (06master...062018-04-vpwallets) 02https://github.com/bitcoin/bitcoin/pull/13017
  6 2018-04-23 07:28:41	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13055: qt: Don't log to console by default (06master...062018_04_gui_console) 02https://github.com/bitcoin/bitcoin/pull/13055
  7 2018-04-23 07:46:48	0|wumpus|this weekend I recovered a node that was crashing with database corruption errors (after, I think, a hard poweroff corrupted it - the log was padded with sudden \0\0\0\0\0\0) simply by deleting leveldb's .log file.
  8 2018-04-23 07:47:44	0|wumpus|after that and restarted, the node succesfully picked up verification again, phew, no reindex
  9 2018-04-23 07:47:46	0|bitcoin-git|[13bitcoin] 15nixbox opened pull request #13056: [tests] Make rpcauth.py testable and add unit tests (06master...06rpcauth) 02https://github.com/bitcoin/bitcoin/pull/13056
 10 2018-04-23 07:50:06	0|wumpus|error was "error in middle of record" in log_reader
 11 2018-04-23 07:55:35	0|wumpus|maybe such an automatic recovery would be possible in some cases, when only the log is corrupt and not any ldb files, it'd just amount to a rollback
 12 2018-04-23 08:35:49	0|bitcoin-git|13bitcoin/06master 143cc9094 15Ben Woosley: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks...
 13 2018-04-23 08:35:49	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/65d7083f152e...e2746db66fd5
 14 2018-04-23 08:35:50	0|bitcoin-git|13bitcoin/06master 14e2746db 15Wladimir J. van der Laan: Merge #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks...
 15 2018-04-23 08:36:29	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (06master...06g-failed-blocks) 02https://github.com/bitcoin/bitcoin/pull/13016
 16 2018-04-23 12:30:26	0|bitcoin-git|13bitcoin/06master 14cf02779 15Wladimir J. van der Laan: Add logging and error handling for file syncing...
 17 2018-04-23 12:30:26	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e2746db66fd5...8b4081a889b3
 18 2018-04-23 12:30:27	0|bitcoin-git|13bitcoin/06master 148b4081a 15Wladimir J. van der Laan: Merge #13039: Add logging and error handling for file syncing...
 19 2018-04-23 12:31:17	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13039: Add logging and error handling for file syncing (06master...062018_04_fsync_noignore) 02https://github.com/bitcoin/bitcoin/pull/13039
 20 2018-04-23 12:37:50	0|bitcoin-git|13bitcoin/06master 14e4d0b44 15Ben Woosley: Consistently log CValidationState on failure...
 21 2018-04-23 12:37:50	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8b4081a889b3...4741ca5dc8fd
 22 2018-04-23 12:37:51	0|bitcoin-git|13bitcoin/06master 144741ca5 15Wladimir J. van der Laan: Merge #13020: Consistently log CValidationState on call failure...
 23 2018-04-23 12:38:39	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13020: Consistently log CValidationState on call failure (06master...06log-cvalidation-state) 02https://github.com/bitcoin/bitcoin/pull/13020
 24 2018-04-23 13:47:24	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #13057: remove redundant pre-selected coin code (06master...06selectedcoins) 02https://github.com/bitcoin/bitcoin/pull/13057
 25 2018-04-23 14:07:23	0|bitcoin-git|13bitcoin/06master 14e87fefc 15Wladimir J. van der Laan: test: Add rpc_bind test to default-run tests...
 26 2018-04-23 14:07:23	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4741ca5dc8fd...d5b2e98250f6
 27 2018-04-23 14:07:24	0|bitcoin-git|13bitcoin/06master 14d5b2e98 15Wladimir J. van der Laan: Merge #12510: test: Add rpc_bind test to default-run tests...
 28 2018-04-23 14:08:01	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (06master...062018_02_reinstate_rpcbind_test) 02https://github.com/bitcoin/bitcoin/pull/12510
 29 2018-04-23 14:47:45	0|bitcoin-git|13bitcoin/06master 146ad47b0 15practicalswift: trivial: Fix relevent typo
 30 2018-04-23 14:47:45	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d5b2e98250f6...5713994de98e
 31 2018-04-23 14:47:46	0|bitcoin-git|13bitcoin/06master 145713994 15MarcoFalke: Merge #13052: trivial: Fix relevent typo...
 32 2018-04-23 14:48:33	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13052: trivial: Fix relevent typo (06master...06relevent) 02https://github.com/bitcoin/bitcoin/pull/13052
 33 2018-04-23 15:15:34	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5713994de98e...d1e3c5e73cfc
 34 2018-04-23 15:15:35	0|bitcoin-git|13bitcoin/06master 1418326ae 15James O'Beirne: [doc] Add comments for chainparams.h, validation.cpp
 35 2018-04-23 15:15:35	0|bitcoin-git|13bitcoin/06master 14d1e3c5e 15Wladimir J. van der Laan: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp...
 36 2018-04-23 15:16:23	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13012: [doc] Add comments for chainparams.h, validation.cpp (06master...062018-04-17-doc-chainparams-validation) 02https://github.com/bitcoin/bitcoin/pull/13012
 37 2018-04-23 15:34:34	0|jnewbery|provoostenator: Yes, agree that 4000 lines is probably too much log. I'd ACK a PR to reduce it. (counter argument is that this is only printed when a script fails, so we want as much logging as possible)
 38 2018-04-23 15:52:10	0|jonasschnelli|hmm... localhost p2p getblocks transfer rate up to block 250000 is roughly 70MB/s (SSD with usual rate of 300MB/s). Reasonable overhead.
 39 2018-04-23 15:59:36	0|wumpus|jonasschnelli: any idea where the overhead is? the deserialize->serialize round trip?
 40 2018-04-23 16:00:05	0|wumpus|or just 'random seeking and reading' wrt i/o, because this concerns such small blocks
 41 2018-04-23 16:04:56	0|bitcoin-git|13bitcoin/06master 140851a75 15João Barbosa: rpc: Interrupt block generation on shutdown request
 42 2018-04-23 16:04:56	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d1e3c5e73cfc...84efa9a0f752
 43 2018-04-23 16:04:57	0|bitcoin-git|13bitcoin/06master 1484efa9a 15Wladimir J. van der Laan: Merge #12448: Interrupt block generation on shutdown request...
 44 2018-04-23 16:05:30	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12448: Interrupt block generation on shutdown request (06master...062018-02-interrupt-generate-blocks) 02https://github.com/bitcoin/bitcoin/pull/12448
 45 2018-04-23 16:10:53	0|promag|wumpus: that was unexpected
 46 2018-04-23 16:12:22	0|wumpus|promag: :-)
 47 2018-04-23 16:42:59	0|jonasschnelli|wumpus: not sure where the bottleneck is. need to analyze more. I first need the make sure it's not the client (pure C p2p client)
 48 2018-04-23 17:24:03	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13058: [wallet] `createwallet` RPC - create new wallet at runtime (06master...06create_wallet) 02https://github.com/bitcoin/bitcoin/pull/13058
 49 2018-04-23 18:23:50	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/84efa9a0f752...d3f04c0e81a6
 50 2018-04-23 18:23:51	0|bitcoin-git|13bitcoin/06master 141f83839 15John Newbery: [wallet] [tests] Test disallowed multiwallet params...
 51 2018-04-23 18:23:51	0|bitcoin-git|13bitcoin/06master 143476e3c 15John Newbery: [wallet] Fix zapwallettxes/multiwallet interaction....
 52 2018-04-23 18:23:52	0|bitcoin-git|13bitcoin/06master 14d3f04c0 15Wladimir J. van der Laan: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction....
 53 2018-04-23 18:24:44	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (06master...06fix_zapwallet_multiwallet_interaction) 02https://github.com/bitcoin/bitcoin/pull/13030
 54 2018-04-23 19:01:20	0|bitcoin-git|13bitcoin/06master 1467bf2aa 15Chun Kuan Lee: qt:Show the entire Window when double clicking on taskbar
 55 2018-04-23 19:01:20	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d3f04c0e81a6...8609ddb36821
 56 2018-04-23 19:01:21	0|bitcoin-git|13bitcoin/06master 148609ddb 15Wladimir J. van der Laan: Merge #12999: qt: Show the Window when double clicking the taskbar icon...
 57 2018-04-23 19:02:06	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12999: qt: Show the Window when double clicking the taskbar icon (06master...06qt-fix) 02https://github.com/bitcoin/bitcoin/pull/12999
 58 2018-04-23 19:09:28	0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8609ddb36821...a49381dfa3ee
 59 2018-04-23 19:09:29	0|bitcoin-git|13bitcoin/06master 142fb168b 15Pieter Wuille: Make iterators in CScript::FindAndDelete const
 60 2018-04-23 19:09:29	0|bitcoin-git|13bitcoin/06master 1433a8ecf 15Pieter Wuille: Delete unused non-const-iterator CSCript::GetOp overloads
 61 2018-04-23 19:09:30	0|bitcoin-git|13bitcoin/06master 146a7456a 15Pieter Wuille: [MOVEONLY] Move CSCript::FindAndDelete to interpreter
 62 2018-04-23 19:10:12	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12885: Reduce implementation code inside CScript (06master...06201803_reducescript) 02https://github.com/bitcoin/bitcoin/pull/12885
 63 2018-04-23 19:18:01	0|jonasschnelli|wumpus: here is the flamgraph during 3.8GB blockserving on localhost: https://bitcoin.jonasschnelli.ch/perf-heavy-blockserving.svg
 64 2018-04-23 19:19:13	0|jonasschnelli|Not sure why I can't untangle the callstack in msghandler 37.68% is spent in "Lloop1_26"
 65 2018-04-23 19:21:00	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13060: [wallet] [rpc] Remove getlabeladdress RPC (06master...06remove_getlabeladdress) 02https://github.com/bitcoin/bitcoin/pull/13060
 66 2018-04-23 19:47:01	0|Chris_Stewart_5|If a node receives blocks in an order like: 1,2,4,3 (where 4 references previous block hash of 3) on the p2p network, will zmq relay 4 after it has successfully connected it with 3?
 67 2018-04-23 19:51:27	0|sipa|Chris_Stewart_5: no, it just notifies for new tips
 68 2018-04-23 19:52:48	0|sipa|as ZMQ is not reliable, you shouldn't use it as more than a notification service anyway
 69 2018-04-23 19:54:50	0|sipa|Chris_Stewart_5: actually, i think that can't happen
 70 2018-04-23 19:54:57	0|sipa|as we always fetch blocks in order
 71 2018-04-23 19:54:59	0|Chris_Stewart_5|sipa: Wouldn't 4 end up as the cannonical tip?
 72 2018-04-23 19:55:21	0|sipa|but a similar scenario can occur during a reorg
 73 2018-04-23 19:55:44	0|sipa|in which case ZMQ will just report the new tip after the reorg, and not the intermediary blocks (afaik, not entirely sure)
 74 2018-04-23 20:01:10	0|Chris_Stewart_5|so basically if there is a reorg that is like 6 blocks deep, you will just be notified of the new tip of that reorg, *not* all the intermittent blocks that happened in the reorg correct?
 75 2018-04-23 20:02:13	0|skeees|In the current state you'll be notified after every ActivateBestChainStep()
 76 2018-04-23 20:02:23	0|skeees|which will definitely give you the new tip
 77 2018-04-23 20:02:33	0|skeees|possibly some of the block in between, but not guaranteed every single one
 78 2018-04-23 20:02:53	0|skeees|the notifications will be pushed to zmq in order (i don't know what ordering guarantees zmq gives you though)
 79 2018-04-23 20:06:55	0|Chris_Stewart_5|skeees: Thanks! :-)
 80 2018-04-23 20:07:48	0|sipa|Chris_Stewart_5: you basically can't rely on ZMQ to relay you everything regardless
 81 2018-04-23 20:08:10	0|sipa|you can use it as a notification that there are new things you should look at (through rpc or rest)
 82 2018-04-23 20:08:54	0|sipa|(and IMHO it was a mistake to make it relay full blocks in the first place, as it confusingly gives you the impression it will give you everything)
 83 2018-04-23 22:00:59	0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #9806: txoutsbyaddress index (take 3) (06master...06gettxoutsbyaddress) 02https://github.com/bitcoin/bitcoin/pull/9806
 84 2018-04-23 22:10:01	0|bitcoin-git|[13bitcoin] 15bmwiedemann opened pull request #13061: Make tests pass after 2020 (06master...06ftbfs-2020) 02https://github.com/bitcoin/bitcoin/pull/13061
 85 2018-04-23 22:10:33	0|midnightmagic|w 80
 86 2018-04-23 23:10:09	0|aj|jtimon: can still drop "assert_contains" from rpc_getblockstats.py
 87 2018-04-23 23:10:47	0|jtimon|yeah, unused, thanks
 88 2018-04-23 23:11:15	0|jtimon|aj: also I just noticed I forgot this nit: https://github.com/bitcoin/bitcoin/pull/10757/files#r181616478
 89 2018-04-23 23:11:27	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13062: Make script interpreter independent from storage type CScript (06master...06201804_spaninterpret) 02https://github.com/bitcoin/bitcoin/pull/13062
 90 2018-04-23 23:15:10	0|bitcoin-git|[13bitcoin] 15promag closed pull request #11402: Use shared pointer for wallet instances (06master...062017-09-wallet-shared-pointer) 02https://github.com/bitcoin/bitcoin/pull/11402
 91 2018-04-23 23:15:36	0|promag|jnewbery: you might want to rebase on top of #13063
 92 2018-04-23 23:15:38	0|gribble|https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
 93 2018-04-23 23:16:02	0|aj|jtimon: there was https://github.com/bitcoin/bitcoin/pull/10757#discussion_r181617123 too
 94 2018-04-23 23:22:42	0|jtimon|aj: right, thanks
 95 2018-04-23 23:31:13	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13064: List support for BIP173 in bips.md (06master...06201804_docbip173) 02https://github.com/bitcoin/bitcoin/pull/13064
 96 2018-04-23 23:32:06	0|bitcoin-git|13bitcoin/06master 14aee80b0 15Wladimir J. van der Laan: qt: Don't log to console by default...
 97 2018-04-23 23:32:06	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a49381dfa3ee...bdda14d1c01c
 98 2018-04-23 23:32:07	0|bitcoin-git|13bitcoin/06master 14bdda14d 15MarcoFalke: Merge #13055: qt: Don't log to console by default...
 99 2018-04-23 23:32:53	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13055: qt: Don't log to console by default (06master...062018_04_gui_console) 02https://github.com/bitcoin/bitcoin/pull/13055
100 2018-04-23 23:58:59	0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13065: Let travis to run verify-commits.sh without errors (06master...06verify-commits) 02https://github.com/bitcoin/bitcoin/pull/13065