1 2018-04-24 01:57:54	0|jimpo|wumpus: You're having trouble viewing #13033?
  2 2018-04-24 01:57:55	0|gribble|https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub
  3 2018-04-24 01:58:09	0|jimpo|That is the PR reopened. It has only like 3 comments.
  4 2018-04-24 02:03:17	0|sipa|Yes, i'm confused too. It opens perfectly here.
  5 2018-04-24 03:28:36	0|roasbeef|odd that a PR would stop loading, just due to the # of comments it has I guess?
  6 2018-04-24 03:30:14	0|roasbeef|guess the solution is to Download More RAM
  7 2018-04-24 03:32:36	0|sipa|roasbeef: i believe it's the github html renderer that times out
  8 2018-04-24 03:32:43	0|sipa|as mobile github clients etc work fine
  9 2018-04-24 04:06:51	0|jimpo|It's pretty bizarry though that it would load reliably for some accounts and in incognito mode, but not others
 10 2018-04-24 04:07:48	0|jimpo|I wouldn't think that there's so much rendering logic that differs between accounts
 11 2018-04-24 04:46:16	0|sipa|jimpo: i wonder if it's geographical
 12 2018-04-24 04:46:46	0|sipa|maybe the render servers are distributed and not the same load/sprcs for people in europe vs north america etc
 13 2018-04-24 05:35:15	0|bitcoin-git|[13bitcoin] 15ken2812221 closed pull request #13065: Let travis run verify-commits.sh without errors (06master...06verify-commits) 02https://github.com/bitcoin/bitcoin/pull/13065
 14 2018-04-24 05:54:03	0|bitcoin-git|13bitcoin/06master 144d33039 15Pieter Wuille: List support for BIP173 in bips.md
 15 2018-04-24 05:54:03	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/bdda14d1c01c...569e3817e000
 16 2018-04-24 05:54:04	0|bitcoin-git|13bitcoin/06master 14569e381 15Wladimir J. van der Laan: Merge #13064: List support for BIP173 in bips.md...
 17 2018-04-24 05:54:59	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13064: List support for BIP173 in bips.md (06master...06201804_docbip173) 02https://github.com/bitcoin/bitcoin/pull/13064
 18 2018-04-24 06:07:56	0|fanquake|Looking forward to Bionic tomorrow. Hopefully we can start using it on WSL soon after..
 19 2018-04-24 06:19:47	0|kallewoof|How are READWRITE(REF(CFlatData(ob))) done these days? I got barfed at when rebasing something.
 20 2018-04-24 06:20:30	0|sipa|kallewoof: depends, what type is ob?
 21 2018-04-24 06:20:59	0|kallewoof|sipa: std::vector<uint256>
 22 2018-04-24 06:21:08	0|kallewoof|Wait, no..
 23 2018-04-24 06:21:31	0|kallewoof|Sorry. Yes. std::vector<uint256>
 24 2018-04-24 06:21:41	0|sipa|with compile-time known length?
 25 2018-04-24 06:22:09	0|kallewoof|No, it's a merkle proof skip list
 26 2018-04-24 06:22:20	0|sipa|then what do you need the flatdata for?
 27 2018-04-24 06:22:52	0|sipa|just READWRITE(the_vector) will work fine
 28 2018-04-24 06:23:07	0|kallewoof|Is CFlatData only used for fixed length stuff?
 29 2018-04-24 06:23:41	0|sipa|CFlatData was historically used to write things as raw bytes, as opposed to the object's serializer
 30 2018-04-24 06:23:57	0|sipa|it's been replaced with native support for arrays
 31 2018-04-24 06:24:23	0|sipa|so you can READWRITE(blah) if blah is 'unsigned char blah[4]' for example, and it will just write 4 bytes
 32 2018-04-24 06:24:30	0|sipa|and with Span
 33 2018-04-24 06:25:10	0|sipa|but uint256 has a serializer that just writes 32 bytes
 34 2018-04-24 06:25:20	0|kallewoof|Okay, so actually reading the comment above, it seems Mark wanted to avoid using the Satoshi-defined compact size format as it was less efficient than the internal varint.
 35 2018-04-24 06:25:34	0|kallewoof|Hence why he wrote the length of the vector and the vector as CFlatData
 36 2018-04-24 06:25:51	0|sipa|i see
 37 2018-04-24 06:25:53	0|sipa|seems overkill to me
 38 2018-04-24 06:26:05	0|kallewoof|Yes, seems unnecessary.
 39 2018-04-24 06:26:11	0|sipa|as the native varint's aren't used anywhere in the p2p protocol already
 40 2018-04-24 06:27:15	0|kallewoof|*nod*
 41 2018-04-24 06:28:08	0|sipa|the same issue came up around bip152
 42 2018-04-24 06:29:00	0|kallewoof|How much more efficient are the varints compared to the compactsize version anyway?
 43 2018-04-24 06:29:16	0|sipa|it depends on the distribution
 44 2018-04-24 06:29:24	0|kallewoof|Right. Of course it does.
 45 2018-04-24 06:29:31	0|sipa|for some distributions the compactsize ones are better
 46 2018-04-24 06:29:38	0|kallewoof|But for a skip list in a merkle proof, I kind of don't think you'll ever have more than 10.
 47 2018-04-24 06:29:50	0|kallewoof|Or very seldom anyway. I could be wrong though.
 48 2018-04-24 06:30:03	0|sipa|then both serializations will give you just 1 byte anyway
 49 2018-04-24 06:30:09	0|kallewoof|Yeah
 50 2018-04-24 06:30:30	0|sipa|compactsize uses 1 byte up to (iirc) 252
 51 2018-04-24 06:30:36	0|sipa|varint only up to 127
 52 2018-04-24 06:30:51	0|sipa|but after that compactsize immediately jumps to 3 bytes
 53 2018-04-24 06:31:03	0|sipa|while varint only uses 2 up to 16000 ish
 54 2018-04-24 06:32:30	0|kallewoof|Oh, they're that different? I thought they were tweaks of the same thing.
 55 2018-04-24 06:34:00	0|ossifrage|Does bitcoin core do some sort of io maintenance task that gobbles up a bunch of disk IO?
 56 2018-04-24 06:34:20	0|kallewoof|Either way, the size of the size of the skip lists is a fraction of the size of the skip lists themselves which are 32 bytes per entry, so I doubt this matters. With 253 entries there are 8096 bytes of data aside from the size. 3 or 2 bytes isn't really gonna make a difference.
 57 2018-04-24 06:34:52	0|ossifrage|QThread just started generating a bunch of disk io without any large corresponding newtwork IO
 58 2018-04-24 07:05:43	0|wumpus|jimpo: I can view it now, couldn't open it yesterday
 59 2018-04-24 07:06:05	0|wumpus|strange
 60 2018-04-24 07:08:37	0|wumpus|and yeah I couldn't see it had only three replies because I couldn't see the thing at all
 61 2018-04-24 07:43:07	0|kallewoof|sipa: Mark pointed out compactsize is malleable (e.g. 00000001 = 01).
 62 2018-04-24 07:44:59	0|kallewoof|sipa: Also noted concern about a non-optimized storage format in consensus code, which I can sort of understand. Gonna think this through some more.
 63 2018-04-24 07:45:46	0|kallewoof|I think the key issue is, what size will the average skip list be, in a merkle proof. If it's "thousands" then using varint sounds sensible. If it's "tens" it sounds overkill.
 64 2018-04-24 09:04:07	0|promag|#13028 is pretty straightforward, would love some ack/nack there
 65 2018-04-24 09:04:09	0|gribble|https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
 66 2018-04-24 09:08:44	0|bitcoin-git|13bitcoin/06master 1480a5e59 15James O'Beirne: [qa] Attach node index to test_node AssertionError and print messages...
 67 2018-04-24 09:08:44	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/569e3817e000...896a9d026ccf
 68 2018-04-24 09:08:45	0|bitcoin-git|13bitcoin/06master 14896a9d0 15Wladimir J. van der Laan: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages...
 69 2018-04-24 09:09:33	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13022: [qa] Attach node index to test_node AssertionError and print messages (06master...062018-04-18-func-test-debug-log) 02https://github.com/bitcoin/bitcoin/pull/13022
 70 2018-04-24 09:12:14	0|bitcoin-git|13bitcoin/06master 141accfbc 15Kristaps Kaupe: Output values for "min relay fee not met" error
 71 2018-04-24 09:12:14	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/896a9d026ccf...34dd1a6d5e36
 72 2018-04-24 09:12:15	0|bitcoin-git|13bitcoin/06master 1434dd1a6 15Wladimir J. van der Laan: Merge #13032: Output values for "min relay fee not met" error...
 73 2018-04-24 09:13:08	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13032: Output values for "min relay fee not met" error (06master...06min-relay-fee-not-met-debug) 02https://github.com/bitcoin/bitcoin/pull/13032
 74 2018-04-24 09:57:38	0|bitcoin-git|13bitcoin/06master 1409b30db 15251: Asserts that the tx version number is a signed 32-bit integer.
 75 2018-04-24 09:57:38	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/34dd1a6d5e36...6e67754e481f
 76 2018-04-24 09:57:39	0|bitcoin-git|13bitcoin/06master 146e67754 15Wladimir J. van der Laan: Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output...
 77 2018-04-24 09:58:13	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output (06master...06issue/11561/test-negative-transaction-version-numbers) 02https://github.com/bitcoin/bitcoin/pull/12436
 78 2018-04-24 11:24:35	0|bitcoin-git|13bitcoin/06master 143ee4be1 15Bernhard M. Wiedemann: Make tests pass after 2020...
 79 2018-04-24 11:24:35	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6e67754e481f...54865cf9e6a8
 80 2018-04-24 11:24:36	0|bitcoin-git|13bitcoin/06master 1454865cf 15Wladimir J. van der Laan: Merge #13061: Make tests pass after 2020...
 81 2018-04-24 11:25:17	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13061: Make tests pass after 2020 (06master...06ftbfs-2020) 02https://github.com/bitcoin/bitcoin/pull/13061
 82 2018-04-24 12:07:33	0|bitcoin-git|13bitcoin/06master 148b8032e 15Chun Kuan Lee: test: Add rpcauth pair that generated by rpcauth
 83 2018-04-24 12:07:33	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/54865cf9e6a8...018c7e5dadc1
 84 2018-04-24 12:07:34	0|bitcoin-git|13bitcoin/06master 14018c7e5 15Wladimir J. van der Laan: Merge #13024: test: Add rpcauth pair that generated by rpcauth.py...
 85 2018-04-24 12:08:16	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13024: test: Add rpcauth pair that generated by rpcauth.py (06master...06rpc_test) 02https://github.com/bitcoin/bitcoin/pull/13024
 86 2018-04-24 12:42:27	0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13066: Make travis to run verify-commits (06master...06verify-commits) 02https://github.com/bitcoin/bitcoin/pull/13066
 87 2018-04-24 13:05:02	0|jonasschnelli|bluematt: has the bitcoincore.org deployment stalled? IMO https://bitcoincore.org/en/segwit_adoption/ should be gone by now
 88 2018-04-24 13:05:42	0|wumpus|you mean it's no longer updating from the github?
 89 2018-04-24 13:21:27	0|bitcoin-git|[13bitcoin] 15laanwj pushed 8 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/018c7e5dadc1...d1d54ae6a362
 90 2018-04-24 13:21:28	0|bitcoin-git|13bitcoin/06master 14a28b907 15John Newbery: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table...
 91 2018-04-24 13:21:29	0|bitcoin-git|13bitcoin/06master 143db1ba0 15John Newbery: [tests] Set -deprecatedrpc=accounts in tests...
 92 2018-04-24 13:21:29	0|bitcoin-git|13bitcoin/06master 144e671f0 15John Newbery: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py...
 93 2018-04-24 13:22:12	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12953: Deprecate accounts (06master...06deprecate_accounts) 02https://github.com/bitcoin/bitcoin/pull/12953
 94 2018-04-24 13:26:41	0|instagibbs|\o/ die accounts, die
 95 2018-04-24 13:30:34	0|sdaftuar|The accounts, the.
 96 2018-04-24 13:36:40	0|jamesob|anyone know what an exit code of -6 from bitcoin-qt signifies? didn't turn anything up with grep
 97 2018-04-24 13:40:39	0|jouke|sdaftuar: that's how I read it :)
 98 2018-04-24 13:52:51	0|bitcoin-git|[13bitcoin] 15ccdle12 opened pull request #13067: Pr fixes ccdle12 (06master...06PR-fixes-ccdle12) 02https://github.com/bitcoin/bitcoin/pull/13067
 99 2018-04-24 14:02:56	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 10 new commits to 060.16: 02https://github.com/bitcoin/bitcoin/compare/845838c4451e...9ea62a3dc4bd
100 2018-04-24 14:02:57	0|bitcoin-git|13bitcoin/060.16 141286f3e 15Ben Woosley: test: Use wait_until to ensure ping goes out...
101 2018-04-24 14:02:57	0|bitcoin-git|13bitcoin/060.16 14cfebd40 15Karl-Johan Alm: [test] Round target fee to 8 decimals in assert_fee_amount...
102 2018-04-24 14:02:58	0|bitcoin-git|13bitcoin/060.16 140e98f96 15Ben Woosley: test: Use wait_until in tests where time was used for polling...
103 2018-04-24 14:26:18	0|sdaftuar|sipa: regarding your comment in https://github.com/bitcoin/bitcoin/pull/13011#issuecomment-383145046 -- #9700 did have a mechanism to avoid doing the precomputation, so that block requests (and rescan) wouldn't be impacted
104 2018-04-24 14:26:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/9700 | Cache segwit signature hash components inside CTransaction to optimize validation performance by sdaftuar · Pull Request #9700 · bitcoin/bitcoin · GitHub
105 2018-04-24 14:27:36	0|sdaftuar|anyway not sure if that is enough to mitigate the concerns?  i'm also happy to adopt a different approach, i tried several designs last year, but i could use some direction to help figure out the best path forward (if this is something we want)
106 2018-04-24 14:28:55	0|jtimon|re-re-review re-re-beg: https://github.com/bitcoin/bitcoin/pull/10757
107 2018-04-24 14:30:05	0|jtimon|I really think it's ready this time, thanks everyone for the many nits that made it much better
108 2018-04-24 14:32:16	0|aj|jtimon: you could change "bool do_mediantxsize" etc back to "const bool" if you wanted :)
109 2018-04-24 14:37:45	0|bitcoin-git|13bitcoin/06master 14fac0db0 15MarcoFalke: wallet: Make fee settings non-static members
110 2018-04-24 14:37:45	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d1d54ae6a362...476cb35551f5
111 2018-04-24 14:37:46	0|bitcoin-git|13bitcoin/06master 14476cb35 15Wladimir J. van der Laan: Merge #12909: wallet: Make fee settings to be non-static members...
112 2018-04-24 14:38:31	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12909: wallet: Make fee settings to be non-static members (06master...06Mf1804-walletMembers) 02https://github.com/bitcoin/bitcoin/pull/12909
113 2018-04-24 14:49:04	0|jtimon|aj: oh, right, thanks
114 2018-04-24 14:55:47	0|jtimon|aj: done
115 2018-04-24 15:08:40	0|BlueMatt|MarcoFalke: I'd like to nominate #12998 for backporting. It has 0 risk of breaking supported configurations and virtually 0 risk of breaking anything else but is useful for a downstream project
116 2018-04-24 15:08:42	0|gribble|https://github.com/bitcoin/bitcoin/issues/12998 | Default to defining endian-conversion DECLs in compat w/o config by TheBlueMatt · Pull Request #12998 · bitcoin/bitcoin · GitHub
117 2018-04-24 15:25:54	0|BlueMatt|jonasschnelli: yea, I'll look into it when someone shows up with a 2fa
118 2018-04-24 15:40:21	0|promag|AccessByTxid requires cs_main?
119 2018-04-24 16:07:01	0|jnewbery|promag: I don't think shared pointers are required for wallet load/create. I'd rather not rebase on your PR unless necessary. I think loadwallet and g_wallet_manager can move forward in parallel
120 2018-04-24 16:22:20	0|promag|jnewbery: yes agree
121 2018-04-24 17:27:19	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/476cb35551f5...a0079d4b6dc6
122 2018-04-24 17:27:20	0|bitcoin-git|13bitcoin/06master 14962d223 15MarcoFalke: bench: Move constructors out of mempool_eviction hot loop
123 2018-04-24 17:27:20	0|bitcoin-git|13bitcoin/06master 14fa3bb18 15MarcoFalke: bench: Amend mempool_eviction test for witness txs
124 2018-04-24 17:27:21	0|bitcoin-git|13bitcoin/06master 14a0079d4 15MarcoFalke: Merge #13013: bench: Amend mempool_eviction test for witness txs...
125 2018-04-24 17:28:10	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13013: bench: Amend mempool_eviction test for witness txs (06master...06Mf1804-benchWitnessMempool) 02https://github.com/bitcoin/bitcoin/pull/13013
126 2018-04-24 17:30:33	0|promag|got "test_framework.authproxy.JSONRPCException: The mempool was not loaded yet (-1)" in https://travis-ci.org/bitcoin/bitcoin/jobs/370654669
127 2018-04-24 17:32:31	0|promag|should it retry?
128 2018-04-24 17:52:56	0|bitcoin-git|[13bitcoin] 15jimpo closed pull request #12647: wallet: Fix possible memory leak in CreateWalletFromFile. (06master...06wallet-pointer) 02https://github.com/bitcoin/bitcoin/pull/12647
129 2018-04-24 18:04:54	0|sdaftuar|sipa: actually, never mind about the segwit-hash-caching. now that we cache script validation success, we can achieve nearly all the benefit with a lot less work (and less controversial design) by just only doing the computation for transactions that aren't in the script cache
130 2018-04-24 18:46:14	0|jnewbery|promag: looks like that job was restarted so I can't see the failure. Was it: https://github.com/bitcoin/bitcoin/issues/12863 ?
131 2018-04-24 19:06:18	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13068: tests: Remove unused constant MAX_INV_SZ (06master...06MAX_INV_SZ) 02https://github.com/bitcoin/bitcoin/pull/13068
132 2018-04-24 19:14:19	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13069: docs: Fix typos (06master...06typos-201804) 02https://github.com/bitcoin/bitcoin/pull/13069
133 2018-04-24 19:14:59	0|promag|jnewbery: yes I've restarted it. Yap, that's the error (it's pasted above)
134 2018-04-24 22:26:12	0|jtimon|jimpo: promag re https://github.com/bitcoin/bitcoin/pull/10757#discussion_r183860805 I mean why is https://github.com/bitcoin/bitcoin/pull/10757/commits/c42248053a7cab3356f72413caafcb4a8fa845d4#diff-dbccfb6d2ff211cd44b8f5e532e3238aR170 working?
135 2018-04-24 22:26:54	0|jtimon|sorry, this https://github.com/bitcoin/bitcoin/pull/10757/commits/c42248053a7cab3356f72413caafcb4a8fa845d4#diff-dbccfb6d2ff211cd44b8f5e532e3238aR146
136 2018-04-24 22:27:34	0|promag|jtimon: vRPCConvertParams is only used by bitcoin-cli
137 2018-04-24 22:27:48	0|promag|to parse argv correctly
138 2018-04-24 22:28:00	0|jtimon|promag: which is used by that test, no?
139 2018-04-24 22:28:07	0|promag|test framework uses python rpc client
140 2018-04-24 22:28:10	0|promag|no
141 2018-04-24 22:28:16	0|jtimon|oh, sorry, got you
142 2018-04-24 22:28:20	0|promag|np
143 2018-04-24 22:28:56	0|promag|I also forget testing with bitcoin-cli..
144 2018-04-24 22:29:44	0|jtimon|yeah, not the first time it happens to me either, should had understood your comment simply by past experience