1 2018-04-25 00:01:30 0|bitcoin-git|[13bitcoin] 15promag opened pull request #13070: Split event handlers by wallet (06master...062018-04-split-handlers-by-wallet) 02 https://github.com/bitcoin/bitcoin/pull/13070
2 2018-04-25 08:25:48 0|wumpus|gahhh github unicorns again
3 2018-04-25 08:30:16 0|kallewoof|same here
4 2018-04-25 08:34:45 0|wumpus|speaking about single points of failure :)
5 2018-04-25 08:35:37 0|aj|really?
6 2018-04-25 08:35:56 0|aj|tried clearing your cookies?
7 2018-04-25 08:47:51 0|wumpus|no, will try that if it doesn't resolve itself
8 2018-04-25 09:46:53 0|wumpus|are functional tests supposed to log everything to console now? or is that an oversight in #13004?
9 2018-04-25 09:46:56 0|gribble|https://github.com/bitcoin/bitcoin/issues/13004 | Print to console by default when not run with -daemon by practicalswift ÷ Pull Request #13004 ÷ bitcoin/bitcoin ÷ GitHub
10 2018-04-25 09:51:35 0|wumpus|I seem to keep strugging with that one, am I the only one?
11 2018-04-25 09:52:41 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13071: test: Don't log to stdout in functional tests (06master...062018_04_test_output) 02 https://github.com/bitcoin/bitcoin/pull/13071
12 2018-04-25 09:52:57 0|wumpus|^
13 2018-04-25 10:10:36 0|aj|wumpus: logtoconsole? should be printtoconsole?
14 2018-04-25 10:46:09 0|bitcoin-git|[13bitcoin] 15ajtowns opened pull request #13072: Update createmultisig RPC to support segwit (06master...06signmultisig) 02 https://github.com/bitcoin/bitcoin/pull/13072
15 2018-04-25 12:26:26 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13071: test: Don't log to stdout in functional tests (06master...062018_04_test_output) 02 https://github.com/bitcoin/bitcoin/pull/13071
16 2018-04-25 12:26:42 0|wumpus|aj: you're right - I don't understand what went wrong there, or why that appeared to fix it
17 2018-04-25 12:27:12 0|wumpus|aj: it's already supposed to pass noprinttoconsole, but it was spitting out pages of logging
18 2018-04-25 13:55:23 0|bitcoin-git|13bitcoin/06master 14e074097 15Wladimir J. van der Laan: Merge #13051: qa: Normalize executable location...
19 2018-04-25 13:55:23 0|bitcoin-git|13bitcoin/06master 14fa811b0 15MarcoFalke: qa: Normalize executable location
20 2018-04-25 13:55:23 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/a0079d4b6dc6...e074097c1ba3
21 2018-04-25 13:56:19 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13051: qa: Normalize executable location (06master...06Mf1804-qaDefaultConfig) 02 https://github.com/bitcoin/bitcoin/pull/13051
22 2018-04-25 13:56:55 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/e074097c1ba3...106d9297801c
23 2018-04-25 13:56:56 0|bitcoin-git|13bitcoin/06master 14106d929 15Wladimir J. van der Laan: Merge #13056: [tests] Make rpcauth.py testable and add unit tests...
24 2018-04-25 13:56:56 0|bitcoin-git|13bitcoin/06master 146674a75 15Qasim Javed: [tests] Make rpcauth.py testable and add unit tests...
25 2018-04-25 13:57:43 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13056: [tests] Make rpcauth.py testable and add unit tests (06master...06rpcauth) 02 https://github.com/bitcoin/bitcoin/pull/13056
26 2018-04-25 14:40:59 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (06master...062018_04_rpcauth_unittest_outoftree) 02 https://github.com/bitcoin/bitcoin/pull/13073
27 2018-04-25 14:45:55 0|wumpus|whops
28 2018-04-25 14:54:27 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/106d9297801c...a785bc3667d3
29 2018-04-25 14:54:28 0|bitcoin-git|13bitcoin/06master 143e53004 15Wladimir J. van der Laan: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
30 2018-04-25 14:54:29 0|bitcoin-git|13bitcoin/06master 14a785bc3 15MarcoFalke: Merge #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
31 2018-04-25 14:55:20 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (06master...062018_04_rpcauth_unittest_outoftree) 02 https://github.com/bitcoin/bitcoin/pull/13073
32 2018-04-25 16:40:09 0|jimpo|Anyone feel like reviewing my logging refactor? #12954
33 2018-04-25 16:40:11 0|gribble|https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo ÷ Pull Request #12954 ÷ bitcoin/bitcoin ÷ GitHub
34 2018-04-25 16:40:36 0|jimpo|Will trade reviews
35 2018-04-25 16:44:25 0|jamesob|jimpo: I'll do it if you take a look at https://github.com/bitcoin/bitcoin/pull/12830
36 2018-04-25 16:51:41 0|jimpo|Sweet, will do
37 2018-04-25 17:04:34 0|wumpus|jamesob: that one looks ready for merge looking at all the(ut)ACKs?
38 2018-04-25 17:05:02 0|jamesob|wumpus: I reckon so, but that's your department :)
39 2018-04-25 17:06:52 0|wumpus|jamesob: I get a compile error when I try to compile it against current master: /.../bitcoin/src/qt/test/addressbooktests.cpp:106:5: error: use of undeclared identifier 'vpwallets'; did you mean 'wallet'?
40 2018-04-25 17:07:02 0|wumpus|jamesob: might need rebase
41 2018-04-25 17:07:25 0|jamesob|wumpus: ah yes, probably needs a rebase. will do now.
42 2018-04-25 17:07:42 0|jamesob|jimpo: in any case, will get around to the logging PR today.
43 2018-04-25 17:07:58 0|wumpus|oh sorry to distract you from reviewing
44 2018-04-25 17:08:55 0|jamesob|not at all
45 2018-04-25 17:32:40 0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/a785bc3667d3...25ad2f75f5d1
46 2018-04-25 17:32:41 0|bitcoin-git|13bitcoin/06master 148cdcaee 15James O'Beirne: [qt] Display more helpful message when adding a send address has failed...
47 2018-04-25 17:32:41 0|bitcoin-git|13bitcoin/06master 14c5b2770 15James O'Beirne: Add purpose arg to Wallet::getAddress...
48 2018-04-25 17:32:42 0|bitcoin-git|13bitcoin/06master 149c01be1 15James O'Beirne: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage...
49 2018-04-25 17:33:23 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12830: [qt] [tests] Clarify address book error messages, add tests (06master...062018-03-27-send-recv-addressbook-error) 02 https://github.com/bitcoin/bitcoin/pull/12830
50 2018-04-25 18:03:41 0|jimpo|jamesob: Left a post-merge review. You can ignore the nits, but I'd test out editing existing entries with either duplicate or new address values. I don't that's working correctly.
51 2018-04-25 18:04:18 0|jamesob|jimpo: thanks for the look! Will test per your notes after reviewing your logging change.
52 2018-04-25 18:05:34 0|jamesob|jimpo: any idea whether the behavior you're describing there was pre-existing? There's definitely some current weirdness with the address book.
53 2018-04-25 18:07:12 0|jimpo|Almost certainly pre-existing
54 2018-04-25 18:08:37 0|jimpo|but getDuplicateAddressWarning() shows the improved error with the line "mode == NewSendingAddress || mode == EditSendingAddress", which makes it seem like it should work with the edit flow
55 2018-04-25 18:16:27 0|aj|wumpus: it wasn't test_runner auto-calling combine_logs after a test failure maybe?
56 2018-04-25 18:18:35 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13074: [trivial] Correct help text for `importaddress` RPC (06master...06importaddress_help_text) 02 https://github.com/bitcoin/bitcoin/pull/13074
57 2018-04-25 19:37:32 0|jamesob|do we want to avoid using CCriticalSection in lieu of std::mutex when introducing new class-scoped locks?
58 2018-04-25 20:05:55 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13075: Remove 'account' API from wallet functional tests (06master...06remove_functional_tests_accounts) 02 https://github.com/bitcoin/bitcoin/pull/13075
59 2018-04-25 20:26:34 0|skeees|jamesob: i think pref is to avoid re-entrant locks if you can - can use CWaitableCriticalSection - which is more or less a type-alias for std::mutex
60 2018-04-25 20:29:36 0|jamesob|skeees: good call, thanks
61 2018-04-25 20:30:40 0|jamesob|another qq: would people be amenable to adding thread name to CLockLocation for easier deadlock debugging, and possibly to log statements as well?
62 2018-04-25 20:31:28 0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13076: Fix ScanForWalletTransactions to return a bool indicating success or failure (06master...06scan-for-wallet-transactions-ret) 02 https://github.com/bitcoin/bitcoin/pull/13076
63 2018-04-25 20:31:29 0|jamesob|and if so, would want to piggyback on the bitcoin-* 16 character pthread names or just have some peripheral mapping of boost thread ids to arbitrary length names?
64 2018-04-25 20:32:03 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13077: Add compile time checking for all cs_KeyStore runtime locking assertions (06master...06cs_KeyStore) 02 https://github.com/bitcoin/bitcoin/pull/13077
65 2018-04-25 20:35:57 0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13079: Fix ScanForWalletTransactions to report progress correctly when a pindexStop is supplied (06master...06scan-for-wallet-stopblock-progress) 02 https://github.com/bitcoin/bitcoin/pull/13079
66 2018-04-25 20:59:38 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13080: Add compile time checking for all ::mempool.cs runtime locking assertions (06master...06mempool.cs) 02 https://github.com/bitcoin/bitcoin/pull/13080
67 2018-04-25 21:17:32 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13081: Add compile time checking for all cs_wallet runtime locking assertions (06master...06cs_wallet-compile-time-checking) 02 https://github.com/bitcoin/bitcoin/pull/13081
68 2018-04-25 21:21:17 0|promag|is this error common? https://travis-ci.org/bitcoin/bitcoin/jobs/370846610
69 2018-04-25 21:21:49 0|promag|https://travis-ci.org/bitcoin/bitcoin/jobs/370846610#L2408
70 2018-04-25 21:35:50 0|bitcoin-git|[13bitcoin] 15kristapsk opened pull request #13082: Don't test against min relay fee information in mining_prioritisetransaction.py (06master...06dont-hardcode-134) 02 https://github.com/bitcoin/bitcoin/pull/13082
71 2018-04-25 21:37:40 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13083: Add compile time checking for all cs_main runtime locking assertions (06master...06cs_main) 02 https://github.com/bitcoin/bitcoin/pull/13083
72 2018-04-25 23:50:02 0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (06master...06201804_keepnegone) 02 https://github.com/bitcoin/bitcoin/pull/13084