1 2018-04-27 01:54:15	0|jtimon|what's the point of if (g_txindex) if g_txindex is never null ?
 2 2018-04-27 01:55:42	0|jtimon|or I'll rephrase, what's the new way of "if (!fTxIndex)" ?
 3 2018-04-27 01:56:40	0|sipa|?
 4 2018-04-27 01:57:01	0|jtimon|sorry, I'll figure it out
 5 2018-04-27 01:57:27	0|aj|g_txindex should be null without -txindex?
 6 2018-04-27 01:57:49	0|sipa|indeed
 7 2018-04-27 01:58:29	0|sipa|jtimon: sorry, i didn't understand your question by missing that your second line was about fTxIndex and not g_txindex
 8 2018-04-27 02:05:00	0|jtimon|I just got a ‘fTxIndex’ was not declared in this scope, greped and since I'm quite sure I didn't invented fTxIndex, I thought to ask, but I copied that fTxIndex from somewhere else and now I want ot know where I copied it from and what happened to that line. but git has all the anwers I'm looking for
 9 2018-04-27 02:07:38	0|sipa|in any case, g_txindex should be null when there is no index
10 2018-04-27 07:37:49	0|Kanmanee|[012f6fd7@gateway/web/freenode/ip.1.47.111.215] has joined #bitcoin-core-dev
11 2018-04-27 09:36:13	0|bitcoin-git|[13bitcoin] 15witty67 opened pull request #13102: for our kids (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13102
12 2018-04-27 09:37:35	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #13102: for our kids (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13102
13 2018-04-27 13:40:35	0|wumpus|how... how long is verify-commits.sh supposed to take?
14 2018-04-27 13:41:37	0|wumpus|I thought I'd post a local performance comparison in #13066 but while the python script finished in 5 minutes, the old shell script seems to be taking forever
15 2018-04-27 13:41:41	0|gribble|https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub
16 2018-04-27 13:55:12	0|wumpus|5min for the python script, 32min+ for the shell script
17 2018-04-27 13:57:23	0|promag|that's a huge difference
18 2018-04-27 13:58:03	0|wumpus|this is not a very fast computer (probably slower than what travis uses), but still
19 2018-04-27 13:59:17	0|promag|wumpus: re #13028 it's no big deal, the new mutex is used in a couple of places, nothing special
20 2018-04-27 13:59:19	0|gribble|https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
21 2018-04-27 14:00:30	0|promag|looks like I'm creating a chain of PR's..
22 2018-04-27 14:04:16	0|sdaftuar|wumpus: i think it's funny that our project has a slow commit verification script, you'd think someone here would be very good at writing a fast one. :)
23 2018-04-27 14:04:41	0|sdaftuar|anyway i just timed it locally, i've never run it before so not sure if i'm doing it right, but it took 5m30seconds but finished with an error
24 2018-04-27 14:04:56	0|sdaftuar|this is on a very fast computer though
25 2018-04-27 14:05:19	0|wumpus|what commit does it get to?
26 2018-04-27 14:06:49	0|sdaftuar|here's my output: https://0bin.net/paste/bcwIMpfNjPlH7JKh#1dF-PaM+KUv4wIDmz1rfrd7PzMrNp5fXmLq8NoFOktU
27 2018-04-27 14:06:50	0|wumpus|I managed to make it quite also after 5mXX but it complained about an unclean commit which was not very deep
28 2018-04-27 14:06:52	0|gribble|https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
29 2018-04-27 14:07:20	0|wumpus|the python script verifies 2627 commits in 5m36.844s
30 2018-04-27 14:07:27	0|sdaftuar|i'll give that a try
31 2018-04-27 14:08:09	0|wumpus|that one gets to commit c17f11f7b43ad3bd9e242c67db1f3679558a0581, that's depth 479
32 2018-04-27 14:09:43	0|promag|MarcoFalke: I don't have windows atm to find the problem
33 2018-04-27 14:09:52	0|wumpus|5.5/479*2627 -> would have taken ~30 minutes to go through them all, that's faster than my 32min, but still
34 2018-04-27 14:13:51	0|sdaftuar|the python script finished in 3m21seconds and didn't produce an error
35 2018-04-27 14:18:42	0|wumpus|I wonder what causes the difference in results
36 2018-04-27 14:19:05	0|ken2812221|This is my original commit. https://github.com/ken2812221/bitcoin/commit/1fac6074126c289a56f84db19845775b96f8f273
37 2018-04-27 14:19:27	0|ken2812221|It runs over 1.5 hours on my PC
38 2018-04-27 14:19:48	0|wumpus|ken2812221: hey you're here! any idea why commit  c17f11f7b43ad3bd9e242c67db1f3679558a0581 fails the clean merge test with the .sh script, but passes with the .py script?
39 2018-04-27 14:22:08	0|ken2812221|sipa says we can only check unclean merge in one month, so I don't check if it commit before one month
40 2018-04-27 14:24:14	0|wumpus|oh right
41 2018-04-27 14:24:37	0|wumpus|it seems to check merge up to 082e26c08bb0a803cf9cf6b015c08ee57f31e623
42 2018-04-27 14:25:07	0|wumpus|and that commit is deeper, so it won't be checked
43 2018-04-27 14:25:22	0|wumpus|(well, the subtree check, but not the merge check)
44 2018-04-27 14:27:12	0|wumpus|eh no, not that either, just the gpg check? your script only checks the sha512sum treehash for the top commit?
45 2018-04-27 14:28:41	0|wumpus|or is that the same for the .sh, I don't remember
46 2018-04-27 14:30:55	0|ken2812221|it only check if you has set --tree-checks, same in shell script
47 2018-04-27 14:31:27	0|wumpus|I see, just figured out --tree-checks
48 2018-04-27 14:34:04	0|wumpus|you're correct, the shell script has the same behavior
49 2018-04-27 14:46:30	0|wumpus|ken2812221: so to be clear: the only expected difference in behavior between your python script and the shell script is that your script only verifies merges up to a certain depth?
50 2018-04-27 14:48:10	0|wumpus|(which is a sensible change, as the shell script throws an error there, not allowing it to verify the gpg signatures deeper either)
51 2018-04-27 14:48:54	0|ken2812221|Yes.
52 2018-04-27 14:51:14	0|wumpus|ok
53 2018-04-27 15:03:42	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/487dcbe80c20...17266a13067c
54 2018-04-27 15:03:43	0|bitcoin-git|13bitcoin/06master 142ae705d 15Andrew Chow: Remove Safe mode
55 2018-04-27 15:03:43	0|bitcoin-git|13bitcoin/06master 147da3b0a 15Wladimir J. van der Laan: rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section...
56 2018-04-27 15:03:44	0|bitcoin-git|13bitcoin/06master 14d8e9a2a 15Wladimir J. van der Laan: Remove "rpc" category from GetWarnings...
57 2018-04-27 15:04:39	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13090: Remove Safe mode (achow101) (06master...062018_04_remove_safemode_rebased) 02https://github.com/bitcoin/bitcoin/pull/13090
58 2018-04-27 16:57:43	0|bitcoin-git|[13bitcoin] 15jamesob opened pull request #13105: [qa] Add --failfast option to functional test runner (06master...062018-04-testrunner-failfast) 02https://github.com/bitcoin/bitcoin/pull/13105
59 2018-04-27 18:12:46	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #13106: Simplify semantics of ChainStateFlushed callback (06master...062018-04-wallet-flush-better-criteria) 02https://github.com/bitcoin/bitcoin/pull/13106
60 2018-04-27 19:34:36	0|jamesob|I'm really down the rabbithole on this qt functional test deadlock stuff -- do we have a way of programmatically capturing stacktraces? any aversion to adding libunwind as a dep when --enable-debug?
61 2018-04-27 19:39:31	0|MarcoFalke|jamesob: You could debug locally in a trusty vm?
62 2018-04-27 19:42:26	0|jamesob|MarcoFalke: yep, am at the moment
63 2018-04-27 20:02:29	0|Master_|Hello
64 2018-04-27 22:44:05	0|instagibbs|can someone point me to where .cookie file went on master? Must have missed it.
65 2018-04-27 22:46:17	0|sipa|it's there for me
66 2018-04-27 22:46:24	0|sipa|$DATADIR/.cookie
67 2018-04-27 22:48:31	0|sipa|do you have rpcuser/rpcpassword/rpcauth set?
68 2018-04-27 22:49:44	0|instagibbs|ok, probably an issue between chair and keyboard