1 2018-04-30 01:15:01 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13120: policy: Treat segwit as always active (06master...06Mf1805-segwitGenesisPolicy) 02 https://github.com/bitcoin/bitcoin/pull/13120
2 2018-04-30 01:31:41 0|mryandao|MarcoFalke: can you have a look at #13109? i've addressed your comments
3 2018-04-30 01:31:43 0|gribble|https://github.com/bitcoin/bitcoin/issues/13109 | [rpc] nit: fix typo for entry description string by mryandao ÷ Pull Request #13109 ÷ bitcoin/bitcoin ÷ GitHub
4 2018-04-30 01:32:10 0|MarcoFalke|mryandao: thx LGTM
5 2018-04-30 01:35:14 0|MarcoFalke|mryandao: Missing white space between "in" and "BTC", no?
6 2018-04-30 01:41:42 0|mryandao|MarcoFalke: ok added the space :/
7 2018-04-30 05:01:27 0|jonasschnelli|roasbeef: that is what I'm doing.. but it still complains after 1.3GB that the map is full
8 2018-04-30 06:45:29 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13113: tests: Make it clear that MAX_INV_SZ is not covered by functional tests (06master...06add-note-about-MAX_INV_SZ) 02 https://github.com/bitcoin/bitcoin/pull/13113
9 2018-04-30 06:47:30 0|wumpus|jonasschnelli: I found it strange too, but it's what e.g. monero is doing
10 2018-04-30 06:47:43 0|wumpus|jonasschnelli: I think they double the map size every time that is needed
11 2018-04-30 06:48:30 0|jonasschnelli|wumpus: okay... funny... also, I can't find any hint in the documentation... it looks like it should be possible to initialize a 4GB map size and fill it up.
12 2018-04-30 06:48:54 0|jonasschnelli|wumpus: do you know how monero deals with the 4GB 32bit limitation?
13 2018-04-30 07:05:19 0|wumpus|jonasschnelli: probably better to take it #monero-dev, but IIRC monero doesn't run on 32-bit
14 2018-04-30 07:06:22 0|jonasschnelli|thanks
15 2018-04-30 07:33:28 0|fanquake|wumpus #13119 & #13109 probably ready to go in
16 2018-04-30 07:33:31 0|gribble|https://github.com/bitcoin/bitcoin/issues/13119 | Remove script to clean up datadirs by MarcoFalke ÷ Pull Request #13119 ÷ bitcoin/bitcoin ÷ GitHub
17 2018-04-30 07:33:32 0|gribble|https://github.com/bitcoin/bitcoin/issues/13109 | [rpc] nit: fix typo for entry description string by mryandao ÷ Pull Request #13109 ÷ bitcoin/bitcoin ÷ GitHub
18 2018-04-30 08:13:44 0|bitcoin-git|13bitcoin/06master 14fa85de9 15MarcoFalke: Remove script to clean up datadirs...
19 2018-04-30 08:13:44 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/3315007e03f5...81743b5b24c0
20 2018-04-30 08:13:45 0|bitcoin-git|13bitcoin/06master 1481743b5 15Jonas Schnelli: Merge #13119: Remove script to clean up datadirs...
21 2018-04-30 08:14:40 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #13119: Remove script to clean up datadirs (06master...06Mf1805-deleteTidyDatadir) 02 https://github.com/bitcoin/bitcoin/pull/13119
22 2018-04-30 08:17:08 0|jonasschnelli|Thanks fanquake: I think 13019 should get another ack (re-kicked travis as well)
23 2018-04-30 08:39:55 0|bitcoin-git|[13bitcoin] 15dbolser opened pull request #13122: --disable-asm is required to compile on FreeBSD (06master...06patch-4) 02 https://github.com/bitcoin/bitcoin/pull/13122
24 2018-04-30 08:43:55 0|fanquake|jonasschnelli I've ACK'd it, travis is now green too.
25 2018-04-30 08:44:09 0|wumpus|fanquake: will take al ook
26 2018-04-30 08:47:20 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13123: Add Clang thread safety annotations for guarded variables in the networking code (06master...06net-guarded-by) 02 https://github.com/bitcoin/bitcoin/pull/13123
27 2018-04-30 08:50:36 0|bitcoin-git|13bitcoin/06master 14f7c414d 15mryandao: nit: fix typo for entry description string
28 2018-04-30 08:50:36 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/81743b5b24c0...219970524d8a
29 2018-04-30 08:50:37 0|bitcoin-git|13bitcoin/06master 142199705 15Wladimir J. van der Laan: Merge #13109: [rpc] nit: fix typo for entry description string...
30 2018-04-30 08:51:25 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13109: [rpc] nit: fix typo for entry description string (06master...06fix-getrawmempool-fee-representation) 02 https://github.com/bitcoin/bitcoin/pull/13109
31 2018-04-30 08:56:22 0|mryandao|even the spelling of descentd(e|a)nt is contentious, kek
32 2018-04-30 09:02:47 0|promag|mryandao: also fix https://github.com/bitcoin/bitcoin/pull/12240/files#diff-ef76fd6674f07db88c3422fdbf0bcf9fR73 ?
33 2018-04-30 09:04:59 0|mryandao|promag: just to be sure what i'm looking at here -- is it just the "descendent" in the release-notes that needs fixing?
34 2018-04-30 09:05:36 0|promag|mryandao: right
35 2018-04-30 09:11:25 0|bitcoin-git|[13bitcoin] 15mryandao opened pull request #13124: [doc] nit: descendent should be spelled descendant even in the release-notes (06master...06fix-getrawmempool-fee-representation) 02 https://github.com/bitcoin/bitcoin/pull/13124
36 2018-04-30 09:17:34 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending (06master...06m_cs_callbacks_pending) 02 https://github.com/bitcoin/bitcoin/pull/13125
37 2018-04-30 09:29:47 0|fanquake|#13124 can go in now too, and that'll be the end of "descendent".
38 2018-04-30 09:29:49 0|gribble|https://github.com/bitcoin/bitcoin/issues/13124 | [doc] nit: descendent should be spelled descendant even in the release-notes by mryandao ÷ Pull Request #13124 ÷ bitcoin/bitcoin ÷ GitHub
39 2018-04-30 09:32:07 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13126: util: Add Clang thread safety annotations for variables guarded by cs_args (06master...06guarded-by-cs_args) 02 https://github.com/bitcoin/bitcoin/pull/13126
40 2018-04-30 09:36:13 0|wumpus|lol couldn't that be done in one PR
41 2018-04-30 09:36:41 0|fanquake|wumpus unfortunately I forgot to search after looking at the last one..
42 2018-04-30 09:37:28 0|bitcoin-git|13bitcoin/06master 149b78ef3 15mryandao: nit: descendent should be spelled descendant even in the release-notes
43 2018-04-30 09:37:28 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/219970524d8a...19fadd9d6883
44 2018-04-30 09:37:29 0|bitcoin-git|13bitcoin/06master 1419fadd9 15Wladimir J. van der Laan: Merge #13124: [doc] nit: descendent should be spelled descendant even in the release-notes...
45 2018-04-30 09:38:11 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13124: [doc] nit: descendent should be spelled descendant even in the release-notes (06master...06fix-getrawmempool-fee-representation) 02 https://github.com/bitcoin/bitcoin/pull/13124
46 2018-04-30 09:38:43 0|fanquake|The GH UI lags a fair way behind a merge being announced here by the git bot
47 2018-04-30 09:39:16 0|wumpus|yes, I've also noticed, can be quite long before the UI notices
48 2018-04-30 09:40:13 0|wumpus|all the requests on their server must be like stampeding unicorns
49 2018-04-30 09:40:22 0|fanquake|hehe
50 2018-04-30 09:42:36 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13127: wallet: Add Clang thread safety annotations for variables guarded by cs_db (06master...06guarded-by-cs_db) 02 https://github.com/bitcoin/bitcoin/pull/13127
51 2018-04-30 09:45:40 0|wumpus|we should probably poke practicalswift to group these things, not create a zillion PRs in a day
52 2018-04-30 09:46:56 0|promag|afaiu he is splitting?
53 2018-04-30 09:47:02 0|fanquake|wumpus I thought there was already one large PR that grouped all these together, and they were now being split up.
54 2018-04-30 09:47:13 0|fanquake|Although I agree, a couple PRs a day is probably enough.
55 2018-04-30 09:47:34 0|wumpus|ok...
56 2018-04-30 09:47:44 0|promag|imo he should go easy
57 2018-04-30 09:48:02 0|promag|wait for a merge and submit a new one
58 2018-04-30 09:48:23 0|promag|otherwise it's overwhelming
59 2018-04-30 09:52:30 0|wumpus|right, it feels a bit like a swarm attack on reviewers
60 2018-04-30 09:59:42 0|wumpus|and I know he doesn't mean it that way...
61 2018-04-30 10:00:20 0|promag|honestly atm I try to avoid those PR
62 2018-04-30 10:01:59 0|wumpus|we should review BlueMatt's PRs more
63 2018-04-30 10:03:28 0|promag|you mean #12979?
64 2018-04-30 10:03:30 0|gribble|https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt ÷ Pull Request #12979 ÷ bitcoin/bitcoin ÷ GitHub
65 2018-04-30 10:05:09 0|wumpus|currently looking at #13106
66 2018-04-30 10:05:10 0|gribble|https://github.com/bitcoin/bitcoin/issues/13106 | Simplify semantics of ChainStateFlushed callback by TheBlueMatt ÷ Pull Request #13106 ÷ bitcoin/bitcoin ÷ GitHub
67 2018-04-30 10:05:23 0|wumpus|but yes definitely that one too
68 2018-04-30 12:04:32 0|provoostenator|"Makefile:5697: recipe for target 'libbitcoin_server_a-init.o' failed" on Ubuntu 16.04 on VM with 2 GB RAM, 30% of which used up by some other process.
69 2018-04-30 12:05:19 0|provoostenator|Killing said process makes the problem go away. But it seems we're quite close to the limit of the minimum recommended system RAM (2 GB) for that file.
70 2018-04-30 12:06:02 0|provoostenator|(the other process being sipa's DNS seeder FYI :-)
71 2018-04-30 12:09:54 0|wumpus|which compiler/version?
72 2018-04-30 12:11:23 0|wumpus|FWIW in the issue about compiler memory usage (#6658) there are some cflags that can be used to tone down memory usage for at least gcc..
73 2018-04-30 12:11:25 0|gribble|https://github.com/bitcoin/bitcoin/issues/6658 | Building requires >1GB memory ÷ Issue #6658 ÷ bitcoin/bitcoin ÷ GitHub
74 2018-04-30 12:12:13 0|provoostenator|gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9
75 2018-04-30 12:13:38 0|wumpus|adding swap also helps
76 2018-04-30 13:21:50 0|promag|merge #13028 ?
77 2018-04-30 13:21:51 0|gribble|https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag ÷ Pull Request #13028 ÷ bitcoin/bitcoin ÷ GitHub
78 2018-04-30 13:26:59 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/19fadd9d6883...9e9b48df72db
79 2018-04-30 13:27:00 0|bitcoin-git|13bitcoin/06master 1458f9a0a 15James O'Beirne: Use --failfast when running functional tests on Travis
80 2018-04-30 13:27:00 0|bitcoin-git|13bitcoin/06master 14bf720c1 15James O'Beirne: Add --failfast option to functional test runner...
81 2018-04-30 13:27:01 0|bitcoin-git|13bitcoin/06master 149e9b48d 15Wladimir J. van der Laan: Merge #13105: [qa] Add --failfast option to functional test runner...
82 2018-04-30 13:27:52 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13105: [qa] Add --failfast option to functional test runner (06master...062018-04-testrunner-failfast) 02 https://github.com/bitcoin/bitcoin/pull/13105
83 2018-04-30 13:46:15 0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #12914: scripted-diff: Remove redundant license reference (HTTP URL) (06master...06copyright-headers) 02 https://github.com/bitcoin/bitcoin/pull/12914
84 2018-04-30 13:48:37 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13128: policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator (06master...06guarded-by-cs_feeEstimator) 02 https://github.com/bitcoin/bitcoin/pull/13128
85 2018-04-30 15:26:35 0|bitcoin-git|13bitcoin/06master 14e2f58f4 15João Barbosa: wallet: Make vpwallets usage thread safe
86 2018-04-30 15:26:35 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/9e9b48df72db...783bb6455e18
87 2018-04-30 15:26:36 0|bitcoin-git|13bitcoin/06master 14783bb64 15Wladimir J. van der Laan: Merge #13028: Make vpwallets usage thread safe...
88 2018-04-30 15:27:16 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13028: Make vpwallets usage thread safe (06master...062018-04-cs_wallets) 02 https://github.com/bitcoin/bitcoin/pull/13028
89 2018-04-30 15:58:37 0|promag|jnewbery: fast rebase on 10740 :)
90 2018-04-30 16:37:20 0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #11596: Add missing cs_main locks when accessing chainActive (06master...06chainActive) 02 https://github.com/bitcoin/bitcoin/pull/11596
91 2018-04-30 16:38:54 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13130: [tests] Fix race in rpc_deprecated.py (06master...06fix_rpc_deprecated) 02 https://github.com/bitcoin/bitcoin/pull/13130
92 2018-04-30 16:39:46 0|jnewbery|thanks promag!
93 2018-04-30 16:40:10 0|jnewbery|#12953 has introduced a race in rpc_deprecated.py. Sorry
94 2018-04-30 16:40:13 0|gribble|https://github.com/bitcoin/bitcoin/issues/12953 | Deprecate accounts by jnewbery ÷ Pull Request #12953 ÷ bitcoin/bitcoin ÷ GitHub
95 2018-04-30 16:40:21 0|jnewbery|Fix is in #13130
96 2018-04-30 16:40:22 0|gribble|https://github.com/bitcoin/bitcoin/issues/13130 | [tests] Fix race in rpc_deprecated.py by jnewbery ÷ Pull Request #13130 ÷ bitcoin/bitcoin ÷ GitHub
97 2018-04-30 16:40:51 0|jnewbery|MarcoFalke, wumpus ^^ should merge the above to fix intermittent travis failures
98 2018-04-30 16:53:50 0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13131: Add Windows shutdown handler (06master...06win-quit) 02 https://github.com/bitcoin/bitcoin/pull/13131
99 2018-04-30 17:05:39 0|bitcoin-git|13bitcoin/06master 14a95bf64 15John Newbery: [tests] Fix race in rpc_deprecated.py...
100 2018-04-30 17:05:39 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/783bb6455e18...3186ad4a81a4
101 2018-04-30 17:05:40 0|bitcoin-git|13bitcoin/06master 143186ad4 15MarcoFalke: Merge #13130: [tests] Fix race in rpc_deprecated.py...
102 2018-04-30 17:06:35 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13130: [tests] Fix race in rpc_deprecated.py (06master...06fix_rpc_deprecated) 02 https://github.com/bitcoin/bitcoin/pull/13130
103 2018-04-30 17:13:33 0|provoostenator|I rebased my Gitian doc PR from February: https://github.com/bitcoin-core/docs/pull/25
104 2018-04-30 17:14:02 0|provoostenator|Would be nice to get this merged before all the Ubuntu 18.04 changes start piling in...
105 2018-04-30 17:36:44 0|provoostenator|(nvm the latter, since these instructions are about the host, not the building machine)
106 2018-04-30 17:43:20 0|jimpo|Any more comments on #12954?
107 2018-04-30 17:43:22 0|gribble|https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo ÷ Pull Request #12954 ÷ bitcoin/bitcoin ÷ GitHub