1 2018-05-01 02:21:09	0|bitcoin-git|[13bitcoin] 15sipa pushed 7 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3186ad4a81a4...5a666428b0f1
  2 2018-05-01 02:21:10	0|bitcoin-git|13bitcoin/06master 146a6d764 15Jim Posen: util: Move debug file management functions into Logger.
  3 2018-05-01 02:21:10	0|bitcoin-git|13bitcoin/06master 14f55f4fc 15Jim Posen: util: Establish global logger object....
  4 2018-05-01 02:21:11	0|bitcoin-git|13bitcoin/06master 143316a9e 15Jim Posen: util: Encapsulate logCategories within BCLog::Logger.
  5 2018-05-01 02:21:56	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #12954: util: Refactor logging code into a global object (06master...06logging) 02https://github.com/bitcoin/bitcoin/pull/12954
  6 2018-05-01 02:53:21	0|meshcollider|ping kallewoof are you online? Need to talk to you about bitcoin wiki but you're not in that channel
  7 2018-05-01 04:21:16	0|kallewoof|meshcollider: pong. I'm joining
  8 2018-05-01 05:33:14	0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13133: Remove python2 from configure.ac (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/13133
  9 2018-05-01 10:22:35	0|wumpus|provoostenator: thanks!
 10 2018-05-01 11:04:45	0|jtimon|BlueMatt: around?
 11 2018-05-01 11:04:52	0|jtimon|I'm not sure I understand you on https://github.com/bitcoin/bitcoin/pull/10757#discussion_r184835724
 12 2018-05-01 11:04:56	0|jtimon|regarding the roundings, we can also multiply everything by 1000 and then divide at the end instead of using floats
 13 2018-05-01 11:04:58	0|jtimon|not sure what do you mean by "rounding issues you see here where things are rounded to the nearest 1"
 14 2018-05-01 11:05:42	0|jtimon|I'd rather change the unit than chaging from int to float
 15 2018-05-01 12:11:57	0|Syd|Bypassicloud
 16 2018-05-01 13:04:40	0|bitcoin-git|13bitcoin/06master 14457c2da 15Chun Kuan Lee: Remove python2 from configure.ac
 17 2018-05-01 13:04:40	0|bitcoin-git|13bitcoin/06master 14a024a18 15MarcoFalke: Merge #13133: Remove python2 from configure.ac...
 18 2018-05-01 13:04:40	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5a666428b0f1...a024a1841d62
 19 2018-05-01 13:05:24	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13133: Remove python2 from configure.ac (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/13133
 20 2018-05-01 13:13:57	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13134: net: Add option `-peersendreject` to configure sending of BIP61 notifications (06master...062018_05_optional_bip61) 02https://github.com/bitcoin/bitcoin/pull/13134
 21 2018-05-01 13:51:40	0|jnewbery|< wumpus> jnewbery: great to see so much progress on account deprecation re: #13075, should we create an issue to track the importprunedfunds issue?
 22 2018-05-01 13:51:42	0|gribble|https://github.com/bitcoin/bitcoin/issues/13075 | Remove account API from wallet functional tests by jnewbery · Pull Request #13075 · bitcoin/bitcoin · GitHub
 23 2018-05-01 13:52:02	0|jnewbery|wumpus: sorry, only just saw this. The importprunedfunds issue is tracked in #13078
 24 2018-05-01 13:52:03	0|gribble|https://github.com/bitcoin/bitcoin/issues/13078 | importprunedfunds + removeprunedfunds + listtransactions can cause OOM · Issue #13078 · bitcoin/bitcoin · GitHub
 25 2018-05-01 13:58:33	0|wumpus|jnewbery: ok will take a look
 26 2018-05-01 14:31:10	0|wumpus|can anyone please pick up #12384 and do just the relevant change?
 27 2018-05-01 14:31:12	0|gribble|https://github.com/bitcoin/bitcoin/issues/12384 | [Docs] Add version footnote to tor.md by Willtech · Pull Request #12384 · bitcoin/bitcoin · GitHub
 28 2018-05-01 14:31:52	0|wumpus|I don't lose patience quickly but there's no reason a one-line change has to take forever
 29 2018-05-01 14:34:21	0|wumpus|and we're not going to change the header style there, his point is 'consistency' but if you look at any of our other .mds we use the ------ / ====== style
 30 2018-05-01 14:34:35	0|wumpus|heck, I'll do it myself
 31 2018-05-01 14:39:45	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (06master...062018_05_tor_md_version) 02https://github.com/bitcoin/bitcoin/pull/13135
 32 2018-05-01 14:41:01	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (06master...062018_05_tor_md_version) 02https://github.com/bitcoin/bitcoin/pull/13135
 33 2018-05-01 14:43:10	0|wumpus|gah
 34 2018-05-01 14:43:27	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a024a1841d62...c5f7efe3312f
 35 2018-05-01 14:43:28	0|bitcoin-git|13bitcoin/06master 1439d2911 15Damian Williamson: [Docs] Add version footnote to tor.md...
 36 2018-05-01 14:43:28	0|bitcoin-git|13bitcoin/06master 14c5f7efe 15Wladimir J. van der Laan: Merge #12384: [Docs] Add version footnote to tor.md...
 37 2018-05-01 14:43:55	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12384: [Docs] Add version footnote to tor.md (06master...06tor.md) 02https://github.com/bitcoin/bitcoin/pull/12384
 38 2018-05-01 14:52:54	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c5f7efe3312f...35eb9d6c880e
 39 2018-05-01 14:52:55	0|bitcoin-git|13bitcoin/06master 142a87b1b 15ctp-tsteenholdt: Add systemd service for bitcoind...
 40 2018-05-01 14:52:55	0|bitcoin-git|13bitcoin/06master 149085532 15ctp-tsteenholdt: Sync contrib/debian from Matt Corallo's PPA
 41 2018-05-01 14:52:56	0|bitcoin-git|13bitcoin/06master 1435eb9d6 15Wladimir J. van der Laan: Merge #12769: Add systemd service to bitcoind in debian package...
 42 2018-05-01 14:53:36	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12769: Add systemd service to bitcoind in debian package (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/12769
 43 2018-05-01 14:56:58	0|BlueMatt|wumpus: oops, I dont think I can build with those changes until at least 2019
 44 2018-05-01 14:57:58	0|wumpus|BlueMatt: gah, I guess it shouldn't have been a PR then
 45 2018-05-01 14:58:16	0|wumpus|BlueMatt: should I revert it?
 46 2018-05-01 14:59:00	0|BlueMatt|yea, my fault, I should have been clear that I intended to un-ack after luke's comments
 47 2018-05-01 14:59:44	0|BlueMatt|I mean I dont care *too* much, the ppa has often been out of sync, but it kinda sucks to remain out of sync
 48 2018-05-01 14:59:56	0|BlueMatt|obviously for any modern releases of ubuntu/debian those changes make sense
 49 2018-05-01 15:00:20	0|BlueMatt|I can also use them on new distros and just revert them on old ones
 50 2018-05-01 15:03:40	0|BlueMatt|oh, I may be wrong, its there on trusty
 51 2018-05-01 15:05:40	0|wumpus|it's been reverted
 52 2018-05-01 15:05:43	0|bitcoin-git|13bitcoin/06master 141408d6c 15Wladimir J. van der Laan: Revert #12769: Add systemd service to bitcoind in debian package...
 53 2018-05-01 15:05:43	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 06master: 02https://github.com/bitcoin/bitcoin/commit/1408d6cf768cc3c88e9ab9efe98b0cb52ae3b537
 54 2018-05-01 15:08:37	0|wumpus|wouldn't it be better to host the debian stuff in a separate repository, that you have write access to yourself BlueMatt?
 55 2018-05-01 15:09:24	0|wumpus|I'm really out of my depth here
 56 2018-05-01 15:11:10	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13136: [trivial] [tests] Fix flake8 warnings in several wallet functional tests (06master...06wallet_test_flake8) 02https://github.com/bitcoin/bitcoin/pull/13136
 57 2018-05-01 15:11:36	0|wumpus|otherwise, just re-file in 2019
 58 2018-05-01 15:11:44	0|BlueMatt|wumpus: thats an option, I mean tbh /I'm/ also definitely a debian packaging expert
 59 2018-05-01 15:18:49	0|BlueMatt|so tbh I'm mostly out of my depth too, though I am using debian again now soooo
 60 2018-05-01 15:46:02	0|MarcoFalke|BlueMatt: wumpus: So what's the status of this? Should this stay reverted in master? Otherwise I suggest a force push to the commit that merged it
 61 2018-05-01 15:46:20	0|wumpus|well I"m not going to re-revert it as least, this is not an edit war
 62 2018-05-01 15:46:52	0|wumpus|having an edit war with myself would be kind of pathetic in any case :)
 63 2018-05-01 15:47:00	0|MarcoFalke|Yeah, thats why I suggested the force push
 64 2018-05-01 15:47:28	0|BlueMatt|MarcoFalke: we do not force-push master
 65 2018-05-01 15:47:37	0|wumpus|sometimes we do
 66 2018-05-01 15:47:40	0|MarcoFalke|^
 67 2018-05-01 15:47:44	0|BlueMatt|I mean its been like 30 minutes
 68 2018-05-01 15:47:47	0|BlueMatt|sure, if its been 30 seconds
 69 2018-05-01 15:47:48	0|BlueMatt|but....
 70 2018-05-01 15:48:03	0|wumpus|in any case the only options are: force push, or re-submit in 2019
 71 2018-05-01 15:48:17	0|wumpus|we're not going to have a fight on the repository
 72 2018-05-01 15:49:17	0|BlueMatt|I mean its /probably/ fine if its merged
 73 2018-05-01 15:49:30	0|BlueMatt|but I'd have to do uploads to figure it out
 74 2018-05-01 15:49:30	0|wumpus|and I'm heading for today, already feels like I've done more damage than good
 75 2018-05-01 15:49:51	0|BlueMatt|also its usually out-of-sync with master, so whatever
 76 2018-05-01 15:50:13	0|BlueMatt|so other option: try to build with it merged when we next do a release, then do a "sync with ppa" pr at that point
 77 2018-05-01 15:50:27	0|wumpus|the optoin I'd prefer is to host this stuff outside of the repository completely, it seems a side-show
 78 2018-05-01 15:50:30	0|wumpus|yeah...
 79 2018-05-01 15:50:57	0|BlueMatt|or that
 80 2018-05-01 15:51:13	0|wumpus|especially if it's always out of sync
 81 2018-05-01 15:53:44	0|MarcoFalke|https://github.com/bitcoin-core/packaging ?
 82 2018-05-01 15:54:17	0|wumpus|sgtm
 83 2018-05-01 15:57:32	0|wumpus|then a debian directory under that, I suppose
 84 2018-05-01 15:57:53	0|MarcoFalke|jup, also move the /rpm/ one
 85 2018-05-01 15:58:04	0|MarcoFalke|* ./contrib/rpm/
 86 2018-05-01 15:58:13	0|wumpus|indeed
 87 2018-05-01 15:58:14	0|BlueMatt|sgtm
 88 2018-05-01 16:05:37	0|wumpus|https://github.com/bitcoin-core/packaging
 89 2018-05-01 16:10:10	0|wumpus|ok, teams also set up so that BlueMatt has admin access to the repository
 90 2018-05-01 16:14:41	0|BlueMatt|ok, I'll try to push the current-changes to it today
 91 2018-05-01 16:18:56	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13137: contrib: Remove distribution packaging (06master...062018_05_move_distro_packaging) 02https://github.com/bitcoin/bitcoin/pull/13137
 92 2018-05-01 16:21:09	0|wumpus|right, probably more urgent to bring it up to date than the (more risky) systemd switch
 93 2018-05-01 16:21:41	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1408d6cf768c...baf6b4e3f956
 94 2018-05-01 16:21:42	0|bitcoin-git|13bitcoin/06master 14a533834 15John Newbery: [tests] Fix flake8 warnings in several wallet functional tests...
 95 2018-05-01 16:21:42	0|bitcoin-git|13bitcoin/06master 14baf6b4e 15MarcoFalke: Merge #13136: [tests] Fix flake8 warnings in several wallet functional tests...
 96 2018-05-01 16:22:34	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13136: [tests] Fix flake8 warnings in several wallet functional tests (06master...06wallet_test_flake8) 02https://github.com/bitcoin/bitcoin/pull/13136
 97 2018-05-01 19:15:06	0|luke-jr|wumpus: BlueMatt: problem with a separate repo is that debian/ has non-packaging stuff in it..
 98 2018-05-01 19:15:15	0|luke-jr|I suppose we could/should fix that anyway
 99 2018-05-01 19:15:49	0|BlueMatt|yes, and I assume the debian/copyright file will now never be updated, but honestly, I'm not sure anyone could care less about that
100 2018-05-01 19:15:54	0|luke-jr|but IMO it's much nicer to have it in the same repo regardless
101 2018-05-01 19:15:57	0|BlueMatt|nor why they should, its clearly presented if they get the source dir
102 2018-05-01 19:16:18	0|luke-jr|BlueMatt: what is clearly presented?
103 2018-05-01 19:19:58	0|BlueMatt|the licenses on individual files
104 2018-05-01 19:24:59	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13138: [tests] Remove accounts from wallet_importprunedfunds.py (06master...06remove_account_wallet_importprunedfunds) 02https://github.com/bitcoin/bitcoin/pull/13138
105 2018-05-01 20:00:29	0|bitcoin-git|[13bitcoin] 15sidhujag opened pull request #13139: Dev 3.x (06master...06dev-3.x) 02https://github.com/bitcoin/bitcoin/pull/13139
106 2018-05-01 20:01:32	0|bitcoin-git|[13bitcoin] 15sidhujag closed pull request #13139: Dev 3.x (06master...06dev-3.x) 02https://github.com/bitcoin/bitcoin/pull/13139
107 2018-05-01 20:15:36	0|luke-jr|BlueMatt: afaik the only place with those is the debian/copyrights file
108 2018-05-01 20:16:17	0|BlueMatt|lol
109 2018-05-01 20:26:39	0|bitcoin-git|[13bitcoin] 15marcoagner opened pull request #13141: [doc] qt: fixes broken link on readme (06master...06fix_qt_readme_typo) 02https://github.com/bitcoin/bitcoin/pull/13141
110 2018-05-01 20:31:18	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13142: Separate IsMine from solvability (06master...06201804_separate_ismine_solvable) 02https://github.com/bitcoin/bitcoin/pull/13142
111 2018-05-01 21:12:46	0|Chris_Stewart_5|Is there ever a situation where we would re-org to a chain that is shorter than the current tip, assuming the current tip is valid of course
112 2018-05-01 21:24:43	0|cfields|Chris_Stewart_5: sure, if the shorter chain has more work
113 2018-05-01 21:34:54	0|sipa|in practice, that's very unlikely to happen absent an attack
114 2018-05-01 21:35:03	0|sipa|as it requires a reorg that spans a retarget
115 2018-05-01 21:43:39	0|gmaxwell|it's trivial for someone to make that happen to a node in IBD however, so don't take the "absent an attack" to mean "absent a very hard attack"
116 2018-05-01 23:55:42	0|bitcoin-git|[13bitcoin] 15jimpo opened pull request #13144: RPC: Improve error messages on RPC endpoints that use GetTransaction (06master...06gettransaction-refactor) 02https://github.com/bitcoin/bitcoin/pull/13144