1 2018-05-02 01:07:37	0|wumpus|luke-jr: yes, agree we should fix that at the same time
  2 2018-05-02 01:12:23	0|wumpus|e.g. moving the assets attribution exclusively to debian seems to have been a bad idea
  3 2018-05-02 01:27:06	0|bitcoin-git|[13bitcoin] 15winder opened pull request #13145: Use common getPath method to create temp directory in tests. (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13145
  4 2018-05-02 01:38:30	0|fanquake|Even though I know that splitting up the massive bitcoin/bitcoin repo is going to be better in the long term. Sometimes I feel like I'm losing a handle on everything that gets split out. Especially what's in the bitcoin-core/docs repo. Haven't reviewed any of the recent gitian build guide changes.
  5 2018-05-02 01:38:50	0|fanquake|wumpus #13141 is trivial and mergeable.
  6 2018-05-02 01:38:52	0|gribble|https://github.com/bitcoin/bitcoin/issues/13141 | [doc] qt: fixes broken link on readme by marcoagner · Pull Request #13141 · bitcoin/bitcoin · GitHub
  7 2018-05-02 01:39:56	0|wumpus|fanquake: it takes some getting used to, that's sure
  8 2018-05-02 01:40:27	0|wumpus|but it seems a good way to delegate, to avoid everything having to go through one small bottleneck
  9 2018-05-02 01:40:58	0|wumpus|fanquake: will take a look
 10 2018-05-02 01:56:17	0|bitcoin-git|13bitcoin/06master 1412ad33a 15marcoagner: [doc] qt: fixes broken link on readme
 11 2018-05-02 01:56:17	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/baf6b4e3f956...57c57df86f14
 12 2018-05-02 01:56:18	0|bitcoin-git|13bitcoin/06master 1457c57df 15Wladimir J. van der Laan: Merge #13141: [doc] qt: fixes broken link on readme...
 13 2018-05-02 01:57:16	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13141: [doc] qt: fixes broken link on readme (06master...06fix_qt_readme_typo) 02https://github.com/bitcoin/bitcoin/pull/13141
 14 2018-05-02 02:01:06	0|wumpus|fanquake: though not sure nightmerging is a good idea
 15 2018-05-02 02:01:48	0|fanquake|wumpus nightmerging?
 16 2018-05-02 02:01:53	0|wumpus|yes, it's night here
 17 2018-05-02 02:02:07	0|wumpus|I'm basically still sleeping :p
 18 2018-05-02 02:03:53	0|fanquake|wumpus hehe. I'm sure you merge enough you can do it in your sleep anyways..
 19 2018-05-02 02:12:24	0|wumpus|fanquake: that's true
 20 2018-05-02 02:20:49	0|wumpus|do we really have a problem with #'s in rpc passwords?
 21 2018-05-02 02:40:19	0|wumpus|bleh https://github.com/bitcoin/bitcoin/issues/13143#issuecomment-385848492
 22 2018-05-02 02:44:21	0|wumpus|I understand that it is convient to use # for defining comments, but did they really have to make it impossible to specify it in program_options? or am I missing something
 23 2018-05-02 02:45:05	0|fanquake|wumpus yes also reproduced that
 24 2018-05-02 02:45:28	0|wumpus|well we're going to replace boost program_options so I guess we can think of a way
 25 2018-05-02 02:45:37	0|luke-jr|we are?
 26 2018-05-02 02:45:46	0|wumpus|there's a PR for that...
 27 2018-05-02 02:45:54	0|fanquake|I'm guessing that the rpcauth.py will never generate any strings containing a "#"
 28 2018-05-02 02:45:54	0|sipa|https://github.com/bitcoin/bitcoin/pull/12744
 29 2018-05-02 02:46:06	0|luke-jr|as for comments, requiring a space prior to # (or start-of-line) would seem logical
 30 2018-05-02 02:46:22	0|sipa|and even less intuitive
 31 2018-05-02 02:46:22	0|wumpus|fanquake: correct - they'd have to adapt rpcauth.py to be able to provide a custom password
 32 2018-05-02 02:47:04	0|wumpus|fanquake: which is trivial, might do it...
 33 2018-05-02 02:48:03	0|luke-jr|using dependencies is strictly better than re-inventing them, but all things considered, I guess this case looks not totally unreasonble :x
 34 2018-05-02 02:49:17	0|wumpus|we have decided long time ago to slowly move away from boost - and there's no std:: equivalent for program_options
 35 2018-05-02 02:50:52	0|luke-jr|only in libconsensus..
 36 2018-05-02 02:51:23	0|sipa|in libconsensus we already did
 37 2018-05-02 02:51:55	0|wumpus|no, not only in libconsensus
 38 2018-05-02 02:52:19	0|wumpus|there's even a project open for it https://github.com/bitcoin/bitcoin/projects/3
 39 2018-05-02 02:52:42	0|luke-jr|I understood it to be using C++ where it has superceded boost
 40 2018-05-02 02:52:45	0|luke-jr|C++11*
 41 2018-05-02 02:54:46	0|luke-jr|not some kind of NIH "let's add to the workload by maintaining re-implementations of things others have already done"
 42 2018-05-02 02:55:37	0|luke-jr|anyway, not worth arguing over until someone proposes reimplementing Qt i guess
 43 2018-05-02 02:55:43	0|sipa|haha
 44 2018-05-02 02:55:47	0|wumpus|are you just arguing for arguing's sake now? I'm tired
 45 2018-05-02 02:56:06	0|wumpus|right
 46 2018-05-02 02:58:47	0|wumpus|qt is pretty ok as a GUI dependency, as these things go, at least it's not a cursed thing like electron
 47 2018-05-02 02:59:20	0|luke-jr|I was not seriously suggesting we discuss reimplementing Qt ;)
 48 2018-05-02 02:59:53	0|fanquake|I assumed we'd be moving to Electron shortly so that we could re-implement everything using WebAssembly ?
 49 2018-05-02 03:00:32	0|sipa|excellent idea.
 50 2018-05-02 03:00:33	0|wumpus|luke-jr: oh I thought we were going to move to SDL2, OpenGL and imgui, and do release on steam...
 51 2018-05-02 03:00:42	0|sipa|wahaha
 52 2018-05-02 03:01:12	0|sipa|i thought bitcoin core was going to become a minecraft plugin?
 53 2018-05-02 03:02:06	0|wumpus|even better, blocks in 3d
 54 2018-05-02 03:02:29	0|luke-jr|fun fact: I only began using the GUI when wumpus wrote Bitcoin-Qt ;)
 55 2018-05-02 03:02:53	0|fanquake|wumpus Probably want to benchmark point and click mining first
 56 2018-05-02 03:03:46	0|wumpus|luke-jr: same here, the old gui was terrible and needed some special pre-release of wxwidgets with unicode support to compile at all
 57 2018-05-02 03:04:37	0|wumpus|fanquake: but minecraft already has mining functionality, that's the genius, just have to put a chain between the blocks
 58 2018-05-02 03:05:39	0|fanquake|:o
 59 2018-05-02 03:10:44	0|sipa|wumpus: i wonder if that wx unicode ever got actually released
 60 2018-05-02 03:11:01	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13146: rpcauth: Make it possible to provide a custom password (06master...062018_05_rpcauth_custom_password) 02https://github.com/bitcoin/bitcoin/pull/13146
 61 2018-05-02 03:13:45	0|sipa|wumpus: november 2013
 62 2018-05-02 03:13:59	0|wumpus|sipa: I'm surprised
 63 2018-05-02 03:14:42	0|sipa|only 2 years after we switched to Qt :D
 64 2018-05-02 03:16:45	0|wumpus|yep and that's the release, I'd imagine it'd take much longer to be taken up by linux distributions
 65 2018-05-02 03:19:23	0|sipa|trusty had it :)
 66 2018-05-02 03:20:02	0|wumpus|:-)
 67 2018-05-02 04:06:46	0|sipa|holy crap we have a lot of circular dependencies
 68 2018-05-02 04:07:18	0|sipa|https://zerobin.net/?26d4014573bf3d3b#Ckub5Tt1vtjJEVObubSjbs/LMPwCiy2KWiXHmdAAGYI=
 69 2018-05-02 04:10:34	0|gmaxwell|It's almost as if it were a program and not a utility toolkit. :P
 70 2018-05-02 04:37:21	0|wumpus|do we at least have a handle on circular dependencies between .a files now?
 71 2018-05-02 04:38:09	0|wumpus|close, I guess #7965
 72 2018-05-02 04:38:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/7965 | Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` · Issue #7965 · bitcoin/bitcoin · GitHub
 73 2018-05-02 04:39:55	0|wumpus|jnewbery: I suppose we can check off 'wallet initialization/verify/shutdown' as well there after #10762?
 74 2018-05-02 04:39:59	0|gribble|https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
 75 2018-05-02 04:44:20	0|wumpus|sipa: how does that script work, does it look at the includes only or at the symbols?
 76 2018-05-02 04:48:16	0|wumpus|oh he left :/
 77 2018-05-02 04:48:36	0|btc|s
 78 2018-05-02 04:48:44	0|btc|aa
 79 2018-05-02 04:49:04	0|btc|hello?
 80 2018-05-02 04:49:30	0|btc|is anybody there
 81 2018-05-02 08:45:23	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13148: logging: Fix potential use-after-free in LogPrintStr(...) (06master...06logprintstr-uaf) 02https://github.com/bitcoin/bitcoin/pull/13148
 82 2018-05-02 10:15:17	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13149: Handle unsuccessful fseek(...):s (06master...06fseek) 02https://github.com/bitcoin/bitcoin/pull/13149
 83 2018-05-02 10:15:30	0|bitcoin-git|13bitcoin/06master 142a89b0c 15Wladimir J. van der Laan: rpcauth: Make it possible to provide a custom password...
 84 2018-05-02 10:15:30	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/57c57df86f14...0bc980b1f65f
 85 2018-05-02 10:15:31	0|bitcoin-git|13bitcoin/06master 140bc980b 15Wladimir J. van der Laan: Merge #13146: rpcauth: Make it possible to provide a custom password...
 86 2018-05-02 10:16:21	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13146: rpcauth: Make it possible to provide a custom password (06master...062018_05_rpcauth_custom_password) 02https://github.com/bitcoin/bitcoin/pull/13146
 87 2018-05-02 10:59:58	0|promag|I would like to know if #13034 is something we want, or if I should remove that from other PR's related to dynamic wallets
 88 2018-05-02 11:00:00	0|gribble|https://github.com/bitcoin/bitcoin/issues/13034 | Introduce WalletManager by promag · Pull Request #13034 · bitcoin/bitcoin · GitHub
 89 2018-05-02 11:00:11	0|promag|so please ACK/NACK there
 90 2018-05-02 11:12:01	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0bc980b1f65f...598db389c33e
 91 2018-05-02 11:12:02	0|bitcoin-git|13bitcoin/06master 1450b6533 15Matt Corallo: scripted-diff: Rename SetBestChain callback ChainStateFlushed...
 92 2018-05-02 11:12:02	0|bitcoin-git|13bitcoin/06master 149cb6cdc 15Matt Corallo: Simplify semantics of ChainStateFlushed callback...
 93 2018-05-02 11:12:03	0|bitcoin-git|13bitcoin/06master 14598db38 15Wladimir J. van der Laan: Merge #13106: Simplify semantics of ChainStateFlushed callback...
 94 2018-05-02 11:12:45	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13106: Simplify semantics of ChainStateFlushed callback (06master...062018-04-wallet-flush-better-criteria) 02https://github.com/bitcoin/bitcoin/pull/13106
 95 2018-05-02 12:17:07	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13151: WIP: net: Serve blocks directly from disk when possible (06master...062018_05_direct_from_disk) 02https://github.com/bitcoin/bitcoin/pull/13151
 96 2018-05-02 12:43:17	0|bitcoin-git|[13bitcoin] 15chris-belcher opened pull request #13152: [WIP] [rpc] Add getaddress RPC command (06master...062018-04-rpc-getaddress) 02https://github.com/bitcoin/bitcoin/pull/13152
 97 2018-05-02 12:51:58	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13153: net: Add missing newlines to debug logging (06master...062018_05_log_newlines) 02https://github.com/bitcoin/bitcoin/pull/13153
 98 2018-05-02 12:53:30	0|fanquake|wumpus new linter inbound..
 99 2018-05-02 12:54:07	0|wumpus|fanquake: there is a linter for that, but somehow it didn't catch these!
100 2018-05-02 12:55:40	0|fanquake|indeed, didn't realise we were checking that https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/lint-logs.sh
101 2018-05-02 12:56:16	0|fanquake|Also, any suggestions for testing #13151 performance improvements?
102 2018-05-02 12:56:17	0|gribble|https://github.com/bitcoin/bitcoin/issues/13151 | WIP: net: Serve blocks directly from disk when possible by laanwj · Pull Request #13151 · bitcoin/bitcoin · GitHub
103 2018-05-02 12:58:06	0|wumpus|ideally we'd have some tool or script that simply pulls blocks through P2P
104 2018-05-02 12:58:22	0|wumpus|just to measure raw download throughput
105 2018-05-02 12:58:43	0|wumpus|I vaguely remember someone mentioning this but I'm not sure where or who
106 2018-05-02 13:00:58	0|wumpus|I mean you could try to benchmark by making a node sync from another node locally, but verification at the client side would distort the results
107 2018-05-02 13:29:21	0|jonasschnelli|hmmm... LMDB seems to consume ~274 bytes for a txindex entry (32byte hash txid, 32byte blockhash). I wonder where to overhead comes from.
108 2018-05-02 13:43:54	0|promag|CBlockIndex::nStatus is protected by cs_main?
109 2018-05-02 13:52:32	0|jonasschnelli|promag: Yeah. Seams like. Its definitively mutable.
110 2018-05-02 13:52:48	0|promag|ty
111 2018-05-02 13:56:59	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/598db389c33e...ef46c9904b80
112 2018-05-02 13:57:00	0|bitcoin-git|13bitcoin/06master 144b75dcf 15MarcoFalke: devtools: Make linter check LogPrint calls
113 2018-05-02 13:57:00	0|bitcoin-git|13bitcoin/06master 14ff2ad2d 15Wladimir J. van der Laan: Add missing newlines to LogPrint debug logging...
114 2018-05-02 13:57:01	0|bitcoin-git|13bitcoin/06master 14ef46c99 15Wladimir J. van der Laan: Merge #13153: Add missing newlines to debug logging...
115 2018-05-02 13:57:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13153: Add missing newlines to debug logging (06master...062018_05_log_newlines) 02https://github.com/bitcoin/bitcoin/pull/13153
116 2018-05-02 14:08:49	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #13154: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 (06master...06pr/flushed) 02https://github.com/bitcoin/bitcoin/pull/13154
117 2018-05-02 14:15:46	0|fanquake|Do you get spammed with emails/notifications if your @ mentioned in a commit body, same as what was happening in PRs?
118 2018-05-02 14:18:44	0|ryanofsky|what's the difference between https://github.com/bitcoin and https://github.com/bitcoin-core?
119 2018-05-02 14:22:05	0|fanquake|ryanofsky In what regard?
120 2018-05-02 14:23:33	0|fanquake|/bitcoin was where bitcoin was migrated to from SF. /bitcoin-core houses some core specific repos such as the website, docs etc
121 2018-05-02 14:24:32	0|wumpus|right - bitcoin is the legacy organization, bitcoin-core is where most of the repositories have been moved
122 2018-05-02 14:25:39	0|ryanofsky|oh ok, so it's just a legacy thing. i didn't know if they two orgs were supposed to have different purposes, or were run by different people or something
123 2018-05-02 14:25:43	0|wumpus|it was originally the plan to move the bitcoin repository too, however since the 'bitcoin core' as currency name bullshit from BCHers, that's probably a bad idea and will only contribute towards user confusion
124 2018-05-02 14:26:17	0|BlueMatt|well except bips, which will probably always stay in bitcoin
125 2018-05-02 14:26:40	0|wumpus|yes, or a 'bips' organization
126 2018-05-02 14:28:02	0|fanquake|The crossover between the "teams" in the two orgs is pretty high. Probably just a few more inactive/older users in /bitcoin
127 2018-05-02 14:36:54	0|wumpus|yes, if you're in bitcoin but not in bitcoin-core or vice versa, let me know, invites are supposed to go out for both at the same time
128 2018-05-02 14:50:18	0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ef46c9904b80...ef006d92845a
129 2018-05-02 14:50:19	0|bitcoin-git|13bitcoin/06master 1473bc1b7 15practicalswift: Initialize editStatus and autoCompleter. Previously not initialized where defined or in constructor.
130 2018-05-02 14:50:19	0|bitcoin-git|13bitcoin/06master 14f131872 15practicalswift: Initialize non-static class members where they are defined
131 2018-05-02 14:50:20	0|bitcoin-git|13bitcoin/06master 141e7813e 15practicalswift: Remove redundant initializations from the constructor
132 2018-05-02 14:51:03	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor (06master...06qt-constructors) 02https://github.com/bitcoin/bitcoin/pull/12928
133 2018-05-02 14:55:54	0|rafalcpp|hm is this expected that v0.16.0 crashes on start with built with --with-incompatible-bdb ?  this issues are closed #6775 (and #12047). System always had libdb5.3 never had libdb4.x (Debian testing 10 from installation)
134 2018-05-02 14:55:56	0|gribble|https://github.com/bitcoin/bitcoin/issues/12047 | Segmentation fault if configured with incompatible BDB · Issue #12047 · bitcoin/bitcoin · GitHub
135 2018-05-02 14:55:56	0|gribble|https://github.com/bitcoin/bitcoin/issues/6775 | Bitcoind v0.11.0 segfaults on startup trying to read wallet. · Issue #6775 · bitcoin/bitcoin · GitHub
136 2018-05-02 15:04:26	0|wumpus|rafalcpp: usually that means that you have multiple versions of berkeleydb installed, and it's compiling against a different one than it's dynamically linking at runtime
137 2018-05-02 15:05:19	0|wumpus|but no, that's not normal, I've been compilng with --with-incompaible-bdb for years, and many others do
138 2018-05-02 15:11:05	0|rafalcpp|wumpus: I seen that today on debian 10 and debian 9. so reopen?
139 2018-05-02 15:12:05	0|wumpus|better to open a new issue, it's not clear this is the same problem
140 2018-05-02 15:13:12	0|wumpus|if it's the same problem then reopening doesn't help - it was a local issue (ABI conflict)
141 2018-05-02 15:13:29	0|wumpus|see e.g. https://github.com/bitcoin/bitcoin/issues/12047#issuecomment-357022687
142 2018-05-02 16:12:35	0|thelox95|hi?
143 2018-05-02 18:22:52	0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #12665: Add compile time checking for run time locking assertions (06master...06compile-time-checking-of-runtime-assertions) 02https://github.com/bitcoin/bitcoin/pull/12665
144 2018-05-02 18:45:36	0|jamesob|are there any caveats we know of re: usage of std::mutex/std::lock_guard on windows? I'm seeing some weird unhandled page faults only on windows with pretty vanilla usage of these constructs
145 2018-05-02 18:57:16	0|sipa|jamesob: care to create a minimal reproduction?
146 2018-05-02 18:57:45	0|jamesob|sipa: yeah, I might have to go down that road
147 2018-05-02 20:12:37	0|jamesob|sipa: this is as concise as I've gotten it so far https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605
148 2018-05-02 20:14:58	0|jamesob|updated with something simpler yet
149 2018-05-02 20:16:14	0|jamesob|hm, seems to have to do with thread_local usage
150 2018-05-02 20:23:49	0|jamesob|either windows c++11 compiler is subtly busted or I don't understand c++; updated the gist with a patch that makes it work: https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605#file-works-cpp-L13
151 2018-05-02 21:15:14	0|booyah|jamesob: why this_id would need to be static? instead of simple std::string local variable?
152 2018-05-02 21:22:15	0|jamesob|booyah: in the real usecase, we're trying to establish a unique ID per thread on a one-time basis
153 2018-05-02 21:24:16	0|sipa|jamesob: wouldn't surprise me if thread_local is broken in some mingw versions
154 2018-05-02 21:24:56	0|jamesob|sipa: certainly appears so. I'm just gonna avoid using it altogether on WIN32
155 2018-05-02 21:25:50	0|booyah|jamesob: would you report a bug to compiler devels?
156 2018-05-02 21:26:02	0|jamesob|booyah: yeah probably
157 2018-05-02 21:26:57	0|booyah|jamesob:  ##c++ <Svitkona> both are working fine on msvc
158 2018-05-02 21:27:29	0|jamesob|as sipa says, it may be a mingw32-specific thing
159 2018-05-02 21:30:20	0|booyah|jamesob: maybe this bug? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83562
160 2018-05-02 21:31:57	0|jamesob|booyah: I can't repro that
161 2018-05-02 21:44:01	0|sipa|jamesob: wouldn't it be easier to just always use std::this_thread::get_id() ?
162 2018-05-02 21:44:35	0|jamesob|sipa: I'd love to do that provided we can assume it's always compatible with boost threads
163 2018-05-02 21:45:11	0|sipa|do we use boost threads anywhere?
164 2018-05-02 21:46:14	0|sipa|seems we do.
165 2018-05-02 21:46:43	0|jamesob|yeah, seems like it: https://github.com/bitcoin/bitcoin/blob/66fcbdcc4cbf5a99fad3ef6b4c953474c92af1be/src/init.cpp#L173
166 2018-05-02 21:47:56	0|sipa|alternatively, i expect boost::this_thread::native_handle to always work
167 2018-05-02 21:49:19	0|sipa|oh, that may not exist
168 2018-05-02 21:49:48	0|jamesob|sipa: even if it did, wouldn't we have to have a bunch of platform-specific cases?
169 2018-05-02 21:50:52	0|sipa|if std::this_thread::get_id works everywhere, could we try that?
170 2018-05-02 21:52:27	0|jamesob|sure thing
171 2018-05-02 21:52:46	0|sipa|also, no need to convert to std::string; you can use std::thread::id as a map key
172 2018-05-02 21:53:16	0|jamesob|willdo
173 2018-05-02 22:23:52	0|promag|jnewbery: re #10740, should it be possible to specify an absolute path if it's in the walletdir?
174 2018-05-02 22:23:58	0|gribble|https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
175 2018-05-02 23:12:58	0|promag|BlueMatt: mind revisit #12151?
176 2018-05-02 23:13:00	0|gribble|https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub