1 2018-05-09 03:27:17 0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13194: Remove template matching and pseudo opcodes (06master...06201805_noscriptpattern) 02https://github.com/bitcoin/bitcoin/pull/13194
2 2018-05-09 04:26:55 0|bitcoin-git|[13bitcoin] 15ken2812221 closed pull request #13107: Fix Windows locale problem (06master...06win-enc) 02https://github.com/bitcoin/bitcoin/pull/13107
3 2018-05-09 04:36:39 0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6b824c090f53...7b966d9e6e30
4 2018-05-09 04:36:40 0|bitcoin-git|13bitcoin/06master 140f0badd 15Karl-Johan Alm: test: Test includeconf parameter.
5 2018-05-09 04:36:40 0|bitcoin-git|13bitcoin/06master 14629ff8c 15Karl-Johan Alm: -includeconf=<path> support in config handler, for including external configuration files
6 2018-05-09 04:36:41 0|bitcoin-git|13bitcoin/06master 1425b7ab9 15Karl-Johan Alm: doc: Add release notes for -includeconf
7 2018-05-09 04:36:50 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10267: New -includeconf argument for including external configuration files (06master...06feature-config-readconfig) 02https://github.com/bitcoin/bitcoin/pull/10267
8 2018-05-09 05:09:04 0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13195: [WIP] Wrap C++17 std::filesystem::path to solve encoding issue on Windows. (06master...06u8path) 02https://github.com/bitcoin/bitcoin/pull/13195
9 2018-05-09 05:36:35 0|wumpus|jonasschnelli: I'm really confused re: #13151
10 2018-05-09 05:36:38 0|gribble|https://github.com/bitcoin/bitcoin/issues/13151 | net: Serve blocks directly from disk when possible by laanwj ÷ Pull Request #13151 ÷ bitcoin/bitcoin ÷ GitHub
11 2018-05-09 05:45:41 0|wumpus|luke-jr: I think that'd be the most efficient solution. But a lot more work, would need some further (OS-specific) abstractions in that case though to get the sendfile command all the way to the network layer, getting around the send buffering
12 2018-05-09 05:46:25 0|wumpus|this was just fairly low-hanging fruit - bypassing the deserialization/serialization should already have helped
13 2018-05-09 05:56:50 0|jonasschnelli|wumpus: 13151. yes. I have no idea why this can happen and I hope it's a local issue... though I doubt it.
14 2018-05-09 05:57:11 0|jonasschnelli|Can you do a test on a fast SSD?
15 2018-05-09 05:57:13 0|wumpus|all the otherresults are at least somewhat hopeful
16 2018-05-09 05:57:26 0|wumpus|no, I don't have any SSD large tnough
17 2018-05-09 06:07:47 0|jonasschnelli|wumpus: I could try to redo the test on a digital ocean instance.. or at least a different ssd env
18 2018-05-09 06:08:31 0|wumpus|I'll also try on another machine when I find time (more spinning rust, though)
19 2018-05-09 06:11:15 0|fanquake|I can test on an SSD. Were both done using bitcoincore-indexd ?
20 2018-05-09 06:15:25 0|bitcoin-git|[13bitcoin] 15glaksmono opened pull request #13196: [WIP] Refactoring platform-specific code in util.h/util.cpp (06master...06bitcoin-12697) 02https://github.com/bitcoin/bitcoin/pull/13196
21 2018-05-09 06:18:11 0|fanquake|Having people grab tickets to work on is good. However I'm wondering if we should mention that opening WIP PRs means that some actual work should have been done? re #13196
22 2018-05-09 06:18:13 0|gribble|https://github.com/bitcoin/bitcoin/issues/13196 | [WIP] Refactoring platform-specific code in util.h/util.cpp by glaksmono ÷ Pull Request #13196 ÷ bitcoin/bitcoin ÷ GitHub
23 2018-05-09 06:23:25 0|ynakasone|join #secp256k1
24 2018-05-09 06:23:44 0|kallewoof|fanquake: Yeah, that's a good rule I think. It will discourage others from working on the issue even if no work has been done.
25 2018-05-09 06:24:09 0|kallewoof|I mean, having that rule will preevent discouraging ---.
26 2018-05-09 06:25:15 0|jonasschnelli|fanquake: yes. if you can test on both hdd/ssd... that would be great.
27 2018-05-09 06:25:43 0|jonasschnelli|maybe use wumpuses branch of the indexer
28 2018-05-09 06:26:01 0|jonasschnelli|make sure you request blocks with witness
29 2018-05-09 06:27:51 0|fanquake|kallewoof yep. WIP PRs should be opened when someones needs help/feedback in regards to code/design decisions.
30 2018-05-09 06:28:08 0|fanquake|We don't need to use them as a signal for "claiming" an issue
31 2018-05-09 06:29:27 0|fanquake|thanks jonasschnelli
32 2018-05-09 06:32:33 0|kallewoof|fanquake: Agreed
33 2018-05-09 06:47:13 0|kallewoof|#12265 has 1 tested ACK, 1 utACK (latest), and 1 ACK and 1 utACK (pre-squash/rebase). It's test bug-fix only, so feels mergeable but if someone would be up for reviewing that would be lovely.
34 2018-05-09 06:47:15 0|gribble|https://github.com/bitcoin/bitcoin/issues/12265 | [test] fundrawtransaction: lock watch-only shared address by kallewoof ÷ Pull Request #12265 ÷ bitcoin/bitcoin ÷ GitHub
35 2018-05-09 06:47:51 0|meshcollider|kallewoof: I'll give it a quick review, hold on a sec :)
36 2018-05-09 06:48:09 0|kallewoof|meshcollider: thanks! :)
37 2018-05-09 06:56:04 0|meshcollider|yeah looks RTM now
38 2018-05-09 07:04:48 0|glaksmono|anyone know when I can merge my PR? haha
39 2018-05-09 07:04:54 0|glaksmono|https://github.com/bitcoin/bitcoin/pull/13183
40 2018-05-09 07:05:07 0|glaksmono|Kind of too excited for my first contribution to bitcoin :)
41 2018-05-09 07:06:11 0|kallewoof|meshcollider: Thanks a lot. Lemme know if you want something reviewed from my end. :)
42 2018-05-09 07:07:04 0|meshcollider|I'm all good for the moment, haven't had a chance to get any new PRs up for a while because of uni sadly
43 2018-05-09 07:07:10 0|kallewoof|glaksmono: Soon I'd suspect. Patience is definitely a valuable asset to have around here though :)
44 2018-05-09 07:07:38 0|kallewoof|meshcollider: OK
45 2018-05-09 07:07:50 0|meshcollider|glaksmono: thanks for helping out! just like every PR it just has to get enough review so that the maintainers can safely merge it :)
46 2018-05-09 07:08:04 0|glaksmono|Got it, thanks guys
47 2018-05-09 07:08:12 0|meshcollider|looks like it is basically ready though, so should be soon like kallewoof said :)
48 2018-05-09 07:50:32 0|bitcoin-git|13bitcoin/06master 1418c0b84 15Grady Laksmono: [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs
49 2018-05-09 07:50:32 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7b966d9e6e30...9458b05f2834
50 2018-05-09 07:50:33 0|bitcoin-git|13bitcoin/06master 149458b05 15Wladimir J. van der Laan: Merge #13183: [travis] New travis job for CHECK_DOCS steps...
51 2018-05-09 07:51:24 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13183: [travis] New travis job for CHECK_DOCS steps (06master...06bitcoin-11004) 02https://github.com/bitcoin/bitcoin/pull/13183
52 2018-05-09 07:51:48 0|meshcollider|glaksmono congratulations :)
53 2018-05-09 07:52:42 0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #13197: util: warn about ignored recursive -includeconf calls (06master...06includeconf-warn-nonrecursive) 02https://github.com/bitcoin/bitcoin/pull/13197
54 2018-05-09 07:54:13 0|kallewoof|grats on first PR :)
55 2018-05-09 08:00:15 0|fanquake|wumpus #13093 Should be ready
56 2018-05-09 08:00:17 0|gribble|https://github.com/bitcoin/bitcoin/issues/13093 | [0.15] backport: depends qt patches by fanquake ÷ Pull Request #13093 ÷ bitcoin/bitcoin ÷ GitHub
57 2018-05-09 08:01:22 0|wumpus|fanquake: ack
58 2018-05-09 08:02:54 0|ken2812221|I don't know why clang hates my code and how to fix it. Any suggestion about #13195?
59 2018-05-09 08:02:56 0|gribble|https://github.com/bitcoin/bitcoin/issues/13195 | [WIP] Wrap C++17 std::filesystem::path to solve encoding issue on Windows. by ken2812221 ÷ Pull Request #13195 ÷ bitcoin/bitcoin ÷ GitHub
60 2018-05-09 08:04:55 0|jonasschnelli|fanquake, wumpus: is there a gitian build required before merging #13093
61 2018-05-09 08:04:56 0|gribble|https://github.com/bitcoin/bitcoin/issues/13093 | [0.15] backport: depends qt patches by fanquake ÷ Pull Request #13093 ÷ bitcoin/bitcoin ÷ GitHub
62 2018-05-09 08:05:42 0|wumpus|jonasschnelli: it can't hurt; though there's a tested ack already
63 2018-05-09 08:07:11 0|wumpus|jonasschnelli: also we've been testing these patches on master already - I guess the useful test of doing a gitian build would be whether a gitian build still works, of course
64 2018-05-09 08:07:41 0|jonasschnelli|I try with my build script (not sure if it can handle older branches... lets see)
65 2018-05-09 08:08:11 0|fanquake|thanks jonass
66 2018-05-09 08:11:15 0|fanquake|wumpus #12265 should be ready to go. John and marco have ackd cc kallewoof
67 2018-05-09 08:11:17 0|gribble|https://github.com/bitcoin/bitcoin/issues/12265 | [test] fundrawtransaction: lock watch-only shared address by kallewoof ÷ Pull Request #12265 ÷ bitcoin/bitcoin ÷ GitHub
68 2018-05-09 08:12:53 0|wumpus|fanquake: yes, that one was about time
69 2018-05-09 08:13:02 0|bitcoin-git|13bitcoin/06master 14891beb0 15Karl-Johan Alm: [test] fundrawtransaction: lock watch-only shared address...
70 2018-05-09 08:13:02 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/9458b05f2834...1834d4d9f0af
71 2018-05-09 08:13:03 0|bitcoin-git|13bitcoin/06master 141834d4d 15Wladimir J. van der Laan: Merge #12265: [test] fundrawtransaction: lock watch-only shared address...
72 2018-05-09 08:13:28 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12265: [test] fundrawtransaction: lock watch-only shared address (06master...06test-fundrawtransaction-lockunspent) 02https://github.com/bitcoin/bitcoin/pull/12265
73 2018-05-09 08:14:14 0|wumpus|ken2812221: hhmm strange
74 2018-05-09 08:23:37 0|fanquake|compiles ok locally
75 2018-05-09 08:24:59 0|ken2812221|I'm trying to do gitian-build on Ubuntu Bionic.
76 2018-05-09 08:29:08 0|ken2812221|Seems it is still an issue with clang on Ubuntu Bionic.
77 2018-05-09 08:37:27 0|fanquake|wumpus I think #13188 can just about go in as well, if you wanted to ack.
78 2018-05-09 08:37:29 0|gribble|https://github.com/bitcoin/bitcoin/issues/13188 | qa: Remove unused option --srcdir by MarcoFalke ÷ Pull Request #13188 ÷ bitcoin/bitcoin ÷ GitHub
79 2018-05-09 08:39:10 0|wumpus|fanquake: only seeing that one now; yes, makes sense I think, srcdir is a misnomer as that's not where the executables end up in out of tree builds
80 2018-05-09 08:42:26 0|bitcoin-git|13bitcoin/06master 14fac1e1f 15MarcoFalke: qa: Remove unused option --srcdir
81 2018-05-09 08:42:26 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1834d4d9f0af...4a50ec0efd06
82 2018-05-09 08:42:27 0|bitcoin-git|13bitcoin/06master 144a50ec0 15Wladimir J. van der Laan: Merge #13188: qa: Remove unused option --srcdir...
83 2018-05-09 08:43:12 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13188: qa: Remove unused option --srcdir (06master...06Mf1805-qaSrcdir) 02https://github.com/bitcoin/bitcoin/pull/13188
84 2018-05-09 09:55:01 0|kallewoof|TIL if you submit a review on a PR and get angry unicorn, refreshing will not duplicate-post your review.
85 2018-05-09 09:55:14 0|kallewoof|(and it seems review goes through despite unicorniness)
86 2018-05-09 10:25:06 0|bitcoin-git|[13bitcoin] 15glaksmono closed pull request #13196: [WIP] Refactoring platform-specific code in util.h/util.cpp (06master...06bitcoin-12697) 02https://github.com/bitcoin/bitcoin/pull/13196
87 2018-05-09 10:29:27 0|bitcoin-git|[13bitcoin] 15glaksmono reopened pull request #13196: [WIP] Refactoring platform-specific code in util.h/util.cpp (06master...06bitcoin-12697) 02https://github.com/bitcoin/bitcoin/pull/13196
88 2018-05-09 11:16:20 0|bitcoin-git|[13bitcoin] 15glaksmono closed pull request #13196: [WIP] Refactoring platform-specific code in util.h/util.cpp (06master...06bitcoin-12697) 02https://github.com/bitcoin/bitcoin/pull/13196
89 2018-05-09 12:50:34 0|bitcoin-git|[13bitcoin] 15sdaftuar opened pull request #13198: [qa] Avoid printing to console during cache creation (06master...062018-05-test-cache-console) 02https://github.com/bitcoin/bitcoin/pull/13198
90 2018-05-09 13:50:25 0|wumpus|#10740 unicorns as well.. ugh
91 2018-05-09 13:50:32 0|gribble|https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery ÷ Pull Request #10740 ÷ bitcoin/bitcoin ÷ GitHub
92 2018-05-09 13:50:49 0|wumpus|oh not anymore after another try
93 2018-05-09 13:59:25 0|promag|wumpus: occasionally I got random unicorns as well
94 2018-05-09 14:02:13 0|wumpus|promag: me too; but I was worried because this is another large PR with lots of comments
95 2018-05-09 14:27:50 0|jnewbery|wumpus: sorry not to answer yesterday re: #10267. My current workaround for unicorn issues is to use chrome's developer tools and use the device toolbar to view the page as mobile/tablet.
96 2018-05-09 14:27:57 0|gribble|https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof ÷ Pull Request #10267 ÷ bitcoin/bitcoin ÷ GitHub
97 2018-05-09 14:27:57 0|jtimon|probably stupid question... in https://github.com/bitcoin/bitcoin/blob/master/src/pubkey.h#L59 why are there 3 ways to indicate non-compressed and 2 ways to indicate compressed? shouldn't one for each be enough? also, should using an enum or macros or constants be more clear?
98 2018-05-09 14:28:31 0|wumpus|jnewbery: interesting, that that works, thanks
99 2018-05-09 14:31:23 0|jtimon|s/should/shouldn't/
100 2018-05-09 14:37:58 0|bitcoin-git|[13bitcoin] 15sdaftuar opened pull request #13199: Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (06master...062018-05-fix-reconsider-block) 02https://github.com/bitcoin/bitcoin/pull/13199
101 2018-05-09 14:50:57 0|bitcoin-git|[13bitcoin] 15jamesob opened pull request #13200: Process logs in a separate thread (06master...062018-05-asynclog) 02https://github.com/bitcoin/bitcoin/pull/13200
102 2018-05-09 14:55:56 0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4a50ec0efd06...612ba35ab140
103 2018-05-09 14:55:57 0|bitcoin-git|13bitcoin/06master 14c22ce8a 15John Newbery: [Tests] Write stdout/stderr to datadir instead of temp file.
104 2018-05-09 14:55:57 0|bitcoin-git|13bitcoin/06master 14e503671 15John Newbery: [Tests] Use LIBC_FATAL_STDERR_=1 in tests...
105 2018-05-09 14:55:58 0|bitcoin-git|13bitcoin/06master 14beee49b 15John Newbery: [tests] Allow stderr to be tested against specified string...
106 2018-05-09 14:56:32 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #12755: [tests] Better stderr testing (06master...06better_stderr_testing) 02https://github.com/bitcoin/bitcoin/pull/12755
107 2018-05-09 15:11:47 0|bitcoin-git|13bitcoin/06master 14a2f678d 15Pieter Wuille: Bugfix: the end of a reorged chain is invalid when connect fails...
108 2018-05-09 15:11:47 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/612ba35ab140...08c1caf86365
109 2018-05-09 15:11:48 0|bitcoin-git|13bitcoin/06master 1408c1caf 15Wladimir J. van der Laan: Merge #13185: Bugfix: the end of a reorged chain is invalid when connect fails...
110 2018-05-09 15:12:34 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13185: Bugfix: the end of a reorged chain is invalid when connect fails (06master...06201805_bugfix_invalidchain_end) 02https://github.com/bitcoin/bitcoin/pull/13185
111 2018-05-09 17:16:45 0|vlugansky|Hi guys! quick question: does anyone manage to add bitcoinold to decentralized exchanges?
112 2018-05-09 17:19:17 0|sipa|vlugansky: this channel is about software development of bitcoin core
113 2018-05-09 17:23:33 0|bitcoin-git|[13bitcoin] 15sdaftuar opened pull request #13201: [qa] Handle disconnect_node race (06master...062018-05-rpc-disconnect-race) 02https://github.com/bitcoin/bitcoin/pull/13201
114 2018-05-09 17:29:37 0|bitcoin-git|[13bitcoin] 15martinus opened pull request #13202: prevents copying of in/outputs for SignSignature (06master...06optimize-SignSignature) 02https://github.com/bitcoin/bitcoin/pull/13202
115 2018-05-09 17:40:30 0|bitcoin-git|[13bitcoin] 15martinus closed pull request #13202: Prevent copying of in/outputs for SignSignature (06master...06optimize-SignSignature) 02https://github.com/bitcoin/bitcoin/pull/13202
116 2018-05-09 17:46:12 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #13203: Add POWER8 ASM for 4-way SHA256 (06master...062018-05-asm) 02https://github.com/bitcoin/bitcoin/pull/13203
117 2018-05-09 18:11:42 0|jl2012|if I have a zero fee unconfirmed parent tx, is it possible to make it relayed/mined with CPFP? Is there any minimum fee requirement for the parent tx?
118 2018-05-09 18:14:51 0|sdaftuar|jl2012: not currently -- transactions below 1sat/byte feerate are not accepted by default
119 2018-05-09 18:15:06 0|sdaftuar|jl2012: and the descendant transaction can't cover the fee, the way our code is structured now
120 2018-05-09 18:26:18 0|bitcoin-git|[13bitcoin] 15JeremyRubin opened pull request #13204: Faster sigcache nonce (06master...06faster-sigcache-nonce) 02https://github.com/bitcoin/bitcoin/pull/13204
121 2018-05-09 18:36:47 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/08c1caf86365...fc642cbdad6e
122 2018-05-09 18:36:48 0|bitcoin-git|13bitcoin/06master 144d4185a 15Andrew Chow: Make gArgs aware of the arguments...
123 2018-05-09 18:36:48 0|bitcoin-git|13bitcoin/06master 14fc642cb 15MarcoFalke: Merge #13190: Have gArgs handle printing help...
124 2018-05-09 18:37:36 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13190: Have gArgs handle printing help (06master...06gargs-help) 02https://github.com/bitcoin/bitcoin/pull/13190
125 2018-05-09 18:45:11 0|bitcoin-git|13bitcoin/06master 1408ebdba 15Suhas Daftuar: [qa] Avoid printing to console during cache creation
126 2018-05-09 18:45:11 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/fc642cbdad6e...196c5a947a07
127 2018-05-09 18:45:12 0|bitcoin-git|13bitcoin/06master 14196c5a9 15MarcoFalke: Merge #13198: [qa] Avoid printing to console during cache creation...
128 2018-05-09 18:46:06 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13198: [qa] Avoid printing to console during cache creation (06master...062018-05-test-cache-console) 02https://github.com/bitcoin/bitcoin/pull/13198
129 2018-05-09 19:13:38 0|jl2012|sdaftuar: thanks. This is the relevant discussion: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-May/015935.html
130 2018-05-09 19:53:18 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13205: [tests] Remove spurious error log in p2p_segwit.py (06master...06p2p_segwit_remove_spurious_error_log) 02https://github.com/bitcoin/bitcoin/pull/13205
131 2018-05-09 20:34:50 0|sipa|i hate unicorns
132 2018-05-09 20:40:26 0|midnightmagic|unicorns are awesome... well.. I mean the angry impale-you kind are, anyway..
133 2018-05-09 20:40:40 0|midnightmagic|http://pbfcomics.com/comics/nice-shirt/
134 2018-05-09 21:22:29 0|achow101|github unicorns suck
135 2018-05-09 23:58:44 0|bitcoin-git|[13bitcoin] 15ken2812221 closed pull request #13195: [WIP] Wrap C++17 std::filesystem::path to solve encoding issue on Windows. (06master...06u8path) 02https://github.com/bitcoin/bitcoin/pull/13195
136 2018-05-09 23:58:58 0|bitcoin-git|[13bitcoin] 15ken2812221 reopened pull request #13107: Fix Windows locale problem (06master...06win-enc) 02https://github.com/bitcoin/bitcoin/pull/13107