1 2018-05-16 00:33:58	0|bitcoin-git|[13bitcoin] 15Empact closed pull request #13223: refactor: Extract BnB-specific data from CInputCoin  (06master...06duplicate-fee-calc) 02https://github.com/bitcoin/bitcoin/pull/13223
 2 2018-05-16 00:53:03	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #13242: uint256: Remove unnecessary crypto/common.h use (06master...06uint256-no-crypto) 02https://github.com/bitcoin/bitcoin/pull/13242
 3 2018-05-16 01:17:49	0|bitcoin-git|[13bitcoin] 15jimpo opened pull request #13243: Make reusable base class for auxiliary indices (06master...06index-abstraction) 02https://github.com/bitcoin/bitcoin/pull/13243
 4 2018-05-16 02:13:30	0|fanquake|If we want to tag 0.16.1, can I get some ACKS on #12967
 5 2018-05-16 02:13:33	0|gribble|https://github.com/bitcoin/bitcoin/issues/12967 | [0.16] Backports by fanquake · Pull Request #12967 · bitcoin/bitcoin · GitHub
 6 2018-05-16 02:34:35	0|kallewoof|It.. assumes that the first 17 IP addresses will not cause a collision. They don't. On little endian machines.
 7 2018-05-16 02:34:55	0|kallewoof|It then assumes taht the 18th IP address will collide. And then it assumes that the 19th won't (where Xth = 250.1.1.<X>).
 8 2018-05-16 02:36:06	0|kallewoof|No wonder big endian systems would fail the uint256 quick hash stuff. It depended on hashes being a certain way for the tests to succeed. That's not exactly how you test collisions normally. I would totally understand if these hashes were consensus critical somehow.
 9 2018-05-16 02:36:52	0|kallewoof|I honestly can't see the purpose of this test at all.
10 2018-05-16 02:41:02	0|sipa|delete it :)
11 2018-05-16 02:42:52	0|kallewoof|sipa: I might! If I can't convince myself they fulfill a purpose.
12 2018-05-16 02:44:34	0|kallewoof|I literally tried changing the IP to 250.1.2.<X> and the tests now fail horribly..
13 2018-05-16 02:45:35	0|kallewoof|These seem to be from an attempt to increase test coverage from a couple of yrs ago or so, according to git blame.
14 2018-05-16 02:46:27	0|kallewoof|Maybe rewrite them to assume that X % of inserted addresses should not cause a collision. That should work on all architectures.
15 2018-05-16 03:06:23	0|mryandao|hmm, i noticed that the -alertnotify flag is still in the manpages for `bitcoind` -- shouldn't that be removed already since 0.14?
16 2018-05-16 03:08:25	0|mryandao|and what does 'a really long fork' even mean?
17 2018-05-16 03:10:55	0|mryandao|oh nvm, just looked into the src and its basically doing an alert if there's a fork thats >= 6 blocks
18 2018-05-16 05:17:08	0|kallewoof|sipa: I ended up keeping the tests for now. I just checked where big endian would see collisions and changed tests to work on both. These tests are pretty bad, though, but I guess for the sake of coverage, or something.
19 2018-05-16 06:49:33	0|jonasschnelli|MarcoFalke: merge with a single ack? https://github.com/bitcoin/bitcoin/pull/13158
20 2018-05-16 08:08:27	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/13da2899ae42...40c34a0a29f6
21 2018-05-16 08:08:28	0|bitcoin-git|13bitcoin/06master 1440c34a0 15Jonas Schnelli: Merge #11491: [gui] Add proxy icon in statusbar...
22 2018-05-16 08:08:28	0|bitcoin-git|13bitcoin/06master 1473cd5b2 15Cristian Mircea Messel: [gui] Add proxy icon in statusbar
23 2018-05-16 08:08:44	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11491: [gui] Add proxy icon in statusbar (06master...06add_proxy_icon) 02https://github.com/bitcoin/bitcoin/pull/11491
24 2018-05-16 08:58:41	0|bhbbh|join
25 2018-05-16 11:40:46	0|bitcoin-git|[13bitcoin] 15laanwj pushed 10 new commits to 060.16: 02https://github.com/bitcoin/bitcoin/compare/9ea62a3dc4bd...feba12fe85e8
26 2018-05-16 11:40:47	0|bitcoin-git|13bitcoin/060.16 14f118a7a 15251: Fix illegal default `addProxy` and `addrSeparateProxyTor` settings....
27 2018-05-16 11:40:47	0|bitcoin-git|13bitcoin/060.16 14f60e84d 15e0: Limit the number of IPs we use from each DNS seeder...
28 2018-05-16 11:40:48	0|bitcoin-git|13bitcoin/060.16 14e802c22 15John Newbery: [config] Remove blockmaxsize option...
29 2018-05-16 12:04:54	0|promag|wumpus: which PR are you looking at?
30 2018-05-16 14:03:54	0|jonasschnelli|Q for anyone with leveldb experience (maybe sipa, wumpus): Is there a performance downside of seeking the cursor to a specific key and read the current cursors value rather then just "read" a keys value "directly"?
31 2018-05-16 14:10:22	0|wumpus|I wouldn't expect there to be a significant difference, as long as you're looking for an existing key - both have to locate the key in the same way
32 2018-05-16 14:14:02	0|jonasschnelli|wumpus: thanks
33 2018-05-16 14:15:14	0|jonasschnelli|I was thinking of storing 1-to-n relations (addressindex; address maps to many txns). Instead of constantly update a single object (read->(update)->write) I though of just reducing to a write operation
34 2018-05-16 14:15:36	0|jonasschnelli|Though it will lead to more disk-space being consumed due to the repetitive key-parts
35 2018-05-16 14:17:33	0|gmaxwell|I would expect pretty poor performance if you look up a non-existing entry, however. (also implied by wumpus' statement; but thought it was worth making a point of)-- otherwise leveldb is pretty fast for misses.
36 2018-05-16 14:29:41	0|bitcoin-git|[13bitcoin] 15ken2812221 opened pull request #13246: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/13246
37 2018-05-16 14:51:18	0|wumpus|right, the per-ldb bloom filter would be expected to make direct misses fast, but if it still has to look at the next record after the cursor, that will be a slower operation
38 2018-05-16 15:00:07	0|jonasschnelli|gmaxwell, wumpus: so for a 1-to-n relation, a exist-check is probably the biggest slowdown (especially for the first entry where the key does not exists). So a single write with hash160-blockkey-txpos is probably faster during indexing...
39 2018-05-16 15:00:42	0|jonasschnelli|for a lookup, just set the cursor to the key (hash160) and itterate as long as the key matches the hash160
40 2018-05-16 15:01:14	0|jonasschnelli|lookup may be slower compared to storing the entire serialized object
41 2018-05-16 15:01:49	0|jonasschnelli|(though I expect cursor->next() must be pretty fast)
42 2018-05-16 15:04:05	0|jonasschnelli|hmm.. my IDE debugger refuses to debug wallet.cpp since we also have interface/wallet.cpp... meh!
43 2018-05-16 15:04:32	0|jonasschnelli|Is that common c++ practice to have same filenames in different subfolders?
44 2018-05-16 15:10:53	0|ryanofsky|of course it is, i don't think you would use folders at all if filenames were supposed to be globally unique
45 2018-05-16 15:11:13	0|promag|jonasschnelli: should not be a problem
46 2018-05-16 15:11:59	0|jonasschnelli|Yes. Your both righ,.. Qt Create dbg/lldb integration is just buggy.
47 2018-05-16 15:12:09	0|jonasschnelli|*Qt Creator
48 2018-05-16 15:38:08	0|wumpus|right, C/C++ has no requirement for filenames to be unique in a project
49 2018-05-16 15:39:48	0|wumpus|this would be really difficult to enforce for large projects with a lot of people working on them. Even more, linkers have no concept of 'project-local' so it'd also collide between libraries then.
50 2018-05-16 15:42:35	0|wumpus|(at one employer we did have a requirement that every include file and compilation unit had a unique name; don't know why; but it resulted in everything being prefixed to the point of absurdity; every module had a two/four letter name, and every file had to be prefixed with the concatenated submodule identifiers)
51 2018-05-16 15:46:46	0|wumpus|inbefore someone proposes it for the bitcoin repository someone to have a reason to add another linter
52 2018-05-16 16:08:22	0|sipa|like src/a/b/c/a_b_c_file.h?
53 2018-05-16 16:16:07	0|ryanofsky|i don't think that's repetitive enough, maybe src/a/a_b/a_b_c/src_a_b_c_file.h
54 2018-05-16 16:16:43	0|sipa|haha
55 2018-05-16 16:30:14	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/40c34a0a29f6...11e7bdfd903e
56 2018-05-16 16:30:15	0|bitcoin-git|13bitcoin/06master 14ecc3c4a 15Matt Corallo: Do not unlock cs_main in ABC unless we've actually made progress....
57 2018-05-16 16:30:16	0|bitcoin-git|13bitcoin/06master 14a3ae8e6 15Jesse Cohen: Fix concurrency-related bugs in ActivateBestChain...
58 2018-05-16 16:30:17	0|bitcoin-git|13bitcoin/06master 14dd435ad 15Jesse Cohen: Add unit tests for signals generated by ProcessNewBlock()...
59 2018-05-16 16:30:59	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13023: Fix some concurrency issues in ActivateBestChain() (06master...06event-tests) 02https://github.com/bitcoin/bitcoin/pull/13023
60 2018-05-16 16:44:03	0|wumpus|yes, that idea, EADGxBLxAP_foowidget.[ch]
61 2018-05-16 19:23:48	0|BlueMatt|https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.16.1 <-- I think we should untag the remaining things and move forward with backports
62 2018-05-16 19:23:50	0|BlueMatt|wumpus: ?
63 2018-05-16 19:38:56	0|bitcoin-git|[13bitcoin] 15laanwj pushed 8 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/11e7bdfd903e...4cfe17c3382b
64 2018-05-16 19:38:57	0|bitcoin-git|13bitcoin/06master 14470316c 15John Newbery: [wallet] setup wallet background flushing in WalletInit directly...
65 2018-05-16 19:38:57	0|bitcoin-git|13bitcoin/06master 1459b87a2 15John Newbery: [wallet] Fix potential memory leak in CreateWalletFromFile...
66 2018-05-16 19:38:58	0|bitcoin-git|13bitcoin/06master 14e0e90db 15John Newbery: [wallet] Add CWallet::Verify function...
67 2018-05-16 19:39:11	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10740: [wallet] `loadwallet` RPC - load wallet at runtime (06master...06load_unload_wallet) 02https://github.com/bitcoin/bitcoin/pull/10740
68 2018-05-16 19:39:21	0|BlueMatt|nice!
69 2018-05-16 19:40:27	0|BlueMatt|another easy high-priority-merge-win: #13011 :p
70 2018-05-16 19:40:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub
71 2018-05-16 19:45:04	0|promag|yap ^
72 2018-05-16 19:48:46	0|bitcoin-git|[13bitcoin] 15skeees opened pull request #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model (06master...06scheduler-tests) 02https://github.com/bitcoin/bitcoin/pull/13247
73 2018-05-16 19:50:05	0|promag|would be nice to have some reviews in #13097
74 2018-05-16 19:50:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/13097 | ui: Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub
75 2018-05-16 19:50:50	0|promag|jonasschnelli luke-jr ^
76 2018-05-16 21:00:43	0|phantomcircuit|sipa, flags ^= 1; is sort of confusing in the transaction deserialization function btw
77 2018-05-16 21:18:01	0|phantomcircuit|AllocateFileRange seems to fallback to writting 1 byte at a time?
78 2018-05-16 21:45:21	0|bitcoin-git|[13bitcoin] 15mess110 opened pull request #13248: [gui] Make proxy icon from statusbar clickable (06master...06make_proxy_icon_clickable) 02https://github.com/bitcoin/bitcoin/pull/13248
79 2018-05-16 22:01:07	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13249: Make objects in range declarations immutable by default (06master...06for-const) 02https://github.com/bitcoin/bitcoin/pull/13249
80 2018-05-16 22:49:55	0|bitcoin-git|[13bitcoin] 15pstratem opened pull request #13250: Simplify ProcessGetBlockData execution (06master...062018-05-16-processgetblockdata) 02https://github.com/bitcoin/bitcoin/pull/13250
81 2018-05-16 22:55:25	0|phantomcircuit|^ but why BlueMatt
82 2018-05-16 22:55:58	0|BlueMatt|cause old code got moved, dont blame me
83 2018-05-16 23:00:17	0|phantomcircuit|sipa, it's making BlueMatt simpler
84 2018-05-16 23:01:29	0|sipa|well please elaborate in the PR description!
85 2018-05-16 23:01:47	0|sipa|does it decrease the size of his color pallette?
86 2018-05-16 23:05:01	0|phantomcircuit|im not sure how that is possible
87 2018-05-16 23:05:05	0|phantomcircuit|blue -> blue
88 2018-05-16 23:08:43	0|sipa|seriously, please give a better description on your PR