1 2018-05-20 02:25:37	0|bitcoin-git|[13bitcoin] 15qshuai closed pull request #13042: Calculated nBits will be replaced by the following GetNextWorkRequire… (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13042
 2 2018-05-20 02:54:19	0|kallewoof|sipa: gmaxwell: I am on macOS running natively
 3 2018-05-20 02:54:27	0|kallewoof|(sorry for late response)
 4 2018-05-20 04:05:14	0|kallewoof|wumpus fanquake: You can drop #12634 from high priority list. Jimpo brought up some points that I hadn't considered, so I think I need to rework this before bringing it up for review. :/
 5 2018-05-20 04:05:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub
 6 2018-05-20 04:13:19	0|gmaxwell|kallewoof: it was a longshot... windows has some really obnoxious behavior around exclusive access to files... so much for that guess
 7 2018-05-20 04:18:19	0|kallewoof|gmaxwell: I haven't closed the lldb session. Not sure what I can glean from lldb/gdb commands though. Looking at threads it doesn't seem like two threads are doing things with leveldb.
 8 2018-05-20 05:22:11	0|bitcoin-git|[13bitcoin] 15brandonrninefive opened pull request #13284: Fix for Issue #13231 - [gui] visual "overflow" of amount input. (06master...06ui_amount_overflow_fix) 02https://github.com/bitcoin/bitcoin/pull/13284
 9 2018-05-20 05:53:34	0|fanquake|kallewoof done
10 2018-05-20 08:18:25	0|kallewoof|fanquake: Thanks!
11 2018-05-20 18:59:56	0|belcher|im writing for a bitcoin core PR, this is rpc_net.py https://pastebin.com/SJKwnfKQ my part starts at line 102, i open a p2pconnection to a node and send it some addresses, but then the node doesnt have those addresses in its getaddr as it should, can anyone see anything wrong?
12 2018-05-20 21:17:14	0|bitcoin-git|[13bitcoin] 15Empact opened pull request #13288: Remove the need to include "rpc/blockchain.cpp' in order to put `GetDifficulty` under test (06master...06get-difficulty) 02https://github.com/bitcoin/bitcoin/pull/13288
13 2018-05-20 22:38:42	0|achow101|belcher: all of those addresses are probably considered "terrible"
14 2018-05-20 22:38:44	0|achow101|belcher: see https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L33
15 2018-05-20 22:41:14	0|belcher|achow101 i tried changing it to addr.time = 1526774400 + i*60 #20th may 2018 but still gives an empty string
16 2018-05-20 22:41:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/20 | JSON-RPC callback · Issue #20 · bitcoin/bitcoin · GitHub
17 2018-05-20 22:41:36	0|achow101|belcher: actually you need to set services to match those for a full node
18 2018-05-20 22:41:48	0|achow101|https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L1840
19 2018-05-20 22:41:56	0|achow101|otherwise they won't get stored
20 2018-05-20 22:42:30	0|belcher|sec, trying that
21 2018-05-20 22:46:17	0|belcher|so thats node_network | node_witness or node_network_limited | node_witness.. that didnt help either, still returns an empty list
22 2018-05-20 22:46:33	0|achow101|belcher: check if they are being added to addrman. There should be lines in the debug.log about it
23 2018-05-20 22:47:10	0|belcher|where does debug.log end up when running tests? like ./test/functional/rpc_net.py
24 2018-05-20 22:48:06	0|achow101|something should be printed that says the datadir
25 2018-05-20 22:48:21	0|achow101|the debug.log will be in there in the regtest folder
26 2018-05-20 22:48:25	0|belcher|ah that must be Initializing test directory /tmp/testqo7f6r9j
27 2018-05-20 22:48:34	0|achow101|yeah, that's it
28 2018-05-20 22:48:51	0|achow101|within that is a datadir for each node started for the test
29 2018-05-20 22:53:32	0|belcher|ok so, the datadir gets cleaned up after the test
30 2018-05-20 22:53:36	0|belcher|it gets deleted
31 2018-05-20 22:53:41	0|achow101|run with --nocleanup
32 2018-05-20 22:53:56	0|achow101|or something like that (check -h)
33 2018-05-20 22:54:13	0|belcher|also i ran it a few times and once it worked, giving the list of addresses, but i ran it again and it gave an empty list again... so maybe its something to do with the time?
34 2018-05-20 22:55:19	0|belcher|the debug.log has this line 2018-05-20T22:55:12.580402Z Added 1000 addresses from 127.0.0.1: 0 tried, 64 new
35 2018-05-20 22:55:21	0|achow101|the time does matter, but I think the first step to debugging this is to figure out whether the addresses make it into addrman in the first place
36 2018-05-20 22:55:52	0|belcher|a little later: 2018-05-20T22:55:12.921387Z Flushed 64 addresses to peers.dat  141ms
37 2018-05-20 22:56:14	0|achow101|aren't you adding 1000 addresses though?
38 2018-05-20 22:56:25	0|belcher|yes.. i dont know where 64 comes from
39 2018-05-20 22:57:27	0|achow101|hold on, I'll try running it too
40 2018-05-20 22:57:43	0|belcher|iv run it again, now its "received: addr (30003 bytes) peer=4" and later "Flushed 0 addresses to peers.dat  291ms"
41 2018-05-20 22:57:51	0|belcher|so zero addresses this time
42 2018-05-20 22:58:26	0|belcher|here's the exact file im running, sec
43 2018-05-20 22:59:05	0|belcher|https://pastebin.com/RbXLPGP5
44 2018-05-20 23:02:02	0|achow101|one thing I'm noticing is that the rpc call is happening before the addr is received, if the ordering in the debug.log is correct
45 2018-05-20 23:03:17	0|belcher|i just added time.sleep(3) in case that helps, didnt seem to
46 2018-05-20 23:04:31	0|achow101|I'm not seeing anything in the debug.log that indicates that addrman is adding anything
47 2018-05-20 23:15:33	0|achow101|belcher: One problem is that the addresses are 192.168.x.x which addrman won't add. I changed those to something else and addrman is adding the addresses
48 2018-05-20 23:16:20	0|belcher|oh yes good point
49 2018-05-20 23:16:58	0|belcher|i just did that and it seems to be working
50 2018-05-20 23:17:20	0|belcher|weirdly the output says 'services': 1 even though i assigned it as node_network | node_witness
51 2018-05-20 23:17:29	0|achow101|although it still seems to only be adding 64 addresses
52 2018-05-20 23:17:43	0|belcher|ah, i still had the time.sleep
53 2018-05-20 23:18:11	0|belcher|when i remove time.sleep it returns an empty list again
54 2018-05-20 23:18:13	0|achow101|and you need the time.sleep
55 2018-05-20 23:18:53	0|belcher|that will slow down the test runtime :\ i wonder if theres a better way, but i dont think the p2p protocol gives a response to 'addr'
56 2018-05-20 23:19:48	0|achow101|I don't think it does
57 2018-05-20 23:20:07	0|achow101|you could send a ping and then wait for pong right after sending addr
58 2018-05-20 23:20:18	0|belcher|good idea
59 2018-05-20 23:20:40	0|belcher|an interesting thing, i tried to make it send 2000 and 2500 addresses instead of 1000, but it returned an empty list then
60 2018-05-20 23:22:22	0|achow101|addr can't be greater than 1000
61 2018-05-20 23:22:39	0|belcher|ah ok
62 2018-05-20 23:23:33	0|belcher|the 64 addresses thing is weird but those 64 can be obtained with getnodeaddresses so its enough to write a test
63 2018-05-20 23:31:37	0|belcher|achow101 mininode.py already has a function sync_with_ping() where it sends a ping and waits for the pong :)
64 2018-05-20 23:31:50	0|belcher|because that sleep() problem has obviously happened a lot before :p