1 2018-05-30 02:59:51	0|CubicEarths|Will BIP 174 make it easier for different brands of wallets to do multi-sig together?
  2 2018-05-30 03:02:11	0|sipa|hopefully
  3 2018-05-30 03:07:04	0|CubicEarths|I've been waiting for that day since multi-sig became a thing
  4 2018-05-30 06:45:33	0|GitHub150|[13bitcoin-detached-sigs] 15jonasschnelli opened pull request #6: 0.16.1: osx signatures for 0.16.1rc (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/6
  5 2018-05-30 07:07:38	0|GitHub159|[13bitcoin-detached-sigs] 15theuni closed pull request #6: 0.16.1: osx signatures for 0.16.1rc (060.16...060.16) 02https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/6
  6 2018-05-30 07:07:55	0|cfields|gitian builders: detached sigs for v0.16.1rc1 are pushed
  7 2018-05-30 07:30:44	0|fanquake|cfields pushed some signed sigs up https://github.com/bitcoin-core/gitian.sigs/pull/712
  8 2018-05-30 08:00:26	0|jonasschnelli|fanquake: cfields sigs matches with mine (https://bitcoin.jonasschnelli.ch/build/634).. will push asap
  9 2018-05-30 08:17:49	0|fanquake|jonasschnelli: What are your thoughts on moving to macOS 10.10 as a minimum required version for 0.17.0 ?
 10 2018-05-30 08:18:09	0|fanquake|qt5.9.x supports > 10.10
 11 2018-05-30 08:18:09	0|jonasschnelli|fanquake: 10.10 is pretty "newish"... not sure.
 12 2018-05-30 08:18:18	0|jonasschnelli|That is a point.
 13 2018-05-30 08:18:40	0|jonasschnelli|qt5.9 is LTR (long term release), right?
 14 2018-05-30 08:18:58	0|fanquake|Correct, which is also why I thought a macOS bump might be ok
 15 2018-05-30 08:19:20	0|jonasschnelli|We use 10.8 as min right now, right?
 16 2018-05-30 08:19:22	0|fanquake|Qt seems to be getting more aggressive with dropping macOS support as well.
 17 2018-05-30 08:19:28	0|fanquake|Yep, 10.8 is the current minimum
 18 2018-05-30 08:19:47	0|fanquake|qt 5.10, 5.11 is macOS 10.11 +
 19 2018-05-30 08:19:54	0|jonasschnelli|I think it would be worth to do sooner then later – IF – there are clear gains (features, stability, etc.)
 20 2018-05-30 08:20:16	0|jonasschnelli|If not, we should probably wait ~1yr before upgrading to Qt5.9
 21 2018-05-30 08:20:21	0|fanquake|There is some code for supporting 10.8, fonts stuff I think, that might be able to be dropped.
 22 2018-05-30 08:20:46	0|fanquake|So for 0.17 we should just bump the 5.7.x, if there is an upgrade available?
 23 2018-05-30 08:21:28	0|fanquake|I'm going to put something together about a bump, might wrap it up in an issue for discussion.
 24 2018-05-30 08:21:31	0|jonasschnelli|We could bump to 5.7.x (if one is willing to work on that PR).
 25 2018-05-30 08:21:39	0|fanquake|Layout any benefits/downsides etc.
 26 2018-05-30 08:21:44	0|jonasschnelli|Upgrading Qt via depends was always pretty painful.
 27 2018-05-30 08:22:30	0|jonasschnelli|Yes. I think minimal system requirements are important (to keep as low as possible). Only increase if necessary
 28 2018-05-30 08:22:46	0|jonasschnelli|necessary == clear gains in UX or other area
 29 2018-05-30 08:23:02	0|fanquake|We are currently using 5.7.1, and there doesn't seem to be any more point releases for the 5.7 branch. So if we stuck to 5.7 we wouldn't need any changes for 0.17
 30 2018-05-30 08:23:14	0|fanquake|It's only compatibility patches, such as for Xcode etc
 31 2018-05-30 08:23:27	0|jonasschnelli|Okay. That makes sense... should also be not to complicated.
 32 2018-05-30 08:24:01	0|jonasschnelli|Did someone mention in the Qt5.9 PR that this will increase minimal system requieremnts for OSX?
 33 2018-05-30 08:24:14	0|fanquake|Here are the qt5.9 "features". Anything stick out to you that would be nice to have? https://wiki.qt.io/New_Features_in_Qt_5.9
 34 2018-05-30 08:24:18	0|jonasschnelli|And I know of a lot of OSX users stuck below 10.10
 35 2018-05-30 08:24:29	0|fanquake|I don't think anyone has mentioned yet, I'll make a comment now.
 36 2018-05-30 08:24:46	0|jonasschnelli|Thanks! I think this is a show stopper for that Qt5.9 PR
 37 2018-05-30 08:25:03	0|jonasschnelli|I looked through the RN of QT5.9,... nothing that we really would need.
 38 2018-05-30 08:25:11	0|jonasschnelli|We use only the very basics of QT
 39 2018-05-30 08:25:51	0|jonasschnelli|AFAIK the biggest problem we should make progress is HiDPI on Win/Linux. I'm not sure if this is a Qt upstream issue or something we can do better
 40 2018-05-30 08:26:04	0|jonasschnelli|Last time I checked, Bitcoin-Core looks pretty bad on Linux/Win HIDPI
 41 2018-05-30 08:26:30	0|jonasschnelli|And I have not read anything about HiDPI improvements in the last RNs,... so very likely something we can do better.
 42 2018-05-30 08:30:07	0|fanquake|mmm. Single mention of High-DPI on Windows in the Qt5.11 Release notes
 43 2018-05-30 08:30:26	0|fanquake|Will have to investigate if we can do better with 5.7
 44 2018-05-30 08:49:20	0|jonasschnelli|fanquake: That would be great. Maybe – if you can – test on HiDPI on Linux (Ubuntu?) and Windows... see if there is something we do wrong in our application that prevents those platforms from correctly rendering on HiDPI
 45 2018-05-30 08:49:22	0|jonasschnelli|It works flawless on macOS
 46 2018-05-30 08:49:32	0|jonasschnelli|(that is what me make think it is an upstream issue)
 47 2018-05-30 08:50:13	0|fanquake|jonasschnelli Yea I'll have a look.
 48 2018-05-30 08:50:24	0|fanquake|Merged all the sigs as well.
 49 2018-05-30 09:00:48	0|wumpus|jonasschnelli: I think qt5 was supposed to have better support for HiDPI, but not sure whether that's only on macosx
 50 2018-05-30 09:01:01	0|wumpus|maybe there's something that has to be enabled, it's always tricky
 51 2018-05-30 09:03:16	0|jonasschnelli|wumpus: Yes. it's on my list since month (figure out the reasons why HiDPI looks bad on Win/Linux).
 52 2018-05-30 09:03:24	0|jonasschnelli|*months
 53 2018-05-30 09:07:09	0|wumpus|jonasschnelli: FWIW on linux I always have DPI issues and have to tune things (such as display DPI) manually, and some programs ignore it, it's not very well coordinated. Wouldn't surprise me if windows is similar.
 54 2018-05-30 09:10:48	0|wumpus|jonasschnelli: then again, if other qt5 applications work and bitcoin core doesn't, yes it's something we forget to do
 55 2018-05-30 09:13:59	0|fanquake|The debug console on Windows looks particularly bad
 56 2018-05-30 09:14:00	0|fanquake|https://0bin.net/paste/zWwN4zEeHJejfj5j#ZCLGsPtKSdXzUt-qTREORO2koOH2frCcvE9vvzu+xS6
 57 2018-05-30 09:16:13	0|wumpus|that's terrible, looks like a bitmap font that was zoomed out?!
 58 2018-05-30 09:16:51	0|fanquake|wumpus Yea I'm not sure, none of the other fonts in the client look that bad, basically just the debug console.
 59 2018-05-30 09:17:26	0|jonasschnelli|I just fail to understand why the HiDPI concept (which practically is a x2 scale) works flawless on OSX and looks so bad on Win
 60 2018-05-30 09:18:05	0|jonasschnelli|which leads me to thinks, Qt needs to fix some things internally
 61 2018-05-30 09:18:20	0|jonasschnelli|but would be great to know how other Qt5 apps behave
 62 2018-05-30 09:19:16	0|wumpus|OSX has a neat and well-organized graphics layer, all things considered, compared to the other OSes
 63 2018-05-30 09:19:52	0|fanquake|Couple other trivial issues on Windows as well, like this box https://0bin.net/paste/6nRFsooj5Y3ludG7#DrYmyEK86QNzE240PzcKhwOlrFWYuid9iPdQRb3Sr+d
 64 2018-05-30 09:20:01	0|wumpus|screen dpi and scaling is simply handled. On Linux/X11 it's also reported to the application / widget toolkit but in a few conflicting ways, which they usually tend to ignore...
 65 2018-05-30 09:20:05	0|fanquake|Things just seem to "break" slightly on Windows.
 66 2018-05-30 09:20:14	0|wumpus|fanquake: probably just a matter of the wrong font
 67 2018-05-30 09:21:24	0|wumpus|I vaguely remember that Wayland, the new Linux graphics stack, improved/standardized handling for screens with different DPI and such, but that's not of much use yet to most users
 68 2018-05-30 09:23:07	0|wumpus|didnt' know 0bin handled images, by the way :o
 69 2018-05-30 09:46:46	0|wumpus|arowser_: looks like you have connection issues
 70 2018-05-30 10:01:41	0|wumpus|rc1 executables up: https://bitcoincore.org/bin/bitcoin-core-0.16.1/test.rc1/
 71 2018-05-30 10:05:34	0|wumpus|arowser_: please fix your connection, or I'll have to ban you
 72 2018-05-30 10:37:55	0|fanquake|What are any changes in master that might stop you opening a wallet with 0.16.1?
 73 2018-05-30 10:38:32	0|fanquake|Managed to generate a wallet that wont open with 0.16.1rc1, but opens with master fine. Can't seen to recreate going either way if I nuke the data dir.
 74 2018-05-30 10:39:16	0|fanquake|Sure I've never seen https://0bin.net/paste/PTTpyv0yB6Mthc9X#QMNg0CvL-/mWbuEnlvjZROaXrlYdu41nqA3FL9MSYp5 before.
 75 2018-05-30 10:54:26	0|provoostenator|fanquake not an incompatible-bdb issue?
 76 2018-05-30 10:56:20	0|wumpus|creating a wallet with master that can't be opened in 0.16.1 is ok, we don't generally support opening wallets created with newer versions in older ones
 77 2018-05-30 10:56:35	0|fanquake|provoostenator Shouldn't be. Using 0.16.rc1 binary, and WSL depends build with master. Both report 4.8.30 in debug log.
 78 2018-05-30 10:56:39	0|wumpus|(the other way around would be bad, or if you open it with master once and then can't use it with 0.16.1 anymore)
 79 2018-05-30 10:57:09	0|wumpus|but wallets *created* with master, well they are at the newest version, which might not be supported with older versions
 80 2018-05-30 11:00:15	0|provoostenator|Would this version change be the reason? https://github.com/bitcoin/bitcoin/commit/a8da482a8bc87ff26194612727d4a7b86b2fb60d
 81 2018-05-30 11:24:09	0|wumpus|provoostenator: yes I think so
 82 2018-05-30 11:32:46	0|fanquake|wumpus can you block Michelle155 from GH
 83 2018-05-30 11:34:36	0|Arvidt|The release notes for 0.16.1rc1 linked in the announcement email is pretty empty / in draft state (e.g. "0.16.x Example item"). I think it would be interesting for someone considering running RC version to have an overview what's new. https://github.com/bitcoin/bitcoin/blob/0.16/doc/release-notes.md
 84 2018-05-30 11:41:33	0|fanquake|Arvidt Looks like a bit of an oversight, will get some release notes PR'd shortly.
 85 2018-05-30 11:48:26	0|wumpus|I don't think any work has been done on the release notes yet, I considered not mentioning them at all, a list of commits would have been more useful
 86 2018-05-30 11:51:23	0|wumpus|I'll add that to the branch today
 87 2018-05-30 11:51:55	0|fanquake|wumpus ^ see above re spammer
 88 2018-05-30 11:52:53	0|wumpus|fanquake: ah overlooked that, yes
 89 2018-05-30 11:53:45	0|wumpus|blocked from bitcoin and bitcoin-core orgs
 90 2018-05-30 12:01:24	0|bitcoin-git|13bitcoin/060.16 14afc115d 15Wladimir J. van der Laan: doc: Add commits and authors to release notes for rc1...
 91 2018-05-30 12:01:24	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.16: 02https://github.com/bitcoin/bitcoin/commit/afc115d7535986f6c2bec3c3ad4ed0fe90d31f01
 92 2018-05-30 12:01:49	0|wumpus|Arvidt: basic info is there now https://github.com/bitcoin/bitcoin/blob/0.16/doc/release-notes.md
 93 2018-05-30 12:13:20	0|bitcoin-git|[13bitcoin] 15fanquake opened pull request #13346: doc: update bitcoin-dot-org links in release-process.md (06master...06release-process-links) 02https://github.com/bitcoin/bitcoin/pull/13346
 94 2018-05-30 12:15:13	0|fanquake|Be good to get some more macOS testers for https://github.com/bitcoin/bitcoin/pull/12783
 95 2018-05-30 12:40:55	0|bitcoin-git|13bitcoin/06master 148310238 15fanquake: doc: update bitcoin-dot-org links in release-process.md
 96 2018-05-30 12:40:55	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f8a29ca823fb...60f0358b4a1e
 97 2018-05-30 12:40:56	0|bitcoin-git|13bitcoin/06master 1460f0358 15MarcoFalke: Merge #13346: doc: update bitcoin-dot-org links in release-process.md...
 98 2018-05-30 12:41:52	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13346: doc: update bitcoin-dot-org links in release-process.md (06master...06release-process-links) 02https://github.com/bitcoin/bitcoin/pull/13346
 99 2018-05-30 13:06:36	0|wumpus|should we put the 0.16.1 release notes in the wiki? or is that not useful for aminor release, I don't expect much editing to be necessary
100 2018-05-30 13:08:17	0|fanquake|wumpus As in have the WIP notes in the wiki? I don't think it'd be necessary
101 2018-05-30 13:09:15	0|wumpus|yes--
102 2018-05-30 13:09:26	0|wumpus|I don't think so either, but just asking
103 2018-05-30 13:09:56	0|wumpus|I see some minor fixups are needed such as the version numbers, but not sure if anyone wants to add any more "notable changes"
104 2018-05-30 13:10:25	0|fanquake|The only one might be for the Windows assert? But the release-notes can be edited as part of that PR if it happens
105 2018-05-30 13:10:43	0|wumpus|re: macOS testing for 12783, jonasschnelli can you do a build please?
106 2018-05-30 13:11:08	0|wumpus|(hopes he fixed his connection by now...)
107 2018-05-30 13:13:10	0|fanquake|wumpus Maybe not heh
108 2018-05-30 13:13:12	0|wumpus|(apparently not)
109 2018-05-30 13:17:41	0|jonasschnelli|wumpus: https://bitcoin.jonasschnelli.ch/build/635
110 2018-05-30 13:22:45	0|provoostenator|Maybe edit the 0.16 release notes to reflect 0.16.1 rather than 0.16.0?
111 2018-05-30 13:23:40	0|fanquake|provoostenator Yes, that is left to do. See above ^
112 2018-05-30 13:29:11	0|wumpus|provoostenator: they do, though the version numbers need bumping in some places
113 2018-05-30 13:29:28	0|wumpus|but the content of the release notes is for 0.16.1
114 2018-05-30 13:33:52	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13347: travis: Skip cache for lint stage (06master...06Mf1806-travisLintNoCache) 02https://github.com/bitcoin/bitcoin/pull/13347
115 2018-05-30 13:40:46	0|bitcoin-git|13bitcoin/06master 143d4fa83 15Wladimir J. van der Laan: Stop translating command line options...
116 2018-05-30 13:40:46	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/60f0358b4a1e...25d2df2aa988
117 2018-05-30 13:40:47	0|bitcoin-git|13bitcoin/06master 1425d2df2 15MarcoFalke: Merge #13341: Stop translating command line options...
118 2018-05-30 13:41:41	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13341: Stop translating command line options (06master...062018_05_notranslate_options) 02https://github.com/bitcoin/bitcoin/pull/13341
119 2018-05-30 14:50:07	0|bitcoin-git|13bitcoin/06master 14c814e2e 15Pieter Wuille: Remove template matching and pseudo opcodes...
120 2018-05-30 14:50:07	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/25d2df2aa988...fd96d54f39cf
121 2018-05-30 14:50:08	0|bitcoin-git|13bitcoin/06master 14fd96d54 15Wladimir J. van der Laan: Merge #13194: Remove template matching and pseudo opcodes...
122 2018-05-30 14:51:00	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13194: Remove template matching and pseudo opcodes (06master...06201805_noscriptpattern) 02https://github.com/bitcoin/bitcoin/pull/13194
123 2018-05-30 14:56:54	0|kallewoof|I've addressed jimpo's concerns in #12634 and would like to re-add it to high pri list. If you don't wanna do that outside of meetings, consider this my spiritual presence at next meeting asking to have it added as I usually can't make it for 4 am. Btw why isn't #12136 on there?
124 2018-05-30 14:57:01	0|gribble|https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub
125 2018-05-30 14:57:04	0|gribble|https://github.com/bitcoin/bitcoin/issues/12136 | Implement BIP 174 Partially Signed Bitcoin Transactions by achow101 · Pull Request #12136 · bitcoin/bitcoin · GitHub
126 2018-05-30 15:03:46	0|instagibbs|the author was busy with other stuff until recently i presume
127 2018-05-30 15:11:12	0|kallewoof|instagibbs: Since wumpus promoted it on twitter I flat out presumed it was on that list tbh.
128 2018-05-30 15:11:57	0|instagibbs|high priority... in our hearts
129 2018-05-30 15:12:30	0|achow101|I asked wumpus to add it to the list a week or two ago but I didn't actually check if it got added
130 2018-05-30 15:12:36	0|gmaxwell|The specification still probably needs work, since it unfortunately hasn't had a lot of attention since it was written.
131 2018-05-30 15:13:02	0|gmaxwell|One of the challenges for high priority is .. like does it mean the feature is high priority or the implementation of it.
132 2018-05-30 15:16:45	0|achow101|gmaxwell: a few people have been looking at it and have sent me comments. I have made some changes to the spec since the original was added to the bips repo
133 2018-05-30 15:17:44	0|gmaxwell|oh good.
134 2018-05-30 15:41:58	0|wumpus|it's high priority to me personally
135 2018-05-30 15:45:26	0|wumpus|the meaning of the "high priority for review" project is to get people to look at it, it does not necessarily imply the change itself has high priority, although it does mean at least the author would like to see it merged (because it blocks further work, for example)
136 2018-05-30 15:49:05	0|wumpus|anyhow -- added them both to the project
137 2018-05-30 16:06:21	0|ken2812221|Is it a good idea to clear the caches for all PR?
138 2018-05-30 16:06:30	0|ken2812221|on travis
139 2018-05-30 16:17:40	0|wumpus|ken2812221: you mean after the 18.04 change?
140 2018-05-30 16:17:54	0|wumpus|cfields ^^
141 2018-05-30 16:20:45	0|ken2812221|Yes, it seems there are a lot of PR tests timed out.
142 2018-05-30 16:23:28	0|wumpus|I don't think cleaning the caches will help for timeouts
143 2018-05-30 16:26:07	0|mryandao|what C++ version is core currently on? do we only support C++17 and beyond?
144 2018-05-30 16:26:31	0|Varunram|the code is on C++11 afaik
145 2018-05-30 16:28:13	0|gmaxwell|mryandao: C++17 is a couple months old and isn't completely supported by any compiler...
146 2018-05-30 16:28:35	0|ken2812221|wunpus: Travis will fetch caches from master if there is no cache linked to the PR.
147 2018-05-30 16:28:44	0|cfields|wumpus: I don't think clearing caches would help at all. Each PR is going to rebuild all depends the next time it's pushed-to no matter what
148 2018-05-30 16:29:17	0|cfields|ken2812221: ah, that's a good point though
149 2018-05-30 16:30:11	0|sipa|mryandao: we were on c++03 until 2016, when we switched to c++11
150 2018-05-30 16:30:47	0|sipa|as gmaxwell says, c++17 is super new, and even c++14 support is pretty novel in compilers
151 2018-05-30 16:32:36	0|sipa|i guess gcc 5 (first with full support for c++14) is 3 years old now
152 2018-05-30 16:33:13	0|mryandao|gcc support still experimental for 17 :/
153 2018-05-30 16:34:35	0|sipa|mryandao: yes, it'll be years before we can adopt c++17
154 2018-05-30 16:38:35	0|gmaxwell|mryandao: even once there is support we can't use it until distributions pick it up.
155 2018-05-30 16:43:06	0|sipa|any reason why we can't adopt c++14 in the near future? gcc5 is in ubuntu 16.04 lts and up
156 2018-05-30 16:44:06	0|mryandao|C++14 enables the removal of boost::chrono
157 2018-05-30 16:48:51	0|bitcoin-git|[13bitcoin] 15jl2012 opened pull request #13348:  Standard template for CHECKMULTISIG with 17~20 keys (06master...0620multisig) 02https://github.com/bitcoin/bitcoin/pull/13348
158 2018-05-30 16:49:54	0|goatpig|std::chrono is in c++11, unless it's doing something different than boost's
159 2018-05-30 17:09:46	0|wumpus|yes, std::chrono is c++11
160 2018-05-30 17:11:04	0|sipa|what is the blocker to doing an s/boost::/std::/ for all of chrono and thread?
161 2018-05-30 17:11:43	0|wumpus|just work
162 2018-05-30 17:12:25	0|wumpus|though I wouldn't be surprised if cfields already has all of that somewhere
163 2018-05-30 17:12:42	0|sipa|i remember something with interruption points
164 2018-05-30 17:13:16	0|wumpus|cfields: so clear all PR caches but not the branches?
165 2018-05-30 17:18:45	0|wumpus|sipa: yes, interruption points are one thing that would have to be implemented on our side
166 2018-05-30 17:20:43	0|sipa|i thought we had done so though, or at least partially
167 2018-05-30 17:20:55	0|wumpus|I think for chrono there were no issues at all, our use of time could even easily be implemented using the C API
168 2018-05-30 17:22:41	0|wumpus|there's DecodeDumpTime in src/wallet/rpcdump which does some boost-related time parsing, but that's not chrono
169 2018-05-30 17:23:02	0|cfields|wumpus: i'm not sure what 'the branches' are in that context?
170 2018-05-30 17:23:14	0|wumpus|cfields: 0.16, master
171 2018-05-30 17:23:25	0|cfields|wumpus: ah yes, leave those
172 2018-05-30 17:24:30	0|cfields|as ken2812221 mentioned, it first tries to find the per-pr cache, and resorts to the generic master cache if that one can't be found...
173 2018-05-30 17:24:58	0|cfields|I'm not 100% if it will try to re-pull from master on a non-new PR, but the cache is useless in that case anyway, so I don't think it could hurt
174 2018-05-30 17:25:04	0|wumpus|thought so, all PR caches are gone now
175 2018-05-30 17:31:03	0|wumpus|apparently still hasn't fixed their connection
176 2018-05-30 17:34:43	0|wumpus|https://travis-ci.org/bitcoin/bitcoin/builds/385749445?utm_source=github_status&utm_medium=notification travis doesn't even load this site here
177 2018-05-30 17:35:14	0|wumpus|might be more than just a cache issue
178 2018-05-30 17:38:52	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/fd96d54f39cf...c4cc8d9930ec
179 2018-05-30 17:38:53	0|bitcoin-git|13bitcoin/06master 144b62bdf 15Ben Woosley: Wallet: Refactor ReserveKeyFromKeyPool for safety...
180 2018-05-30 17:38:54	0|bitcoin-git|13bitcoin/06master 14c4cc8d9 15Wladimir J. van der Laan: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety...
181 2018-05-30 17:39:42	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety (06master...06refactor_wallet_RKFKP) 02https://github.com/bitcoin/bitcoin/pull/13252
182 2018-05-30 17:45:30	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c4cc8d9930ec...61fcef0f89c4
183 2018-05-30 17:45:31	0|bitcoin-git|13bitcoin/06master 14174f7c8 15Andrew Chow: Use a struct for arguments and nested map for categories...
184 2018-05-30 17:45:31	0|bitcoin-git|13bitcoin/06master 144f8704d 15Andrew Chow: Give an error and exit if there are unknown parameters...
185 2018-05-30 17:45:32	0|bitcoin-git|13bitcoin/06master 149030557 15Andrew Chow: Test gArgs erroring on unknown args
186 2018-05-30 17:46:10	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13112: Throw an error for unknown args (06master...06gargs-know-args) 02https://github.com/bitcoin/bitcoin/pull/13112
187 2018-05-30 18:29:41	0|jonasschnelli|My testnet seed – after a report from an lnd dev – does report a high amount of ABC and BCash and classic peers.
188 2018-05-30 18:30:10	0|jonasschnelli|They all have protocol number 80002 and may disconnect on requesting a block
189 2018-05-30 18:30:25	0|jonasschnelli|Not sure if they are on a different chain or it they are just dishonest, spy-peers.
190 2018-05-30 18:31:21	0|jonasschnelli|It is maybe a cat and mouse game, but eventually we should add more checks to sipa seeds, Like requesting a block around the current best known tip (would require a bitcoind on the seeder)
191 2018-05-30 18:31:34	0|jonasschnelli|*sipas seed software
192 2018-05-30 18:41:34	0|wumpus|jonasschnelli: yes...
193 2018-05-30 18:42:48	0|jonasschnelli|Maybe the only solutions are enough honest peers that will reduce the amount of served dishnoest peers
194 2018-05-30 18:45:10	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #13349: bench: Don't return a bool from main (06master...062017_05_bench_warning) 02https://github.com/bitcoin/bitcoin/pull/13349
195 2018-05-30 18:50:37	0|sipa|TIL C++11 contains regex matching, and we're even using it in bench_bitcoin
196 2018-05-30 18:57:03	0|sipa|wumpus: are we moving away from trusty in gitian as well?
197 2018-05-30 19:32:03	0|bitcoin-git|[13bitcoin] 15lmanners opened pull request #13350: [tests] Add logging to provide anchor points when debugging failures. (06master...06testlogging) 02https://github.com/bitcoin/bitcoin/pull/13350
198 2018-05-30 19:50:16	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13351: wallet: Prevent segfault when sending to unspendable witness (06master...06Mf1806-walletUnspendableWitnessIsMine) 02https://github.com/bitcoin/bitcoin/pull/13351
199 2018-05-30 20:04:17	0|bitcoin-git|13bitcoin/06master 14d8c4998 15practicalswift: Fix typos
200 2018-05-30 20:04:17	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/61fcef0f89c4...472fe8a2ce9f
201 2018-05-30 20:04:18	0|bitcoin-git|13bitcoin/06master 14472fe8a 15MarcoFalke: Merge #13069: docs: Fix typos...
202 2018-05-30 20:05:02	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13069: docs: Fix typos (06master...06typos-201804) 02https://github.com/bitcoin/bitcoin/pull/13069
203 2018-05-30 20:49:09	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13352: qa: Avoid checking reject code for now (06master...06Mf1806-qaRejectCode) 02https://github.com/bitcoin/bitcoin/pull/13352
204 2018-05-30 20:53:57	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #13353: qa: Fixup setting of PATH env var (06master...06Mf1806-qaPathBitcoind) 02https://github.com/bitcoin/bitcoin/pull/13353