1 2018-06-02 01:10:39 0|mryandao|l
2 2018-06-02 01:13:15 0|sipa|m
3 2018-06-02 01:15:43 0|gmaxwell|f
4 2018-06-02 02:22:56 0|luke-jr|k
5 2018-06-02 03:02:49 0|bitcoin-git|[13bitcoin] 15steverusso opened pull request #13372: Docs: Linked to 'Building on FreeBSD' in build-unix.md (06master...06link-to-building-on-freebsd) 02https://github.com/bitcoin/bitcoin/pull/13372
6 2018-06-02 06:34:09 0|wumpus|sipa: the idea to use VARINT for the service bits is that the higher bits are not used, so on the average case this will save some bytes per entry
7 2018-06-02 06:34:30 0|wumpus|sipa: and ok, I'm fine with removing the onioncat padding for torv2, it seemed easiest for implementations
8 2018-06-02 06:35:42 0|wumpus|sipa: but if you think the VARINT doesn't help I'll change it back to just uint64_t
9 2018-06-02 06:39:04 0|sipa|wumpus: my point is more that if you're going to make it variable length... why limit to 64 bits?
10 2018-06-02 06:59:42 0|mryandao|has anyone tried to do a `git request-pull` without a github account?
11 2018-06-02 07:01:14 0|mryandao|would sending the pending changes to the mailing list prompt any of the maintainers to address the PR?
12 2018-06-02 07:08:34 0|wumpus|sipa: my point is more to have a limit, what would you suggest to limit it to?
13 2018-06-02 07:09:02 0|wumpus|sipa: my reasoning was: 64 bits is more than enough for now, so there's no actual need to allow longer values
14 2018-06-02 07:10:17 0|wumpus|mryandao: that's not really our way of working, I don't think anyone has ever posted a patch to the mailing list
15 2018-06-02 07:10:37 0|wumpus|it's even harder to get things to be reviewed that way then on it is on github
16 2018-06-02 07:21:15 0|sipa|wumpus: right, but you can have a serialization that supports longer, even though you currently don't use (or accept) it?
17 2018-06-02 07:21:38 0|sipa|this is just a nit... i'm totally fine with a varint or just 64 bit, and extend it later again if needed
18 2018-06-02 07:24:36 0|wumpus|sipa: right, that'd be ok to me
19 2018-06-02 07:29:14 0|wumpus|I've updated the torv2 format to strip the onioncat prefixing
20 2018-06-02 14:30:06 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #12744: WIP: eliminate dependency on boost::program_options (06master...06program_options) 02https://github.com/bitcoin/bitcoin/pull/12744
21 2018-06-02 17:10:08 0|bitcoin-git|[13bitcoin] 15eudisd opened pull request #13373: Qt: Update Wallet Encryption Titles To Better Describe Process (06master...06feature/bitcoin-#13245) 02https://github.com/bitcoin/bitcoin/pull/13373
22 2018-06-02 17:46:14 0|bitcoin-git|[13bitcoin] 15kaplanmaxe opened pull request #13374: utils and libraries: checking for bitcoin address in translations (06master...06check-addr-translations) 02https://github.com/bitcoin/bitcoin/pull/13374
23 2018-06-02 20:31:13 0|bitcoin-git|[13bitcoin] 15undercoverGod opened pull request #13375: utils and libraries: address check in update-translations.py (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/13375