1 2018-06-18 00:34:01	0|bitcoin-git|[13bitcoin] 15qmma70 opened pull request #13490: Rewind when active block tip is higher than nStopAtHeight (06master...06rewind) 02https://github.com/bitcoin/bitcoin/pull/13490
  2 2018-06-18 00:37:32	0|gmaxwell|uh, that would make stop at height less useful for me. :(
  3 2018-06-18 00:38:27	0|gmaxwell|sjors request for a 'determinstic blockchain snapshot' as I understand what he's saying  wouldn't be achieved by that
  4 2018-06-18 00:43:08	0|sipa|isn't there an easier solution to make sure ABC just doesn't pass the stopatheight value?
  5 2018-06-18 00:44:37	0|luke-jr|or just have a tx spend index, so we can calculate past UTXO states if that's the goal
  6 2018-06-18 00:45:26	0|gmaxwell|why tie it with stop at height, we could have a version of invalidateblock that rewinds to a particular block.
  7 2018-06-18 00:46:22	0|sipa|well the fact that -stopatheight doesn't actually stop at that height is a bug afaik, and it should be fixed
  8 2018-06-18 00:46:43	0|sipa|but going past it and then rolling back seems like an enormously roundabout way of accomplishing that
  9 2018-06-18 00:47:23	0|gmaxwell|::nods::
 10 2018-06-18 00:50:42	0|sipa|actually i don't understand how this is possible at all, except in case there is a reorg just around that height
 11 2018-06-18 00:54:48	0|gmaxwell|in any case if someone needs a utxo set at a particular place it should be triggered by blockhash
 12 2018-06-18 00:59:56	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #13491: Improve handling of INVALID in IsMine (06master...06201806_cleanmine) 02https://github.com/bitcoin/bitcoin/pull/13491
 13 2018-06-18 01:49:31	0|bitcoin-git|[13bitcoin] 15promag opened pull request #13492: Fix reply not sent when event loop terminates prematurely (06master...062018-06-http-shutdown) 02https://github.com/bitcoin/bitcoin/pull/13492
 14 2018-06-18 02:36:15	0|bitcoin-git|[13bitcoin] 15ken2812221 closed pull request #13485: Ensure that http event loop is empty before the loop exit (06master...06http_shutdown) 02https://github.com/bitcoin/bitcoin/pull/13485
 15 2018-06-18 04:33:47	0|bitcoin-git|[13bitcoin] 15fanquake opened pull request #13493: gui: Add leading 0 to QT_VERSION check for QFontDatabase (06master...06remove-qtversion-qfontdatabase) 02https://github.com/bitcoin/bitcoin/pull/13493
 16 2018-06-18 08:05:00	0|HearingVo|Can someone provide me with some BitCoin?
 17 2018-06-18 08:47:29	0|promag|jonasschnelli: friendly ping #13111
 18 2018-06-18 08:47:32	0|gribble|https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
 19 2018-06-18 09:43:04	0|gnappuraz|Hi, I have a question regarding some bitcoin source code i'm trying to understand. Is this the right place?
 20 2018-06-18 09:50:03	0|jonasschnelli|promag: Yes. Will review this afternoon
 21 2018-06-18 09:50:23	0|promag|gnappuraz: just ask
 22 2018-06-18 09:50:26	0|promag|jonasschnelli: nice
 23 2018-06-18 09:53:23	0|gnappuraz|I was looking at the wallet.h file, there is a mapWallet map<uint256, CWalletTx>... I was trying to figure out what this map exactly contains
 24 2018-06-18 09:54:51	0|gnappuraz|it seems the main memory storage to bookkeep the transactions seen so far. Not sure if invalid txs and txs from forks are there too though
 25 2018-06-18 09:56:45	0|jonasschnelli|gnappuraz: What do you mean with invalid txns?
 26 2018-06-18 09:57:05	0|jonasschnelli|Yes. It is the main storage for transactions filtered out of the blockchain and mempool that are relevant to the wallet keys
 27 2018-06-18 09:57:31	0|gnappuraz|also orphans?
 28 2018-06-18 09:57:35	0|jonasschnelli|But they are checked for confirmation or conflicts during presentation... so you can't assume that all transactions in mapWallet are confirmed, etc.
 29 2018-06-18 09:57:40	0|jonasschnelli|Orphans possible, yes.
 30 2018-06-18 09:57:47	0|gnappuraz|ok thank you very much!
 31 2018-06-18 09:58:11	0|jonasschnelli|Its just a set of transactions that have relevance to your keys/scripts in your wallet...
 32 2018-06-18 09:58:40	0|jonasschnelli|If you want to render a balance, etc. you need to check / calculate if the transactions counts, etc.
 33 2018-06-18 09:58:46	0|gnappuraz|if instead I need to fetch txs that are not related to my wallet?
 34 2018-06-18 09:59:33	0|jonasschnelli|gnappuraz: depends... if you know the blockhash/heigh and the txid, you can use getrawtransaction
 35 2018-06-18 09:59:48	0|jonasschnelli|If you only know the txid, you may need the -txindex=1 (enabled tx index)
 36 2018-06-18 10:00:17	0|gnappuraz|right, thanks
 37 2018-06-18 10:00:43	0|jonasschnelli|The wallet is a partial indexing service for the blockchain,... it "indexes" transactions relevant to the keys/scripts in the wallet
 38 2018-06-18 10:01:00	0|jonasschnelli|(it not only indexes, it "extracts" the transactions)
 39 2018-06-18 10:01:14	0|gnappuraz|i understand
 40 2018-06-18 10:30:29	0|fanquake|wumpus: You commented on the wrong PR re squashing commits
 41 2018-06-18 10:39:44	0|wumpus|fanquake: yep, resolved now
 42 2018-06-18 10:43:45	0|fanquake|qt4 changes looking good
 43 2018-06-18 10:44:45	0|fanquake|managed to engage the wrong @wumpus again
 44 2018-06-18 10:45:22	0|promag|thanks jonas, will sort it out
 45 2018-06-18 10:56:56	0|fanquake|provoostenator: As far as I can tell I've gotten ios cross builds working. Will PR some depends changes shortly.
 46 2018-06-18 11:13:20	0|murrayn|was there not a time, not so long ago, where transaction age was a factor in prioritization? am i misremembering?
 47 2018-06-18 11:16:35	0|wumpus|utxo age was
 48 2018-06-18 11:17:49	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d6cf4bd7eb3b...45c00f841612
 49 2018-06-18 11:17:50	0|bitcoin-git|13bitcoin/06master 143352da8 15practicalswift: Add "export LC_ALL=C" to all shell scripts
 50 2018-06-18 11:17:50	0|bitcoin-git|13bitcoin/06master 1447776a9 15practicalswift: Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
 51 2018-06-18 11:17:51	0|bitcoin-git|13bitcoin/06master 1445c00f8 15Wladimir J. van der Laan: Merge #13454: Make sure LC_ALL=C is set in all shell scripts...
 52 2018-06-18 11:18:35	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13454: Make sure LC_ALL=C is set in all shell scripts (06master...06avoid-locale-dependent-range-expressions) 02https://github.com/bitcoin/bitcoin/pull/13454
 53 2018-06-18 11:19:15	0|wumpus|it used to be the sorting criterion for the free transaction area that some miners maintained in blocks
 54 2018-06-18 11:59:32	0|promag|jonasschnelli: pushed a fix
 55 2018-06-18 12:00:06	0|jonasschnelli|promag: will test asap
 56 2018-06-18 12:00:55	0|promag|jonasschnelli: ty
 57 2018-06-18 12:01:55	0|promag|jonasschnelli: now in the main window the wallet selector hidden when there is only 1 wallet loaded
 58 2018-06-18 12:02:06	0|promag|*is hidden*
 59 2018-06-18 12:02:22	0|rabidus|oispa liivit
 60 2018-06-18 12:02:32	0|rabidus|oops sorry, wrong channel :(
 61 2018-06-18 12:03:04	0|promag|jonasschnelli: we should create a model for wallets no?
 62 2018-06-18 12:03:35	0|promag|btw, any objection to change QObject::connect to qt5 syntax (after qt4 is dropped)?
 63 2018-06-18 12:11:09	0|fanquake|promag sounds good
 64 2018-06-18 12:20:11	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (06master...06lc-all-lint-python-utf8-encoding) 02https://github.com/bitcoin/bitcoin/pull/13494
 65 2018-06-18 12:25:20	0|ahp1992|hi
 66 2018-06-18 12:26:14	0|ahp1992|hello all
 67 2018-06-18 12:30:28	0|promag|thank fanquake
 68 2018-06-18 12:32:50	0|bitcoin-git|13bitcoin/06master 147b23e6e 15practicalswift: Follow-up to #13454: Fix broken build by exporting LC_ALL=C
 69 2018-06-18 12:32:50	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/45c00f841612...d67eff8002d7
 70 2018-06-18 12:32:51	0|bitcoin-git|13bitcoin/06master 14d67eff8 15MarcoFalke: Merge #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C...
 71 2018-06-18 12:33:42	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (06master...06lc-all-lint-python-utf8-encoding) 02https://github.com/bitcoin/bitcoin/pull/13494
 72 2018-06-18 12:53:35	0|ahp1992|let me know, how can i study to do own currency using bitcoin core.
 73 2018-06-18 13:03:44	0|fanquake|ahp1992 off-topic here.
 74 2018-06-18 13:30:30	0|bitcoin-git|13bitcoin/06master 1455771b7 15lucash.dev@gmail.com: Removed unused == operator from CMutableTransaction.
 75 2018-06-18 13:30:30	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d67eff8002d7...2d071f5a7055
 76 2018-06-18 13:30:31	0|bitcoin-git|13bitcoin/06master 142d071f5 15Wladimir J. van der Laan: Merge #13443: Removed unused == operator from CMutableTransaction....
 77 2018-06-18 13:31:12	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13443: Removed unused == operator from CMutableTransaction. (06master...06remove-CMutableTransaction-equals) 02https://github.com/bitcoin/bitcoin/pull/13443
 78 2018-06-18 13:33:43	0|bitcoin-git|13bitcoin/06master 141e1eb63 15Pieter Wuille: Improve coverage of SHA256 SelfTest code
 79 2018-06-18 13:33:43	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2d071f5a7055...450055bdbdcb
 80 2018-06-18 13:33:44	0|bitcoin-git|13bitcoin/06master 14450055b 15Wladimir J. van der Laan: Merge #13438: Improve coverage of SHA256 SelfTest code...
 81 2018-06-18 13:34:37	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13438: Improve coverage of SHA256 SelfTest code (06master...06201806_selftestsha) 02https://github.com/bitcoin/bitcoin/pull/13438
 82 2018-06-18 14:54:13	0|jonasschnelli|sipa: would it be possible to have 3 different BCHs in Bech32X (three length of checksum)?
 83 2018-06-18 15:18:07	0|bitcoin-git|13bitcoin/06master 14ac3224c 15Wladimir J. van der Laan: Merge #13412: Make ReceivedBlockTransactions return void...
 84 2018-06-18 15:18:07	0|bitcoin-git|13bitcoin/06master 14fafa270 15MarcoFalke: Make ReceivedBlockTransactions return void
 85 2018-06-18 15:18:07	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/450055bdbdcb...ac3224c8eea9
 86 2018-06-18 15:18:58	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13412: Make ReceivedBlockTransactions return void (06master...06Mf1806-refactorReturnCodeValidation) 02https://github.com/bitcoin/bitcoin/pull/13412
 87 2018-06-18 15:20:12	0|bitcoin-git|[13bitcoin] 15wodry opened pull request #13496: Test: Harden lint-filenames.sh (06master...06harden-test-lint-filenames.sh) 02https://github.com/bitcoin/bitcoin/pull/13496
 88 2018-06-18 15:29:22	0|sipa|jonasschnelli: sure, what lengths
 89 2018-06-18 15:30:07	0|jonasschnelli|I think 7, 14, and 21 (correction)
 90 2018-06-18 15:31:09	0|jonasschnelli|Or maybe 7, 14, 28
 91 2018-06-18 15:31:21	0|jonasschnelli|7 is ~5%, 14: ~10%, 28: ~20%
 92 2018-06-18 15:31:34	0|jonasschnelli|(for 512bit)
 93 2018-06-18 15:33:27	0|bitcoin-git|13bitcoin/06master 14faa18ca 15MarcoFalke: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
 94 2018-06-18 15:33:27	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ac3224c8eea9...088240685456
 95 2018-06-18 15:33:28	0|bitcoin-git|13bitcoin/06master 140882406 15Wladimir J. van der Laan: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds...
 96 2018-06-18 15:34:23	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (06master...06Mf1806-walletPrunedFundsSegfault) 02https://github.com/bitcoin/bitcoin/pull/13437
 97 2018-06-18 16:35:50	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #13498: [wallet] Fixups from account API deprecation (06master...06account_deprecation_fixups) 02https://github.com/bitcoin/bitcoin/pull/13498
 98 2018-06-18 19:00:58	0|sipa|jonasschnelli: around?
 99 2018-06-18 19:01:27	0|jonasschnelli|sipa: yes (phonetyping)
100 2018-06-18 19:03:08	0|sipa|jonasschnelli: i have a few thoughts on a format for describing sets of scriptPubKey
101 2018-06-18 19:03:37	0|sipa|it's probably more complicated than what you're thinking about, but it's also pretty much what i'd want the entire wallet to migrate to
102 2018-06-18 19:03:49	0|sipa|i'll do a writeup/prototype over the next few days if you're interested
103 2018-06-18 19:04:11	0|jonasschnelli|sure. I think we could first use it for the scantxoutset
104 2018-06-18 19:04:21	0|sipa|yeah
105 2018-06-18 19:04:50	0|sipa|but it would also support things like multisig of multiple hd paths etc
106 2018-06-18 19:05:20	0|jonasschnelli|I think that's great... i guess it's related to your thoughts on PSBT
107 2018-06-18 19:05:35	0|sipa|yes
108 2018-06-18 19:06:03	0|sipa|and also for supporting hw wallets directly in core, and forward compatibility with schnorr etc
109 2018-06-18 19:06:28	0|jonasschnelli|Good.
110 2018-06-18 19:06:45	0|jonasschnelli|I wanted to comment about the encoding...
111 2018-06-18 19:07:13	0|jonasschnelli|Do you think pure binary serialization is unacceptable?
112 2018-06-18 19:07:21	0|sipa|for psbt?
113 2018-06-18 19:07:26	0|jonasschnelli|yes
114 2018-06-18 19:07:36	0|sipa|sure, that'd be the most common thing to do
115 2018-06-18 19:07:42	0|jonasschnelli|or where do you see advantages of base64 and z85, etc.
116 2018-06-18 19:07:46	0|sipa|but we can't put pure binary in an RPC response
117 2018-06-18 19:07:55	0|jonasschnelli|yes. sure.
118 2018-06-18 19:08:11	0|sipa|the common assumption i think is using hex
119 2018-06-18 19:08:29	0|jonasschnelli|yeah... I guess size won't matter to much on that layer
120 2018-06-18 19:08:38	0|sipa|but as i know how annoying raw transactions in hex can be to copy paste, i wanted to suggest something smaller
121 2018-06-18 19:08:45	0|sipa|and z85 looks pretty neat actually
122 2018-06-18 19:08:51	0|jonasschnelli|yes. I like it.
123 2018-06-18 19:08:53	0|sipa|it's 5 characters per 4 bytes
124 2018-06-18 19:09:16	0|jonasschnelli|but PSBT could also have it own file type... end user could email and dbl-click etc
125 2018-06-18 19:09:25	0|sipa|it probably should
126 2018-06-18 19:10:01	0|jonasschnelli|For RPC it will be a long chuck of text. both with hex or z85.
127 2018-06-18 19:10:08	0|sipa|yes
128 2018-06-18 19:10:34	0|sipa|but 1.6x shorter with z85
129 2018-06-18 19:11:09	0|jonasschnelli|Yes. But hassle on the client side... eventually opt-in?
130 2018-06-18 19:11:31	0|sipa|yeah, the burden of implementing z85 would be a deterrent i guess
131 2018-06-18 19:11:41	0|sipa|base64 is more common
132 2018-06-18 19:11:55	0|jonasschnelli|Yes.
133 2018-06-18 19:11:58	0|sipa|i don't care much; i just brought it up because it would be good to standardize on one
134 2018-06-18 19:12:32	0|jonasschnelli|I think z85 brings in some perfection and I generally think it's worth to explore
135 2018-06-18 19:13:01	0|sipa|cfields: what clang version will be used for 0.17 osx builds?
136 2018-06-18 19:13:18	0|jonasschnelli|and it not very complex so if one can deal with PSBT, z85 seem a trivial puzzlepiece
137 2018-06-18 19:13:34	0|jonasschnelli|*its
138 2018-06-18 20:01:48	0|bitcoin-git|[13bitcoin] 15JeremyRubin reopened pull request #12763: Add RPC Whitelist Feature from #12248 (06master...06whitelistrpc) 02https://github.com/bitcoin/bitcoin/pull/12763
139 2018-06-18 20:07:10	0|bitcoin-git|[13bitcoin] 15jamesob closed pull request #12407: Ensure nStatus is set properly for all invalid blocks (06master...06jamesob/2018-02-mark-headers-invalid) 02https://github.com/bitcoin/bitcoin/pull/12407
140 2018-06-18 21:53:57	0|nkohen|Does anyone know what the intended functionality of combinerawtransaction is with bitcoind?
141 2018-06-18 21:56:39	0|sipa|nkohen: create a raw transaction for a 2-of-2 multisig, give it to both parties, each sign their part with a single signature; combinerawtransaction will turn it into a full transaction
142 2018-06-18 21:59:45	0|nkohen|Thanks!
143 2018-06-18 22:30:31	0|bitcoin-git|[13bitcoin] 15achow101 opened pull request #13500: [wallet] Decouple wallet version from client version (06master...06decouple-wallet-version) 02https://github.com/bitcoin/bitcoin/pull/13500
144 2018-06-18 22:33:43	0|gmaxwell|sipa: is z85 as copy and paste friendly as base64?
145 2018-06-18 22:40:37	0|sipa|gmaxwell: probably not
146 2018-06-18 22:41:26	0|sipa|it's designed to not need escaping in typical programming languages when surrounded by quotation marks, though
147 2018-06-18 22:42:11	0|sipa|wait, what do you mean by copy-paste friendly?
148 2018-06-18 22:47:32	0|bitcoin-git|[13bitcoin] 15promag opened pull request #13501: Remove race on shutdown between event loop exit and http reply (06master...062018-06-loopexit) 02https://github.com/bitcoin/bitcoin/pull/13501
149 2018-06-18 22:49:47	0|gmaxwell|sipa: mostly not having weird escape characters that will cause misbehavior when pasted.
150 2018-06-18 22:50:44	0|gmaxwell|it has / which is unfortunate for pasting into IRC.
151 2018-06-18 22:51:11	0|sipa|gmaxwell: it excludes \ ' " ; ,
152 2018-06-18 22:51:33	0|sipa|and |
153 2018-06-18 22:51:59	0|sipa|if it would have excluded < / >, and included , ; | instead it would be clean html
154 2018-06-18 22:52:36	0|gmaxwell|I'm surprised it doesn't include ,;| as those are generally safe AFAIK.
155 2018-06-18 22:52:50	0|sipa|yup
156 2018-06-18 22:53:40	0|sipa|hmm, there are are 94 non-space printable ascii characters
157 2018-06-18 22:53:46	0|sipa|so 9 must be excluded
158 2018-06-18 22:57:46	0|sipa|\ ' " ; , | ` ~
159 2018-06-18 22:57:50	0|sipa|i must be missing one still
160 2018-06-18 22:59:44	0|gmaxwell|https://tools.ietf.org/html/rfc1924  has < and > but leaves out the slashes.
161 2018-06-18 23:00:02	0|gmaxwell|it gives rationale for each of the omitted characters.
162 2018-06-18 23:01:13	0|sipa|that's specific for ipv6 addresses, though
163 2018-06-18 23:01:19	0|sipa|for example the chose to exclude [ ]
164 2018-06-18 23:01:55	0|gmaxwell|Right.  & is also an escape character that should be aboided.
165 2018-06-18 23:02:00	0|gmaxwell|(at that document argues,
166 2018-06-18 23:02:49	0|gmaxwell|<>"'`/\&. seem more obvious safe characters to exclude to me.
167 2018-06-18 23:04:22	0|sipa|or just base64... only 6.25% less efficient
168 2018-06-18 23:04:34	0|sipa|and far more common
169 2018-06-18 23:05:01	0|gmaxwell|it is sad that base64 has / but at least it's a common and well understood thing.
170 2018-06-18 23:05:09	0|sipa|the base85 trick of encoding 32-bit integers is neat, though