1 2018-06-29 09:36:56 0|bitcoin-git|[13bitcoin] 15Gnappuraz opened pull request #13568: Trivial: Remove double semicolon from wallet.cpp (06master...06typo_double_semicolon) 02 https://github.com/bitcoin/bitcoin/pull/13568
2 2018-06-29 09:41:17 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/b330f3fdd56b...90990d274185
3 2018-06-29 09:41:18 0|bitcoin-git|13bitcoin/06master 142fca656 15fanquake: depends: Update Qt download url
4 2018-06-29 09:41:18 0|bitcoin-git|13bitcoin/06master 1490990d2 15Wladimir J. van der Laan: Merge #13544: depends: Update Qt download url...
5 2018-06-29 09:42:06 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13544: depends: Update Qt download url (06master...06qt-been-archived) 02 https://github.com/bitcoin/bitcoin/pull/13544
6 2018-06-29 10:21:35 0|promag|wumpus: how about #12151
7 2018-06-29 10:21:38 0|gribble|https://github.com/bitcoin/bitcoin/issues/12151 | rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag ÷ Pull Request #12151 ÷ bitcoin/bitcoin ÷ GitHub
8 2018-06-29 10:31:32 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/90990d274185...f3c9c40aeb12
9 2018-06-29 10:31:33 0|bitcoin-git|13bitcoin/06master 14962d8ee 15practicalswift: Remove boost dependency (boost/assign/std/vector.hpp)
10 2018-06-29 10:31:33 0|bitcoin-git|13bitcoin/06master 14c6fd0df 15practicalswift: Fix incorrect tests
11 2018-06-29 10:31:34 0|bitcoin-git|13bitcoin/06master 14f3c9c40 15MarcoFalke: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency....
12 2018-06-29 10:32:20 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency. (06master...06fix-test-and-de-boost) 02 https://github.com/bitcoin/bitcoin/pull/13545
13 2018-06-29 14:05:28 0|jnewbery|promag: what are you asking wumpus for on 12151?
14 2018-06-29 14:14:00 0|bitcoin-git|[13bitcoin] 15aqwark opened pull request #13569: Need help! wallet.dat corrupt (06master...06master) 02 https://github.com/bitcoin/bitcoin/pull/13569
15 2018-06-29 14:15:50 0|bitcoin-git|[13bitcoin] 15domob1812 opened pull request #13570: RPC: Add new "getzmqnotifications" method (06master...06zmq) 02 https://github.com/bitcoin/bitcoin/pull/13570
16 2018-06-29 14:24:01 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #13569: Need help! wallet.dat corrupt (06master...06master) 02 https://github.com/bitcoin/bitcoin/pull/13569
17 2018-06-29 15:21:30 0|promag|jnewbery: asking if it's merge ready
18 2018-06-29 15:55:33 0|jnewbery|doesn't look like it to me. There are no ACKs since your last change and rebase
19 2018-06-29 16:04:15 0|jnewbery|you'll find more success seeking review than asking a maintainer to merge an unreviewed PR :)
20 2018-06-29 16:09:48 0|jonasschnelli|Core-memchart: Wallets(1000 keys) versus memory consumption: https://bitcointools.jonasschnelli.ch/mem-graph.png
21 2018-06-29 16:09:58 0|bitcoin-git|13bitcoin/06master 14fa87da2 15MarcoFalke: qa: Avoid start/stop of the network thread mid-test
22 2018-06-29 16:09:58 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/f3c9c40aeb12...a6ed99a1e6fa
23 2018-06-29 16:09:59 0|bitcoin-git|13bitcoin/06master 14a6ed99a 15Wladimir J. van der Laan: Merge #13517: qa: Remove need to handle the network thread in tests...
24 2018-06-29 16:10:48 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #13517: qa: Remove need to handle the network thread in tests (06master...06Mf1806-qaAsyncIo) 02 https://github.com/bitcoin/bitcoin/pull/13517
25 2018-06-29 16:12:11 0|jonasschnelli|A wallet with 1000keys (keypool 1000) and no transaction requires roughly 6.8MB of ram
26 2018-06-29 16:49:48 0|satwo|Hello all. When running bitcoind with printtoconsole=1 in bitcoin.conf, I am still getting output written to debug.log (in addition to stdout, which is what I want). Am I missing something? FWIW I am using a patched version of Bitcoin Core that simply adds a couple LogPrint statements in Validation.cpp, but I doubt that would have anything to do with this behavior.
27 2018-06-29 16:52:51 0|sipa|satwo: what changed or what do you expect to see differently? (in case i'm missing some context)
28 2018-06-29 17:05:33 0|satwo|sipa: Well, I'm expecting the trace/debug info to stop going to debug.log altogether based on the docs ("Send trace/debug info to console instead of debug.log file"). The problem is I'm running this node on a small VM with limited storage so an ever-growing debug.log is not desired
29 2018-06-29 17:07:21 0|satwo|BTW "Send trace/debug info to console instead of debug.log file" is from -printtoconsole under bitcoind -h
30 2018-06-29 17:14:01 0|satwo|It seems that this is the expected behavior based on InitLogging() in init.cpp. The m_print_to_file flag does not take into consideration "-printtoconsole"
31 2018-06-29 17:20:28 0|sipa|satwo: sounds like a bug to me
32 2018-06-29 17:20:38 0|sipa|was this changed recently?
33 2018-06-29 17:21:28 0|satwo|Not that I'm aware of. Only had a need for this functionality recently
34 2018-06-29 17:22:54 0|satwo|I'd be happy to submit a fix/PR. I guess the question is, should there be two separate flags for -printtoconsole and -printtofile so that they're not mututally exclusive? The latter would just default to 1
35 2018-06-29 17:26:19 0|sipa|satwo: that sounds ideal; but if the behaviour unintentionally changed in a recent commit, that is a bug, and should be fixed independently from improving the functionality
36 2018-06-29 17:28:37 0|satwo|sipa: looking over the history now. there were some relatively recent changes in April which are related to this stuff
37 2018-06-29 17:49:03 0|achow101|satwo: sipa this was changed recently for the default printtoconsole when not using -daemon change that happened a few months ago
38 2018-06-29 17:49:39 0|gmaxwell|why was that changed?
39 2018-06-29 17:50:25 0|achow101|see #13004
40 2018-06-29 17:50:28 0|gribble|https://github.com/bitcoin/bitcoin/issues/13004 | Print to console by default when not run with -daemon by practicalswift ÷ Pull Request #13004 ÷ bitcoin/bitcoin ÷ GitHub
41 2018-06-29 17:50:43 0|sipa|oh
42 2018-06-29 17:50:45 0|achow101|and #12689
43 2018-06-29 17:50:48 0|gribble|https://github.com/bitcoin/bitcoin/issues/12689 | Smarter default behavior for -printtoconsole by eklitzke ÷ Pull Request #12689 ÷ bitcoin/bitcoin ÷ GitHub
44 2018-06-29 17:51:33 0|gmaxwell|so ... how do you turn off logging to a file?
45 2018-06-29 17:51:42 0|achow101|USE -nodebuglogfile
46 2018-06-29 17:51:49 0|achow101|or -debuglogfile=0
47 2018-06-29 17:51:55 0|achow101|i think
48 2018-06-29 17:52:01 0|gmaxwell|It makes sense that non-daemon operation prints to the console by default, I guess.
49 2018-06-29 17:52:02 0|gmaxwell|OK
50 2018-06-29 17:52:06 0|gmaxwell|satwo: there you go.
51 2018-06-29 17:52:28 0|gmaxwell|has someone written a release note for that? :P
52 2018-06-29 17:52:42 0|sipa|The command line help for -printtoconsole is wrong though
53 2018-06-29 17:52:49 0|achow101|indeed
54 2018-06-29 17:52:58 0|sipa|It should probably explain the full behaviour, including a reference to -debuglogfile
55 2018-06-29 17:56:17 0|gmaxwell|PR description also doesn't describe this change in behavior.
56 2018-06-29 17:56:29 0|gmaxwell|It's burried in a comment in the original pr. :P
57 2018-06-29 17:58:00 0|satwo|Thanks all. I'd be happy to make a go at modifying the command line help.
58 2018-06-29 18:17:59 0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #12611: interpreter: Use safer casting in IsValidSignatureEncoding(...) (06master...06safer-casting-in-IsValidSignatureEncoding) 02 https://github.com/bitcoin/bitcoin/pull/12611